[PATCH] Make EBN happy

Hello,

Here is a collection of patches to correct EBN warnings. I have:
1) ported .ui files to use K* classes rather than Q*. While doing so, i have 
opened and save the .ui file in designer. Apparently the format has changed a 
bit, which makes the diff larger.
2) improved single char efficiency
3) corrected include directives
4) avoided the use of a QString() to reset a QKeySequence
I hope the patches are fine.

Regards,

Médéric

_______________________________________________
Kstars-devel mailing list
Kstars-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel

1e8 stars

Hello,

We now have support for 1e8 stars in trunk, but the 1e8 data file is
not available via the Download tool.  Akarsh, would it be okay to add
the file now, or do you need more time?  Oh, wait...did we decide that
the 1e8 file is too big to post for download?  How big is the current
version of the binary file?

thanks,
Jason

Re: 1e8 stars

Hi Jason,

> We now have support for 1e8 stars in trunk, but the 1e8 data file is
> not available via the Download tool.  Akarsh, would it be okay to add
> the file now, or do you need more time?  Oh, wait...did we decide that
> the 1e8 file is too big to post for download?  How big is the current
> version of the binary file?

I still don't have the 1e8 binary file ready. The support is there,
but I haven't found time to set up my system to start creating the
binary files. I should start the process at most by the weekend.

Regards
Akarsh

_______________________________________________
Kstars-devel mailing list
Kstars-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel

KDE/kdeedu/kstars/kstars

SVN commit 856296 by asimha:

Applying Médéric's EBN fixes. 

Médéric's description of the patch:

Here is a collection of patches to correct EBN warnings. I have:
1) ported .ui files to use K* classes rather than Q*. While doing so, i have
opened and save the .ui file in designer. Apparently the format has changed a
bit, which makes the diff larger.
2) improved single char efficiency
3) corrected include directives
4) avoided the use of a QString() to reset a QKeySequence

Thanks, Med!

CCMAIL: kstars-devel <at> kde.org

 M  +1 -1      colorscheme.cpp  
 M  +4 -1      data/tools/binfile.h  
 M  +0 -38     deepstardata.h  
 M  +1 -1      detaildialog.cpp  
 M  +37 -91    devmanager.ui  
 M  +20 -63    fitshistogramui.ui  
 M  +29 -15    focusdialog.ui  
 M  +36 -40    imgsequencedlg.ui  
 M  +55 -52    indiconf.ui  
 M  +4 -4      indidevice.cpp  
 M  +27 -23    indihostconf.ui  
 M  +2 -2      indimenu.cpp  

KDE/kdeedu/kstars/kstars

SVN commit 856298 by asimha:

Tell Krazy not to check the kstars/data/tools directory, as it
contains only tools that are used to generate data files. The tools
are mostly C programs and perl scripts.

CCMAIL: kstars-devel <at> kde.org

 A             .krazy  

KDE/kdeedu/kstars/kstars

SVN commit 857041 by harris:

Apply small patch from Ralf Habacker to fix reading of UTF-8-encoded files on 
win32.  Though linux systems don't seem to need the call to 
QTextStream::setEncoding("UTF-8"), it doesn't seem to do any harm, so I added the 
two calls without any #ifdef wrappers.

Thanks for the patch Ralf!

CCMAIL: kstars-devel <at> kde.org
CCMAIL: ralf.habacker <at> freenet.de

 M  +2 -0      ksfilereader.cpp  

--- trunk/KDE/kdeedu/kstars/kstars/ksfilereader.cpp #857040:857041
@@ -39,6 +39,7 @@
 {
     QIODevice* device = (QIODevice*) & file;
     QTextStream::setDevice( device );
+    QTextStream::setCodec("UTF-8");
     m_targetLine = MAXUINT;
 }

@@ -49,6 +50,7 @@
         return false;
     }
     QTextStream::setDevice( &m_file );
+    QTextStream::setCodec("UTF-8");
     return true;
 }

KDE/kdeedu/kstars/kstars/tools

SVN commit 857043 by harris:

Make Location button functional.  Add text label to Print button (still 
non-functional).  Make default window size smaller for small screens.

CCMAIL: kstars-devel <at> kde.org

 M  +23 -0     skycalendar.cpp  
 M  +1 -0      skycalendar.h  
 M  +4 -4      skycalendar.ui  

--- trunk/KDE/kdeedu/kstars/kstars/tools/skycalendar.cpp #857042:857043
@@ -17,12 +17,14 @@

 #include "skycalendar.h"

+#include <QDesktopWidget>
 #include <kdebug.h>
 #include <KPlotObject>
 #include <KPushButton>

 #include "calendarwidget.h"
 #include "geolocation.h"
+#include "locationdialog.h"
 #include "kstars.h"
 #include "kstarsdatetime.h"
 #include "kstarsdata.h"
@@ -46,11 +48,21 @@
     setButtons( KDialog::User1 | KDialog::Close );
     setModal( false );

KDE/kdeedu/kstars/kstars/data

SVN commit 857472 by asimha:

Applying James Cameron's patch fixing a spelling mistake in
Cities.dat

Thanks James.

CCMAIL: kstars-devel <at> kde.org

 M  +1 -1      Cities.dat  

--- trunk/KDE/kdeedu/kstars/kstars/data/Cities.dat #857471:857472
@@ -657,7 +657,7 @@
 Concord                          : California            : USA                   : 37 : 58 : 30 : N : 122 :  1 : 48 : W : -8.0 : US
 Concord                          : New Hampshire         : USA                   : 43 : 12 : 21 : N :  71 : 32 : 25 : W : -5.0 : US
 Condon                           : Oregon                : USA                   : 45 : 13 : 58 : N : 120 : 10 :  1 : W : -8.0 : US
-Connabarabran                    :                       : Australia             : 31 : 16 :  6 : S : 149 :  4 :  0 : E : 10.0 : AU
+Coonabarabran                    :                       : Australia             : 31 : 16 :  6 : S : 149 :  4 :  0 : E : 10.0 : AU
 Consort                          : Alberta               : Canada                : 52 : 01 : 00 : N : 110 : 46 : 00 : W : -7.0 : US
 Conway                           : Arkansas              : USA                   : 35 :  6 :  0 : N :  92 : 27 :  0 : W : -6.0 : US
 Conway                           : New Hampshire         : USA                   : 44 :  0 :  0 : N :  71 : 10 :  1 : W : -5.0 : US

KDE/kdeedu/kstars/kstars/data/tools

SVN commit 858641 by asimha:

Adding machinery to generate the USNO NOMAD 1e8 portion much
faster.

nomadmysql2bin-split.c generates separate files for each trixel from
the database and nomadmysql2bin-merge.c puts them all together and
creates the index tables etc.

Also making nomadbinfiletester capable of handling large files.

CCMAIL: kstars-devel <at> kde.org

 M  +13 -4     Makefile  
 AM            generate-nomad-data-dumps.sh  
 M  +9 -3      nomadbinfiletester.c  
 A             nomadmysql2bin-merge.c   [License: GPL (v2+)]
 A             nomadmysql2bin-split.c   [License: GPL (v2+)]
 A             readnomadbindump.c   [License: GPL (v2+)]

--- trunk/KDE/kdeedu/kstars/kstars/data/tools/Makefile #858640:858641
@@ -15,24 +15,33 @@
 KSTARS_MYSQL_DB_TBL=tycho2
 KSTARS_NOMAD_MYSQL_DB_TBL=nomad

-all: mysql2bin binfiletester

+all: mysql2bin binfiletester nomadbinfiletester nomadmysql2bin-merge nomadmysql2bin-split
+
 mysql2bin: mysql2bin.c

KDE/kdeedu/kstars/kstars/skycomponents

SVN commit 858694 by asimha:

Default bright magnitude values had better be fainter than the
catalogs we have!

CCMAIL: kstars-devel <at> kde.org

 M  +1 -1      starblock.cpp  

--- trunk/KDE/kdeedu/kstars/kstars/skycomponents/starblock.cpp #858693:858694
@@ -50,7 +50,7 @@
         parent->releaseBlock( this );
     parent = NULL;
     faintMag = -5.0;
-    brightMag = 15.0;
+    brightMag = 35.0;
     nStars = 0;
 }