headers
Jason Harris | 2 Dec 06:50

KDE/kdeedu/kstars/kstars/tools

SVN commit 743859 by harris:

In the observing list, removing objects named "star" from the list now
removes the correct objects.

CCMAIL: kstars-devel <at> kde.org

 M  +12 -2     observinglist.cpp  

--- trunk/KDE/kdeedu/kstars/kstars/tools/observinglist.cpp #743858:743859
@@ -233,7 +233,17 @@
             QModelIndex mSortIndex = m_SortModel->index( irow, 0 );
             QModelIndex mIndex = m_SortModel->mapToSource( mSortIndex );
             foreach ( SkyObject *o, obsList() ) {
-                if ( o->translatedName() == mIndex.data().toString() ) {
+                //Stars named "star" must be matched by coordinates
+                if ( o->name() == "star" ) {
+                    int irow = mIndex.row();
+                    QString ra = m_Model->item(irow, 1)->text();
+                    QString dc = m_Model->item(irow, 2)->text();
+                    if ( o->ra()->toHMSString() == ra && o->dec()->toDMSString() == dc ) {
+                        slotRemoveObject( o );
+                        break;
+                    }
+
+                } else if ( o->translatedName() == mIndex.data().toString() ) {
                     slotRemoveObject( o );
                     break;
                 }
@@ -241,7 +251,7 @@
(Continue reading)

Permalink | Reply | 0 comments |
headers
Jason Harris | 2 Dec 07:13

KDE/kdeedu/kstars/kstars

SVN commit 743860 by harris:

Observing list wizard: 
The magnitude limit spinbo is now enabled when its 
checkbox is checked.
When defining a circular or rectangular region, the 
object count is not updated until all fields are filled in.

CCMAIL: kstars-devel <at> kde.org

 M  +32 -6     tools/obslistwizard.cpp  
 M  +3 -0      tools/obslistwizard.h  
 M  +2 -0      widgets/dmsbox.h  

--- trunk/KDE/kdeedu/kstars/kstars/tools/obslistwizard.cpp #743859:743860
@@ -59,17 +59,18 @@
     //Update the count of objects when certain UI elements are modified
     connect( olw->TypeList, SIGNAL( itemSelectionChanged() ), this, SLOT( slotUpdateObjectCount() ) );
     connect( olw->ConstellationList, SIGNAL( itemSelectionChanged() ), this, SLOT(
slotUpdateObjectCount() ) );
-    connect( olw->RAMin, SIGNAL( lostFocus() ), this, SLOT( slotUpdateObjectCount() ) );
-    connect( olw->RAMax, SIGNAL( lostFocus() ), this, SLOT( slotUpdateObjectCount() ) );
-    connect( olw->DecMin, SIGNAL( lostFocus() ), this, SLOT( slotUpdateObjectCount() ) );
-    connect( olw->DecMax, SIGNAL( lostFocus() ), this, SLOT( slotUpdateObjectCount() ) );
-    connect( olw->RA, SIGNAL( lostFocus() ), this, SLOT( slotUpdateObjectCount() ) );
-    connect( olw->Dec, SIGNAL( lostFocus() ), this, SLOT( slotUpdateObjectCount() ) );
+    connect( olw->RAMin, SIGNAL( lostFocus() ), this, SLOT( slotCheckRegion() ) );
+    connect( olw->RAMax, SIGNAL( lostFocus() ), this, SLOT( slotCheckRegion() ) );
+    connect( olw->DecMin, SIGNAL( lostFocus() ), this, SLOT( slotCheckRegion() ) );
+    connect( olw->DecMax, SIGNAL( lostFocus() ), this, SLOT( slotCheckRegion() ) );
(Continue reading)

Permalink | Reply | 0 comments |
headers
Jason Harris | 2 Dec 16:02

KDE/kdeedu/kstars/kstars/tools

SVN commit 744014 by harris:

Improvements to the Observing list wizard.

* Filtering by magnitude updates the object count correctly
* Moved logic outside of loops for filtering by rectangular/circular region
* Fixed Next/Prev buttons enabled state for first/last pages

CCMAIL: kstars-devel <at> kde.org

 M  +77 -70    obslistwizard.cpp  
 M  +4 -2      obslistwizard.h  

--- trunk/KDE/kdeedu/kstars/kstars/tools/obslistwizard.cpp #744013:744014
@@ -46,6 +46,7 @@
     setButtons( KDialog::User1|KDialog::User2|KDialog::Ok|KDialog::Cancel );
     setButtonGuiItem( KDialog::User1, KGuiItem( QString("< ") + i18n("&Back"), QString(), i18n("Go to
previous Wizard page") ) );
     setButtonGuiItem( KDialog::User2, KGuiItem( i18n("&Next") + QString(">"), QString(), i18n("Go to
next Wizard page") ) );
+    enableButton( KDialog::User1, false );

     connect( olw->AllButton, SIGNAL( clicked() ), this, SLOT( slotAllButton() ) );
     connect( olw->NoneButton, SIGNAL( clicked() ), this, SLOT( slotNoneButton() ) );
@@ -59,18 +60,18 @@
     //Update the count of objects when certain UI elements are modified
     connect( olw->TypeList, SIGNAL( itemSelectionChanged() ), this, SLOT( slotUpdateObjectCount() ) );
     connect( olw->ConstellationList, SIGNAL( itemSelectionChanged() ), this, SLOT(
slotUpdateObjectCount() ) );
-    connect( olw->RAMin, SIGNAL( lostFocus() ), this, SLOT( slotCheckRegion() ) );
(Continue reading)

Permalink | Reply | 0 comments |
headers
Tobias Powalowski | 2 Dec 16:41
X-Face
Picon
Picon

kstars in kdeedu 3.96.2 tarball broken

Hi
http://websvn.kde.org/trunk/KDE/kdeedu/kstars/kstars/indi/libs/indicom.c?r1=699071&r2=741058

[ 30%] Built target indi_apogee_alta
make -f kstars/kstars/indi/CMakeFiles/indi_sbig_stv.dir/build.make 
kstars/kstars/indi/CMakeFiles/indi_sbig_stv.dir/depend
CMakeFiles/indi_celestron_gps.dir/libs/indicom.o: In function 
`extractISOTime':
indicom.c:(.text+0xe92): undefined reference to `ln_get_date_from_tm'
collect2: ld returned 1 exit status
make[2]: Leaving directory `/home/tobias/Arch/devel/kde4/kdeedu/src/build'
make -f kstars/kstars/indi/CMakeFiles/indi_meade_lpi.dir/build.make 
kstars/kstars/indi/CMakeFiles/indi_meade_lpi.dir/build
make[2]: *** [kstars/kstars/indi/indi_celestron_gps] Error 1
make[2]: Leaving directory `/home/tobias/Arch/devel/kde4/kdeedu/src/build'
make[1]: *** [kstars/kstars/indi/CMakeFiles/indi_celestron_gps.dir/all] Error 
2
make[1]: *** Waiting for unfinished jobs....

somehow this commit seems to break compilation, with indi and libnova 
installed on the build system.

greetings
tpowa
--

-- 
Tobias Powalowski
Archlinux Developer & Package Maintainer (tpowa)
http://www.archlinux.org
tpowa <at> archlinux.org
(Continue reading)

Permalink | Reply | 1 comment |
headers
Jason Harris | 3 Dec 19:31

Re: kstars in kdeedu 3.96.2 tarball broken

Hello,

On Sunday 02 December 2007 08:41:02 am Tobias Powalowski wrote:
> somehow this commit seems to break compilation, with indi and libnova
> installed on the build system.
>
> greetings
> tpowa

I believe Jasem fixed this issue, with r741234[1].  IIUC, the problem is due 
to the fact that cmake was not checking the version of libnova that is 
installed.  If you don't want to update your sources, I think you could also 
get the latest version of libnova (Jasem, what is the minimum version that 
has the ln_get_date_from_tm function?)

Jason

[1]: http://www.nabble.com/KDE-kdeedu-kstars-kstars-tf4869291.html

--

-- 
KStars: KDE Desktop Planetarium
kstars <at> 30doradus.org
Permalink | Reply | 0 comments |
headers
Andrew Buck | 4 Dec 08:41
Picon
Favicon

Submitting my first patch and saying hello

Hello everyone, this is my first post to this mailing list, in fact the
first to any "dev" mailing list at all, so forgive me (and please
correct me) if I my message contains some sort of a problem.  I would
like to begin by thanking all of you for making this wonderful program,
I have learned more about the motions of the stars/planets your program
than from anywhere else, and I have only been using it a short time.

The primary reason for my post is I would like to submit a bit of a
patch, I hope to do more substantial work in the future but I haven't
learned too much about the code base yet so I am just "testing the
waters" with what I think might be a bit of a performance improvement.
I run a debian system so I grabbed a copy of the source code from
"apt-get source" and compiled it with deugging and profiling turned on.
After letting it crunch away at a time advance of 5 minutes to keep the
CPU loaded, I examined the grpof output and the biggest "self time" was
the function dms::setFromString(...) defined in dms.cpp.  Upon
examination of the function I found this block of code...

	QString entry = str.stripWhiteSpace();

	//remove any instances of unit characters.
	//h, d, m, s, ', ", or the degree symbol (ASCII 176)
	entry.replace( QRegExp("h"), "" );
	entry.replace( QRegExp("d"), "" );
	entry.replace( QRegExp("m"), "" );
	entry.replace( QRegExp("s"), "" );
	QString sdeg;
	sdeg.sprintf("%c", 176);
	entry.replace( QRegExp(sdeg), "" );
	entry.replace( QRegExp("\'"), "" );
(Continue reading)

Permalink | Reply | 1 comment |
headers
Luciano Montanaro | 4 Dec 10:41
Gravatar

Re: Submitting my first patch and saying hello

Il Tuesday 04 December 2007 08:41:56 Andrew Buck ha scritto:
> Hello everyone, this is my first post to this mailing list, in fact the
> first to any "dev" mailing list at all, so forgive me (and please
> correct me) if I my message contains some sort of a problem.  I would
> like to begin by thanking all of you for making this wonderful program,
> I have learned more about the motions of the stars/planets your program
> than from anywhere else, and I have only been using it a short time.
>
> The primary reason for my post is I would like to submit a bit of a
> patch, I hope to do more substantial work in the future but I haven't
> learned too much about the code base yet so I am just "testing the
> waters" with what I think might be a bit of a performance improvement.
> I run a debian system so I grabbed a copy of the source code from
> "apt-get source" and compiled it with deugging and profiling turned on.
> After letting it crunch away at a time advance of 5 minutes to keep the
> CPU loaded, I examined the grpof output and the biggest "self time" was
> the function dms::setFromString(...) defined in dms.cpp.  Upon
> examination of the function I found this block of code...
>
> 	QString entry = str.stripWhiteSpace();
>
> 	//remove any instances of unit characters.
> 	//h, d, m, s, ', ", or the degree symbol (ASCII 176)
> 	entry.replace( QRegExp("h"), "" );
> 	entry.replace( QRegExp("d"), "" );
> 	entry.replace( QRegExp("m"), "" );
> 	entry.replace( QRegExp("s"), "" );
> 	QString sdeg;
> 	sdeg.sprintf("%c", 176);
> 	entry.replace( QRegExp(sdeg), "" );
(Continue reading)

Permalink | Reply | 0 comments |
headers
Jason Harris | 5 Dec 16:40

Re: kstars in kdeedu 3.96.2 tarball broken

Hello,

The issue isn't the versioning in cmake.  It's that the linker is not
linking the libnova library for some reason.  I installed
libnova-0.12.1 here, and I get the same linker error that Tobias
reported:
Linking CXX executable indi_celestron_gps
CMakeFiles/indi_celestron_gps.dir/libs/indicom.o: In function `extractISOTime':
/home/kstars/kde/src/kdeedu/kstars/kstars/indi/libs/indicom.c:72:
undefined reference to `ln_get_date_from_tm'
/home/kstars/kde/src/kdeedu/kstars/kstars/indi/libs/indicom.c:78:
undefined reference to `ln_get_date_from_tm'
collect2: ld returned 1 exit status
make[2]: *** [kstars/kstars/indi/indi_celestron_gps] Error 1

However, ln_get_date_from_tm does indeed appear to be in the library:
% strings /usr/lib64/libnova.so | grep ln_get_date_from_tm
ln_get_date_from_tm

So it seems that the problem must be that the library is not getting
linked.  I took a quick look at the indi/CMakeLists.txt file but
unfortunately I really don't have time to dig into this today.  I hope
Jasem will be able to have a look before the RC2 tagging.

Jason

On 12/3/07, Tobias Powalowski <t.powa <at> gmx.de> wrote:
> On Monday 03 December 2007 19:31:41 Jason Harris wrote:
> > Hello,
> >
(Continue reading)

Permalink | Reply | 0 comments |
headers
Jasem Mutlaq | 5 Dec 18:58

KDE/kdeedu/kstars/kstars/indi

SVN commit 745194 by mutlaqja:

libnova wasn't linked due to a stupid copy/paste mistake! I was focusing my attention on a
completely different problem, and it turned out to be a one liner.
Sorry about the error, but I guess this is it.

CCMAIL:kstars-devel <at> kde.org

 M  +1 -1      CMakeLists.txt  

--- trunk/KDE/kdeedu/kstars/kstars/indi/CMakeLists.txt #745193:745194
@@ -233,7 +233,7 @@
 target_link_libraries(indi_celestron_gps ${KDE4_KDECORE_LIBS} m )

 if (NOVA_FOUND)
-  target_link_libraries(indi_lx200basic ${NOVA_LIBRARIES})
+  target_link_libraries(indi_celestron_gps ${NOVA_LIBRARIES})
 endif (NOVA_FOUND)

 install(TARGETS indi_celestron_gps DESTINATION ${BIN_INSTALL_DIR} )
Permalink | Reply | 0 comments |
headers
Jason Harris | 6 Dec 16:02

KDE/kdeedu/kstars/kstars

SVN commit 745603 by harris:

Fixing crash in jupiter moons tool.

This is a strange one.  Before applying this patch, opening the
jupiter moons tool (Ctrl+J) would crash KStars immediately (though I
clearly remember using it with no problem recently).  The backtrace
indicated the last code executed was ~JupiterMoons(), which consisted
of a single line:

    delete[] Moon;

because the four moons were stored as an array of TrailObject
pointers.  After a long time spent trying various fixes (I was misled
into thinking the problem was related to KPlotWidget, because there's
a similar-seeming and still-unresolved crash in modvizequinox, and
both use a KPlotWidget), I decided to change from an array of
TrailObject pointers to a QList.  Now the dtor looks like:

    qDeleteAll( Moon );

voila', no more crash.

I don't claim to understand what's going on here...

CCMAIL: kstars-devel <at> kde.org

 M  +5 -5      jupitermoons.cpp  
 M  +2 -1      jupitermoons.h  
 M  +4 -4      tools/jmoontool.cpp
(Continue reading)

Permalink | Reply | 0 comments |

Gmane