Tiny patch to correct some EBN warnings

Hello,

Here is a very tiny patch to correct some EBN warnings 
(http://www.englishbreakfastnetwork.org/krazy/reports/kde-4.0/kdeedu/kstars/index.html ) 
related to spelling and to QString::null. The patch is against SVN head.

Regards,

Médéric

_______________________________________________
Kstars-devel mailing list
Kstars-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel

KDE/kdeedu/kstars/kstars/data

SVN commit 641847 by harris:

Update DST rule for the US
CCMAIL: kstars-devel <at> kde.org

 M  +1 -1      TZrules.dat  

--- trunk/KDE/kdeedu/kstars/kstars/data/TZrules.dat #641846:641847
@@ -1,7 +1,7 @@
 #"US": DST starts on the first Sunday of April, reverts on the 
 #      last Sunday of October (2:00 am).  Canada uses this 
 #      rule as well.
-US  Apr  1Sun  02:00  Oct   Sun  02:00
+US  Mar  2Sun  02:00  Nov  1Sun  02:00

 #"MX": DST starts on the 1st Sunday of May, and switch back on 
 #      the last Sunday of September (2:00 am). (Mexico)

New DST rules in the US

Hello,

Starting this year, Daylight Savings Time in the US begins on the second 
Sunday in March, and reverts on the first Sunday in November. It used to 
start on the first Sunday in April, and revert on the last Sunday in October. 

KStars needs to know about DST rules, so you should update the relevant file. 
All you have to do is open the "Get New Stuff" tool (Ctrl+D), and install 
"Updated Daylight Savings Time rules" from the list.

regards,
Jason

--

-- 
KStars: KDE Desktop Planetarium
kstars <at> 30doradus.org

KDE/kdeedu/kstars/kstars

SVN commit 643494 by harris:

New visual Equinox/Solstice calculator module.  Instead of 
displaying the date/time of the solstice and equinox events 
for a given year, the events are highlighted on a plot of the 
Sun's declinatin as a function of time over the course of the 
given year.

Please have a look and let me know what you think; I may try to 
convert some other modules to this "visual" style as well.

CCMAIL: kstars-devel <at> kde.org

 M  +3 -2      CMakeLists.txt  
 M  +0 -31     kssun.cpp  
 M  +0 -10     kssun.h  
 M  +1 -1      tools/astrocalc.cpp  
 M  +2 -0      tools/modcalcapcoord.cpp  
 D             tools/modcalcequinox.cpp  
 D             tools/modcalcequinox.h  
 D             tools/modcalcequinox.ui  
 A             tools/modcalcvizequinox.cpp   [License: GPL (v2+)]
 A             tools/modcalcvizequinox.h   [License: GPL (v2+)]
 A             tools/modcalcvizequinox.ui  

--- trunk/KDE/kdeedu/kstars/kstars/CMakeLists.txt #643493:643494
@@ -29,6 +29,7 @@
 set(libkstarstools_SRCS 
 	tools/altvstime.cpp
 	tools/astrocalc.cpp

Re: KDE/kdeedu/kstars/kstars

On Saturday, 17. March 2007, Jason Harris wrote:

>  M  +3 -2      CMakeLists.txt
> @@ -29,6 +29,7 @@
>  set(libkstarstools_SRCS
>  	tools/altvstime.cpp
>  	tools/astrocalc.cpp
> +	tools/eqplotwidget.cpp
>  	tools/jmoontool.cpp
>  	tools/lcgenerator.cpp
>  	tools/modcalcangdist.cpp

Could you please add this file to SVN? the dashboard build is failing due to 
this for two days already. 

Dirk

Re: KDE/kdeedu/kstars/kstars

Am Montag, 19. März 2007 12:32 schrieb Dirk Mueller:
> >  M  +3 -2      CMakeLists.txt
> > @@ -29,6 +29,7 @@
> >  set(libkstarstools_SRCS
> >       tools/altvstime.cpp
> >       tools/astrocalc.cpp
> > +     tools/eqplotwidget.cpp
> >       tools/jmoontool.cpp
> >       tools/lcgenerator.cpp
> >       tools/modcalcangdist.cpp
>
> Could you please add this file to SVN? the dashboard build is failing due
> to this for two days already.

I just removed that line in the CMake-file, now at least cmake works. Of 
course, the code still doesn't compile.

ui_modcalcvizequinox.h:25:26: error: eqplotwidget.h: No such file or directory

Carsten

_______________________________________________
Kstars-devel mailing list
Kstars-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel

branches/KDE/3.5/kdeedu/kstars/kstars

SVN commit 645106 by harris:

Fixing bug #139676.  There was a bug in the calculation of a planet's 
phase angle, which resulted in nonsense magnitudes (most obviously in 
Mars).  For the Sun, the apparent magnitude was never set, so it 
displayed 0.0 instead of the true value of -26.73.

I will forward-port to trunk as well.

BUG: 139676
CCMAIL: kstars-devel <at> kde.org

 M  +12 -10    ksplanetbase.cpp  
 M  +1 -0      kssun.cpp  

--- branches/KDE/3.5/kdeedu/kstars/kstars/ksplanetbase.cpp #645105:645106
@@ -202,10 +202,11 @@
 	double cosDec, sinDec;
 	dec()->SinCos(cosDec, sinDec);
 	
-	//JH: Fixing calculation of phase. Using formula from 
-	//"Practical Astronomy With Your Calculator":
-	double d = ecLong()->radians() - helEcLong()->radians();
-	double f1 = 0.5*( 1 + cos( d ) );
+	/* Phase of the planet in degrees */
+	double earthSun = 1.;
+	double cosPhase = (rsun()*rsun() + rearth()*rearth() - earthSun*earthSun) 
+	  / (2 * rsun() * rearth() );   
+	double phase = acos ( cosPhase ) * 180.0 / dms::PI;

new Oxygen icon for KStars

Hello!

I was pleasantly surprised to see that the Oxygen team has already made a new 
icon for KStars.  Here it is:
http://websvn.kde.org/trunk/KDE/kdelibs/pics/oxygen/128x128/apps/kstars.png?revision=640052&view=markup

What do you think?  Should we lobby for keeping the old "brass sextant" icon, 
but updated and oxygen-ified?  Or are you happy with the telescope?  I guess 
I like it, although some color might be nice.

Jason
--

-- 
KStars: KDE Desktop Planetarium
kstars <at> 30doradus.org

Re: new Oxygen icon for KStars

--- Jason Harris <kstars <at> 30doradus.org> wrote:

> Hello!
> 
> I was pleasantly surprised to see that the Oxygen
> team has already made a new 
> icon for KStars.  Here it is:
>
http://websvn.kde.org/trunk/KDE/kdelibs/pics/oxygen/128x128/apps/kstars.png?revision=640052&view=markup
> 
> What do you think?  Should we lobby for keeping the
> old "brass sextant" icon, 
> but updated and oxygen-ified? 

Count me in this team :) 

Jasem