headers
Robert Mathias Marmorstein | 7 Jul 2011 22:07
Picon
Favicon
Gravatar

Review Request: Update kword and karbon filters to use libwpd-0.9 and libwpg-0.2

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101875/

Review request for KOffice.
By Robert Mathias Marmorstein.

Description

This patch updates kword and karbon to use new versions of the libwpX libraries. Mostly this is just a build system change, but required a few minor code changes.

Testing

Loaded an old WPD file into kword and some WPGs from the web into karbon. Both imported fine. Krazy passes all the files I modified and "make test" doesn't indicate any errors in the new code, either.

Diffs

  • cmake/modules/FindWPD.cmake (9bd788c)
  • cmake/modules/FindWPG.cmake (eeba521)
  • filters/karbon/wpg/import/CMakeLists.txt (7818d71)
  • filters/karbon/wpg/import/FileOutputHandler.hxx (811f972)
  • filters/karbon/wpg/import/FileOutputHandler.cxx (0f73b3b)
  • filters/karbon/wpg/import/GraphicsElement.hxx (8367e9a)
  • filters/karbon/wpg/import/GraphicsElement.cxx (362a71d)
  • filters/karbon/wpg/import/GraphicsHandler.hxx (8da653d)
  • filters/karbon/wpg/import/OdgExporter.hxx (ad6259a)
  • filters/karbon/wpg/import/OdgExporter.cxx (f386fbf)
  • filters/karbon/wpg/import/WPGImport.cpp (d40c25f)
  • filters/kword/wordperfect/import/wpimport.cc (c45c754)

View Diff

 
_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

The KOffice team has split into KOffice and Calligra suite. You find the Calligra project on the
calligra-devel <at> kde.org mailing list. More information at www.koffice.org and www.calligra-suite.org.
Permalink | Reply | 1 comment |
headers
Thomas Zander | 8 Jul 2011 07:25
Picon
Favicon

Re: Review Request: Update kword and karbon filters to use libwpd-0.9 and libwpg-0.2

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101875/

Ship it!

The changes look good to me.

- Thomas


On July 7th, 2011, 8:07 p.m., Robert Mathias Marmorstein wrote:

Review request for KOffice.
By Robert Mathias Marmorstein.

Updated July 7, 2011, 8:07 p.m.

Description

This patch updates kword and karbon to use new versions of the libwpX libraries. Mostly this is just a build system change, but required a few minor code changes.

Testing

Loaded an old WPD file into kword and some WPGs from the web into karbon. Both imported fine. Krazy passes all the files I modified and "make test" doesn't indicate any errors in the new code, either.

Diffs

  • cmake/modules/FindWPD.cmake (9bd788c)
  • cmake/modules/FindWPG.cmake (eeba521)
  • filters/karbon/wpg/import/CMakeLists.txt (7818d71)
  • filters/karbon/wpg/import/FileOutputHandler.hxx (811f972)
  • filters/karbon/wpg/import/FileOutputHandler.cxx (0f73b3b)
  • filters/karbon/wpg/import/GraphicsElement.hxx (8367e9a)
  • filters/karbon/wpg/import/GraphicsElement.cxx (362a71d)
  • filters/karbon/wpg/import/GraphicsHandler.hxx (8da653d)
  • filters/karbon/wpg/import/OdgExporter.hxx (ad6259a)
  • filters/karbon/wpg/import/OdgExporter.cxx (f386fbf)
  • filters/karbon/wpg/import/WPGImport.cpp (d40c25f)
  • filters/kword/wordperfect/import/wpimport.cc (c45c754)

View Diff

 
_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

The KOffice team has split into KOffice and Calligra suite. You find the Calligra project on the
calligra-devel <at> kde.org mailing list. More information at www.koffice.org and www.calligra-suite.org.
Permalink | Reply | 0 comments |
headers
Thomas Zander | 9 Jul 2011 15:32
Picon
Favicon

Review Request: Make kword WP import filter compile for me.

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101901/

Review request for KOffice.
By Thomas Zander.

Description

I got a compiler error on ubuntu (11.04 32 bit) due to a method signature difference; the code used size_t and the libwpd header file uses unsigned long. Downloading the tarball of libwpd (0.9.2) I confirmed that the red() method uses unsigned long. I want to update koffice to follow.

Diffs

  • filters/kword/wordperfect/import/wpimport.cc (8c8b8e3)

View Diff

 
_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

The KOffice team has split into KOffice and Calligra suite. You find the Calligra project on the
calligra-devel <at> kde.org mailing list. More information at www.koffice.org and www.calligra-suite.org.
Permalink | Reply | 1 comment |
headers
Robert Mathias Marmorstein | 9 Jul 2011 16:42
Picon
Favicon
Gravatar

Re: Review Request: Make kword WP import filter compile for me.

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101901/

Ship it!

Looks good!

- Robert Mathias


On July 9th, 2011, 1:32 p.m., Thomas Zander wrote:

Review request for KOffice.
By Thomas Zander.

Updated July 9, 2011, 1:32 p.m.

Description

I got a compiler error on ubuntu (11.04 32 bit) due to a method signature difference; the code used size_t and the libwpd header file uses unsigned long. Downloading the tarball of libwpd (0.9.2) I confirmed that the red() method uses unsigned long. I want to update koffice to follow.

Diffs

  • filters/kword/wordperfect/import/wpimport.cc (8c8b8e3)

View Diff

 
_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

The KOffice team has split into KOffice and Calligra suite. You find the Calligra project on the
calligra-devel <at> kde.org mailing list. More information at www.koffice.org and www.calligra-suite.org.
Permalink | Reply | 0 comments |

Gmane