Re: Review Request: Improvements and Bug fixes for Levels Filter

> On 2009-02-27 02:05:56, Boudewijn Rempt wrote:
> > Looks good!

If you think it's OK, feel free to commit. I don't have an SVN account.

- antiquark

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/182/#review290
-----------------------------------------------------------

On 2009-02-25 10:18:58, antiquark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/182/
> -----------------------------------------------------------
> 
> (Updated 2009-02-25 10:18:58)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> wdg_level.ui

Re: koffice/libs/kotext

On Saturday 28 February 2009, Pierre Stirnweiss wrote:
> Le samedi 28 février 2009 04:50:00, Thorsten Zachmann a écrit :
> > You are right here. If I add the <style:default-style
> > style:family="paragraph"> as defined in the file like it is done for
> > kword then the loading of the text formats is broken. Looks like we
> > missed something when we added this.
>
> Hello, I was looking into the test file you told me to see why my unit test
> was succeeding with defaultstyles.xml and why the presentation was buggy
> with the default-style added to the defaultstyles.xml.
> I might have overlooked something because the file is quite full, but the
> thing I don't get is that you have a <style:style name="P1"
> family="paragraph" fo:font-size="14pt"> defined in styles.xml and a
> <style:style name="P1" family="paragraph" with just margins defined> in
> automatic styles in content.xml.
> Is it valid? I thought there could only be one style with same name/family?

Yes it is valid, as long both styles are automatic styles. The one in 
styles.xml can only be used by stuff in the styles.xml file and the one in 
content.xml only by stuff in content.xml. Should I try to come up with a 
simpler example?

> Also, a lot of the styles and the default-style defined in the styles.xml
> have got the "graphic" family, how does this relate to the kotext
> ParagraphStyles?

ooimpress uses the graphic family for saving the styles. That is not a problem 
in general. There is one problem however the custom styles (<office:styles>) 
do not show up in the style manager due to that as there only styles with the 
family "paragraph" are handled at the moment. If kpresenter saves styles it 

Deselecting when clicking outside of canvas

Hello,

Sven created the following bug report:

https://bugs.kde.org/show_bug.cgi?id=185765

While the bug report is against kpresenter the problem is there for all 
applications that don't have a infinite canvas.

One idea to solve the problem would be to add KoTool::deselect() that would 
get called when a click event outside the canvas is triggered. Each tool 
would then need to implement it, so it works on all tools as this is a 
problem for all tools.

What do you think? Should we implement that. Should this be changed now or 
should we wait for after the release?

Have a nice weekend,

Thorsten

Re: koffice/libs/kotext

_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

Re: Deselecting when clicking outside of canvas

On Sunday 1. March 2009 06.42.33 Thorsten Zachmann wrote:
> Hello,
>
> Sven created the following bug report:
>
> https://bugs.kde.org/show_bug.cgi?id=185765
>
> While the bug report is against kpresenter the problem is there for all
> applications that don't have a infinite canvas.
>
> One idea to solve the problem would be to add KoTool::deselect() that would
> get called when a click event outside the canvas is triggered. Each tool
> would then need to implement it, so it works on all tools as this is a
> problem for all tools.
>
> What do you think? Should we implement that. Should this be changed now or
> should we wait for after the release?

What about we just tell the tool that a position that is outside the canvas is 
clicked on?  Something like -10, 0 ?
I wrote a patch for this that was meant to fix another problem, but can easily 
be adjusted to fit your bugreport.

The reason that patch is not committed yet is because it is pending feedback 
from the Krita guys because it worked on all apps except for Krita (and the 
patch *was* for a krita bug ;)

So my personal point of view is that we can wait till after 2.0 for this, the 
bug is minor (usability, not stability).

--

-- 
Thomas Zander

_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

Re: koffice/libs/kotext

On Sunday 01 March 2009, Pierre Stirnweiss wrote:
> Here is my nested spans example file, which works ok in KWord, even when
> defaultstyles.xml is there.

It works here as for the paragraph there is not font size defined. See that 
attached file for the error.

Thorsten

_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

Re: Applications categories

Hey!

On Sun, Mar 1, 2009 at 00:44, Andrew <andrew.dorrell <at> gmail.com> wrote:
> My voice is feeling very tiny in this thread...

If only I could tell how much I know this feeling...


> Andrew Dorrell wrote:
>> Publishing applications: kword, kpresenter
>> Graphics applications: karbon14, krita
>> Business applications: kspread, kexi, kplato
>> Tools: kchart, kformula
>
> Many writers would see kword as a creativity app 

Hehe. Indeed.
Actually I was playing with this categorisation and moved it around my
brain. AFAIK the colours are set now, so we cannot move kspread from
the frst to the third category anymore unless we have *really* good
reasons...

And I wonder if we have to publish this categories anyway...

koffice/kspread/part

SVN commit 933604 by jaham:

fix embedding in konqueror

CCBUG:181369
CCMAIL:koffice-devel <at> kde.org

 M  +2 -1      View.cpp  

--- trunk/koffice/kspread/part/View.cpp #933603:933604
 <at>  <at>  -1149,7 +1149,8  <at>  <at> 
     refreshView();

     // Activate the cell tool.
-    KoToolManager::instance()->switchToolRequested("KSpreadCellToolId");
+    if (shell()) 
+        KoToolManager::instance()->switchToolRequested("KSpreadCellToolId");
 }

 void View::activateFormulaEditor()

Re: Deselecting when clicking outside of canvas

On Sunday 01 March 2009, Thomas Zander wrote:

> The reason that patch is not committed yet is because it is pending
> feedback from the Krita guys because it worked on all apps except for Krita
> (and the patch *was* for a krita bug ;)

Yes... I've been trying this patch on and off, but it gives some very weird 
results that I haven't been able to describe properly, but which include 
infinite loops when some tools enter the canvas area. 

--

-- 
Boudewijn Rempt | http://www.valdyas.org

Re: Deselecting when clicking outside of canvas

_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel