[Patch] Bug 69284: Specified currency is ignored when formatting currency cells

The patch is attached to the bug report:
http://bugs.kde.org/show_bug.cgi?id=69284

Needed it to update the gnumeric import/export filters.

Note: I do not completely 100% understand the changes yet. I based
them on the rest of the code. So, please check if it's all ok, thanks.

[Patch] suggestion for: Bug 90569: goal seek ignores number format from locale

suggested patch is attached at the bug report:
http://bugs.kde.org/show_bug.cgi?id=90569

It works on my pc.

It would be nice if someone can test it too, thanks.

kpresenter crash + patch

Hello all,

I found a crash in kpresenter. The cause of the crash lies in the reference 
counters of command in the handling of grouped objects. One way to reproduce 
the crash is:

1. create a new document with a grouped object
2. save and close document
3. open the just saved document
4. ungroup the grouped object
5. undo the command
6. try to add an object to the page( other commands will also do, just the 
history has to be cleared ) -> crash

The reason of the crash is that the objects in the group are getting deleted.

The attached patch solves this problem. I really would appreciate if someone 
could have a look at the patch. I hope I have thought of everythink. What do 
you think?

The patch does the following:
if you in/decrement the refcounter on an grouped object all the subobjects are 
in/decremented. 
If you add/remove a grouped object to/from the object list all subobjects are 
added/removed from the object list.
It no longer tries to deletes the objects when they are removed from the 
object list.

Have a nice day,

Re: [Patch] suggestion for: Bug 90569: goal seek ignores number format from locale

On Fri, 1 Oct 2004 02:42:33 +0200, Tim Beaulen <tbscope <at> gmail.com> wrote:
> suggested patch is attached at the bug report:
> http://bugs.kde.org/show_bug.cgi?id=90569
> 
> It works on my pc.
> 
> It would be nice if someone can test it too, thanks.

Hm, you seem to be using KGlobal::locale() to access the locale class.
However, KSpread uses its own locale, KSpreadLocale, which derives
from KLocale and adds some extra functionality. Hence, I think you
should be using that one instead (it can be accessed using something
like m_view->doc()->locale() if I remember it correctly). Could you
modify the patch likewise and re-submit it?

/ Tomas

Re: [Patch] Bug 69284: Specified currency is ignored when formatting currency cells

On Fri, 1 Oct 2004 01:07:40 +0200, Tim Beaulen <tbscope <at> gmail.com> wrote:
> The patch is attached to the bug report:
> http://bugs.kde.org/show_bug.cgi?id=69284
> 
> Needed it to update the gnumeric import/export filters.
> 
> Note: I do not completely 100% understand the changes yet. I based
> them on the rest of the code. So, please check if it's all ok, thanks.

Committed, seems to be OK. Not 100% sure if the code is okay, as
KSpreadStyle badly needs some polishing, but hey...

/ Tomas

Re: Dock windows in Karbon, Kivio and Krita

On Thu, Sep 30, 2004 at 03:33:15PM +0200, Boudewijn Rempt wrote:
> So, I propose to move the kiviodockers to the KOffice UI library, and call the 
> dockers from all three applications. I've volunteered to do that job. I'll 
> write a patch for all three applications and show the patches to the 
> maintainers, and I'm willing to take up maintainership of the docker classes 
> in koffice ui libs.

I agree that they look best for most cases.  I would like to see a (future)
expansion where dragging the docker from the document-space will create a
toolbar (or QDock) so it is allowed to float outside the main window though.

If you move it to the kofficelibs, also take a look if the dockers can be
moved/duplicated between views. Its nasty that after a 'view->split view'
you have to re-add all your dockers in the new view.

Also; please take good care in making the API better; the APIs I have seen
from kivio in the past are really not that great..

> If I get the okay, I'll start work right away .

I'm not technically familiar with KOffice anymore; perhaps someone else
has problems with this, so don't see this as an OK just yet :)

--

-- 
Thomas Zander

_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org

Re: [Patch] suggestion for: Bug 90569: goal seek ignores number format from locale

Thanks,

used m_pView->doc()->locale() instead of KGlobal::locale().

On Fri, 1 Oct 2004 10:25:16 +0200, Tomas Mecir <mecirt <at> gmail.com> wrote:
> 
> Hm, you seem to be using KGlobal::locale() to access the locale class.
> However, KSpread uses its own locale, KSpreadLocale, which derives
> from KLocale and adds some extra functionality. Hence, I think you
> should be using that one instead (it can be accessed using something
> like m_view->doc()->locale() if I remember it correctly). Could you
> modify the patch likewise and re-submit it?
> 
> / Tomas
>

Re: Dock windows in Karbon, Kivio and Krita

On Friday 01 October 2004 13:35, Thomas Zander wrote:

> I agree that they look best for most cases.  I would like to see a (future)
> expansion where dragging the docker from the document-space will create a
> toolbar (or QDock) so it is allowed to float outside the main window
> though.

It should be possible to hack the Kivio dockers to make it possible to drag
the palettes out of the window; I guess the reason that doesn't work is 
because the window borders are also the areas where the docker slides into 
hiding if placed against. Cyrilla also mentioned this point, and it should be 
doable.

> If you move it to the kofficelibs, also take a look if the dockers can be
> moved/duplicated between views. Its nasty that after a 'view->split view'
> you have to re-add all your dockers in the new view.

I'm not sure I get this... Every view needs its own set of dockers, at least 
that's the way it is now, and I foresee a lot of problems if that chagnes..

>
> Also; please take good care in making the API better; the APIs I have seen
> from kivio in the past are really not that great..
>

This one is fairly nice, at least _I_ like it.
--

-- 
Boudewijn Rempt | "Geef mij maar zuurtjes."
http://www.valdyas.org/fading/index.cgi

Re: Dock windows in Karbon, Kivio and Krita

On Fri, Oct 01, 2004 at 02:22:48PM +0200, Boudewijn Rempt wrote:
> On Friday 01 October 2004 13:35, Thomas Zander wrote:
> > If you move it to the kofficelibs, also take a look if the dockers can be
> > moved/duplicated between views. Its nasty that after a 'view->split view'
> > you have to re-add all your dockers in the new view.
> 
> I'm not sure I get this... Every view needs its own set of dockers, at least 
> that's the way it is now, and I foresee a lot of problems if that chagnes..

What I mean; is that if you open a new view you expect (from a usability
point of view) that the old dockers are also available in the old one.
If that means adding the dockers on 'new view', then no problem.  I'm not
talking about implementation here :)

Please note that if a user dragged a docker out of a window, and wants to
drop it in another window you also have a problem.  For that reason I suggested
to 'move' the dockers.  That this means they are removed from one and new
instances are added to the other (if thats needed from a programming POV)
is irrelevant to the user.

> > Also; please take good care in making the API better; the APIs I have seen
> > from kivio in the past are really not that great..
> >
>
> This one is fairly nice, at least _I_ like it.

Ah; cool ;)

--

-- 
Thomas Zander

The state of KChart

Hello,

I wanted to translate the KChart Handbook into Dutch,
but reading it I realized that there isn't much to
translate and that a re-write was needed.

But playing around/testing KChart I noticed that there
are some serious problems with this application. There
seems to e a lot wrong with it, even if you just run
it as a stand-alone application. I already knew that
from using it from within KSpread is impossible
because there is something broken regarding the
transfer of data from the sheet to the application,
but now I'm convinced that the problem is actually
more serious.

So my question is if somebody is still maintaining
this piece of software and what the plans for the
future are.

Marc

P.S. While testing I wondered if it is possible to
edit a KPart in 'full-screen mode'. If you embed the
KPart in a smallish frame it can become very difficult
to work with it. I tried double clicking but this only
gives me the correct menus and toolbars, nothing else.
The frame with the embedded object remains small.