headers
Marc Heyvaert | 1 Apr 2004 06:04
Picon
Favicon

Re: copyright messages

Hi

--- David Faure <faure <at> kde.org> wrote:

> AFAIK the GNU people say that trivial changes don't
> give rights to
> become copyright holder.
> So people fixing one typo, changing whitespace, or
> adding one #include,
> don't need to be added. Those actually changing
> code, and more than
> one or two line, should be added.
> The line isn't very precise of course, but I think a
> little bit of common sense
> should be enough :)
> 

Well common sense is then what I shall (continue to)
use.

In fact I have a little file with developers names and
e-mail adresses. I go through WEBCVS where I can see
very easily what sort of commits have been made bt
whom and when. I also look at the comments in case the
commits have been made on behalf of someone else.

When there is no doubt I copy paste from my list. When
there is any doubt (judging from the comment or when I
see an unknown name) I use colored diff on the commit
or the latest 'annotate" version to see the extend of
(Continue reading)

Permalink | Reply | 0 comments |
headers
Nicolas Goutte | 1 Apr 2004 13:53
Picon

Re: copyright messages

On Wednesday 31 March 2004 14:19, Clarence Dang wrote:
> On Wed, 31 Mar 2004 08:55 pm, Marc Heyvaert wrote:
> > I'm back again fixing copyright messages in KSpread =
>
> Write a script to do it :)

Be careful that patches added by third person cannot be get by a script. So 
anyway you need to verify by hand afterwards.

>
(...)
>
> Clarence
>
>
> _______________________________________________
> koffice-devel mailing list
> koffice-devel <at> mail.kde.org
> https://mail.kde.org/mailman/listinfo/koffice-devel
Permalink | Reply | 0 comments |
headers
Nicolas Goutte | 1 Apr 2004 13:51
Picon

Re: KSpell2 and some other things

On Tuesday 30 March 2004 23:19, Zack Rusin wrote:
> On Tuesday 30 March 2004 12:39, Lukáš Tinkl wrote:
> > Great new Zack and thanks for your hard work on the spellcheck
> > engine. I have only one question: do you plan to move kspell2
> > entirely into koffice or leave it in kdenonbeta for the time being?
> > When do you you expect kdelibs to standardize on kspell2?
>
> I'd like to move it to kdelibs once the configuration dialog is done. It
> has to be a KCMDialog with :
> a) global page for picking the default language and the preferred
> client,
> b) custom plugin pages for plugin specific options.
> It's just that at the moment I'm flooded with work so unless someone
> will write the dialog, which I don't think is going to happen, all I
> can say is that kspell2 will be moved to kdelibs before the next
> freeze :)
> So basically the whole thing will include:
> 1) removing kospell from koffice,

> 2) if koffice will not depend on next kdelibs head then adding a copy of
> it and configure.in.in testing whether to compile it,

KOffice will still have to compile on KDE 3.2.x if KDE 3.3 final is not out. 
However as KOffice 1.4 final (or whatever will be its final version number) 
will be on KDE 4, you do not need to give full functionality (or not at all 
if it is easier) when working on KDE 3.2.x.

> 3) applying my patches to koffice,
> 4) look pretty (i got that one well covered).
>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Nicolas Goutte | 1 Apr 2004 14:26
Picon

Re: copyright messages

On Wednesday 31 March 2004 12:55, Marc Heyvaert wrote:
> Hello,
>
(...)
>
> 2. You have made a change and your name is not yet on
> the list : add (C) 2004 your name <your e-mail>

As we are discussiong it publicly: does the word "copyright" need to be on 
each copyright line or not?

If I remember well an email, only this word (and the exact copyright sign) are 
protected not "(C)". See also:
http://lists.kde.org/?l=kde-core-devel&m=106911152931134&w=2

Also there is also the problem about how years should be listed, see: 
http://lists.kde.org/?l=kde-devel&m=99375732508963&w=2 

>
(...)
>
>
> Regards

I am sorry to have not brought these problems earlier.

>
> Marc

Have a nice day!
(Continue reading)

Permalink | Reply | 5 comments |
headers
Marc Heyvaert | 1 Apr 2004 16:48
Picon
Favicon

Re: copyright messages

Hello,

Well, there is a license policy...

http://developer.kde.org/policies/licensepolicy.html

--- Nicolas Goutte <nicolasg <at> snafu.de> wrote:
> 
> As we are discussiong it publicly: does the word
> "copyright" need to be on 
> each copyright line or not?
> 
I read up on the links that you provided, and for me
it's clear that the word copyright has to be
there...and it is...only once but that is sufficient.
The "c in a circle" is not needed if the word
copyright is there. We substitute with '(C)' which is
not the same but this is not material in this case, in
fact, even the word copyright and date could be
ommitted, because the CVS provides us with proof of
creation of the work at a particular date. So I'm not
worried legally.

Read the following quote :

HOW TO SECURE A COPYRIGHT
Copyright Secured Automatically upon Creation
The way in which copyright protection is secured is
frequently misunderstood. No publication or
registration or other action in the Copyright Office
(Continue reading)

Permalink | Reply | 4 comments |
headers
Nicolas Goutte | 1 Apr 2004 19:35
Picon

Re: copyright messages

On Thursday 01 April 2004 16:48, Marc Heyvaert wrote:
> Hello,
>
> Well, there is a license policy...
>
> http://developer.kde.org/policies/licensepolicy.html

Yes, but it does not explain/fix how the copyright header should look like, 
only its minimum content.

>
> --- Nicolas Goutte <nicolasg <at> snafu.de> wrote:
> > As we are discussiong it publicly: does the word
> > "copyright" need to be on
> > each copyright line or not?
>
> I read up on the links that you provided, and for me
> it's clear that the word copyright has to be
> there...and it is...only once but that is sufficient.

Good, I see your point.

> The "c in a circle" is not needed if the word
> copyright is there. We substitute with '(C)' which is
> not the same but this is not material in this case, in

> fact, even the word copyright and date could be
> ommitted, because the CVS provides us with proof of
> creation of the work at a particular date. So I'm not
> worried legally.
(Continue reading)

Permalink | Reply | 2 comments |
headers
Marc Heyvaert | 1 Apr 2004 20:03
Picon
Favicon

Re: copyright messages

Hello Nicolas,

--- Nicolas Goutte <nicolasg <at> snafu.de> wrote:
> 
> No, that would be annoying for everybody, as it
> would force to open/save every 
> single source file as UTF-8, which is currently not
> needed (only a few files 
> need it.)
> 
> (There is no extended ASCII, ISO-8859-1 and UTF-8
> are byte-to-byte different 
> outside ASCII, even if ISO-8859-1 is 1:1 inside
> Unicode. But UTF-8 codes it 
> differently.)
> 
> > character -no extra font needed, so I think we can
> use
> 
> For Western Europe / Northern America only!
> 
Silly me! And I already did a test... with
kspread/KSpreadAppIface.cc

It compiled on my system and the CVS didn't seem to
mind and it displays ok on WEBCVS.

But I'l put it right.

I think that in info files it is also customary to use
(Continue reading)

Permalink | Reply | 1 comment |
headers
Thomas Zander | 1 Apr 2004 21:57
Picon
Favicon

Re: copyright messages


On Thursday 01 April 2004 16:48, Marc Heyvaert wrote:
>  in
> fact, even the word copyright and date could be
> ommitted, because the CVS provides us with proof of
> creation of the work at a particular date. So I'm not
> worried legally.

This is not strictly true; besides the 'external document' claim made 
elsewhere its easy to remove this kind of data from CVS (admin only) and 
therefor breaking this kind of documentation.
In other words; don't rely on revisions and dates being there for all time.

--

-- 
Thomas Zander
Permalink | Reply | 0 comments |
headers
Nicolas Goutte | 1 Apr 2004 22:03
Picon

Re: copyright messages

On Thursday 01 April 2004 20:03, Marc Heyvaert wrote:
> Hello Nicolas,
>
> --- Nicolas Goutte <nicolasg <at> snafu.de> wrote:
> > No, that would be annoying for everybody, as it
> > would force to open/save every
> > single source file as UTF-8, which is currently not
> > needed (only a few files
> > need it.)
> >
> > (There is no extended ASCII, ISO-8859-1 and UTF-8
> > are byte-to-byte different
> > outside ASCII, even if ISO-8859-1 is 1:1 inside
> > Unicode. But UTF-8 codes it
> > differently.)
> >
> > > character -no extra font needed, so I think we can
> >
> > use
> >
> > For Western Europe / Northern America only!
>
> Silly me! And I already did a test... with
> kspread/KSpreadAppIface.cc
>

> It compiled on my system and the CVS didn't seem to
> mind and it displays ok on WEBCVS.

Gcc does not really care. For it, it is just a sequence of bytes, especially
(Continue reading)

Permalink | Reply | 0 comments |
headers
Brad Hards | 2 Apr 2004 13:26
Picon

[patch] fix for Bug #76287 - please review


For bug:76287 (filename extension not added on save), I'd like to commit the 
following patch. Is this OK?

diff -u -4 -p -r1.106 webpresentation.cc
--- webpresentation.cc  25 Feb 2004 17:18:01 -0000      1.106
+++ webpresentation.cc  2 Apr 2004 11:24:02 -0000
 <at>  <at>  -1120,9 +1120,12  <at>  <at>  void KPWebPresentationCreateDialog::save

     filename = url.path();

     if ( !filename.isEmpty() ) {
       webPres.setConfig( filename );
+        if (filename.endsWith(".kpweb"))
+            webPres.setConfig( filename );
+        else
+            webPres.setConfig( filename + ".kpweb" );
         webPres.saveConfig();
     }
 }
Permalink | Reply | 3 comments |

Gmane