Burkhard Lück | 25 Jun 14:56 2016
Picon

Review Request 128286: Port i18n for stepcre to kf5

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128286/

Review request for KDE Edu.
By Burkhard Lück.
Repository: step

Description

use EXTRACT_TR_STRINGS instead of XGETTEXT_QT which works only for kde4 ecm_create_qm_loader

Diffs

  • CMakeLists.txt (c3b4784)
  • stepcore/CMakeLists.txt (4d85f97)
  • stepcore/Messages.sh (3b30376)

View Diff

_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
Burkhard Lück | 25 Jun 14:12 2016
Picon

Re: Review Request 127901: Update Parley handbook to 16.04

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127901/

docs/parley/index.docbook (Diff revision 1) 414 414
<para>After the solution is revealed, you see a big icon on the right that indicates if your answer will count as right or wrong.<!--FIXME this was removed?

This was removed?


docs/parley/index.docbook (Diff revision 1) 475 473 476 474 477 475 478 476 479 477 480 478 481 479 482 480 483 481 484 482 485 483 486 484 487 485 488 486 489 487 490 488 491 489 492 490 493 491 494 492 495 493 496 497
<!--FIXME this was removed?
<sect3 id="with-yes-no-answers"><title>With yes/no answers</title><sect3 id="with-yes-no-answers"><title>With yes/no answers</title>
<para>Normally &parley; automatically proposes one correct and several wrong answers in Multiple Choice mode. For some exercises instead you will have preset answers like yes/no or similar. And for these you have to configure the practice by clicking on <link linkend="advanced-practice-configuration"><guilabel>Configure Practice</guilabel></link>.<para>Normally &parley; automatically proposes one correct and several wrong answers in Multiple Choice mode. For some exercises instead you will have preset answers like yes/no or similar. And for these you have to configure the practice by clicking on <link linkend="advanced-practice-configuration"><guilabel>Configure Practice</guilabel></link>.
</para></para>
<para>Select the tab <guilabel>Specific</guilabel> and you will get something very similar to the following screenshot:<para>Select the tab <guilabel>Specific</guilabel> and you will get something very similar to the following screenshot:
</para></para>
<para><para>
<screenshot><screenshot>
<screeninfo></screeninfo><screeninfo></screeninfo>
<mediaobject> <mediaobject>
<imageobject> <imageobject>
<imagedata fileref="Parley_configure_specific.png" format="PNG"/> <imagedata fileref="configure_specific.png" format="PNG"/>
</imageobject> </imageobject>
<textobject> <textobject>
<phrase></phrase> <phrase></phrase>
</textobject> </textobject>
</mediaobject> </mediaobject>
</screenshot></screenshot>
</para></para>
<para>If you have just <emphasis>two choices</emphasis> like <emphasis>yes/no</emphasis> in the section <guilabel>Multiple Choice</guilabel> set the <guilabel>Number of choices</guilabel> to <guilabel>2</guilabel>.<para>If you have just <emphasis>two choices</emphasis> like <emphasis>yes/no</emphasis> in the section <guilabel>Multiple Choice</guilabel> set the <guilabel>Number of choices</guilabel> to <guilabel>2</guilabel>.
</para></para>
</sect3></sect3>
-->

This was removed and the sect is no longer valid?


docs/parley/index.docbook (Diff revision 1) 548 549 549 550 550 551 551 552 552 553 553 554 554 555 555 556 556 557 557 558 558 559 559 560 560 561 561 562 562 563 563 564 564 565 565 566 566 567 567 568 568 569 569 570 570 571 571 572 572 573 573 574 574 575 575 576 576 577 577 578 578 579 579 580 580 581 581 582 582 583 583 584 585
<sect2 id="counting-an-answer-as-right"><title>Counting an Answer as Right</title><sect2 id="counting-an-answer-as-right"><title>Counting an Answer as Right</title>
<para>After the solution is revealed, you see a big icon on the right that indicates if your answer will count as right or wrong.<para>After the solution is revealed, you see a big icon on the right that indicates if your answer will count as right or wrong.
</para></para>
<para>If you see the big checkmark, &parley; thinks you were right.<para>If you see the big checkmark, &parley; thinks you were right.
</para></para>
<para><para>
<screenshot><screenshot>
<screeninfo></screeninfo><screeninfo></screeninfo>
<mediaobject> <mediaobject>
<imageobject> <imageobject>
<imagedata fileref="Parley_practice_icon_right.png" format="PNG"/> <imagedata fileref="Parley_practice_icon_right.png" format="PNG"/>
</imageobject> </imageobject>
<textobject> <textobject>
<phrase></phrase> <phrase></phrase>
</textobject> </textobject>
</mediaobject> </mediaobject>
</screenshot></screenshot>
</para></para>
<para>If you needed more than one attempt to answer correctly, your answer will be counted as wrong.<para>If you needed more than one attempt to answer correctly, your answer will be counted as wrong.
</para></para>
<para><para>
<screenshot><screenshot>
<screeninfo></screeninfo><screeninfo></screeninfo>
<mediaobject> <mediaobject>
<imageobject> <imageobject>
<imagedata fileref="Parley_practice_icon_wrong.png" format="PNG"/> <imagedata fileref="Parley_practice_icon_wrong.png" format="PNG"/>
</imageobject> </imageobject>
<textobject> <textobject>
<phrase></phrase> <phrase></phrase>
</textobject> </textobject>
</mediaobject> </mediaobject>
</screenshot></screenshot>
</para></para>
<para>You can click the small icon next to the indicator to change how your answer is counted. The big symbol always indicates how the answer is counted.<para>You can click the small icon next to the indicator to change how your answer is counted. The big symbol always indicates how the answer is counted.
</para></para>
</sect2></sect2>
-->

This was removed from code?


docs/parley/index.docbook (Diff revision 1) 1741 1729 1742 1730 1743 1731 1744 1732 1745 1733 1746 1734 1747 1735 1748 1736 1749 1737 1750 1738 1751 1739 1752 1740 1753 1741 1754 1742 1755 1743
<chapter id="parley-on-windows"><title>Parley on Windows</title><chapter id="parley-on-windows"><title>Parley on Windows</title>
<para>It is possible to install Parley together with other <ulink url="http://edu.kde.org">Educational software</ulink> on Windows systems. For further info please visit <ulink url="http://windows.kde.org">this page</ulink>.<para>It is possible to install Parley together with other <ulink url="http://edu.kde.org">Educational software</ulink> on Windows systems. For further info please visit <ulink url="http://windows.kde.org">this page</ulink>.
</para></para>
<para>The steps to be followed in short:<para>The steps to be followed in short:
</para></para>
<para>Download the installer <ulink url="http://windows.kde.org/download.php">here</ulink><para>Download the installer <ulink url="http://windows.kde.org/download.php">here</ulink>
</para></para>
<para>Then follow the installation procedure like for any other Windows software - screenshots are <ulink url="http://www.winkde.org/pub/kde/ports/win32/installer/manual/">here</ulink>. <para>Then follow the installation procedure like for any other Windows software.
</para></para>
<para>When you come to the <guilabel>Package selection screen</guilabel>, select the language(s) you wish the software to be available in <emphasis>and</emphasis> the package - in this case <guilabel>kdeedu</guilabel>. If you don't select any language you will automatically get English.<para>When you come to the <guilabel>Package selection screen</guilabel>, select the language(s) you wish the software to be available in <emphasis>and</emphasis> the package - in this case <guilabel>kdeedu</guilabel>. If you don't select any language you will automatically get English.
</para></para>
<para>Then finish the installation process by clicking on next, following the coming screens just like you normally do with other windows software.<para>Then finish the installation process by clicking on next, following the coming screens just like you normally do with other windows software.
</para></para>
<para>Please note that the Parley team does not deal with the Windows-Installer and therefore we cannot easily answer your questions. Should you have difficulties, please contact the KDE-Windows team directly. You can do so by subscribing to the mailing list <ulink url="https://mail.kde.org/mailman/listinfo/kde-windows">here</ulink> or join them on IRC at irc://freenode.net Channel: #kde-windows.<para>Please note that the Parley team does not deal with the Windows-Installer and therefore we cannot easily answer your questions. Should you have difficulties, please contact the KDE-Windows team directly. You can do so by subscribing to the mailing list <ulink url="https://mail.kde.org/mailman/listinfo/kde-windows">here</ulink> or join them on IRC at irc://freenode.net Channel: #kde-windows.
</para></para>

Parley is afaik not available on Windows, right?


- Burkhard Lück


On Juni 18th, 2016, 5:14 nachm. UTC, Burkhard Lück wrote:

Review request for Documentation, KDE Edu, Andreas Cord-Landwehr, and Julian Helfferich.
By Burkhard Lück.

Updated Juni 18, 2016, 5:14 nachm.

Repository: parley

Description

proofreading new screenshots, not uploaded Please review the FIXME's with questions

Who should be added for review?

Testing

passes checkXML5

Diffs

  • docs/parley/index.docbook (420d137)

View Diff

_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
Julian Helfferich | 25 Jun 12:18 2016
Gravatar

Re: Review Request 127901: Update Parley handbook to 16.04

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127901/

Thank you for updating the docbook. I found just two typos.


docs/parley/index.docbook (Diff revision 1) 422
<!--FIXME Hint behaviour changed? 1. click -> no visible change, 2. click -> counted as wrong-->

The behaviour should be: Every time "Hint" is pressed, one option is grayed out. The answer is revealed when only one option is left. This seems to be a bug and I will look into it Monday.


docs/parley/index.docbook (Diff revision 1) 436 438
<para>Once you made your choice by clicking on what you believe to be correct, &parley; shows up with the screen below if the answer was right. Go ahead with the next question by clicking on <guilabel>Continue</guilabel>.<para>Once you made your choice by clicking on what you believe to be correct ot type the number in front of the choice, &parley; shows up with the screen below if the answer was right. Go ahead with the next question by clicking on <guilabel>Continue</guilabel>.

Typo: ot -> or


docs/parley/index.docbook (Diff revision 1) 614
<!--FIXME Example Sentences parctice missing -->

Typo: parctice -> practice


- Julian Helfferich


On June 18th, 2016, 12:14 p.m. CDT, Burkhard Lück wrote:

Review request for Documentation, KDE Edu, Andreas Cord-Landwehr, and Julian Helfferich.
By Burkhard Lück.

Updated June 18, 2016, 12:14 p.m.

Repository: parley

Description

proofreading new screenshots, not uploaded Please review the FIXME's with questions

Who should be added for review?

Testing

passes checkXML5

Diffs

  • docs/parley/index.docbook (420d137)

View Diff

_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
no-reply | 24 Jun 19:33 2016
Picon

Jenkins-kde-ci: marble master kf5-qt5 » Linux,gcc - Build # 146 - Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: https://build.kde.org/job/marble%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/146/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 24 Jun 2016 17:02:25 +0000
Build duration: 18 min

CHANGE SET
Revision 976b3fda308237366cfe391ffde48e275595e436 by Friedrich W. H. Kossebau: (Change more
&amp;quot;%L1&amp;quot; to QString::number in TestGeoDataCoordinates logging)
  change: edit tests/TestGeoDataCoordinates.cpp
Revision 75da2948cc2315df28c150ed062061cae95d85b7 by Friedrich W. H. Kossebau: (Reenable all data
again for TestGeoDataCoordinates::testFromLocaleString)
  change: edit tests/TestGeoDataCoordinates.cpp

JUNIT RESULTS
	
Name: (root) Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: TestSuite.TestGeoDataCoordinates

COBERTURA RESULTS

Cobertura Coverage Report

By packages
  
_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
Heiko Becker | 22 Jun 20:38 2016
Gravatar

Review Request 128275: Pass -fext-numeric-literals to fix the build with Qt 5.7

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128275/

Review request for KDE Edu and Andreas Cord-Landwehr.
By Heiko Becker.
Repository: rocs

Description

Otherwise I get "error: unable to find numeric literal operator 'operator""Q' BOOST_DEFINE_MATH_CONSTANT(half, 5.000000000000000..."

Testing

I assume this is due to Qt 5.7 requiring C++11 but to be honest I'm not entirely sure. However with this change, rocs builds fine again.

Diffs

  • CMakeLists.txt (8e2c4e8)

View Diff

_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
no-reply | 22 Jun 01:03 2016
Picon

Jenkins-kde-ci: kstars master kf5-qt5 » Linux,gcc - Build # 103 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: https://build.kde.org/job/kstars%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/103/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 21 Jun 2016 22:54:53 +0000
Build duration: 6 min 41 sec

CHANGE SET
Revision a431fc4893928132674e21218525e23b61a2125c by mutlaqja: (Do not try to sync text if it is write-only)
  change: edit kstars/indi/indielement.cpp
Revision 255818d1f3d2f2b3649eabc04a110e9a5ea91197 by mutlaqja: (Fix Web manager check/uncheck in editor)
  change: edit kstars/ekos/profileeditor.cpp
Revision bdcb7178c1552ff9a76379194132a7fd8116ba93 by mutlaqja: (Add support to remote astrometry
solver in INDI::CCD driver)
  change: edit kstars/ekos/align.cpp
  change: add kstars/ekos/remoteastrometryparser.h
  change: edit kstars/ekos/align.h
  change: edit kstars/kstars.kcfg
  change: edit kstars/ekos/align.ui
  change: add kstars/ekos/remoteastrometryparser.cpp
  change: edit kstars/CMakeLists.txt
  change: edit kstars/org.kde.kstars.Ekos.Align.xml
_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
Hartmut Riesenbeck | 19 Jun 22:18 2016
Picon
Picon
Gravatar

Review Request 128256: [Parley] Replace deprecated libkeduvocdocument methods

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128256/

Review request for KDE Edu.
By Hartmut Riesenbeck.
Repository: parley

Description

With commit ddb743b of libkeduvocdocument some methods which returned non const refereces to private member values of KEduVocTranslation have been set as deprecated. These methods were replaced with new provided ones.

Some unused lines were commented out to make the compiling free of warnings.

Testing

Tested manualy.

Diffs

  • src/collection/entryfilter.cpp (8d6ca047380ac9ba464a5a1b425215df9759a324)
  • src/dashboard/collectionwidget.cpp (3d1ff3300cc86be7c4d341872e77d7bb4096f791)
  • src/dashboard/dashboard.cpp (978935e080ce5ef07a84364af2c618f892180b50)
  • src/editor/conjugationwidget.cpp (d19d4fe7e7f23aec11192744c4cff6a576cbcbc6)
  • src/editor/multiplechoicewidget.cpp (b0412e82c5cdd00925c7f7c22dd801aac551ff56)
  • src/practice/configure/generalpracticeoptions.cpp (a4677bc84152d2cf019c48f972504151a468c760)
  • src/practice/conjugationbackendmode.cpp (b57595ea7d008de300cf0d87405f6e85d89a5552)
  • src/practice/practicemainwindow.cpp (3ca2d4e92cc2ee2823c8430bad7d76001033c9d2)
  • src/practice/sessionmanagerbase.cpp (bb4d08ca228ff00feb52179e80527bde69b0925e)
  • src/scripts/scripting/translation.h (5ef3ffe1eca6c7f309b182f9cee84f9559e0d9e2)
  • src/scripts/scripting/translation.cpp (e8845117a6e297822a0ed32d4841e46e67d71274)
  • src/statistics/statisticslegendwidget.cpp (46d3a3434608602ab977c3aebde2308bfb13aaab)

View Diff

_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
Alexander Potashev | 17 Jun 21:37 2016
Picon

Review Request 128229: Remove the google_images.py script: Google image search API is not available anymore

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128229/

Review request for KDE Edu and Andreas Cord-Landwehr.
By Alexander Potashev.
Bugs: 364373
Repository: parley

Description

Remove the google_images.py script: Google image search API is not available anymore

BUG: 364373 REVIEW: 128229

Testing

Parley does not crash anymore after opening a vocabulary.

Diffs

  • plugins/CMakeLists.txt (296b5eceebdcc99cfad791f689823e243dc404c2)
  • plugins/google_images.desktop (37ce88487a860a20862967da0369a9d278117027)
  • plugins/google_images.py (c4ccd6acf1bf9b0e7ed94c24c445789a1b450f5b)
  • plugins/google_images.ui (b8dc772069e9951d118916829ccab7639f9e0871)

View Diff

_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
Hartmut Riesenbeck | 16 Jun 16:52 2016
Picon
Picon
Gravatar

Review Request 128212: libkeduvocdocument: Non const references methods in KEduVocTranslation are set deprecated

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128212/

Review request for KDE Edu.
By Hartmut Riesenbeck.
Repository: libkeduvocdocument

Description

Two methods which returns non const refereces to private member values of KEduVocTranslation have been set as deprecated. Alternative getter/setter methods were added. The usage of the deprecated methods in the library were refactored to new methods.

Testing

Unit tests passed.

Diffs

  • keduvocdocument/keduvockvtml2writer.cpp (682095503680ddf4fd2f1dfe3de8e94fc28fc69d)
  • keduvocdocument/keduvoctranslation.h (2b72d7a516352ed6f1418d0b9d7a0ac56f511e42)
  • keduvocdocument/keduvoctranslation.cpp (c098060fe98679edd5f45cd451657d378d08cdd9)
  • keduvocdocument/readerwriters/keduvockvtml2reader.cpp (0bcb4bde0b3455f171002294aad4488abb175543)
  • keduvocdocument/readerwriters/keduvockvtmlreader.cpp (063ac7e2eba447334ea7ead7ba4ed17b3f361de8)

View Diff

_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
no-reply | 15 Jun 00:15 2016
Picon

Jenkins-kde-ci: rocs Applications-14.12 latest-qt4 » Linux,gcc - Build # 1 - Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: https://build.kde.org/job/rocs%20Applications-14.12%20latest-qt4/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 22:09:00 +0000
Build duration: 5 min 51 sec

CHANGE SET
No changes

JUNIT RESULTS
	
Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.TestScriptEngine

COBERTURA RESULTS

Cobertura Coverage Report

By packages
  
_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
no-reply | 15 Jun 00:13 2016
Picon

Jenkins-kde-ci: rocs Applications-14.12 stable-qt4 » Linux,gcc - Build # 1 - Successful!


GENERAL INFO

BUILD SUCCESS
Build URL: https://build.kde.org/job/rocs%20Applications-14.12%20stable-qt4/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 22:09:00 +0000
Build duration: 4 min 3 sec

CHANGE SET
No changes

JUNIT RESULTS
	
Name: (root) Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 14 test(s)

COBERTURA RESULTS

Cobertura Coverage Report

By packages
  
_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

Gmane