no-reply | 23 May 17:40 2016
Picon

Jenkins-kde-ci: marble master kf5-qt5 » Linux,gcc - Build # 56 - Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: https://build.kde.org/job/marble%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/56/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 May 2016 15:31:47 +0000
Build duration: 8 min 43 sec

CHANGE SET
Revision b64b2e584c0b4270ad843d461588aa06eb3d4841 by Friedrich W. H. Kossebau: (Use type const
char[] instead of const char* for const string)
  change: edit src/apps/behaim/main.cpp
  change: edit src/lib/marble/osm/OsmPlacemarkData.cpp
  change: edit src/lib/marble/geodata/parser/GeoDataTypes.h
  change: edit src/lib/marble/geodata/handlers/dgml/DgmlAuxillaryDictionary.cpp
  change: edit src/plugins/runner/osm/OsmElementDictionary.h
  change: edit src/plugins/runner/gpx/handlers/GPXElementDictionary.cpp
  change: edit src/lib/marble/osm/OsmPlacemarkData.h
  change: edit src/lib/marble/geodata/handlers/dgml/DgmlElementDictionary.h
  change: edit src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.h
  change: edit src/lib/marble/geodata/handlers/kml/KmlElementDictionary.cpp
  change: edit src/apps/marble-maps/main.cpp
  change: edit src/apps/marble-qt/QtMainWindow.cpp
  change: edit src/plugins/runner/osm/OsmElementDictionary.cpp
  change: edit src/lib/marble/geodata/parser/GeoSceneTypes.h
  change: edit src/lib/marble/geodata/data/GeoDataCoordinates.cpp
  change: edit src/lib/marble/geodata/parser/GeoDataTypes.cpp
  change: edit src/lib/marble/geodata/parser/GeoSceneTypes.cpp
  change: edit src/lib/marble/geodata/handlers/kml/KmlElementDictionary.h
(Continue reading)

Hartmut Riesenbeck | 18 May 21:52 2016
Picon
Picon

Review Request 127958: Fix Coverty Scan ID 1342042 - Explicit null dereferenced

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127958/

Review request for KDE Edu.
By Hartmut Riesenbeck.
Repository: parley

Description

KGameThemeSelectorPrivate::_k_updateThemeList() was made more robust to prevent null pointer access when an entry in themeMap was not found. For this case the value() method returns a null pointer which was not checked before refactoring.

Diffs

  • src/settings/kgametheme/kgamethemeselector.cpp (dc896d5792e6090f63dfb54c6c377e5971f41aeb)

View Diff

_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
Yao-Wang Li | 17 May 23:43 2016
Picon
Gravatar

articulate did not work on arch linux

Hi everybody,

I installed the articulate from the AUR, while I cannot use it. 
Nothing was showed on the software GUI. It was also empty on the GUI
when I wanted to download the course. 

Best Regards,

Yaowang
_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
no-reply | 14 May 02:38 2016
Picon

Jenkins-kde-ci: kstars master kf5-qt5 » Linux,gcc - Build # 66 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: https://build.kde.org/job/kstars%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/66/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 14 May 2016 00:36:16 +0000
Build duration: 2.5 sec

CHANGE SET
No changes
_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
Burkhard Lück | 12 May 21:06 2016
Picon

Review Request 127901: Update Parley handbook to 16.04

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127901/

Review request for Documentation and KDE Edu.
By Burkhard Lück.
Repository: parley

Description

proofreading new screenshots, not uploaded Please review the FIXME's with questions

Who should be added for review?

Testing

passes checkXML5

Diffs

  • docs/parley/index.docbook (420d137)

View Diff

_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
no-reply | 11 May 17:50 2016
Picon

Jenkins-kde-ci: kstars master kf5-qt5 » Linux,gcc - Build # 62 - Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: https://build.kde.org/job/kstars%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/62/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 11 May 2016 15:45:42 +0000
Build duration: 5 min 13 sec

CHANGE SET
Revision 65c7ddb115228a1056fe3218d6701c75d15f0638 by mutlaqja: (Enabling Tests directory again and
organizing test directory for the)
  change: edit kstars/skyobjects/deepskyobject.h
  change: edit kstars/CMakeLists.txt
  change: add Tests/auxiliary/testcsvparser.cpp
  change: delete Tests/testcsvparser.cpp
  change: edit datahandlers/catalogdb.h
  change: edit kstars/skycomponents/cometscomponent.h
  change: delete Tests/testfwparser.cpp
  change: add Tests/auxiliary/testdms.h
  change: add Tests/auxiliary/CMakeLists.txt
  change: edit Tests/CMakeLists.txt
  change: edit datahandlers/catalogdb.cpp
  change: edit kstars/printing/printingwizard.cpp
  change: edit kstars/skycomponents/constellationartcomponent.cpp
  change: edit kstars/dialogs/exportimagedialog.cpp
  change: delete Tests/testcsvparser.h
  change: edit kstars/skycomponents/catalogcomponent.h
  change: add Tests/auxiliary/testfwparser.h
  change: edit kstars/skyobjects/constellationsart.cpp
  change: add Tests/auxiliary/testcsvparser.h
  change: edit kstars/skycomponents/constellationartcomponent.h
  change: edit kstars/skycomponents/asteroidscomponent.h
  change: edit kstars/kstarsdata.h
  change: delete Tests/testfwparser.h
  change: edit kstars/skycomponents/skymapcomposite.cpp
  change: edit kstars/skycomponents/deepskycomponent.h
  change: edit kstars/skycomponents/flagcomponent.cpp
  change: add Tests/auxiliary/testdms.cpp
  change: add Tests/auxiliary/testfwparser.cpp
  change: edit kstars/printing/pwizfovsh.cpp
  change: edit kstars/skyobjects/constellationsart.h
  change: edit CMakeLists.txt
  change: edit datahandlers/ksparser.h
  change: edit kstars/printing/shfovexporter.cpp
  change: edit kstars/skycomponents/catalogcomponent.cpp

JUNIT RESULTS
	
Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.DMSTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/21 (95%)FILES 166/510 (33%)CLASSES 166/510 (33%)LINE 594/62856 (1%)CONDITIONAL
567/38751 (1%)

By packages

	Tests.auxiliary
		FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 254/254 (100%)CONDITIONAL 164/308 (53%)
	datahandlers
		FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 120/628 (19%)CONDITIONAL 83/320 (26%)
	kstars
		FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 15/4980 (0%)CONDITIONAL 28/3802 (1%)
	kstars.auxiliary
		FILES 8/33 (24%)CLASSES 8/33 (24%)LINE 25/11774 (0%)CONDITIONAL 16/7830 (0%)
	kstars.dialogs
		FILES 8/18 (44%)CLASSES 8/18 (44%)LINE 8/1883 (0%)CONDITIONAL 16/1046 (2%)
	kstars.ekos
		FILES 10/35 (29%)CLASSES 10/35 (29%)LINE 10/9940 (0%)CONDITIONAL 20/6293 (0%)
	kstars.ekos.guide
		FILES 1/11 (9%)CLASSES 1/11 (9%)LINE 1/2090 (0%)CONDITIONAL 2/882 (0%)
	kstars.fitsviewer
		FILES 2/12 (17%)CLASSES 2/12 (17%)LINE 6/2453 (0%)CONDITIONAL 4/1348 (0%)
	kstars.htmesh
		FILES 5/23 (22%)CLASSES 5/23 (22%)LINE 5/1448 (0%)CONDITIONAL 10/1502 (1%)
	kstars.indi
		FILES 7/46 (15%)CLASSES 7/46 (15%)LINE 7/4968 (0%)CONDITIONAL 14/3531 (0%)
	kstars.oal
		FILES 4/25 (16%)CLASSES 4/25 (16%)LINE 4/1497 (0%)CONDITIONAL 8/769 (1%)
	kstars.options
		FILES 5/8 (63%)CLASSES 5/8 (63%)LINE 5/600 (1%)CONDITIONAL 10/264 (4%)
	kstars.printing
		FILES 7/37 (19%)CLASSES 7/37 (19%)LINE 7/1602 (0%)CONDITIONAL 14/730 (2%)
	kstars.projections
		FILES 7/14 (50%)CLASSES 7/14 (50%)LINE 7/465 (2%)CONDITIONAL 14/246 (6%)
	kstars.skycomponents
		FILES 34/77 (44%)CLASSES 34/77 (44%)LINE 36/4175 (1%)CONDITIONAL 68/2897 (2%)
	kstars.skyobjects
		FILES 14/35 (40%)CLASSES 14/35 (40%)LINE 36/3332 (1%)CONDITIONAL 26/1406 (2%)
	kstars.time
		FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/436 (0%)CONDITIONAL 0/282 (0%)
	kstars.tools
		FILES 27/56 (48%)CLASSES 27/56 (48%)LINE 27/8922 (0%)CONDITIONAL 54/4572 (1%)
	kstars.tools.whatsinteresting
		FILES 5/14 (36%)CLASSES 5/14 (36%)LINE 18/466 (4%)CONDITIONAL 10/277 (4%)
	kstars.widgets
		FILES 2/25 (8%)CLASSES 2/25 (8%)LINE 2/826 (0%)CONDITIONAL 4/424 (1%)
	kstars.xplanet
		FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 1/117 (1%)CONDITIONAL 2/22 (9%)
_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
Julian Helfferich | 11 May 06:14 2016
Gravatar

Review Request 127891: Parley: Quickly edit vocabularies during practice

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127891/

Review request for KDE Edu and KDE Usability.
By Julian Helfferich.
Bugs: 170534
Repository: parley

Description

I have implemented a wish request (bug 170534) I would very much see in Parley: Add an option to edit the vocabulary during practice. To keep the review request small, I have implemented the quick edit option only for Flashcard practice. However, the approach is easy to extend.

I took the following approach:

  • The QLabel displaying the question/solution is replaced by a custom widget.
  • The widget is designed to behave similar to a QLabel, but it adds an additional action to the right-click context menu: "Edit vocabulary entry" (see screenshot 1).
  • When this option is selected, the QLabel is swapped with a QLineEdit and two ToolButtons for "Accept" and "Cancel" (see screenshot 2).
  • Clicking the "Cancel" button brings back the Label displaying the question/solution.
  • Clicking the "Accept" button or pressing enter brings back the question/solution label and emits the entryEdited() signal.
  • This signal is passed on to Practice State Machine as questionEdited() or solutionEdited() which modifies the vocabulary entry.

The approach does not make the quick edit option very obvious. Instead, I have opted for not changing the look and feel of the application. Another option would be to add an "edit" ToolButton (see screenshot 3).

Testing

Flashcard practice.

Started editing -> Canceled edit Started editing -> Accepted edit -> Confirmed that vocabulary was modified Started editing -> Pressed continue/Answer later/Hint

Diffs

  • src/CMakeLists.txt (fd352de)
  • src/practice/abstractfrontend.h (f5f9552)
  • src/practice/editable_label.ui (PRE-CREATION)
  • src/practice/editablelabel.h (PRE-CREATION)
  • src/practice/editablelabel.cpp (PRE-CREATION)
  • src/practice/flashcardmodewidget.cpp (ced6ca6)
  • src/practice/practice_widget_flashcard.ui (e1aa099)
  • src/practice/practicestatemachine.h (b67ba32)
  • src/practice/practicestatemachine.cpp (8756592)
  • src/practice/rightclickeditlabel.h (PRE-CREATION)
  • src/practice/rightclickeditlabel.cpp (PRE-CREATION)

View Diff

File Attachments

  • Additional context menu entry
  • Edit vocabulary entry
  • Edit tool button
  • _______________________________________________
    kde-edu mailing list
    kde-edu <at> mail.kde.org
    https://mail.kde.org/mailman/listinfo/kde-edu
    
    Hartmut Riesenbeck | 10 May 15:23 2016
    Picon
    Picon

    Review Request 127886: Fix Coverty Scan ID 259547 - Uninitialized pointer field

    This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127886/

    Review request for KDE Edu.
    By Hartmut Riesenbeck.
    Repository: parley

    Description

    Missing initialization of m_parent in default constructor of class Translator was fixed.

    Diffs

    • src/scripts/translator.cpp (e96e6f857e72d183ee7775882d6b2125c94e3dea)

    View Diff

    _______________________________________________
    kde-edu mailing list
    kde-edu <at> mail.kde.org
    https://mail.kde.org/mailman/listinfo/kde-edu
    
    Hartmut Riesenbeck | 10 May 09:50 2016
    Picon
    Picon

    Review Request 127881: Fix theme cache path handling

    This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127881/

    Review request for KDE Edu.
    By Hartmut Riesenbeck.
    Repository: parley

    Description

    When path to theme cache file does not exitst (e.g. after a fresh installation) it is not created automatically which caused the following error to be shown on stderr while reading and writing:

    "QIODevice::read (QFile, "/path/to/theme/cache/startpagethemecache.bin" ): device not open"

    Automatic creation of theme cache path is added. Location of cache file is moved to QStandardPaths::CacheLocation.

    Because for me it looks like that the theme image cache is what its name shows, a cache. I think that it's better to store it at QStandardPaths::CacheLocation rather then QStandardPaths::DataLocation.

    Diffs

    • src/practice/imagecache.h (26afb8a5439d0909a8410c992eadd9cbe021fc5c)
    • src/practice/imagecache.cpp (9d01395804c6bce3551743292790e6b642ab9337)
    • src/practice/themedbackgroundrenderer.cpp (7623d69369e189abd66c4fff39b023fae32b73d1)

    View Diff

    _______________________________________________
    kde-edu mailing list
    kde-edu <at> mail.kde.org
    https://mail.kde.org/mailman/listinfo/kde-edu
    
    Burkhard Lück | 8 May 19:08 2016
    Picon

    Review Request 127871: Upfate KGeography docbook to 16.04

    This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127871/

    Review request for Documentation, KDE Edu and Albert Astals Cid.
    By Burkhard Lück.
    Repository: kgeography

    Description

    remove entities package + kappname + kgeography bump date + releaseinfo remove somme comments fix link to world map replace KDEDIR with XDG_DATA_HOME replace kde4-config with kf5-config remove chapter faq remove appendix proofreading new screenshots, already committed

    Testing

    passes checkXML5

    Diffs

    • doc/index.docbook (aed8bf1)

    View Diff

    _______________________________________________
    kde-edu mailing list
    kde-edu <at> mail.kde.org
    https://mail.kde.org/mailman/listinfo/kde-edu
    
    Burkhard Lück | 7 May 21:39 2016
    Picon

    Review Request 127861: Remove Extra toolbar

    This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127861/

    Review request for KDE Edu and Jeremy Whiting.
    By Burkhard Lück.
    Repository: kiten

    Description

    comment Extra toolbar, it is empty and just confusing users

    Testing

    builds

    Diffs

    • app/kitenui.rc (8c779d0)

    View Diff

    _______________________________________________
    kde-edu mailing list
    kde-edu <at> mail.kde.org
    https://mail.kde.org/mailman/listinfo/kde-edu
    

    Gmane