Re: Review Request: PATCH: Honor size and coordinates when creating new Konqueror windows

Re: QComboBox vs KConfigDialogManager

On Tuesday, May 31, 2011 21:55:59 Jeremy Whiting wrote:
> 1) Check if the widget has a kcfg_property is set on the widget.  If so, use
> that property's value as the property to record.
> 2) Check if the widget has a User property to save (This was not set in
> QComboBox in 4.7 but is set in 4.8 to the currentIndex property)
> 3) Try casting to a combobox and use the current text if the combobox is
> editable, otherwise use the currentIndex
> 
> Anyone here can guess where the problem lies? 

erf!

> a) change all our .ui files KComboBox, QComboBox widgets to have
> kcfg_property set if we want to save the currentText as the value of the
> config item.

this doesn't sound like a great solution since it means not only a lot of work 
and testing in our own repos (with a high risk of missing something), but it 
will affect all third parties as well (which we can't guarantee will notice or 
provide a fix on their own). a fix, even if it is a (well documented with 
comments ;) work-around, in KConfigDialogManager would probably be more 
valuable as a result.

--

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

On Mon, Apr 25, 2011 at 6:54 PM, Olivier Goffart <ogoffart <at> kde.org> wrote:

> In this case, we have to see if we can fix it in Qt. I do not see any solution
> on top of my head. We have to discuss if it is ok to break this use case if
> there is no solution.

The Qt documentation, about signals and slots[1] says this:

"Since slots are normal member functions, they follow the normal C++
rules when called directly. However, as slots, they can be invoked by
any component, regardless of its access level, via a signal-slot
connection. This means that a signal emitted from an instance of an
arbitrary class can cause a private slot to be invoked in an instance
of an unrelated class."

This makes a promise that any class can use a private slot without
access checking. It doesn't say how that slot was declared, just that
the private slot can be invoked by any other class. The change to
Q_PRIVATE_SLOT introduces access checking of slots and breaks the
promise, and so it needs to be left unchanged until Qt 5.

Regards, Eli.

[1] http://doc.qt.nokia.com/latest/signalsandslots.html#slots

Re: Review Request: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

Re: Review Request: kcm-grub2

On Thu, May 26, 2011 at 00:03, Konstantinos Smanis
<konstantinos.smanis <at> gmail.com> wrote:
>> The following line should probably be simplified (see
>> http://websvn.kde.org/?revision=1184860&view=revision):
>>
>> src/kcm_grub2.cpp:113:                    QTreeWidgetItem *item = new
>> QTreeWidgetItem(ui.treeWidget_recover, QStringList(QString()) << name
>> << partition->filePath() << volume->label() << volume->fsType() <<
>> i18n("%1 GiB", QString::number(volume->size() / 1073741824)));
>
> Thanks. Fixed: http://commits.kde.org/kcm-grub2/87eac2b1ef0b8f3a1907b86ab7054b99a0ed5ab9
>
> Konstantinos

If noone else objects, would it be possible for a sysadmin to make the move?

Thanks,
Konstantinos

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

On Wednesday, 1 de June de 2011 01:42:13 argonel wrote:
> This makes a promise that any class can use a private slot without
> access checking. It doesn't say how that slot was declared, just that
> the private slot can be invoked by any other class. The change to
> Q_PRIVATE_SLOT introduces access checking of slots and breaks the
> promise, and so it needs to be left unchanged until Qt 5.

You're assuming you're allowed to use Q_PRIVATE_SLOT. That macro is not 
documented, so any use of it outside Qt is suspect by itself. Qt makes promise 
of source compatibility when using it.

--

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

Re: kio/scheduler: Does not compile with Qt from 4.8 branch

Isn't this problem easily solvable by changing those slots defined in
Q_PRIVATE_SLOT to actual private slots of KIO::Scheduler and
forwarding the call to the existing code ? See attached patch.

On Wed, Jun 1, 2011 at 10:47 AM, Jeremy Whiting <jpwhiting <at> kde.org> wrote:
> Until those that know the code get this issue sorted out,  I've pasted a
> small workaround that gets it to build here:
> http://paste.kde.org/77059/
>
> Jeremy
>
> On Wed, Jun 1, 2011 at 2:39 AM, Thiago Macieira <thiago <at> kde.org> wrote:
>>
>> On Wednesday, 1 de June de 2011 01:42:13 argonel wrote:
>> > This makes a promise that any class can use a private slot without
>> > access checking. It doesn't say how that slot was declared, just that
>> > the private slot can be invoked by any other class. The change to
>> > Q_PRIVATE_SLOT introduces access checking of slots and breaks the
>> > promise, and so it needs to be left unchanged until Qt 5.
>>
>> You're assuming you're allowed to use Q_PRIVATE_SLOT. That macro is not
>> documented, so any use of it outside Qt is suspect by itself. Qt makes
>> promise
>> of source compatibility when using it.
>>
>> --
>> Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
>>  Senior Product Manager - Nokia, Qt Development Frameworks
>>      PGP/GPG: 0x6EF45358; fingerprint:
>>      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
>
>

Re: Review Request: PATCH: When user selects 'Open With...', show the open with dialog

Review Request: Fix KComboBox KConfigXT bug when using qt 4.8