Re: [PATCH] Request review for KSharedDataCache (Round 2)

On Thursday, April 29, 2010 21:12:42 Michael Pyne wrote:
> Well that [changeable layout] isn't what *I* wanted, but I see your point
> given that precondition, and it occurs to me that the one having to touch
> my code afterwards may want to change the layout, so I'll move it around
> indeed.

For everyone's information, KSharedDataCache and KImageCache are now in trunk. 
I'll give it a day or two for any last minute comments and port KIconLoader 
over shortly.

For my Plasma dev friends, I also intend to port Plasma::Theme over to use 
KImageCache, using the attached patch. Please let me know if there are 
problems with this.

Regards,
 - Michael Pyne

Re: [PATCH] Request review for KSharedDataCache (Round 2)

On April 30, 2010, Michael Pyne wrote:
> For my Plasma dev friends, I also intend to port Plasma::Theme over to use
> KImageCache, using the attached patch. Please let me know if there are
> problems with this.

i'm applying the patch now and will test it over the next few days. thanks for 
the patch and all the work on this.

btw, are the old caching classes going to be deprecated?

--

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

Re: [PATCH] Request review for KSharedDataCache (Round 2)

On Friday, April 30, 2010 22:00:39 Aaron J. Seigo wrote:
> On April 30, 2010, Michael Pyne wrote:
> > For my Plasma dev friends, I also intend to port Plasma::Theme over to
> > use KImageCache, using the attached patch. Please let me know if there
> > are problems with this.
> 
> i'm applying the patch now and will test it over the next few days. thanks
> for the patch and all the work on this.
> 
> btw, are the old caching classes going to be deprecated?

Yes, but obviously I cannot remove them. KIconCache (a subclass of 
KPixmapCache) will also receive a very stern warning. It somehow made it to 
the public API even though as far as I can tell it was only ever meant to be 
used in the implementation of KIconLoader.

Regards,
 - Michael Pyne

Re: New dependency for kdelibs and kdebase: dbusmenu-qt

On Thursday 29 April 2010, Aaron J. Seigo wrote:
> On April 29, 2010, Andriy Rysin wrote:
> > I am getting this when trying to compile latest kdebase, any way
> > around it?
>
> i assume you have re-run cmake in your build dir? sometimes i find i have
> to run cmake by hand again in these cases (and sometimes even remove
> CMakeCache.txt in the top level build dir), and that the automatic re-check
> triggered by a make in the build dir after a build change isn't enough on
> its own.

If you have such a case reproducable, let me know.
Having to rerun cmake manually sounds like a bug.

Instead of deleting CMakeCache.txt you can also start cmake-gui and delete 
just the variables which matter for the specific case.

Alex

Re: Windows x64 khtml patch

Re: New dependency for kdelibs and kdebase: dbusmenu-qt

On Thursday 29 April 2010, Andreas Pakulat wrote:
> On 29.04.10 08:17:03, Aaron J. Seigo wrote:
> > On April 28, 2010, Andreas Pakulat wrote:
> > > I know, I recall seeing a review-request. But there was no sign that
> > > this is going live and when this is going live _before_ the commit. The
> >
> > that's the entire POINT of a review request and why they get forwarded to
> > important mailing lists like this. if you want to provide feedback, then
> > provide feedback then.
>
> My main problem with this was that it wasn't announced before and no a
> review-request is not enough. There should be a warning send to all major
> lists (in particular kde-devel and eventually the kde-cvs-announce list)
> before adding a new dependency and with a concrete date when this new
> dependency is added. A review request is not the right tool for doing that,
> its the right tool to discuss what the code using the new dep will look
> like.

I agree completely.
I don't feel like digging through all review requests like "Add something for 
Foo" to check whether this maybe also installs new cmake files, if I am not 
involved in project Foo otherwise.

> > > And the review-request wasn't posted to the buildsystem list at all,
> > > which is a requirement before introducing new, especially installed,
> > > cmake files.
> >
> > yes, apparently it is according to this:
> >
> > 	http://techbase.kde.org/Policies/CMake_Commit_Policy
> >
> > in future i'll try and ensure that happens when its something that
> > touches my code or code i work with.
>
> I'd like to note that this is not new and has been posted to all major
> lists when it went into effect sometime last year (IIRC).

Yes.

Alex

Re: New dependency for kdelibs and kdebase: dbusmenu-qt

On Sunday 25 April 2010, Aurélien Gâteau wrote:
> Hi,
>
> I just committed support for DBusMenu in kdelibs and kdebase.
>
> - In kdelibs, DBusMenu is used by KStatusNotifierItem to export their
> menus over DBus.
> - In kdebase, DBusMenu is used by the Plasma SystemTray applet to render
> the KStatusNotifierItem menus.
>
> The advantage of this new system is that the visualisation gets more
> control over the rendering of its items, compared to the previous
> implementation which asked the application to show their menu at a give
> position.
>
> It is also nice for users of libappindicator-enabled [1] GNOME
> applications, because the SystemTray menus of these applications will be
> rendered using a native KDE menu.
>
> This means to build kdelibs and kdebase you now need to install
> dbusmenu-qt. dbusmenu-qt tarballs are available here:
>
>    http://people.canonical.com/~agateau/dbusmenu/
>
> You can also get the code from Gitorious:
>
>    http://gitorious.org/dbusmenu/

I just installed it:

hammer:~/src/packages/libdbusmenu-qt-0.3.2/build$ make install
[ 76%] Built target dbusmenu-qt
[ 88%] Built target dbusmenuexportertest
[100%] Built target dbusmenuimportertest
Install the project...
-- Install configuration: ""
-- Installing: /opt/dbusmenuqt/lib/pkgconfig/dbusmenu-qt.pc
-- Installing: /opt/dbusmenuqt/lib/libdbusmenu-qt.so.2.0.2
-- Installing: /opt/dbusmenuqt/lib/libdbusmenu-qt.so.2
-- Installing: /opt/dbusmenuqt/lib/libdbusmenu-qt.so
-- Removed runtime path from "/opt/dbusmenuqt/lib/libdbusmenu-qt.so.2.0.2"
-- Installing: /opt/dbusmenuqt/include/dbusmenu-qt/.
-- Installing: /opt/dbusmenuqt/include/dbusmenu-qt/./dbusmenu_export.h
-- Installing: /opt/dbusmenuqt/include/dbusmenu-qt/./dbusmenuexporter.h
-- Installing: /opt/dbusmenuqt/include/dbusmenu-qt/./dbusmenuimporter.h
hammer:~/src/packages/libdbusmenu-qt-0.3.2/build$       

Is is intentional that libdbusmenu-qt.so.2.0.2 is installed with empty RPATH ?

Alex

Re: keyboard2 moved to kdereview

On Friday 30 April 2010, Andriy Rysin wrote:
> 2010/4/29 Aaron J. Seigo <aseigo <at> kde.org>
> > On April 25, 2010, Andriy Rysin wrote:
> > > drawing the text I need to find a way to leave the taskbar
> > > background (but this was also the problem before).
> > 
> > looking at the code in Flags, i think i can see the problem: you
> > probably just
> > need to fill the pixmap first with Qt::transparent so the
> > background is, well,
> > transparent :) then you can paint the text, flag, etc over top of
> > that.
> 
> yep, I found it today and already pushed the code for transparency
> The problem with text over the flag is that it's hard to find the
> right way to paint readable text with all the possible flag colors
> and their combination. So for now it'll be either text or flag, so
> far the early feedback was pretty positive.

Drawing a dark outline around white text usually is a good solution for 
this problem. To get something like an outline which also looks good for 
small fonts you could draw the text in black, then blur it and then draw 
the text in white over the blurred black text.

Regards,
Ingo

Re: Review Request: Add ffmpegthumbnailer for video previews

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3818/
-----------------------------------------------------------

(Updated 2010-05-01 12:57:38.647909)

Review request for kdelibs.

Changes
-------

Some more cleanups

Summary
-------

This change adds a ffmpegbackend for rendering video thumbnails 
FFMPEG is required for this. 

Diffs (updated)
-----

  /trunk/KDE/kdemultimedia/CMakeLists.txt 1121489 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/CMakeLists.txt PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer.h PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer.cpp PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/.directory PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/AUTHORS PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/ChangeLog PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/README PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/filmstripfilter.h PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/filmstripfilter.cpp PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/histogram.h PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/ifilter.h PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/imagetypes.h PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/imagewriter.h PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/imagewriterfactory.h PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/moviedecoder.h PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/moviedecoder.cpp PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/pngwriter.h PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/pngwriter.cpp PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videoframe.h PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videothumbnailer.h PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videothumbnailer.cpp PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videothumbnailerc.h PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videothumbnailerc.cpp PRE-CREATION 
  /trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbs.desktop PRE-CREATION 

Diff: http://reviewboard.kde.org/r/3818/diff

Testing
-------

Screenshots
-----------

Dolphin with ffmpegthumbs
  http://reviewboard.kde.org/r/3818/s/375/

Thanks,

Andreas

Re: Configuration of database connection information

Am Freitag, 30. April 2010 15:24:39 schrieb Lynn Hazan:
> I am currently developing an application which is displaying data retrieved
> from a database. For that purpose I am using a dedicated unique database
> user account .
> I would like to store the database connection information (host, database
> name, user name, password) in an application configuration file which
> should not be accessible to everybody. The idea is to have the information
> outside the compiled code so it can be easily updated it if necessary, but
> protected.
> 
> This configuration would be application internal (not accessible to the end
> users like with KConfig).

KWallet is the standard solution for encrypted storage of credentials. It 
requires that a wallet password be entered before the credentials can be 
retrieved.

If you need to update credentials on multiple client workstations, you should 
be able to distribute updated wallet files to your workstations, and have 
KWallet pick it up.

Greetings
Stefan