Friedrich W. H. Kossebau | 22 May 2013 20:09

Review Request 110600: Turn filemanager templates into product + move from /templates to /extra/filemanagertemplates

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110600/

Review request for Calligra.

By Friedrich W. H. Kossebau.

Description

Creating packages makes one realize what stuff is installed :) IMHO these templates should be moved to /extra/filemanagertemplates instead of enlarging the toplevel dir, and no longer unconditionally installed, just when part of productsets (all, desktop, osx for now).

Diffs

CMakeLists.txt (9b10d3c)
cmake/productsets/all.cmake (5f27fd4)
cmake/productsets/desktop.cmake (a732e36)
cmake/productsets/osx.cmake (80b8b2b)
extras/CMakeLists.txt (5c2676f)
extras/filemanagertemplates/CMakeLists.txt (PRE-CREATION)
extras/filemanagertemplates/Illustration.desktop (PRE-CREATION)
extras/filemanagertemplates/Illustration.odg (PRE-CREATION)
extras/filemanagertemplates/Presentation.desktop (PRE-CREATION)
extras/filemanagertemplates/Presentation.odp (PRE-CREATION)
extras/filemanagertemplates/README (PRE-CREATION)
extras/filemanagertemplates/SpreadSheet.desktop (PRE-CREATION)
extras/filemanagertemplates/SpreadSheet.ods (PRE-CREATION)
extras/filemanagertemplates/TextDocument.desktop (PRE-CREATION)
extras/filemanagertemplates/TextDocument.odt (PRE-CREATION)
extras/filemanagertemplates/insert_ident_string.sh (PRE-CREATION)
templates/CMakeLists.txt (4e2647e)
templates/Illustration.desktop (df9841a)
templates/Illustration.odg (86ed6a9)
templates/Presentation.desktop (bc8fbf1)
templates/Presentation.odp (e3625b3)
templates/README (a7fd592)
templates/SpreadSheet.desktop (44a54af)
templates/SpreadSheet.ods (bf1a14a)
templates/TextDocument.desktop (32178a8)
templates/TextDocument.odt (03a8595)
templates/insert_ident_string.sh (d73b7ea)

View Diff

<div>
  <div>
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8"><tr>
<td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110600/">http://git.reviewboard.kde.org/r/110600/</a>
     </td>
    </tr></table>
<br><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8"><tr>
<td>

<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>

<h1>Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10"><tr>
<td>
   Creating packages makes one realize what stuff is installed :)

IMHO these templates should be moved to /extra/filemanagertemplates instead of enlarging the toplevel dir, and no longer unconditionally installed, just when part of productsets (all, desktop, osx for now).
  </td>
 </tr></table>
<h1>Diffs </h1>
<ul>
<li>CMakeLists.txt <span>(9b10d3c)</span>
</li>

 <li>cmake/productsets/all.cmake <span>(5f27fd4)</span>
</li>

 <li>cmake/productsets/desktop.cmake <span>(a732e36)</span>
</li>

 <li>cmake/productsets/osx.cmake <span>(80b8b2b)</span>
</li>

 <li>extras/CMakeLists.txt <span>(5c2676f)</span>
</li>

 <li>extras/filemanagertemplates/CMakeLists.txt <span>(PRE-CREATION)</span>
</li>

 <li>extras/filemanagertemplates/Illustration.desktop <span>(PRE-CREATION)</span>
</li>

 <li>extras/filemanagertemplates/Illustration.odg <span>(PRE-CREATION)</span>
</li>

 <li>extras/filemanagertemplates/Presentation.desktop <span>(PRE-CREATION)</span>
</li>

 <li>extras/filemanagertemplates/Presentation.odp <span>(PRE-CREATION)</span>
</li>

 <li>extras/filemanagertemplates/README <span>(PRE-CREATION)</span>
</li>

 <li>extras/filemanagertemplates/SpreadSheet.desktop <span>(PRE-CREATION)</span>
</li>

 <li>extras/filemanagertemplates/SpreadSheet.ods <span>(PRE-CREATION)</span>
</li>

 <li>extras/filemanagertemplates/TextDocument.desktop <span>(PRE-CREATION)</span>
</li>

 <li>extras/filemanagertemplates/TextDocument.odt <span>(PRE-CREATION)</span>
</li>

 <li>extras/filemanagertemplates/insert_ident_string.sh <span>(PRE-CREATION)</span>
</li>

 <li>templates/CMakeLists.txt <span>(4e2647e)</span>
</li>

 <li>templates/Illustration.desktop <span>(df9841a)</span>
</li>

 <li>templates/Illustration.odg <span>(86ed6a9)</span>
</li>

 <li>templates/Presentation.desktop <span>(bc8fbf1)</span>
</li>

 <li>templates/Presentation.odp <span>(e3625b3)</span>
</li>

 <li>templates/README <span>(a7fd592)</span>
</li>

 <li>templates/SpreadSheet.desktop <span>(44a54af)</span>
</li>

 <li>templates/SpreadSheet.ods <span>(bf1a14a)</span>
</li>

 <li>templates/TextDocument.desktop <span>(32178a8)</span>
</li>

 <li>templates/TextDocument.odt <span>(03a8595)</span>
</li>

 <li>templates/insert_ident_string.sh <span>(d73b7ea)</span>
</li>

</ul>
<p><a href="http://git.reviewboard.kde.org/r/110600/diff/">View Diff</a></p>

  </td>
 </tr></table>
</div>
 </div>

headers

Friedrich W. H. Kossebau | 22 May 2013 17:23

Review Request 110596: Slightly improve KoResourceItemChooser UI strings (and add some context markers)

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110596/

Review request for Calligra and Boudewijn Rempt.

By Friedrich W. H. Kossebau.

Description

Two i18n were missing. Tooltips text are normal casing. Click messages might be rather normal casing as well, also no fullstop at end. Window title/menu actions should be title casing.

Diffs

libs/widgets/KoResourceItemChooser.cpp (a2750b5)

View Diff

<div>
  <div>
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8"><tr>
<td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110596/">http://git.reviewboard.kde.org/r/110596/</a>
     </td>
    </tr></table>
<br><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8"><tr>
<td>

<div>Review request for Calligra and Boudewijn Rempt.</div>
<div>By Friedrich W. H. Kossebau.</div>

<h1>Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10"><tr>
<td>
   Two i18n were missing.
Tooltips text are normal casing.
Click messages might be rather normal casing as well, also no fullstop at end.
Window title/menu actions should be title casing.
  </td>
 </tr></table>
<h1>Diffs </h1>
<ul>
<li>libs/widgets/KoResourceItemChooser.cpp <span>(a2750b5)</span>
</li>

</ul>
<p><a href="http://git.reviewboard.kde.org/r/110596/diff/">View Diff</a></p>

  </td>
 </tr></table>
</div>
 </div>

headers

Friedrich W. H. Kossebau | 22 May 2013 17:19

Review Request 110595: Remove get-prefix from getResourceByName/getAssignedTagsList/getTagNamesList method names

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110595/

Review request for Calligra.

By Friedrich W. H. Kossebau.

Description

get-prefix is not very Qt-ish, so I would propose to remove some more for consistency.

Diffs

libs/widgets/tests/KoResourceTagging_test.cpp (9100e7a)
libs/widgets/KoResourceTagging.cpp (b678000)
libs/widgets/KoResourceTagging.h (0624096)
libs/widgets/KoResourceServerProvider.cpp (64e5fde)
libs/widgets/KoResourceServerAdapter.h (02ab31e)
libs/widgets/KoResourceModel.cpp (a9cb212)
libs/widgets/KoResourceServer.h (1ab4ad6)
libs/widgets/KoResourceModel.h (3ccb28b)
libs/widgets/KoResourceItemChooser.cpp (a2750b5)
libs/widgets/KoResourceItemChooser.h (d26f5a5)
krita/ui/widgets/kis_preset_chooser.cpp (9f07c8a)
krita/ui/widgets/kis_preset_chooser.h (5df3b56)
krita/ui/kis_paintop_box.cc (61c0d12)
krita/ui/ko_favorite_resource_manager.cpp (2481ce1)
krita/plugins/paintops/libpaintop/kis_brush_based_paintop_settings.cpp (389bd9f)
krita/plugins/paintops/libbrush/kis_svg_brush_factory.cpp (9833a6d)
krita/plugins/paintops/libbrush/kis_gbr_brush_factory.cpp (fe52a42)
krita/plugins/paintops/libbrush/kis_png_brush_factory.cpp (0a2d25e)
krita/plugins/paintops/libbrush/kis_abr_brush_factory.cpp (34e7264)
krita/plugins/extensions/dockers/defaultdockers/kis_palette_docker.cc (c61eb54)
krita/plugins/extensions/bigbrother/bigbrother.cc (f59e55e)

View Diff

<div>
  <div>
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8"><tr>
<td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110595/">http://git.reviewboard.kde.org/r/110595/</a>
     </td>
    </tr></table>
<br><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8"><tr>
<td>

<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>

<h1>Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10"><tr>
<td>
   get-prefix is not very Qt-ish, so I would propose to remove some more for consistency.
  </td>
 </tr></table>
<h1>Diffs </h1>
<ul>
<li>libs/widgets/tests/KoResourceTagging_test.cpp <span>(9100e7a)</span>
</li>

 <li>libs/widgets/KoResourceTagging.cpp <span>(b678000)</span>
</li>

 <li>libs/widgets/KoResourceTagging.h <span>(0624096)</span>
</li>

 <li>libs/widgets/KoResourceServerProvider.cpp <span>(64e5fde)</span>
</li>

 <li>libs/widgets/KoResourceServerAdapter.h <span>(02ab31e)</span>
</li>

 <li>libs/widgets/KoResourceModel.cpp <span>(a9cb212)</span>
</li>

 <li>libs/widgets/KoResourceServer.h <span>(1ab4ad6)</span>
</li>

 <li>libs/widgets/KoResourceModel.h <span>(3ccb28b)</span>
</li>

 <li>libs/widgets/KoResourceItemChooser.cpp <span>(a2750b5)</span>
</li>

 <li>libs/widgets/KoResourceItemChooser.h <span>(d26f5a5)</span>
</li>

 <li>krita/ui/widgets/kis_preset_chooser.cpp <span>(9f07c8a)</span>
</li>

 <li>krita/ui/widgets/kis_preset_chooser.h <span>(5df3b56)</span>
</li>

 <li>krita/ui/kis_paintop_box.cc <span>(61c0d12)</span>
</li>

 <li>krita/ui/ko_favorite_resource_manager.cpp <span>(2481ce1)</span>
</li>

 <li>krita/plugins/paintops/libpaintop/kis_brush_based_paintop_settings.cpp <span>(389bd9f)</span>
</li>

 <li>krita/plugins/paintops/libbrush/kis_svg_brush_factory.cpp <span>(9833a6d)</span>
</li>

 <li>krita/plugins/paintops/libbrush/kis_gbr_brush_factory.cpp <span>(fe52a42)</span>
</li>

 <li>krita/plugins/paintops/libbrush/kis_png_brush_factory.cpp <span>(0a2d25e)</span>
</li>

 <li>krita/plugins/paintops/libbrush/kis_abr_brush_factory.cpp <span>(34e7264)</span>
</li>

 <li>krita/plugins/extensions/dockers/defaultdockers/kis_palette_docker.cc <span>(c61eb54)</span>
</li>

 <li>krita/plugins/extensions/bigbrother/bigbrother.cc <span>(f59e55e)</span>
</li>

</ul>
<p><a href="http://git.reviewboard.kde.org/r/110595/diff/">View Diff</a></p>

  </td>
 </tr></table>
</div>
 </div>

headers

Friedrich W. H. Kossebau | 22 May 2013 17:01

Review Request 110594: Remove unused "image_popup" menu declaration in krita.rc

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110594/

Review request for Calligra and Boudewijn Rempt.

By Friedrich W. H. Kossebau.

Description

Seems no longer used

Diffs

krita/krita.rc (461b994)

View Diff

<div>
  <div>
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8"><tr>
<td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110594/">http://git.reviewboard.kde.org/r/110594/</a>
     </td>
    </tr></table>
<br><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8"><tr>
<td>

<div>Review request for Calligra and Boudewijn Rempt.</div>
<div>By Friedrich W. H. Kossebau.</div>

<h1>Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10"><tr>
<td>
   Seems no longer used
  </td>
 </tr></table>
<h1>Diffs </h1>
<ul>
<li>krita/krita.rc <span>(461b994)</span>
</li>

</ul>
<p><a href="http://git.reviewboard.kde.org/r/110594/diff/">View Diff</a></p>

  </td>
 </tr></table>
</div>
 </div>

headers

Elvis Stansvik | 22 May 2013 15:39

Review Request 110593: Check for null image in drop event

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110593/

Review request for Calligra and C. Boemann.

By Elvis Stansvik.

Description

When dropping this particular cat http://www.mrwallpaper.com/wallpapers/Cat-Sad-Annoyed.jpg which I've come to call Cat Astrophy, from Chromium 27.0.1453.93 onto Calligra Words, I get: Application: Calligra Words (calligrawords), signal: Aborted Using host libthread_db library "/usr/lib/libthread_db.so.1". [Current thread is 1 (Thread 0x7f1591110780 (LWP 28742))] Thread 2 (Thread 0x7f156d38f700 (LWP 28743)): #0 0x00007f158a19909d in poll () from /usr/lib/libc.so.6 #1 0x00007f158565d134 in ?? () from /usr/lib/libglib-2.0.so.0 #2 0x00007f158565d23c in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0 #3 0x00007f158b0448f6 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQtCore.so.4 #4 0x00007f158b01696f in QEventLoop::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQtCore.so.4 #5 0x00007f158b016c65 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQtCore.so.4 #6 0x00007f158af1567f in QThread::exec() () from /usr/lib/libQtCore.so.4 #7 0x00007f158aff8113 in ?? () from /usr/lib/libQtCore.so.4 #8 0x00007f158af17d1f in ?? () from /usr/lib/libQtCore.so.4 #9 0x00007f158ac88dd2 in start_thread () from /usr/lib/libpthread.so.0 #10 0x00007f158a1a1ced in clone () from /usr/lib/libc.so.6 Thread 1 (Thread 0x7f1591110780 (LWP 28742)): [KCrash Handler] #5 0x00007f158a0f11c9 in raise () from /usr/lib/libc.so.6 #6 0x00007f158a0f25c8 in abort () from /usr/lib/libc.so.6 #7 0x00007f158af0d8df in qt_message_output(QtMsgType, char const*) () from /usr/lib/libQtCore.so.4 #8 0x00007f158af0da69 in ?? () from /usr/lib/libQtCore.so.4 #9 0x00007f158af0e274 in qFatal(char const*, ...) () from /usr/lib/libQtCore.so.4 #10 0x00007f1572f2d8bd in PictureShapeFactory::createShape (this=0x1e5d8b0, params=0x7fff51f7f660, documentResources=0x1e47790) at /home/estan/kde4/src/calligra/plugins/pictureshape/PictureShapeFactory.cpp:71 #11 0x00007f157b1bc597 in KWView::addImages (this=0x23d1a10, imageList=..., insertAt=...) at /home/estan/kde4/src/calligra/words/part/KWView.cpp:1134 #12 0x00007f1590a88804 in KoView::dropEvent (this=0x23d1a10, event=0x7fff51f7fd20) at /home/estan/kde4/src/calligra/libs/main/KoView.cpp:277 #13 0x00007f158bf371be in QWidget::event(QEvent*) () from /usr/lib/libQtGui.so.4 #14 0x00007f158bee80ac in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/libQtGui.so.4 #15 0x00007f158beef4fe in QApplication::notify(QObject*, QEvent*) () from /usr/lib/libQtGui.so.4 #16 0x00007f1590a1827a in KoApplication::notify (this=0x7fff51f80470, receiver=0x2571c00, event=0x7fff51f7fd20) at /home/estan/kde4/src/calligra/libs/main/KoApplication.cpp:556 #17 0x00007f158b017c3d in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/lib/libQtCore.so.4 #18 0x00007f158bf6d481 in ?? () from /usr/lib/libQtGui.so.4 #19 0x00007f158bf519bd in QApplication::x11ClientMessage(QWidget*, _XEvent*, bool) () from /usr/lib/libQtGui.so.4 #20 0x00007f158bf5e88f in QApplication::x11ProcessEvent(_XEvent*) () from /usr/lib/libQtGui.so.4 #21 0x00007f158bf84fb2 in ?? () from /usr/lib/libQtGui.so.4 #22 0x00007f158565ce46 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0 #23 0x00007f158565d198 in ?? () from /usr/lib/libglib-2.0.so.0 #24 0x00007f158565d23c in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0 #25 0x00007f158b0448d5 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQtCore.so.4 #26 0x00007f158bf85066 in ?? () from /usr/lib/libQtGui.so.4 #27 0x00007f158b01696f in QEventLoop::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQtCore.so.4 #28 0x00007f158b016c65 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQtCore.so.4 #29 0x00007f158b01bccb in QCoreApplication::exec() () from /usr/lib/libQtCore.so.4 #30 0x00007f1590d4d2f4 in kdemain (argc=1, argv=0x7fff51f80658) at /home/estan/kde4/src/calligra/words/app/main.cpp:43 #31 0x00000000004009d2 in main (argc=1, argv=0x7fff51f80658) at /home/estan/kde4/build/calligra/words/app/calligrawords_dummy.cpp:3 Apparently it can happen that QMimeData::hasImage() can return true, but QMimeData::imageData returns a null QImage. I guess this should be considered a Qt bug. This fix simply introduces a check for a null image to avoid the crash. I guess I should investigate why Qt ends up in this state in the first place, but it doesn't hurt to be careful.

Testing

Dropped Cat Astrophy before and after the fix and the crash is gone.

Diffs

libs/main/KoView.cpp (c9c82e5)

View Diff

<div>
  <div>
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8"><tr>
<td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110593/">http://git.reviewboard.kde.org/r/110593/</a>
     </td>
    </tr></table>
<br><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8"><tr>
<td>

<div>Review request for Calligra and C. Boemann.</div>
<div>By Elvis Stansvik.</div>

<h1>Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10"><tr>
<td>
   When dropping this particular cat

http://www.mrwallpaper.com/wallpapers/Cat-Sad-Annoyed.jpg

which I've come to call Cat Astrophy, from Chromium 27.0.1453.93 onto Calligra Words, I get:

Application: Calligra Words (calligrawords), signal: Aborted
Using host libthread_db library "/usr/lib/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f1591110780 (LWP 28742))]

Thread 2 (Thread 0x7f156d38f700 (LWP 28743)):
#0  0x00007f158a19909d in poll () from /usr/lib/libc.so.6
#1  0x00007f158565d134 in ?? () from /usr/lib/libglib-2.0.so.0
#2  0x00007f158565d23c in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0
#3  0x00007f158b0448f6 in QEventDispatcherGlib::processEvents(QFlags&lt;QEventLoop::ProcessEventsFlag&gt;) () from /usr/lib/libQtCore.so.4
#4  0x00007f158b01696f in QEventLoop::processEvents(QFlags&lt;QEventLoop::ProcessEventsFlag&gt;) () from /usr/lib/libQtCore.so.4
#5  0x00007f158b016c65 in QEventLoop::exec(QFlags&lt;QEventLoop::ProcessEventsFlag&gt;) () from /usr/lib/libQtCore.so.4
#6  0x00007f158af1567f in QThread::exec() () from /usr/lib/libQtCore.so.4
#7  0x00007f158aff8113 in ?? () from /usr/lib/libQtCore.so.4
#8  0x00007f158af17d1f in ?? () from /usr/lib/libQtCore.so.4
#9  0x00007f158ac88dd2 in start_thread () from /usr/lib/libpthread.so.0
#10 0x00007f158a1a1ced in clone () from /usr/lib/libc.so.6

Thread 1 (Thread 0x7f1591110780 (LWP 28742)):
[KCrash Handler]
#5  0x00007f158a0f11c9 in raise () from /usr/lib/libc.so.6
#6  0x00007f158a0f25c8 in abort () from /usr/lib/libc.so.6
#7  0x00007f158af0d8df in qt_message_output(QtMsgType, char const*) () from /usr/lib/libQtCore.so.4
#8  0x00007f158af0da69 in ?? () from /usr/lib/libQtCore.so.4
#9  0x00007f158af0e274 in qFatal(char const*, ...) () from /usr/lib/libQtCore.so.4
#10 0x00007f1572f2d8bd in PictureShapeFactory::createShape (this=0x1e5d8b0, params=0x7fff51f7f660, documentResources=0x1e47790) at /home/estan/kde4/src/calligra/plugins/pictureshape/PictureShapeFactory.cpp:71
#11 0x00007f157b1bc597 in KWView::addImages (this=0x23d1a10, imageList=..., insertAt=...) at /home/estan/kde4/src/calligra/words/part/KWView.cpp:1134
#12 0x00007f1590a88804 in KoView::dropEvent (this=0x23d1a10, event=0x7fff51f7fd20) at /home/estan/kde4/src/calligra/libs/main/KoView.cpp:277
#13 0x00007f158bf371be in QWidget::event(QEvent*) () from /usr/lib/libQtGui.so.4
#14 0x00007f158bee80ac in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/libQtGui.so.4
#15 0x00007f158beef4fe in QApplication::notify(QObject*, QEvent*) () from /usr/lib/libQtGui.so.4
#16 0x00007f1590a1827a in KoApplication::notify (this=0x7fff51f80470, receiver=0x2571c00, event=0x7fff51f7fd20) at /home/estan/kde4/src/calligra/libs/main/KoApplication.cpp:556
#17 0x00007f158b017c3d in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/lib/libQtCore.so.4
#18 0x00007f158bf6d481 in ?? () from /usr/lib/libQtGui.so.4
#19 0x00007f158bf519bd in QApplication::x11ClientMessage(QWidget*, _XEvent*, bool) () from /usr/lib/libQtGui.so.4
#20 0x00007f158bf5e88f in QApplication::x11ProcessEvent(_XEvent*) () from /usr/lib/libQtGui.so.4
#21 0x00007f158bf84fb2 in ?? () from /usr/lib/libQtGui.so.4
#22 0x00007f158565ce46 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#23 0x00007f158565d198 in ?? () from /usr/lib/libglib-2.0.so.0
#24 0x00007f158565d23c in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0
#25 0x00007f158b0448d5 in QEventDispatcherGlib::processEvents(QFlags&lt;QEventLoop::ProcessEventsFlag&gt;) () from /usr/lib/libQtCore.so.4
#26 0x00007f158bf85066 in ?? () from /usr/lib/libQtGui.so.4
#27 0x00007f158b01696f in QEventLoop::processEvents(QFlags&lt;QEventLoop::ProcessEventsFlag&gt;) () from /usr/lib/libQtCore.so.4
#28 0x00007f158b016c65 in QEventLoop::exec(QFlags&lt;QEventLoop::ProcessEventsFlag&gt;) () from /usr/lib/libQtCore.so.4
#29 0x00007f158b01bccb in QCoreApplication::exec() () from /usr/lib/libQtCore.so.4
#30 0x00007f1590d4d2f4 in kdemain (argc=1, argv=0x7fff51f80658) at /home/estan/kde4/src/calligra/words/app/main.cpp:43
#31 0x00000000004009d2 in main (argc=1, argv=0x7fff51f80658) at /home/estan/kde4/build/calligra/words/app/calligrawords_dummy.cpp:3

Apparently it can happen that QMimeData::hasImage() can return true, but QMimeData::imageData returns a null QImage. I guess this should be considered a Qt bug.

This fix simply introduces a check for a null image to avoid the crash. I guess I should investigate why Qt ends up in this state in the first place, but it doesn't hurt to be careful.
  </td>
 </tr></table>
<h1>Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10"><tr>
<td>
   Dropped Cat Astrophy before and after the fix and the crash is gone.
  </td>
 </tr></table>
<h1>Diffs </h1>
<ul>
<li>libs/main/KoView.cpp <span>(c9c82e5)</span>
</li>

</ul>
<p><a href="http://git.reviewboard.kde.org/r/110593/diff/">View Diff</a></p>

  </td>
 </tr></table>
</div>
 </div>

headers

Beojan Stanislaus | 22 May 2013 10:33

Table rows incorrectly rendered in Words

With a document created in Microsoft Word (both .doc and .odt formats), table 
rows are rendered too narrow, causing the text within to be cut off.

Would it be possible to ensure all table cells are correctly resized for their 
contents to be visible?

Sincerely,

Beojan Stanislaus

headers

Jaroslaw Staniek | 22 May 2013 08:31

Running Words and Sheets, etc. from the KRunner

Hi,
Entering almost the full "calligrawords" may be seen as suboptimal. Ideas?

http://forum.kde.org/viewtopic.php?f=203&t=111295&p=265463#p265463

--

-- 
regards / pozdrawiam, Jaroslaw Staniek
 Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org
 Qt Certified Specialist | http://qt-project.org
 http://www.linkedin.com/in/jstaniek

headers

Friedrich W. H. Kossebau | 21 May 2013 20:31

Review Request 110581: Rename installed libkdchart to libcalligrakdchart, to prevent naming clashes

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110581/

Review request for Calligra.

By Friedrich W. H. Kossebau.

Description

There might be some other people out there that use libkdchart... so to prevent any naming clashes we better prefix our copy. Okay to backport to 2.7?

Diffs

3rdparty/kdchart/src/CMakeLists.txt (0c62a5d)
CMakeLists.txt (8b84dca)
kexi/plugins/reports/CMakeLists.txt (14e0ff9)
plan/libs/models/CMakeLists.txt (f168557)
plan/libs/ui/CMakeLists.txt (f813a10)
plugins/chartshape/CMakeLists.txt (c853ec0)
plugins/reporting/chart/CMakeLists.txt (92bf3de)

View Diff

<div>
  <div>
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8"><tr>
<td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110581/">http://git.reviewboard.kde.org/r/110581/</a>
     </td>
    </tr></table>
<br><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8"><tr>
<td>

<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>

<h1>Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10"><tr>
<td>
   There might be some other people out there that use libkdchart... so to prevent any naming clashes we better prefix our copy.

Okay to backport to 2.7?
  </td>
 </tr></table>
<h1>Diffs </h1>
<ul>
<li>3rdparty/kdchart/src/CMakeLists.txt <span>(0c62a5d)</span>
</li>

 <li>CMakeLists.txt <span>(8b84dca)</span>
</li>

 <li>kexi/plugins/reports/CMakeLists.txt <span>(14e0ff9)</span>
</li>

 <li>plan/libs/models/CMakeLists.txt <span>(f168557)</span>
</li>

 <li>plan/libs/ui/CMakeLists.txt <span>(f813a10)</span>
</li>

 <li>plugins/chartshape/CMakeLists.txt <span>(c853ec0)</span>
</li>

 <li>plugins/reporting/chart/CMakeLists.txt <span>(92bf3de)</span>
</li>

</ul>
<p><a href="http://git.reviewboard.kde.org/r/110581/diff/">View Diff</a></p>

  </td>
 </tr></table>
</div>
 </div>

headers

Friedrich W. H. Kossebau | 21 May 2013 18:40

Review Request 110579: Fix compilation on ARM: result of dividing by 2.0 is double, so not qreal (qMax needs same types)

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110579/

Review request for Calligra.

By Friedrich W. H. Kossebau.

Description

Found when compiling 2.7 Beta2 on build.merproject.org with ARM targets. So will also backport to 2.7 Instead dividing qreal by 2 (integer) also results in qreal. But preferred to be more explicit here, as some might think that result is integer (I had to look up at least ;) )

Diffs

plugins/formulashape/elements/MultiscriptElement.cpp (9cdcc56)

View Diff

<div>
  <div>
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8"><tr>
<td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110579/">http://git.reviewboard.kde.org/r/110579/</a>
     </td>
    </tr></table>
<br><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8"><tr>
<td>

<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>

<h1>Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10"><tr>
<td>
   Found when compiling 2.7 Beta2 on build.merproject.org with ARM targets.

So will also backport to 2.7

Instead dividing qreal by 2 (integer) also results in qreal. But preferred to be more explicit here, as some might think that result is integer (I had to look up at least ;) )

  </td>
 </tr></table>
<h1>Diffs </h1>
<ul>
<li>plugins/formulashape/elements/MultiscriptElement.cpp <span>(9cdcc56)</span>
</li>

</ul>
<p><a href="http://git.reviewboard.kde.org/r/110579/diff/">View Diff</a></p>

  </td>
 </tr></table>
</div>
 </div>

headers

Sascha Suelzer | 20 May 2013 13:30

Review Request 110541: Synchronized tag categories and their views for resource choosers, KoResourceFiltering refactored a bit.

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110541/

Review request for Calligra.

By Sascha Suelzer.

Description

With this patch, the tag categories the user can define for various resources will update for any resource chooser of the same type. Examples: Defining a new tag in the preset popup combobox will also create the respective tag entry in the preset docker one. If both choosers would display the same tag category, and the user adds a resource to the category in one chooser, the view of the other would reflect the change as well. Both these things are achieved with a new set of signals and slots regarding tag category creation and modification. Other changes: Refactored KoResourceFiltering a bit to make intent more clear and functionality a bit more fine grained, also fixed the naming for its private support class members from m_foo to foo since the fields are all public. Tag categories are now ordered in an alphabetical manner at all times. -------------------------------- Current shortcomings: Due to my inexperience with Qt GUI elements, repopulating the tag combobox upon synchronized tag addition briefly shows the changes in its content. The box visibly `flickers' for a split second before settling on the correct tag again. I am not really sure if KoResourceModel should be the class for the signals: signals: void tagBoxEntryModified(); void tagBoxEntryAdded(QString tag); void tagBoxEntryRemoved(QString tag); It seems to me that perhaps all of this tagging and filtering stuff should go into the adapter directly, perhaps? But The KoResourceItemChoosers would still require the notifications and the model is pretty much the only bridge, so maybe the place is okay after all. I also want to refactor some of the new code I introduced to make it look nicer, but I wanted to get this review request out for now so it is know that it is being worked on, since this builds on the former shortcomings of https://git.reviewboard.kde.org/r/110429/

Testing

Only tested for Krita, everything seems to work as it should.

Diffs

krita/plugins/paintops/libbrush/kis_brush_server.cpp (5e4db8d)
krita/ui/kis_palette_manager.cpp (568859a)
krita/ui/ko_favorite_resource_manager.h (fbfa86f)
krita/ui/ko_favorite_resource_manager.cpp (2481ce1)
krita/ui/widgets/kis_preset_chooser.h (5df3b56)
krita/ui/widgets/kis_preset_chooser.cpp (9f07c8a)
libs/widgets/KoResourceFiltering.h (9f8f967)
libs/widgets/KoResourceFiltering.cpp (f564210)
libs/widgets/KoResourceItemChooser.h (d26f5a5)
libs/widgets/KoResourceItemChooser.cpp (a2750b5)
libs/widgets/KoResourceModel.h (3ccb28b)
libs/widgets/KoResourceModel.cpp (a9cb212)
libs/widgets/KoResourceServer.h (1ab4ad6)
libs/widgets/KoResourceServerAdapter.h (02ab31e)
libs/widgets/KoResourceServerAdapter.cpp (f1dc50f)
libs/widgets/KoResourceServerObserver.h (52bc7fc)
libs/widgets/KoResourceTagging.h (0624096)
libs/widgets/KoResourceTagging.cpp (b678000)

View Diff

<div>
  <div>
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8"><tr>
<td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110541/">http://git.reviewboard.kde.org/r/110541/</a>
     </td>
    </tr></table>
<br><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8"><tr>
<td>

<div>Review request for Calligra.</div>
<div>By Sascha Suelzer.</div>

<h1>Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10"><tr>
<td>
   With this patch, the tag categories the user can define for various resources will update for any resource chooser of the same type.
Examples: 
Defining a new tag in the preset popup combobox will also create the respective tag entry in the preset docker one.
If both choosers would display the same tag category, and the user adds a resource to the category in one chooser, the view of the other would reflect the change as well.

Both these things are achieved with a new set of signals and slots regarding tag category creation and modification.

Other changes:
Refactored KoResourceFiltering a bit to make intent more clear and functionality a bit more fine grained, also fixed the naming for its private support class members from m_foo to foo since the fields are all public.
Tag categories are now ordered in an alphabetical manner at all times.

--------------------------------

Current shortcomings:
Due to my inexperience with Qt GUI elements, repopulating the tag combobox upon synchronized tag addition briefly shows the changes in its content. The box visibly `flickers' for a split second before settling on the correct tag again.

I am not really sure if KoResourceModel should be the class for the signals:
signals:
    void tagBoxEntryModified();
    void tagBoxEntryAdded(QString tag);
    void tagBoxEntryRemoved(QString tag);

It seems to me that perhaps all of this tagging and filtering stuff should go into the adapter directly, perhaps? But The KoResourceItemChoosers would still require the notifications and the model is pretty much the only bridge, so maybe the place is okay after all.

I also want to refactor some of the new code I introduced to make it look nicer, but I wanted to get this review request out for now so it is know that it is being worked on, since this builds on the former shortcomings of 
https://git.reviewboard.kde.org/r/110429/
  </td>
 </tr></table>
<h1>Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10"><tr>
<td>
   Only tested for Krita, everything seems to work as it should.
  </td>
 </tr></table>
<h1>Diffs </h1>
<ul>
<li>krita/plugins/paintops/libbrush/kis_brush_server.cpp <span>(5e4db8d)</span>
</li>

 <li>krita/ui/kis_palette_manager.cpp <span>(568859a)</span>
</li>

 <li>krita/ui/ko_favorite_resource_manager.h <span>(fbfa86f)</span>
</li>

 <li>krita/ui/ko_favorite_resource_manager.cpp <span>(2481ce1)</span>
</li>

 <li>krita/ui/widgets/kis_preset_chooser.h <span>(5df3b56)</span>
</li>

 <li>krita/ui/widgets/kis_preset_chooser.cpp <span>(9f07c8a)</span>
</li>

 <li>libs/widgets/KoResourceFiltering.h <span>(9f8f967)</span>
</li>

 <li>libs/widgets/KoResourceFiltering.cpp <span>(f564210)</span>
</li>

 <li>libs/widgets/KoResourceItemChooser.h <span>(d26f5a5)</span>
</li>

 <li>libs/widgets/KoResourceItemChooser.cpp <span>(a2750b5)</span>
</li>

 <li>libs/widgets/KoResourceModel.h <span>(3ccb28b)</span>
</li>

 <li>libs/widgets/KoResourceModel.cpp <span>(a9cb212)</span>
</li>

 <li>libs/widgets/KoResourceServer.h <span>(1ab4ad6)</span>
</li>

 <li>libs/widgets/KoResourceServerAdapter.h <span>(02ab31e)</span>
</li>

 <li>libs/widgets/KoResourceServerAdapter.cpp <span>(f1dc50f)</span>
</li>

 <li>libs/widgets/KoResourceServerObserver.h <span>(52bc7fc)</span>
</li>

 <li>libs/widgets/KoResourceTagging.h <span>(0624096)</span>
</li>

 <li>libs/widgets/KoResourceTagging.cpp <span>(b678000)</span>
</li>

</ul>
<p><a href="http://git.reviewboard.kde.org/r/110541/diff/">View Diff</a></p>

  </td>
 </tr></table>
</div>
 </div>

headers

KDE CI System | 20 May 2013 11:29

Jenkins build became unstable: calligra_master #1146

See <http://build.kde.org/job/calligra_master/1146/changes>

127	May 2013
208	April 2013
314	March 2013
336	February 2013
420	January 2013
434	December 2012
320	November 2012
279	October 2012
160	September 2012
452	August 2012
428	July 2012
442	June 2012
543	May 2012
393	April 2012
346	March 2012
246	February 2012
164	January 2012
314	December 2011
326	November 2011
297	October 2011
312	September 2011
242	August 2011
246	July 2011
296	June 2011
160	May 2011
242	April 2011
147	March 2011
225	February 2011
320	January 2011
123	December 2010

Mon	Tue	Wed	Thu	Fri	Sat	Sun

		1	2	3	4	5
6	7	8	9	10	11	12
13	14	15	16	17	18	19
20	21	22	23	24	25	26
27	28	29	30	31