Gustav Gonzalez | 29 Jul 04:11 2015

[tupi/devel] src: Fixing Ellipse copy/paste issue

Git commit 187bb8c5e91e425d3472f12ecde355c241e9ee7f by Gustav Gonzalez.
Committed on 29/07/2015 at 02:09.
Pushed by gustavgonzalez into branch 'devel'.

Fixing Ellipse copy/paste issue

M  +1    -0    src/components/exposure/tupexposuretable.cpp
M  +28   -16   src/components/paintarea/tuppaintarea.cpp
M  +1    -0    src/plugins/tools/nodes/nodestool.cpp
M  +1    -1    src/store/tupellipseitem.cpp
M  +2    -0    src/store/tupframe.cpp
M  +1    -1    src/store/tupitemfactory.cpp

http://commits.kde.org/tupi/187bb8c5e91e425d3472f12ecde355c241e9ee7f

diff --git a/src/components/exposure/tupexposuretable.cpp b/src/components/exposure/tupexposuretable.cpp
index 2fdb6ad..25d750e 100644
--- a/src/components/exposure/tupexposuretable.cpp
+++ b/src/components/exposure/tupexposuretable.cpp
 <at>  <at>  -229,6 +229,7  <at>  <at>  void TupExposureTable::requestFrameSelection(int currentSelectedRow, int current

             if (currentSelectedRow >= framesTotalAtCurrentLayer()) {
                 selectionModel()->clearSelection();
+                // TODO: Check why cell selection is awkward
                 selectFrame(currentLayer(), framesTotalAtCurrentLayer() - 1);
             } else {
                 if (previousRow != currentSelectedRow) 
diff --git a/src/components/paintarea/tuppaintarea.cpp b/src/components/paintarea/tuppaintarea.cpp
index 1c6238f..59e904d 100644
--- a/src/components/paintarea/tuppaintarea.cpp
(Continue reading)

Eike Hein | 29 Jul 04:03 2015
Picon

[plasma-desktop/hein/appdash] applets/kicker/package/contents/ui: Don't add footer below the last subgrid.

Git commit e596bb1d4c8b2bded60f1cabf7c354b7ba417c0d by Eike Hein.
Committed on 29/07/2015 at 02:02.
Pushed by hein into branch 'hein/appdash'.

Don't add footer below the last subgrid.

This way a multi-grid scrolled up all the way has its
last row line up with the adjacent favorites grid.

M  +1    -1    applets/kicker/package/contents/ui/ItemMultiGridView.qml

http://commits.kde.org/plasma-desktop/e596bb1d4c8b2bded60f1cabf7c354b7ba417c0d

diff --git a/applets/kicker/package/contents/ui/ItemMultiGridView.qml b/applets/kicker/package/contents/ui/ItemMultiGridView.qml
index ef3edd6..b7adf1a 100644
--- a/applets/kicker/package/contents/ui/ItemMultiGridView.qml
+++ b/applets/kicker/package/contents/ui/ItemMultiGridView.qml
 <at>  <at>  -89,7 +89,7  <at>  <at>  PlasmaExtras.ScrollArea {

             delegate: Item {
                 width: column.width
-                height: headerHeight + gridView.height + footerHeight
+                height: headerHeight + gridView.height + (index == repeater.count - 1 ? 0 : footerHeight)

                 property int headerHeight: (gridViewLabel.height
                     + gridViewLabelUnderline.height + units.largeSpacing)

Leslie Zhai | 29 Jul 04:00 2015
Picon

[plasma-workspace/accounts-service] /: Update CMakeLists

Git commit d82c41d0f4c261dbcc2929a583a942be2c5f9af4 by Leslie Zhai.
Committed on 29/07/2015 at 02:00.
Pushed by lesliezhai into branch 'accounts-service'.

Update CMakeLists

M  +6    -4    CMakeLists.txt

http://commits.kde.org/plasma-workspace/d82c41d0f4c261dbcc2929a583a942be2c5f9af4

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 18b15f2..9fe2008 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
 <at>  <at>  -94,11 +94,13  <at>  <at>  find_package(Wayland 1.3 COMPONENTS Client Server)
 set_package_properties(Wayland PROPERTIES
                        TYPE REQUIRED
                        PURPOSE "Required for building screenlocker")
+
 find_package(QtAccountsService)
-set_package_properties(QtAccountsService PROPERTIES DESCRIPTION "Qt-style API to use
freedesktop.org's AccountsService DBus service"
-                    URL "https://github.com/AOSC-Dev/qtaccountsservice"
-                    TYPE REQUIRED
-                    )
+set_package_properties(QtAccountsService PROPERTIES 
+    DESCRIPTION "Qt-style API to use freedesktop.org's AccountsService DBus service"
+    URL "https://github.com/AOSC-Dev/qtaccountsservice"
+    TYPE REQUIRED
+)
(Continue reading)

Eike Hein | 29 Jul 03:58 2015
Picon

[plasma-desktop/hein/appdash] applets/kicker/package/contents/ui: Skip lazy menu delay in reset state.

Git commit bb3cfa55284053e1889eb65236c17cbf2d47a23d by Eike Hein.
Committed on 29/07/2015 at 01:57.
Pushed by hein into branch 'hein/appdash'.

Skip lazy menu delay in reset state.

M  +1    -1    applets/kicker/package/contents/ui/DashboardRepresentation.qml

http://commits.kde.org/plasma-desktop/bb3cfa55284053e1889eb65236c17cbf2d47a23d

diff --git a/applets/kicker/package/contents/ui/DashboardRepresentation.qml b/applets/kicker/package/contents/ui/DashboardRepresentation.qml
index a4a8402..23a634b 100644
--- a/applets/kicker/package/contents/ui/DashboardRepresentation.qml
+++ b/applets/kicker/package/contents/ui/DashboardRepresentation.qml
 <at>  <at>  -644,7 +644,7  <at>  <at>  Kicker.FullScreenWindow {
                             onPositionChanged: { // Lazy menu implementation.
                                 mouseCol = mouse.x;

-                                if (index == ListView.view.currentIndex) {
+                                if (ListView.view.currentIndex == 0 || index == ListView.view.currentIndex) {
                                     updateCurrentItem();
                                 } else if ((index == ListView.view.currentIndex - 1) && mouse.y < (height - 6)
                                     || (index == ListView.view.currentIndex + 1) && mouse.y > 5) {

Leslie Zhai | 29 Jul 03:57 2015
Picon

[plasma-workspace/accounts-service] ksmserver/screenlocker/greeter: ksmserver/screenlocker/greeter: directly use QtAccoutsService`s

Git commit a173d3a1f7db7721377c8f18eb6d8f411ea4d8d2 by Leslie Zhai.
Committed on 29/07/2015 at 01:56.
Pushed by lesliezhai into branch 'accounts-service'.

ksmserver/screenlocker/greeter: directly use QtAccoutsService`s
UserAccount for faceIconPath

M  +7    -2    ksmserver/screenlocker/greeter/greeterapp.cpp

http://commits.kde.org/plasma-workspace/a173d3a1f7db7721377c8f18eb6d8f411ea4d8d2

diff --git a/ksmserver/screenlocker/greeter/greeterapp.cpp b/ksmserver/screenlocker/greeter/greeterapp.cpp
index 7dfeaae..4903b07 100644
--- a/ksmserver/screenlocker/greeter/greeterapp.cpp
+++ b/ksmserver/screenlocker/greeter/greeterapp.cpp
 <at>  <at>  -194,8 +194,13  <at>  <at>  void UnlockApp::desktopResized()
         QQmlContext* context = view->engine()->rootContext();
         const KUser user;
         const QString fullName = user.property(KUser::FullName).toString();
-        QtAccountsService::AccountsManager accountsManager;
-        QString faceIconPath = accountsManager.findUserIconFile(user.loginName());
+        QtAccountsService::UserAccount* userAccount = new QtAccountsService::UserAccount;
+        QString faceIconPath = "";
+        if (userAccount) {
+            faceIconPath = userAccount->iconFileName();
+            delete userAccount;
+            userAccount = nullptr;
+        }

         context->setContextProperty(QStringLiteral("kscreenlocker_userName"), fullName.isEmpty() ?
(Continue reading)

Eike Hein | 29 Jul 03:51 2015
Picon

[plasma-desktop/hein/appdash] applets/kicker/package/contents/ui: Sanity check.

Git commit 46b3d8dd311c6851b8684aa5f95caf19462b33d7 by Eike Hein.
Committed on 29/07/2015 at 01:51.
Pushed by hein into branch 'hein/appdash'.

Sanity check.

M  +2    -0    applets/kicker/package/contents/ui/DashboardRepresentation.qml
M  +1    -1    applets/kicker/package/contents/ui/ItemGridDelegate.qml

http://commits.kde.org/plasma-desktop/46b3d8dd311c6851b8684aa5f95caf19462b33d7

diff --git a/applets/kicker/package/contents/ui/DashboardRepresentation.qml b/applets/kicker/package/contents/ui/DashboardRepresentation.qml
index fb3d06a..a4a8402 100644
--- a/applets/kicker/package/contents/ui/DashboardRepresentation.qml
+++ b/applets/kicker/package/contents/ui/DashboardRepresentation.qml
 <at>  <at>  -30,6 +30,8  <at>  <at>  import org.kde.plasma.private.kicker 0.1 as Kicker
 import "../code/tools.js" as Tools

 /* TODO
+ * mouse wheel on nested view
+ * dnd locks mouse
  * Reverse layout in rtl locales.
  * Keep cursor column when arrow'ing down past partial rows.
 */
diff --git a/applets/kicker/package/contents/ui/ItemGridDelegate.qml b/applets/kicker/package/contents/ui/ItemGridDelegate.qml
index 2247e91..1a969c2 100644
--- a/applets/kicker/package/contents/ui/ItemGridDelegate.qml
+++ b/applets/kicker/package/contents/ui/ItemGridDelegate.qml
 <at>  <at>  -59,7 +59,7  <at>  <at>  MouseArea {
     }
(Continue reading)

Eike Hein | 29 Jul 03:42 2015
Picon

[plasma-desktop/hein/appdash] applets/kicker/package/contents/ui: Fix fallthrough to view context menu.

Git commit b26bb25060f63675a66dc42dc479576c8d4b59a6 by Eike Hein.
Committed on 29/07/2015 at 01:42.
Pushed by hein into branch 'hein/appdash'.

Fix fallthrough to view context menu.

M  +6    -3    applets/kicker/package/contents/ui/DashboardRepresentation.qml

http://commits.kde.org/plasma-desktop/b26bb25060f63675a66dc42dc479576c8d4b59a6

diff --git a/applets/kicker/package/contents/ui/DashboardRepresentation.qml b/applets/kicker/package/contents/ui/DashboardRepresentation.qml
index cf87e22..fb3d06a 100644
--- a/applets/kicker/package/contents/ui/DashboardRepresentation.qml
+++ b/applets/kicker/package/contents/ui/DashboardRepresentation.qml
 <at>  <at>  -385,9 +385,10  <at>  <at>  Kicker.FullScreenWindow {
                 Item {
                     id: mainGridContainer

+                    anchors.fill: parent
                     z: (opacity == 1.0) ? 1 : 0

-                    anchors.fill: parent
+                    enabled: (opacity == 1.0) ? 1 : 0

                     property int headerHeight: mainColumnLabel.height + mainColumnLabelUnderline.height + units.largeSpacing

 <at>  <at>  -474,9 +475,10  <at>  <at>  Kicker.FullScreenWindow {
                     }

                     z: (opacity == 1.0) ? 1 : 0
(Continue reading)

Leslie Zhai | 29 Jul 03:39 2015
Picon

[plasma-desktop/user-accounts] applets/kickoff/package/contents/ui: applets/kickoff: directly use QtAccountsService`s UserAccount for

Git commit 3a0514b9d9fbec41d2e85d72537e4e6abe671255 by Leslie Zhai.
Committed on 29/07/2015 at 01:38.
Pushed by lesliezhai into branch 'user-accounts'.

applets/kickoff: directly use QtAccountsService`s UserAccount for
current login user

M  +5    -5    applets/kickoff/package/contents/ui/Header.qml

http://commits.kde.org/plasma-desktop/3a0514b9d9fbec41d2e85d72537e4e6abe671255

diff --git a/applets/kickoff/package/contents/ui/Header.qml b/applets/kickoff/package/contents/ui/Header.qml
index e46475e..8c732dd 100644
--- a/applets/kickoff/package/contents/ui/Header.qml
+++ b/applets/kickoff/package/contents/ui/Header.qml
 <at>  <at>  -37,11 +37,11  <at>  <at>  Item {
         id: kuser
     }

-    AccountsManager {
-        id: accountsManager
+    UserAccount {
+        id: userAccount

-        onUserAccountChanged: {
-            faceIcon.source = accountsManager.findUserIconFile(kuser.loginName) != "" ?
accountsManager.findUserIconFile(kuser.loginName) : kuser.faceIconUrl;
+        onAccountChanged: {
+            faceIcon.source = userAccount.iconFileName != "" ? userAccount.iconFileName : kuser.faceIconUrl;
         }
(Continue reading)

Friedrich W. H. Kossebau | 29 Jul 02:55 2015
Picon

[calligra/calligra/2.9] libs/odf: Sanitize memory management of KoXmlNodeData a little

Git commit 1d3684be07a10283cfa7bc02c992dfbd7369b343 by Friedrich W. H. Kossebau.
Committed on 29/07/2015 at 00:55.
Pushed by kossebau into branch 'calligra/2.9'.

Sanitize memory management of KoXmlNodeData a little

Summary:
1. Cleanup sharing of KoXmlNodeData objects
Many null DOM element types (as created by default constructor) did not get the
KoXmlNodeData::null instance to share, but a new separate instance, without any need.
Destructors tested for need for dereferencing on multiple levels instead of just in
the destructor of the central baseclass KoXmlNode. Additionally do the destructors try
to deal with superclasses having already removed the KoXmlNodeData instance, which points
to ownership of those instances not properly respected.
The KoXmlNodeData::null instance was excluded from dereferencing, but not from
referencing, which seems more a workaround. Testing for identity to KoXmlNodeData::null
was done both in the unref() call itself as well as before calling the unref() call.
The new code now uses KoXmlNodeData::null whereever possible. It also uses a parameter
to the constructor to KoXmlNodeData to define the initial ref count, to avoid further
unref() or ref() calls to adapt to the usage.

2. Create subclass KoXmlDocumentData to KoXmlNodeData
It holds all properties and methods interesting only to the KoXmlDocument objects,
to reduce footprint of KoXmlNodeData and separate the setContent functionality more

3. Deduplicate creating the DocumentTypeNode after setContent() success

Test Plan: All tests still pass, and different apps can load files as before.

Subscribers: Calligra-Devel-list
(Continue reading)

Eike Hein | 29 Jul 02:45 2015
Picon

[plasma-desktop/hein/appdash] applets/kicker/plugin: Clean up gunk.

Git commit 083cfb086d5e2ea9ff0ca5a0fdec1fafc36aaa64 by Eike Hein.
Committed on 29/07/2015 at 00:43.
Pushed by hein into branch 'hein/appdash'.

Clean up gunk.

M  +0    -8    applets/kicker/plugin/fullscreenwindow.cpp

http://commits.kde.org/plasma-desktop/083cfb086d5e2ea9ff0ca5a0fdec1fafc36aaa64

diff --git a/applets/kicker/plugin/fullscreenwindow.cpp b/applets/kicker/plugin/fullscreenwindow.cpp
index 3f1964f..b8ddf80 100644
--- a/applets/kicker/plugin/fullscreenwindow.cpp
+++ b/applets/kicker/plugin/fullscreenwindow.cpp
 <at>  <at>  -102,14 +102,6  <at>  <at>  void FullScreenWindow::hideEvent(QHideEvent *event)
 void FullScreenWindow::updateTheme()
 {
     KWindowEffects::enableBlurBehind(winId(), true);
-
-    return;
-
-    KWindowEffects::enableBackgroundContrast(winId(),
-        m_theme.backgroundContrastEnabled(),
-        m_theme.backgroundContrast(),
-        m_theme.backgroundIntensity(),
-        m_theme.backgroundSaturation());
 }

 void FullScreenWindow::parentScreenChanged(const QScreen *screen)

(Continue reading)

Eike Hein | 29 Jul 02:45 2015
Picon

[plasma-desktop/hein/appdash] applets/kicker/plugin: Check string bounds.

Git commit 57ba45c76b3b60ee18ecd4b803a399272e62a7a7 by Eike Hein.
Committed on 29/07/2015 at 00:44.
Pushed by hein into branch 'hein/appdash'.

Check string bounds.

M  +5    -0    applets/kicker/plugin/rootmodel.cpp

http://commits.kde.org/plasma-desktop/57ba45c76b3b60ee18ecd4b803a399272e62a7a7

diff --git a/applets/kicker/plugin/rootmodel.cpp b/applets/kicker/plugin/rootmodel.cpp
index aadccc2..fde16fd 100644
--- a/applets/kicker/plugin/rootmodel.cpp
+++ b/applets/kicker/plugin/rootmodel.cpp
 <at>  <at>  -258,6 +258,11  <at>  <at>  void RootModel::refresh()

             for (int i = 0; i < model->count(); ++i) {
                 AbstractEntry *appEntry = static_cast<AbstractEntry *>(model->index(i, 0).internalPointer());
+
+                if (appEntry->name().isEmpty()) {
+                    continue;
+                }
+
                 const QChar &first = appEntry->name().at(0).toUpper();
                 m_categoryHash[first.isDigit() ? QStringLiteral("0-9") : first].append(appEntry);
             }


Gmane