Re: [Laszlo-reviews] [UPDATED] For Review: Change 20090929-ptw-y Summary: A cut at getting backtracing to work in swf9
P T Withington <ptw <at> pobox.com>
2009-10-01 23:20:14 GMT
I found one more Flex compiler bug:
http://bugs.adobe.com/jira/browse/ASC-3852
It blows it if you try to return out of a for-in inside a try/finally.
Gee, if you look at the number of bugs about try/catch/finally and
verifier errors, you'd think they'd never written a byte-code compiler
before. :P
I can't figure out a workaround for this bug though. It crops up in
two places in the smoketest. Luckily for me, when I look at those two
places, I can see that they are actually broken! They are using for-
in on an Array, which is really a no-no. So, I rewrote them to use
for instead... I know, that is cheating.
Maybe Adobe can pay us to fix their byte compiler.
On 2009-09-30, at 22:45, P T Withington wrote:
> [Still not ready for prime time, but at least swf8 and dhtml are
> working again. swf9 works and almost runs with backtrace on, but
> the debugger is all screwed up. I know there are no backtraces
> actually captured in swf9 yet, this is just to see if I can get the
> instrumentation to work...
>
> Anyways, if you feel like playing with it some more, download the
> newest version.]
>
> Change 20090929-ptw-y by ptw <at> repo-man.home on 2009-09-29 18:01:59 EDT
> in /Users/ptw/OpenLaszlo/trunk
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: A cut at getting backtracing to work in swf9
>
> Bugs Fixed: LPP-8479 Debug.evalCarefully not necessary after LPP-8222?
> [I got carried away trying to make the line numbering in the debugger
> more accurate...]
>
> Technical Reviewer: hminsky (pending)
> QA Reviewer: a.bargull <at> intensis.de (pending)
>
> Release Notes:
> The debugger indicates when the file/line information on a debugger
> message is not accurate. If the location information is coming
> from the view associated with the error, rather than @file it will
> print %file. If the line number is only approximate (backtracing
> is not enabled), rather than #line it will print ~line.
>
> Details:
>
>
> Tests:
> More stuff works, still failing for swf9+debug+bactrace
>
> Files:
> M test/smoke/lztext.lzl
> M test/smoke/lzunit-test.lzl
> M WEB-INF/lps/lfc/kernel/swf9/LzPreloader.as
> M WEB-INF/lps/lfc/kernel/swf9/LFCApplication.as
> M WEB-INF/lps/lfc/debugger/LzMessage.lzs
> M WEB-INF/lps/lfc/debugger/LzDebug.lzs
> M WEB-INF/lps/lfc/debugger/platform/swf9/LzDebug.as
> M WEB-INF/lps/lfc/debugger/LzMonitor.lzs
> M WEB-INF/lps/lfc/debugger/LzTrace.lzs
> M WEB-INF/lps/lfc/debugger/LzBacktrace.lzs
> M WEB-INF/lps/lfc/core/LzNode.lzs
> M WEB-INF/lps/lfc/build.xml
> M WEB-INF/lps/lfc/compiler/LzDebugStub.lzs
> M WEB-INF/lps/lfc/compiler/LzBootstrapDebugService.lzs
> M WEB-INF/lps/server/src/org/openlaszlo/cm/
> CompilationManager.java
> M WEB-INF/lps/server/src/org/openlaszlo/sc/
> JavascriptGenerator.java
> M WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java
> M WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
> M WEB-INF/lps/server/src/org/openlaszlo/sc/
> TranslationContext.java
> M WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
> M WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java
> M WEB-INF/lps/server/src/org/openlaszlo/compiler/
> ToplevelCompiler.java
> M WEB-INF/lps/server/src/org/openlaszlo/compiler/SWF9Writer.java
> M WEB-INF/lps/templates/info-response.xslt
> M build.properties
> M lps/components/debugger/platform/swf9/eval.lzs
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090929-ptw-y.tar