P T Withington | 1 Oct 04:45
Picon
Favicon
Gravatar

[Laszlo-reviews] [UPDATED] For Review: Change 20090929-ptw-y Summary: A cut at getting backtracing to work in swf9

[Still not ready for prime time, but at least swf8 and dhtml are  
working again.  swf9 works and almost runs with backtrace on, but the  
debugger is all screwed up.  I know there are no backtraces actually  
captured in swf9 yet, this is just to see if I can get the  
instrumentation to work...

Anyways, if you feel like playing with it some more, download the  
newest version.]

Change 20090929-ptw-y by ptw <at> repo-man.home on 2009-09-29 18:01:59 EDT
     in /Users/ptw/OpenLaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: A cut at getting backtracing to work in swf9

Bugs Fixed: LPP-8479 Debug.evalCarefully not necessary after LPP-8222?
[I got carried away trying to make the line numbering in the debugger
more accurate...]

Technical Reviewer: hminsky (pending)
QA Reviewer: a.bargull <at> intensis.de (pending)

Release Notes:
    The debugger indicates when the file/line information on a debugger
    message is not accurate.  If the location information is coming
    from the view associated with the error, rather than @file it will
    print %file.  If the line number is only approximate (backtracing
    is not enabled), rather than #line it will print ~line.

Details:
(Continue reading)

P T Withington | 1 Oct 20:40
Picon
Favicon
Gravatar

Re: [Laszlo-reviews] [UPDATED] For Review: Change 20090929-ptw-y Summary: A cut at getting backtracing to work in swf9

I updated the archive, so if you are playing with this, you should get  
a new copy.

I added a kludge to the unparser to work around the bug with comma  
expressions in []'s.  Will you file that bug with Adobe?  You said you  
had a test case.

With that kludge, things mostly run in sw9 with backtrace annotation.   
There are a couple more verify errors, but they don't halt the  
execution.

I'm going to work on converting LzBacktrace to a class now, so  
backtraces can actually be captured and displayed...

On 2009-09-30, at 22:45, P T Withington wrote:

> [Still not ready for prime time, but at least swf8 and dhtml are  
> working again.  swf9 works and almost runs with backtrace on, but  
> the debugger is all screwed up.  I know there are no backtraces  
> actually captured in swf9 yet, this is just to see if I can get the  
> instrumentation to work...
>
> Anyways, if you feel like playing with it some more, download the  
> newest version.]
>
> Change 20090929-ptw-y by ptw <at> repo-man.home on 2009-09-29 18:01:59 EDT
>    in /Users/ptw/OpenLaszlo/trunk
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: A cut at getting backtracing to work in swf9
(Continue reading)

Henry Minsky | 1 Oct 20:46
Favicon

Re: [Laszlo-reviews] [UPDATED] For Review: Change 20090929-ptw-y Summary: A cut at getting backtracing to work in swf9

I filed an adobe bug with test case for the comma-separated-expressions used in square brackets.



On Thu, Oct 1, 2009 at 2:40 PM, P T Withington <ptw <at> pobox.com> wrote:
I updated the archive, so if you are playing with this, you should get a new copy.

I added a kludge to the unparser to work around the bug with comma expressions in []'s.  Will you file that bug with Adobe?  You said you had a test case.

With that kludge, things mostly run in sw9 with backtrace annotation.  There are a couple more verify errors, but they don't halt the execution.

I'm going to work on converting LzBacktrace to a class now, so backtraces can actually be captured and displayed...


On 2009-09-30, at 22:45, P T Withington wrote:

[Still not ready for prime time, but at least swf8 and dhtml are working again.  swf9 works and almost runs with backtrace on, but the debugger is all screwed up.  I know there are no backtraces actually captured in swf9 yet, this is just to see if I can get the instrumentation to work...

Anyways, if you feel like playing with it some more, download the newest version.]

Change 20090929-ptw-y by ptw <at> repo-man.home on 2009-09-29 18:01:59 EDT
  in /Users/ptw/OpenLaszlo/trunk
  for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: A cut at getting backtracing to work in swf9

Bugs Fixed: LPP-8479 Debug.evalCarefully not necessary after LPP-8222?
[I got carried away trying to make the line numbering in the debugger
more accurate...]

Technical Reviewer: hminsky (pending)
QA Reviewer: a.bargull <at> intensis.de (pending)

Release Notes:
 The debugger indicates when the file/line information on a debugger
 message is not accurate.  If the location information is coming
 from the view associated with the error, rather than <at> file it will
 print %file.  If the line number is only approximate (backtracing
 is not enabled), rather than #line it will print ~line.

Details:


Tests:
  More stuff works, still failing for swf9+debug+bactrace

Files:
M      test/smoke/lztext.lzl
M      test/smoke/lzunit-test.lzl
M      WEB-INF/lps/lfc/kernel/swf9/LzPreloader.as
M      WEB-INF/lps/lfc/kernel/swf9/LFCApplication.as
M      WEB-INF/lps/lfc/debugger/LzMessage.lzs
M      WEB-INF/lps/lfc/debugger/LzDebug.lzs
M      WEB-INF/lps/lfc/debugger/platform/swf9/LzDebug.as
M      WEB-INF/lps/lfc/debugger/LzMonitor.lzs
M      WEB-INF/lps/lfc/debugger/LzTrace.lzs
M      WEB-INF/lps/lfc/debugger/LzBacktrace.lzs
M      WEB-INF/lps/lfc/core/LzNode.lzs
M      WEB-INF/lps/lfc/build.xml
M      WEB-INF/lps/lfc/compiler/LzDebugStub.lzs
M      WEB-INF/lps/lfc/compiler/LzBootstrapDebugService.lzs
M      WEB-INF/lps/server/src/org/openlaszlo/cm/CompilationManager.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/TranslationContext.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ToplevelCompiler.java
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/SWF9Writer.java
M      WEB-INF/lps/templates/info-response.xslt
M      build.properties
M      lps/components/debugger/platform/swf9/eval.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090929-ptw-y.tar




--
Henry Minsky
Software Architect
hminsky <at> laszlosystems.com


_______________________________________________
Laszlo-reviews mailing list
Laszlo-reviews <at> www.openlaszlo.org
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
Henry Minsky | 1 Oct 23:46
Picon

[Laszlo-reviews] For Review: Change 20091001-hqm-G Summary: make shadowbox work in IE7/DHTML

Change 20091001-hqm-G by hqm <at> badtzmaru.home on 2009-10-01 17:43:26 EDT
     in /Users/hqm/openlaszlo/trunk6
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: make shadowbox work in IE7/DHTML

New Features:

Bugs Fixed: LPP-8207

Technical Reviewer: maynard
QA Reviewer: max
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

Create a rotated bitmap resource for the shadow

Tests:

<canvas width="100%" height="80%" >
   <include href="incubator/shadowbox.lzx"/>
   <shadowbox width="200" height="200" y="10" x="10" shadowleft="true">
     <view bgcolor="#cccccc" width="200" height="200"/>
   </shadowbox>
</canvas>

shadow appears in IE7 DHTML on the left and top of the square

Files:
M      lps/components/incubator/shadowbox.lzx
D      lps/components/incubator/resources/shadowbox/shadow_inset.swf
A      lps/components/incubator/resources/shadowbox/shadow_inset.png
A      lps/components/incubator/resources/shadowbox/ 
shadow_inset_vert.png
D      lps/components/incubator/resources/shadowbox/autoPng
D      lps/components/incubator/resources/shadowbox/autoPng/ 
shadow_inset.png

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20091001-hqm-G.tar
P T Withington | 2 Oct 01:20
Picon
Favicon
Gravatar

Re: [Laszlo-reviews] [UPDATED] For Review: Change 20090929-ptw-y Summary: A cut at getting backtracing to work in swf9

I found one more Flex compiler bug:

http://bugs.adobe.com/jira/browse/ASC-3852

It blows it if you try to return out of a for-in inside a try/finally.

Gee, if you look at the number of bugs about try/catch/finally and  
verifier errors, you'd think they'd never written a byte-code compiler  
before.  :P

I can't figure out a workaround for this bug though.  It crops up in  
two places in the smoketest.  Luckily for me, when I look at those two  
places, I can see that they are actually broken!  They are using for- 
in on an Array, which is really a no-no.  So, I rewrote them to use  
for instead...  I know, that is cheating.

Maybe Adobe can pay us to fix their byte compiler.

On 2009-09-30, at 22:45, P T Withington wrote:

> [Still not ready for prime time, but at least swf8 and dhtml are  
> working again.  swf9 works and almost runs with backtrace on, but  
> the debugger is all screwed up.  I know there are no backtraces  
> actually captured in swf9 yet, this is just to see if I can get the  
> instrumentation to work...
>
> Anyways, if you feel like playing with it some more, download the  
> newest version.]
>
> Change 20090929-ptw-y by ptw <at> repo-man.home on 2009-09-29 18:01:59 EDT
>    in /Users/ptw/OpenLaszlo/trunk
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: A cut at getting backtracing to work in swf9
>
> Bugs Fixed: LPP-8479 Debug.evalCarefully not necessary after LPP-8222?
> [I got carried away trying to make the line numbering in the debugger
> more accurate...]
>
> Technical Reviewer: hminsky (pending)
> QA Reviewer: a.bargull <at> intensis.de (pending)
>
> Release Notes:
>   The debugger indicates when the file/line information on a debugger
>   message is not accurate.  If the location information is coming
>   from the view associated with the error, rather than @file it will
>   print %file.  If the line number is only approximate (backtracing
>   is not enabled), rather than #line it will print ~line.
>
> Details:
>
>
> Tests:
>    More stuff works, still failing for swf9+debug+bactrace
>
> Files:
> M      test/smoke/lztext.lzl
> M      test/smoke/lzunit-test.lzl
> M      WEB-INF/lps/lfc/kernel/swf9/LzPreloader.as
> M      WEB-INF/lps/lfc/kernel/swf9/LFCApplication.as
> M      WEB-INF/lps/lfc/debugger/LzMessage.lzs
> M      WEB-INF/lps/lfc/debugger/LzDebug.lzs
> M      WEB-INF/lps/lfc/debugger/platform/swf9/LzDebug.as
> M      WEB-INF/lps/lfc/debugger/LzMonitor.lzs
> M      WEB-INF/lps/lfc/debugger/LzTrace.lzs
> M      WEB-INF/lps/lfc/debugger/LzBacktrace.lzs
> M      WEB-INF/lps/lfc/core/LzNode.lzs
> M      WEB-INF/lps/lfc/build.xml
> M      WEB-INF/lps/lfc/compiler/LzDebugStub.lzs
> M      WEB-INF/lps/lfc/compiler/LzBootstrapDebugService.lzs
> M      WEB-INF/lps/server/src/org/openlaszlo/cm/ 
> CompilationManager.java
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/ 
> JavascriptGenerator.java
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/ 
> TranslationContext.java
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
> ToplevelCompiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/SWF9Writer.java
> M      WEB-INF/lps/templates/info-response.xslt
> M      build.properties
> M      lps/components/debugger/platform/swf9/eval.lzs
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090929-ptw-y.tar
Henry Minsky | 2 Oct 03:20
Favicon

Re: [Laszlo-reviews] [UPDATED] For Review: Change 20090929-ptw-y Summary: A cut at getting backtracing to work in swf9

BTW, the console remote debugger option should work, so you might be able to use our debugger to  debug in swf10 even if the LZX
debugger component is broken.


On Thu, Oct 1, 2009 at 7:20 PM, P T Withington <ptw <at> pobox.com> wrote:
I found one more Flex compiler bug:

http://bugs.adobe.com/jira/browse/ASC-3852

It blows it if you try to return out of a for-in inside a try/finally.

Gee, if you look at the number of bugs about try/catch/finally and verifier errors, you'd think they'd never written a byte-code compiler before.  :P

I can't figure out a workaround for this bug though.  It crops up in two places in the smoketest.  Luckily for me, when I look at those two places, I can see that they are actually broken!  They are using for-in on an Array, which is really a no-no.  So, I rewrote them to use for instead...  I know, that is cheating.

Maybe Adobe can pay us to fix their byte compiler.


On 2009-09-30, at 22:45, P T Withington wrote:

[Still not ready for prime time, but at least swf8 and dhtml are working again.  swf9 works and almost runs with backtrace on, but the debugger is all screwed up.  I know there are no backtraces actually captured in swf9 yet, this is just to see if I can get the instrumentation to work...

Anyways, if you feel like playing with it some more, download the newest version.]

Change 20090929-ptw-y by ptw <at> repo-man.home on 2009-09-29 18:01:59 EDT
  in /Users/ptw/OpenLaszlo/trunk
  for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: A cut at getting backtracing to work in swf9

Bugs Fixed: LPP-8479 Debug.evalCarefully not necessary after LPP-8222?
[I got carried away trying to make the line numbering in the debugger
more accurate...]

Technical Reviewer: hminsky (pending)
QA Reviewer: a.bargull <at> intensis.de (pending)

Release Notes:
 The debugger indicates when the file/line information on a debugger
 message is not accurate.  If the location information is coming
 from the view associated with the error, rather than <at> file it will
 print %file.  If the line number is only approximate (backtracing
 is not enabled), rather than #line it will print ~line.

Details:


Tests:
  More stuff works, still failing for swf9+debug+bactrace

Files:
M      test/smoke/lztext.lzl
M      test/smoke/lzunit-test.lzl
M      WEB-INF/lps/lfc/kernel/swf9/LzPreloader.as
M      WEB-INF/lps/lfc/kernel/swf9/LFCApplication.as
M      WEB-INF/lps/lfc/debugger/LzMessage.lzs
M      WEB-INF/lps/lfc/debugger/LzDebug.lzs
M      WEB-INF/lps/lfc/debugger/platform/swf9/LzDebug.as
M      WEB-INF/lps/lfc/debugger/LzMonitor.lzs
M      WEB-INF/lps/lfc/debugger/LzTrace.lzs
M      WEB-INF/lps/lfc/debugger/LzBacktrace.lzs
M      WEB-INF/lps/lfc/core/LzNode.lzs
M      WEB-INF/lps/lfc/build.xml
M      WEB-INF/lps/lfc/compiler/LzDebugStub.lzs
M      WEB-INF/lps/lfc/compiler/LzBootstrapDebugService.lzs
M      WEB-INF/lps/server/src/org/openlaszlo/cm/CompilationManager.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/TranslationContext.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ToplevelCompiler.java
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/SWF9Writer.java
M      WEB-INF/lps/templates/info-response.xslt
M      build.properties
M      lps/components/debugger/platform/swf9/eval.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090929-ptw-y.tar




--
Henry Minsky
Software Architect
hminsky <at> laszlosystems.com


_______________________________________________
Laszlo-reviews mailing list
Laszlo-reviews <at> www.openlaszlo.org
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
Max Carlson | 2 Oct 04:11
Favicon

Re: [Laszlo-reviews] For Review: Change 20091001-hqm-G Summary: make shadowbox work in IE7/DHTML

Approved

Henry Minsky wrote:
> Change 20091001-hqm-G by hqm <at> badtzmaru.home on 2009-10-01 17:43:26 EDT
>     in /Users/hqm/openlaszlo/trunk6
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: make shadowbox work in IE7/DHTML
> 
> New Features:
> 
> Bugs Fixed: LPP-8207
> 
> Technical Reviewer: maynard
> QA Reviewer: max
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Release Notes:
> 
> Details:
> 
> Create a rotated bitmap resource for the shadow
> 
> Tests:
> 
> <canvas width="100%" height="80%" >
>   <include href="incubator/shadowbox.lzx"/>
>   <shadowbox width="200" height="200" y="10" x="10" shadowleft="true">
>     <view bgcolor="#cccccc" width="200" height="200"/>
>   </shadowbox>
> </canvas>
> 
> shadow appears in IE7 DHTML on the left and top of the square
> 
> 
> Files:
> M      lps/components/incubator/shadowbox.lzx
> D      lps/components/incubator/resources/shadowbox/shadow_inset.swf
> A      lps/components/incubator/resources/shadowbox/shadow_inset.png
> A      lps/components/incubator/resources/shadowbox/shadow_inset_vert.png
> D      lps/components/incubator/resources/shadowbox/autoPng
> D      
> lps/components/incubator/resources/shadowbox/autoPng/shadow_inset.png
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20091001-hqm-G.tar

--

-- 
Regards,
Max Carlson
OpenLaszlo.org
Max Carlson | 2 Oct 06:01
Favicon

[Laszlo-reviews] For Review: Change 20091001-maxcarlson-D Summary: Fix IE clickability issues when interacting with iframes

Change 20091001-maxcarlson-D by maxcarlson <at> bank.lan on 2009-10-01  
20:53:54 PDT
     in /Users/maxcarlson/openlaszlo/trunk-clean
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix IE clickability issues when interacting with iframes

Bugs Fixed: LPP-8435 - The visible atrribute of view will cannot work  
well,when clicking on html iframe to control the display of a view

Technical Reviewer: ptw
QA Reviewer: hminsky

Details: I'm not sure why, but IE needs to have its stylesheet  
twiddled for this testcase to work.  For some reason, the clickable  
<img/> remains active without this change - probably more IE renderer  
voodoo.

LzMouseKernel - Shorten lookups in setMouseControl().  Eliminate  
__cachedSelection cruft.  In setGlobalClickable() when  
quirks.fix_ie_clickable is on, explicitly toggle the CSS display  
attribute for all clickdivs.

Tests: See testcase from LPP-8435.

Files:
M       WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20091001-maxcarlson-D.tar
Max Carlson | 2 Oct 06:09
Favicon

Re: [Laszlo-reviews] For Review: Change 20091001-maxcarlson-D Summary: Fix IE clickability issues when interacting with iframes

I'm going to check this in ahead of review, since it's critical for 
webtop.  Tucker, please integrate to the 4.6 branch and start a build ASAP.

Max Carlson wrote:
> Change 20091001-maxcarlson-D by maxcarlson <at> bank.lan on 2009-10-01  
> 20:53:54 PDT
>      in /Users/maxcarlson/openlaszlo/trunk-clean
>      for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Fix IE clickability issues when interacting with iframes
> 
> Bugs Fixed: LPP-8435 - The visible atrribute of view will cannot work  
> well,when clicking on html iframe to control the display of a view
> 
> Technical Reviewer: ptw
> QA Reviewer: hminsky
> 
> Details: I'm not sure why, but IE needs to have its stylesheet  
> twiddled for this testcase to work.  For some reason, the clickable  
> <img/> remains active without this change - probably more IE renderer  
> voodoo.
> 
> LzMouseKernel - Shorten lookups in setMouseControl().  Eliminate  
> __cachedSelection cruft.  In setGlobalClickable() when  
> quirks.fix_ie_clickable is on, explicitly toggle the CSS display  
> attribute for all clickdivs.
> 
> Tests: See testcase from LPP-8435.
> 
> Files:
> M       WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20091001-maxcarlson-D.tar
> _______________________________________________
> Laszlo-reviews mailing list
> Laszlo-reviews <at> www.openlaszlo.org
> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews

--

-- 
Regards,
Max Carlson
OpenLaszlo.org
P T Withington | 2 Oct 15:22
Favicon

Re: [Laszlo-reviews] For Review: Change 20091001-maxcarlson-D Summary: Fix IE clickability issues when interacting with iframes

We love IE!

Approved.

On 2009-10-02, at 00:01, Max Carlson wrote:

> Change 20091001-maxcarlson-D by maxcarlson <at> bank.lan on 2009-10-01
> 20:53:54 PDT
>     in /Users/maxcarlson/openlaszlo/trunk-clean
>     for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Fix IE clickability issues when interacting with iframes
>
> Bugs Fixed: LPP-8435 - The visible atrribute of view will cannot work
> well,when clicking on html iframe to control the display of a view
>
> Technical Reviewer: ptw
> QA Reviewer: hminsky
>
> Details: I'm not sure why, but IE needs to have its stylesheet
> twiddled for this testcase to work.  For some reason, the clickable
> <img/> remains active without this change - probably more IE renderer
> voodoo.
>
> LzMouseKernel - Shorten lookups in setMouseControl().  Eliminate
> __cachedSelection cruft.  In setGlobalClickable() when
> quirks.fix_ie_clickable is on, explicitly toggle the CSS display
> attribute for all clickdivs.
>
> Tests: See testcase from LPP-8435.
>
> Files:
> M       WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20091001-maxcarlson-D.tar
> _______________________________________________
> Laszlo-reviews mailing list
> Laszlo-reviews <at> www.openlaszlo.org
> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews

Gmane