I'm fine with checking this in and merging to 4.3. Tucker - can you do the merge?
Then, it should be in tonight's final build.
Thanks!
Amy
On Tue, Mar 31, 2009 at 7:09 PM , Max Carlson wrote:
This is an extremely low-risk change - all that happened is an attribute name changed to be something that more accurately describes what it does - videoView.showFrame -> startTime. I think this should go into 4.3 because this is a new attribute/feature and it's important to get the naming correct the first time - otherwise it becomes much more difficult to change.
--
Regards,
Max Carlson
OpenLaszlo.org
------------------------------
From: sallen <at> openlaszlo.org
To: laszlo-checkins <at> openlaszlo.org
Date: Tue Mar 31 15:58:51 PDT 2009
Subject: [Laszlo-checkins] r13566 - in openlaszlo/trunk: lps/components/av lps/components/extensions/av test/video
Author: sallen
Date: 2009-03-31 15:58:50 -0700 (Tue, 31 Mar 2009)
New Revision: 13566
Modified:
openlaszlo/trunk/lps/components/av/videoplayer.lzx
openlaszlo/trunk/lps/components/av/videoscreen.lzx
openlaszlo/trunk/lps/components/extensions/av/videoview.lzx
openlaszlo/trunk/test/video/test-stream-video.lzx
openlaszlo/trunk/test/video/test-videoplayer-http.lzx
Log:
in /Users/sarah/src/svn/openlaszlo/trunk-review/test/video
Summary: videoView.showFrame -> startTime
New Features:
Bugs Fixed: LPP-799 videoView.showFrame -> startTime
Technical Reviewer: max
QA Reviewer: (pending)
Doc Reviewer: (pending)
Documentation:
doc'd in reference
Release Notes:
Details:
Tests:
Modified: openlaszlo/trunk/lps/components/av/videoplayer.lzx
===================================================================
--- openlaszlo/trunk/lps/components/av/videoplayer.lzx 2009-03-31 22:30:35 UTC (rev 13565)
+++ openlaszlo/trunk/lps/components/av/videoplayer.lzx 2009-03-31 22:58:50 UTC (rev 13566)
<at> <at> -28,15 +28,17 <at> <at>
see mediastream for details -->
<attribute name="url" type="string" value=""/>
- <!--- Show this frame when the url is set.
- Use -1 to show no frame.
- Default: 0 -->
- <attribute name="showframe" type="number" value="0"/>
<!--- when true, playback will start automatically
without user action -->
<attribute name="autoplay" value="false"/>
+ <!--- Show the frame from this time (in seconds) whenever the url
+ is set for video playback.
+ Use -1 to show no frame (which will leave the image as it
+ was when switching videos) -->
+ <attribute name="starttime" value="0" type="number"/>
+
<!--- why would you want this? no test case, marking private
<at> access private -->
<attribute name="showscreen" value="true"/>
<at> <at> -122,7 +124,7 <at> <at>
autoplay="${classroot.autoplay}"
url="${classroot.url}"
volume="${parent.vslider.volume}"
- showframe="${parent.showframe}"
+ starttime="${parent.starttime}"
borderTop="${parent.borderTop}"
borderLeft="${parent.borderLeft}"
borderBottom="${parent.borderBottom}"
Modified: openlaszlo/trunk/lps/components/av/videoscreen.lzx
===================================================================
--- openlaszlo/trunk/lps/components/av/videoscreen.lzx 2009-03-31 22:30:35 UTC (rev 13565)
+++ openlaszlo/trunk/lps/components/av/videoscreen.lzx 2009-03-31 22:58:50 UTC (rev 13566)
<at> <at> -16,7 +16,7 <at> <at>
<!--- true for verbose debug logging -->
<attribute name="debug" value="false"/>
- <attribute name="showframe" value="0"/>
+ <attribute name="starttime" value="0" type="number"/>
<attribute name="type" type="string" value="http"/>
<attribute name="url" type="string" value=""/>
<at> <at> -75,6 +75,7 <at> <at>
stream="$once{classroot.ms}"
visible="${parent.visible && (this.width > 1) && (this.height > 1)}"
playvolume="${classroot.volume}"
+ starttime="${classroot.starttime}"
debug="${parent.debug}"
>
Modified: openlaszlo/trunk/lps/components/extensions/av/videoview.lzx
===================================================================
--- openlaszlo/trunk/lps/components/extensions/av/videoview.lzx 2009-03-31 22:30:35 UTC (rev 13565)
+++ openlaszlo/trunk/lps/components/extensions/av/videoview.lzx 2009-03-31 22:58:50 UTC (rev 13566)
<at> <at> -54,9 +54,11 <at> <at>
Default: false. -->
<attribute name="autoplay" value="false"/>
- <!--- Show this frame when the url is set for recorded video.
- Use -1 to show no frame-->
- <attribute name="showframe" value="0"/>
+ <!--- Show the frame from this time (in seconds) whenever the url
+ is set for video playback.
+ Use -1 to show no frame (which will leave the image as it
+ was when switching videos) -->
+ <attribute name="starttime" value="0" type="number"/>
<!--- If true, Debug.write extra stuff (this may go away). -->
<attribute name="debug" value="false"/>
<at> <at> -164,8 +166,8 <at> <at>
this.stream, "onplaying")
if (this.stream.playing || this.stream.type == 'http') {
// show poster frame now for http streams
- if (!this.stream.playing && this.showframe != -1) {
- this.stream.seek(this.showframe);
+ if (!this.stream.playing && this.starttime != -1) {
+ this.stream.seek(this.starttime);
}
this._setPlayStream();
}
<at> <at> -286,7 +288,7 <at> <at>
<method name="_updateStreamUrl"> <![CDATA[
//Debug.write("%w _updateStreamUrl %w %w",
- // this, this.url, this.showframe);
+ // this, this.url, this.starttime);
this.stream.setAttribute("url", this.url);
]]>
Modified: openlaszlo/trunk/test/video/test-stream-video.lzx
===================================================================
--- openlaszlo/trunk/test/video/test-stream-video.lzx 2009-03-31 22:30:35 UTC (rev 13565)
+++ openlaszlo/trunk/test/video/test-stream-video.lzx 2009-03-31 22:58:50 UTC (rev 13566)
<at> <at> -22,7 +22,7 <at> <at>
<simplelayout axis="y" inset="10" spacing="5"/>
<constantlayout axis="x" value="10"/>
<text>v2: don't show first frame initially</text>
- <videoview id="v2" showframe="-1">
+ <videoview id="v2" starttime="-1">
<mediastream id="s2"
url="http:videos/good-dog.flv"/>
</videoview>
Modified: openlaszlo/trunk/test/video/test-videoplayer-http.lzx
===================================================================
--- openlaszlo/trunk/test/video/test-videoplayer-http.lzx 2009-03-31 22:30:35 UTC (rev 13565)
+++ openlaszlo/trunk/test/video/test-videoplayer-http.lzx 2009-03-31 22:58:50 UTC (rev 13566)
<at> <at> -8,11 +8,11 <at> <at>
<simplelayout axis="x" spacing="10"/>
<view layout="axis:y">
<text multiline="true">
- v1: showframe="1"<br/>
+ v1: starttime="1"<br/>
showTimeDisplay="false" showVolumeControl="false"<br/>
progressColor="0x0000cc" border="1" sliderGap="0"
</text>
- <videoplayer id="v1" showframe="1"
+ <videoplayer id="v1" starttime="1"
showTimeDisplay="false" showVolumeControl="false"
progressColor="0x0000cc"
border="1" sliderGap="0"
_______________________________________________
Laszlo-checkins mailing list
RSS Feed