Re: For Review: Change 20090131-ptw-Y Summary: Repair think-oh in binary library compiling

approved!

On Sat, Jan 31, 2009 at 6:08 PM, P T Withington <ptw <at> pobox.com> wrote:
> Change 20090131-ptw-Y by ptw <at> dueling-banjos.home on 2009-01-31 17:59:21 EST
>    in /Users/ptw/OpenLaszlo/trunk-4
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Repair think-oh in binary library compiling
>
> Bugs Fixed: LPP-7607  Can't extend from a class in the incubator in an lzo
>
> Technical Reviewer: hminsky (pending)
> QA Reviewer: lhenrywilkins (pending)
>
> Details:
>    ClassModel/modelOnly should also be true when not linking.
>
> Tests:
>    Test case from bug
>
> Files:
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassCompiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090131-ptw-Y.tar
>

--

-- 
Henry Minsky
Software Architect

Re: For Review: Change 20090130-dda-P Summary: Restore LzDelegate documentation

Re: For Review: Change 20090130-dda-r Summary: doc examples get width=100% when unspecified

Re: IRC, or some other chat?

I'm not sure, as many people don't seem to use IRC nowadays. But the  
advantage of IRC is, that there log files, there's lots of free  
clients around and it's easy to use.

IRC is better than proprietary solutions like Google Talk or Skype.  
Another interesting option would be Webtop integrated with a chat,  
running solely for the OL community.

- Raju

On Jan 30, 2009, at 8:08 PM, P T Withington wrote:

> We'd like to improve OL developer communication by providing some  
> medium where developers can meet and communicate in real time.  We  
> used to have an IRC channel irc.freenode.net#laszlo, but that fell  
> into disuse.
>
> Is IRC the best medium for this?
>
> Other ideas?

For Review: Summary: Fix radio button in incubator. Change 20090201-Philip-0

Change 20090201-Philip-0 by Philip <at> Philip-DC on 2009-02-01 18:23:44 EST
     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix radio button in incubator

New Features:

Bugs Fixed: LPP-7698

Technical Reviewer: henry
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
The last change to the incubator changed a method name from setValue 
to doSetValue. The problem is that setValue is an override and the 
name can't be changed. The way to fix the problem in compiling for 
swf9 is to specify a default value for the second argument. I also 
changed it in baseradio.  baseedittext has a similar issue but 
setValue() has 3 arguments. The change appears to be safe (because 
the old override of setValue did not call the base class).

Tests:
The following test works properly in swf8/swf9, dhtml.

<canvas>
<include href="incubator/lzradio_resources.lzx" />
<include href="incubator/lzradio.lzx" />

<include href="incubator/newcheckbox.lzx" />

<simplelayout spacing="20"/>

<baseradiogroup layout="class:simplelayout" bgcolor="%cccccc">
   <lzradiobutton value="1">Button 1</lzradiobutton>
   <lzradiobutton value="2">Button 2</lzradiobutton>
   <lzradiobutton value="3">Button 3</lzradiobutton>
</baseradiogroup>

<newcheckbox bgcolor="%cccccc">Checkbox 1</newcheckbox>

</canvas>

Files:
M      lps/components/incubator/basecheckbox.lzx
M      lps/components/incubator/baseradio.lzx

http://svn.openlaszlo.org/openlaszlo/patches/20090201-Philip-0.tar

Re: For Review: Summary: Fix radio button in incubator. Change 20090201-Philip-0

I'm confused, it looks like there's an exact copy of baseedittext.lzx
in both lps/components/base and lps/components/incubator.  How did
that happen?

On Sun, Feb 1, 2009 at 6:47 PM, Philip Romanik
<promanik <at> laszlosystems.com> wrote:
> Change 20090201-Philip-0 by Philip <at> Philip-DC on 2009-02-01 18:23:44 EST
>    in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Fix radio button in incubator
>
> New Features:
>
> Bugs Fixed: LPP-7698
>
> Technical Reviewer: henry
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> The last change to the incubator changed a method name from setValue to
> doSetValue. The problem is that setValue is an override and the name can't
> be changed. The way to fix the problem in compiling for swf9 is to specify a
> default value for the second argument. I also changed it in baseradio.
>  baseedittext has a similar issue but setValue() has 3 arguments. The change
> appears to be safe (because the old override of setValue did not call the
> base class).
>
> Tests:
> The following test works properly in swf8/swf9, dhtml.
>
> <canvas>
> <include href="incubator/lzradio_resources.lzx" />
> <include href="incubator/lzradio.lzx" />
>
> <include href="incubator/newcheckbox.lzx" />
>
> <simplelayout spacing="20"/>
>
> <baseradiogroup layout="class:simplelayout" bgcolor="%cccccc">
>  <lzradiobutton value="1">Button 1</lzradiobutton>
>  <lzradiobutton value="2">Button 2</lzradiobutton>
>  <lzradiobutton value="3">Button 3</lzradiobutton>
> </baseradiogroup>
>
> <newcheckbox bgcolor="%cccccc">Checkbox 1</newcheckbox>
>
> </canvas>
>
>
> Files:
> M      lps/components/incubator/basecheckbox.lzx
> M      lps/components/incubator/baseradio.lzx
>
>
> http://svn.openlaszlo.org/openlaszlo/patches/20090201-Philip-0.tar
>
>
>

--

-- 
Henry Minsky
Software Architect
hminsky <at> laszlosystems.com

Re: For Review: Summary: Fix radio button in incubator. Change 20090201-Philip-0

Re: For Review: Summary: Fix radio button in incubator. Change 20090201-Philip-0

My mistake, I'd copied it over when I was working on scrolledittext.

On Sun, Feb 1, 2009 at 9:13 PM, Philip Romanik
<promanik <at> laszlosystems.com> wrote:
> There isn't a baseedittext.lzx in /lps/components/base.
>
>
>
> I'm confused, it looks like there's an exact copy of baseedittext.lzx in
> both lps/components/base and lps/components/incubator.  How did that happen?
>
> On Sun, Feb 1, 2009 at 6:47 PM, Philip Romanik < promanik <at> laszlosystems.com>
> wrote:
>> Change 20090201-Philip-0 by Philip <at> Philip-DC on 2009-02-01 18:23:44 EST
>>    in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
>>    for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: Fix radio button in incubator
>>
>> New Features:
>>
>> Bugs Fixed: LPP-7698
>>
>> Technical Reviewer: henry
>> QA Reviewer: (pending)
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details:
>> The last change to the incubator changed a method name from setValue
>> to doSetValue. The problem is that setValue is an override and the
>> name can't be changed. The way to fix the problem in compiling for
>> swf9 is to specify a default value for the second argument. I also changed
>> it in baseradio.
>>  baseedittext has a similar issue but setValue() has 3 arguments. The
>> change appears to be safe (because the old override of setValue did
>> not call the base class).
>>
>> Tests:
>> The following test works properly in swf8/swf9, dhtml.
>>
>> <canvas>
>> <include href="incubator/lzradio_resources.lzx" /> <include
>> href="incubator/lzradio.lzx" />
>>
>> <include href="incubator/newcheckbox.lzx" />
>>
>> <simplelayout spacing="20"/>
>>
>> <baseradiogroup layout="class:simplelayout" bgcolor="%cccccc">
>> <lzradiobutton value="1">Button 1</lzradiobutton>  <lzradiobutton
>> value="2">Button 2</lzradiobutton>  <lzradiobutton value="3">Button
>> 3</lzradiobutton> </baseradiogroup>
>>
>> <newcheckbox bgcolor="%cccccc">Checkbox 1</newcheckbox>
>>
>> </canvas>
>>
>>
>> Files:
>> M      lps/components/incubator/basecheckbox.lzx
>> M      lps/components/incubator/baseradio.lzx
>>
>>
>> http://svn.openlaszlo.org/openlaszlo/patches/20090201-Philip-0.tar
>>
>>
>>
>
>
>
> --
> Henry Minsky
> Software Architect
> hminsky <at> laszlosystems.com

--

-- 
Henry Minsky
Software Architect
hminsky <at> laszlosystems.com

Re: For Review: Summary: Fix radio button in incubator. Change 20090201-Philip-0

approved

On Sun, Feb 1, 2009 at 6:47 PM, Philip Romanik
<promanik <at> laszlosystems.com> wrote:
> Change 20090201-Philip-0 by Philip <at> Philip-DC on 2009-02-01 18:23:44 EST
>    in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Fix radio button in incubator
>
> New Features:
>
> Bugs Fixed: LPP-7698
>
> Technical Reviewer: henry
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> The last change to the incubator changed a method name from setValue to
> doSetValue. The problem is that setValue is an override and the name can't
> be changed. The way to fix the problem in compiling for swf9 is to specify a
> default value for the second argument. I also changed it in baseradio.
>  baseedittext has a similar issue but setValue() has 3 arguments. The change
> appears to be safe (because the old override of setValue did not call the
> base class).
>
> Tests:
> The following test works properly in swf8/swf9, dhtml.
>
> <canvas>
> <include href="incubator/lzradio_resources.lzx" />
> <include href="incubator/lzradio.lzx" />
>
> <include href="incubator/newcheckbox.lzx" />
>
> <simplelayout spacing="20"/>
>
> <baseradiogroup layout="class:simplelayout" bgcolor="%cccccc">
>  <lzradiobutton value="1">Button 1</lzradiobutton>
>  <lzradiobutton value="2">Button 2</lzradiobutton>
>  <lzradiobutton value="3">Button 3</lzradiobutton>
> </baseradiogroup>
>
> <newcheckbox bgcolor="%cccccc">Checkbox 1</newcheckbox>
>
> </canvas>
>
>
> Files:
> M      lps/components/incubator/basecheckbox.lzx
> M      lps/components/incubator/baseradio.lzx
>
>
> http://svn.openlaszlo.org/openlaszlo/patches/20090201-Philip-0.tar
>
>
>

--

-- 
Henry Minsky
Software Architect
hminsky <at> laszlosystems.com

[UPDATE] For Review: Change 20090130-ptw-t Summary: Implement LFC end of kernel scrolling API

[UPDATE:  This now compiles and seems to work in swf9.  The kernel  
work to call back to scrollevent and to implement the line/pixel  
conversions is still to be done in all 3 kernels, but I was able to  
patch enough of this together that is should be working at least as  
well as the current implementation... so give it a real review and we  
can check it in.]

Change 20090130-ptw-t by ptw <at> dueling-banjos.home on 2009-01-30  
18:08:40 EST
     in /Users/ptw/OpenLaszlo/trunk-4
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Implement LFC end of kernel scrolling API

Bugs Fixed: LPP-6580  scrolledittext doesn't work in 4.1 (partial)

Technical Reviewer: max (pending)
QA Reviewer: hminsky (pending)

Details:
     LzSprite.*, LaszloView, LaszloCanvas: Add linescrolling
     capability, unify capabilities as a sprite instance var.

     swf9/LzTextSprite: Add primitive version of setX/YScroll

     LzInputText: Set tsprite in __makeSprite

     LzText: Implement new kernel scrolling API.  Cache tsprite for
     efficiency.

     newcontent: Silence warnings.

Tests:
     swf9 compiles

Files:
M      WEB-INF/lps/lfc/kernel/swf/LzSprite.as
M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M      WEB-INF/lps/lfc/kernel/swf9/LzTextSprite.as
M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
M      WEB-INF/lps/lfc/views/LzInputText.lzs
M      WEB-INF/lps/lfc/views/LzText.lzs
M      WEB-INF/lps/lfc/views/LaszloView.lzs
M      WEB-INF/lps/lfc/views/LaszloCanvas.lzs
M      lps/components/debugger/newcontent.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090130-ptw-t.tar