headers
Henry Minsky | 1 Jan 05:08
Picon

UPDATED For Review: Change 20081231-hqm-K Summary: fix null pointer error in <switch> statement

Sorry, had bogus modified file in previous tar file...

Change 20081231-hqm-K by hqm <at> badtzmaru.home on 2008-12-31 12:05:35 EST
     in /Users/hqm/openlaszlo/trunk4
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: fix null pointer error in <switch> statement

New Features:

Bugs Fixed: LP-6982

Technical Reviewer: andre
QA Reviewer: promanik
Doc Reviewer: (pending)

Documentation:

Release Notes:

<switch> statement now supports an <unless> clause

example:

<switch>
   <unless property="$dhtml">
      [lzx code to be included]
   </unless>
</switch>
(Continue reading)

Permalink | Reply | 2 comments |
headers
André Bargull | 2 Jan 17:24

Re: UPDATED For Review: Change 20081231-hqm-K Summary: fix null pointer error in <switch> statement

Not approved.

1. There is some debug code in Parser.java
> +            System.err.println("getCompileTimeConstants = "+cc);

2. And the "debug" and "profile" attributes on <canvas> can override the 
default runtime properties (see l. 436-444 in Compiler.java). So with 
your change the following testcase is no longer compiled in (proper) 
debug-mode.
In swf8, the debug-window doesn't show up, although `$debug` evaluates 
to `true`. In dhtml, the debug console shows up and the debug-lfc is 
included, but `$debug` evals to `false`. And swf9 doesn't compile at 
all, compile-error was:
> Access to an undefined property LzDebuggerWindowConsoleBridge.

testcase:
---
<canvas debug="true" >
   <handler name="oninit" >
     txt.addFormat("$debug = %w", $debug === true);
   </handler>
   <text id="txt" />
</canvas>
---

On 1/1/2009 5:08 AM, Henry Minsky wrote:
> Sorry, had bogus modified file in previous tar file...
> 
> 
>
(Continue reading)

Permalink | Reply | 1 comment |
headers
André Bargull | 2 Jan 18:56

Re: For Review: Change 20081230-maxcarlson-5 Summary: Re-select text when focus is lost by clicking lon an unfocusable element (swf8 only)

Not approved.

1) At general, I'd like to propose to add an attribute which defines how 
selection should be handled, because IMO this feels like a big change in 
L&F of inputtexts and some users may prefer that selection is cleared as 
soon as e.g. the window is dragged (in the testcase).

2) The new behaviour doesn't really reflect DHTML, for example click on 
the inputtext and then on the canvas: in dhtml, selection is cleared, 
whereas in swf8, the selection will be recreated.

3) And in my opinion, it looks like a defect when the selection is 
recreated on "onmouseup", because there is no selection when you drag 
the window around, but only after releasing the mouse-button you'll get 
the previous text selection. I'd prefer either no recreation at all or 
continuous selection (as in dhtml).

4) Scrolling for multiline texts (as in the debug-window) is broken. 
Click on edittext, inspect the debug-message and then try to scroll with 
arrow-buttons to the top. (You can use the testcase below.)

5) And finally, the general focusing is broken. If you add a handler to 
onfocus on lz.Focus, you'll get this output in swf8:
> new focus on .field
> new focus on null
> new focus on .field

But in dhtml, it justs:
> new focus on .field
(Continue reading)

Permalink | Reply | 0 comments |
headers
Henry Minsky | 2 Jan 20:54
Picon

Re: UPDATED For Review: Change 20081231-hqm-K Summary: fix null pointer error in <switch> statement

Hmm,  I think I need to add a special case in Parser to read these
attributes from the canvas element before the <switch> tags get
evaluated...

On Fri, Jan 2, 2009 at 11:24 AM, André Bargull <andre.bargull <at> udo.edu> wrote:
> Not approved.
>
> 1. There is some debug code in Parser.java
>>
>> +            System.err.println("getCompileTimeConstants = "+cc);
>
>
> 2. And the "debug" and "profile" attributes on <canvas> can override the
> default runtime properties (see l. 436-444 in Compiler.java). So with your
> change the following testcase is no longer compiled in (proper) debug-mode.
> In swf8, the debug-window doesn't show up, although `$debug` evaluates to
> `true`. In dhtml, the debug console shows up and the debug-lfc is included,
> but `$debug` evals to `false`. And swf9 doesn't compile at all,
> compile-error was:
>>
>> Access to an undefined property LzDebuggerWindowConsoleBridge.
>
>
>
> testcase:
> ---
> <canvas debug="true" >
>  <handler name="oninit" >
>    txt.addFormat("$debug = %w", $debug === true);
>  </handler>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Henry Minsky | 3 Jan 00:11
Picon

UPDATED For Review: Change 20090102-hqm-r Summary: fix null pointer error in <switch> statement


Change 20090102-hqm-r by hqm <at> badtzmaru.home on 2009-01-02 18:06:10 EST
     in /Users/hqm/openlaszlo/trunk4
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: fix null pointer error in <switch> statement

New Features:

Bugs Fixed: LP-6982

Technical Reviewer: andre
QA Reviewer: promanik
Doc Reviewer: (pending)

Documentation:

Release Notes:

<switch> statement now supports an <unless> clause

example:

<switch>
  <unless property="$dhtml">
     [lzx code to be included]
  </unless>
</switch>

Details:
(Continue reading)

Permalink | Reply | 1 comment |
headers
André Bargull | 3 Jan 18:09

For Review: Change 20090103-bargull-XZh Summary: newlines aren't printed in IE

Change 20090103-bargull-XZh by bargull <at> dell--p4--2-53 on 2009-01-03 18:03:13
in /home/Admin/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: newlines aren't printed in IE

New Features:

Bugs Fixed: LPP-7550

Technical Reviewer: ptw
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
Also replace the html-entities for \n to
so that newlines will show up in IE.

Tests:
see bugreport

Files:
M WEB-INF/lps/lfc/debugger/platform/dhtml/LzDebug.js

Changeset: 
http://svn.openlaszlo.org/openlaszlo/patches/20090103-bargull-XZh.tar
(Continue reading)

Permalink | Reply | 0 comments |
headers
Henry Minsky | 3 Jan 21:38
Picon

For Review: Change 20090103-hqm-t Summary: make swf9 hyperlinks be enabled when 'clickable' is asserted

This is a proposed fix for the missing hyperlink functionality. I  
thought it would make sense to tie the
hyperlink function to the 'clickable' attribute, since that happens to  
set mouseEnabled in swf9 anyway.

This has the benefit of disabling the hyperlinks if you set  
clickable=false on a text field.

Change 20090103-hqm-t by hqm <at> badtzmaru.home on 2009-01-03 15:32:03 EST
     in /Users/hqm/openlaszlo/trunk4
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary:  make swf9 hyperlinks be enabled when 'clickable' is asserted

New Features:

Bugs Fixed: LPP-7551

Technical Reviewer: andre
QA Reviewer: max
Doc Reviewer: (pending)

Documentation:

Release Notes:

In order to use hyperlinks, the 'clickable' attribute must be enabled
on a text field.  The HTML used for a hyperlink is created by using the
cross-platform LzText.makeTextLink(TEXT, VALUE) method. The "ontextlink"
event will be sent with VALUE when the link is clicked.
(Continue reading)

Permalink | Reply | 3 comments |
headers
Henry Minsky | 3 Jan 21:40
Picon

Re: For Review: Change 20090103-hqm-t Summary: make swf9 hyperlinks be enabled when 'clickable' is asserted

If we go with this approach, I guess I'll need to add code to the swf8
and DHTML LzTextSprite to disable
text link event handling on hyperlinks when clickable is set to false.

On Sat, Jan 3, 2009 at 3:38 PM, Henry Minsky <henry.minsky <at> gmail.com> wrote:
> This is a proposed fix for the missing hyperlink functionality. I thought it
> would make sense to tie the
> hyperlink function to the 'clickable' attribute, since that happens to set
> mouseEnabled in swf9 anyway.
>
> This has the benefit of disabling the hyperlinks if you set clickable=false
> on a text field.
>
>
> Change 20090103-hqm-t by hqm <at> badtzmaru.home on 2009-01-03 15:32:03 EST
>    in /Users/hqm/openlaszlo/trunk4
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary:  make swf9 hyperlinks be enabled when 'clickable' is asserted
>
> New Features:
>
> Bugs Fixed: LPP-7551
>
> Technical Reviewer: andre
> QA Reviewer: max
> Doc Reviewer: (pending)
>
> Documentation:
>
(Continue reading)

Permalink | Reply | 2 comments |
headers
André Bargull | 3 Jan 23:12

Re: For Review: Change 20090103-hqm-t Summary: make swf9 hyperlinks be enabled when 'clickable' is asserted

Your testcase doesn't work in swf8, in fact you must not set clickable 
to `true` or textlinks won't work for swf8. And there is another 
disadvantage if you tie textlinks to clickable attribute: you can no 
longer distinguish textlinks from normal text, because a handpointer is 
now used for the whole text object.

On 1/3/2009 9:40 PM, Henry Minsky wrote:
> If we go with this approach, I guess I'll need to add code to the swf8
> and DHTML LzTextSprite to disable
> text link event handling on hyperlinks when clickable is set to false.
> 
> 
> On Sat, Jan 3, 2009 at 3:38 PM, Henry Minsky <henry.minsky <at> gmail.com> wrote:
>> This is a proposed fix for the missing hyperlink functionality. I thought it
>> would make sense to tie the
>> hyperlink function to the 'clickable' attribute, since that happens to set
>> mouseEnabled in swf9 anyway.
>>
>> This has the benefit of disabling the hyperlinks if you set clickable=false
>> on a text field.
>>
>>
>> Change 20090103-hqm-t by hqm <at> badtzmaru.home on 2009-01-03 15:32:03 EST
>>    in /Users/hqm/openlaszlo/trunk4
>>    for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary:  make swf9 hyperlinks be enabled when 'clickable' is asserted
>>
>> New Features:
>>
(Continue reading)

Permalink | Reply | 1 comment |
headers
Henry Minsky | 3 Jan 23:31
Favicon

Re: For Review: Change 20090103-hqm-t Summary: make swf9 hyperlinks be enabled when 'clickable' is asserted

Yeah,  the hand cursor ought to only show up over the hyperlinks.

For the LINK event, I think it is OK to install the TextEvent.LINK
handler by default on all text sprites, it doesn't
really cost anything. That just leaves the question about what to do
about mouseEnabled.

Maybe we need to say that you need to have selectable=true in order to
be able to click on hyperlinks?
Because in swf9, if you have selectable=false,
LzTextSprite.setSelectable() currently forces mouseEnabled = false on
the TextField, which disables the hyperlinks.

On Sat, Jan 3, 2009 at 5:12 PM, André Bargull <andre.bargull <at> udo.edu> wrote:
> Your testcase doesn't work in swf8, in fact you must not set clickable to
> `true` or textlinks won't work for swf8. And there is another disadvantage
> if you tie textlinks to clickable attribute: you can no longer distinguish
> textlinks from normal text, because a handpointer is now used for the whole
> text object.
>
>
> On 1/3/2009 9:40 PM, Henry Minsky wrote:
>>
>> If we go with this approach, I guess I'll need to add code to the swf8
>> and DHTML LzTextSprite to disable
>> text link event handling on hyperlinks when clickable is set to false.
>>
>>
>> On Sat, Jan 3, 2009 at 3:38 PM, Henry Minsky <henry.minsky <at> gmail.com>
>> wrote:
(Continue reading)

Permalink | Reply | 0 comments |

Gmane