For Review: Change 20081130-hqm-7 Summary: document LzView.focusable as read/write

Change 20081130-hqm-7 by hqm <at> badtzmaru.home on 2008-11-30 21:03:47 EST
     in /Users/hqm/openlaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary:  document LzView.focusable as read/write

New Features:

Bugs Fixed: LPP-6022

Technical Reviewer: max
QA Reviewer: mamye
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

Tests:

should say read/write in docs

Files:
M      WEB-INF/lps/lfc/views/LaszloView.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081130-hqm-7.tar

Re: Replication example

Thanks!  :)

P T Withington wrote:
> [Adding laszlo-dev]
>
> I think you should start with the simplest possible example, which is 
> explicit replication, without even having a dataset.  Then add a local 
> dataset, and if possible, a remote dataset.  We would really like 
> implicit replication to go away, so I would not even give an example 
> of that.  Please cc Lou on any discussions, so he is aware of what 
> L-in-10 has and can make sure the main documentation doesn't conflict.
>
> Here is a (pretty simple) explicit replication example without a dataset:
>
>    <attribute name="sauces" value="['chocolate', 'lavender', 'olive', 
> 'orange', 'plum', 'snow', 'thistle', 'violet']" />
>    <combobox name="sauce" editable="false">
>      <replicator nodes="$once{canvas.sauces}">
>        <textlistitem text="${this.presentValue()}" type="color" />
>      </replicator>
>    </combobox>
>
> But, maybe you can come up with something even simpler, no need to 
> actually drag in combobox...
>
> On 2008-11-26, at 23:30EST, J Crowley wrote:
>
>> So, I'm trying to come up with a replication example that's simple 
>> enough to fit in with the other L-in-10 stuff yet demonstrates the 
>> two primary ways of doing data replication (explicit and implicit).  

Re: For Review: Change 20081128-Philip-2 Summary: Get lzproject working in swf9

Approved!

Philip Romanik wrote:
> Change 20081128-Philip-2 by Philip <at> Philip-DC <mailto:Philip <at> Philip-DC> 
> on 2008-11-28 12:54:55 EST
>     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
>     for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Get lzproject working in swf9
>
> New Features:
>
> Bugs Fixed: LPP-7256
>
> Technical Reviewer: jcrowley
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> Most issues had to do with incorrect method arguments.    
>
> Tests:
> lzproject works the same in swf8/swf9/dhtml.
>
> Files:
> M      demos/lzproject/lzx/lzproject/modules/BackendService.lzx

Re: Replication example

So how about something like:

<canvas>
  <dataset name="dset">
    <cars>
      <car>Corvette</car>
      <car>Miata</car>
      <car>Lotus 7</car>
      <car>Lumina</car>
      <car>Carmen Ghia</car>
      <car>Corolla</car>
      <car>Prius</car>
      <car>Delorean</car>
    </cars>
  </dataset>

  <dataset name="remotedset" src="phonebook.xml"/>

  <view width="140" height="160" bgcolor="0x666699">
    <simplelayout axis="y"/>
    <attribute name="sauces" value="['chocolate', 'lavender', 'olive', 
'orange', 'plum', 'snow', 'thistle', 'violet']" />
    <text fgcolor="white" fontstyle="bold" text="Without Dataset"/>

    <replicator nodes="$once{parent.sauces}">
      <text fgcolor="white" text="${this.presentValue()}"/>
    </replicator>
  </view>

  <view width="140" height="160" y="170" bgcolor="0x666699">

For Review: 20081201-laszlo-0 Summary: Datapointer.deleteNode() should check previous sibling if next sibling doesn't exist, Databinding example 23 exhibits odd behavior

Change 20081201-laszlo-0 by laszlo <at> T43-L3XEXMW on 2008-12-01 05:36:10 EST
    in /home/laszlo/src/svn/openlaszlo/trunk-grayfox
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Datapointer.deleteNode() should check previous sibling if next 
sibling doesn't exist
    Databinding example 23 exhibits odd behavior

New Features:

Bugs Fixed: LPP-7416 - Datapointer.deleteNode() should check previous 
sibling if next sibling doesn't exist
            LPP-7220 - Databinding example 23 exhibits odd behavior

Technical Reviewer: ptw
QA Reviewer: andre.bargull <at> udo.edu
Doc Reviewer: lou <at> louiorio.com

Documentation:

Release Notes:

Details: LPP-7416 - Applied Andre's fix suggestion.
         LPP-7220 - Changed rerunxpath to false to get the
            example to function appropriately (with LPP-7416
            fixed).

Tests: Run databinding-$23.lzx.  Click "Next" until you
    reach the end of the list.  Click "Delete".  You
    should now move to the previous node when the current

Re: For Review: 20081201-laszlo-0 Summary: Datapointer.deleteNode() should check previous sibling if next sibling doesn't exist, Databinding example 23 exhibits odd behavior

The example (and its documentation) needs to be changed, or else it'll 
suggest a bit nonsense to the reader:
In fact, the "setXPath(..)"-call can be removed completely, you just 
need to set the rerunxpath-attribute to `false`. And then you also need 
to adjust this sentence from the doc:
> The solution is to reset the datapath's XPath to the proper value by calling the setXPath() method: 

Otherwise approved!

On 12/1/2008 11:57 AM, J Crowley wrote:
> Change 20081201-laszlo-0 by laszlo <at> T43-L3XEXMW on 2008-12-01 05:36:10 EST
>    in /home/laszlo/src/svn/openlaszlo/trunk-grayfox
>    for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Datapointer.deleteNode() should check previous sibling if next 
> sibling doesn't exist
>    Databinding example 23 exhibits odd behavior
> 
> New Features:
> 
> Bugs Fixed: LPP-7416 - Datapointer.deleteNode() should check previous 
> sibling if next sibling doesn't exist
>            LPP-7220 - Databinding example 23 exhibits odd behavior
> 
> Technical Reviewer: ptw
> QA Reviewer: andre.bargull <at> udo.edu
> Doc Reviewer: lou <at> louiorio.com
> 
> Documentation:
> 

UPDATE: For Review: Change 20081128-bargull-Rhp Summary: UPDATE: schema build warnings

Change 20081128-bargull-Rhp by bargull <at> dell--p4--2-53 on 2008-11-28 22:53:41
in /home/Admin/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: UPDATE: schema build warnings

New Features:

Bugs Fixed: LPP-7408 (partial)

Technical Reviewer: ptw
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
Class: Changed profile annotation, so it doesn't use a local (actually 
global) variable to shorten the assignment expression.
LzNode: added @type
LzFont: mark internal properties as @access private
LzSelectionManager: rename argument to match java-doc
LzMakeLoadSprite: rename argument (also a bugfix..)
LzBrowserKernel: move doc into code (not really important here, it's a 
kernel class)
LzDataset: rename arg in java-doc to match implementation
LzReplicationManager: rename argument to match java-doc

Re: UPDATE: For Review: Change 20081128-bargull-Rhp Summary: UPDATE: schema build warnings

Approved.

FWIW, the way to introduce temporary vars at the top level is to put  
them in a function:

  if ($profile) {
    (function () {
      var ii = Instance.prototype.$lzsc$initialize;
      ii._dbg_name = ii.name = 'Instance';
    })();
  }

But I seem to forget that more often than not.

On 2008-12-01, at 09:56EST, André Bargull wrote:

> Change 20081128-bargull-Rhp by bargull <at> dell--p4--2-53 on 2008-11-28  
> 22:53:41
> in /home/Admin/src/svn/openlaszlo/trunk
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: UPDATE: schema build warnings
>
> New Features:
>
> Bugs Fixed: LPP-7408 (partial)
>
> Technical Reviewer: ptw
> QA Reviewer: (pending)
> Doc Reviewer: (pending)

For Review: Change 20081201-bargull-znZ Summary: add new style setter for "contextmenu"

Change 20081201-bargull-znZ by bargull <at> dell--p4--2-53 on 2008-12-01 15:57:19
in /home/Admin/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: add new style setter for "contextmenu"

New Features:

Bugs Fixed: LPP-7418, LPP-7408 (partial)

Technical Reviewer: hminsky
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
SchemaBuilder:
- introduce some new types (or the SchemaBuilder will fail to generate 
the schema)
LzDatapointer:
- add @type for context (the doc explains that this field points to a 
clonemanager, but there are actually more possibilities, I've enumerated 
them in a @devnote)
LaszloView:
- add @type for contextmenu
- add "contextmenu"-setter
- deprecate "setContextMenu(..)"

Re: For Review: Change 20081201-bargull-znZ Summary: add new style setter for "contextmenu"