Re: For Review: Change 20080531-bargull-HUV Summary: Revert typing for LzNode#setSelected(..)
André Bargull <a.bargull <at> intensis.de>
2008-06-01 09:42:49 GMT
> Are you running the swf9 compiler with warnings enabled?
No, I didn't do that yet.
Warnings was wrong in this context, there are a couple of compiler
errors, because components override "LzNode#setSelected(Boolean)"
without declaring the right argument type. That's way I've changed
"LzNode#setSelected(Boolean)" back to "LzNode#setSelected(*)".
I've just created LPP-6080, so that the compiler will take this part.
On 6/1/2008 4:29 AM, Henry Minsky wrote:
> Hey Andre,
>
> Are you running the swf9 compiler with warnings enabled?
>
> I haven't tried that for a while, since there were so many initially
> that it was overwhelming.
>
> But I guess all those declarations you've been adding will help a lot
> to get to the point
> in reducing the flood of warnings.
>
>
> On Sat, May 31, 2008 at 11:22 AM, André Bargull <a.bargull <at> intensis.de
> <mailto:a.bargull <at> intensis.de>> wrote:
>
> Change 20080531-bargull-HUV by bargull <at> dell--p4--2-53 on
> 2008-05-31 17:07:33
> in /home/Admin/src/svn/openlaszlo/trunk
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Revert typing for LzNode#setSelected(..)
>
> New Features:
>
> Bugs Fixed: LPP-6076
>
> Technical Reviewer: ptw
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> Components give way too much warnings with typing information
> enabled for "LzNode#setSelected(..)".
> So back out for now.
>
> Tests:
> swf9 still compiles
>
> Files:
> M WEB-INF/lps/lfc/core/LzNode.lzs
> M WEB-INF/lps/lfc/data/LzDatapath.lzs
>
> Changeset:
> http://svn.openlaszlo.org/openlaszlo/patches/20080531-bargull-HUV.tar
>
>
>
>
>
>
> --
> Henry Minsky
> Software Architect
> hminsky <at> laszlosystems.com <mailto:hminsky <at> laszlosystems.com>
>