List to collaborate on OpenLaszlo platform development, submit source code and report bugs

The current lossage

Spot the bug:

   /* -*- file: base/basecomponent.lzx#110.11 -*- */
  56    override function construct (parent, args) {
  57    with (this) {
  58    super.construct(parent, args);
  59    var p = this.immediateparent;
  60    while (p != canvas) {
  61    if (p instanceof lz.basecomponent) {
  62    this._parentcomponent = p;

Er, there is a `parent` property on `this` that is shadowing the  
argument.  Who is inserting that `with (this)`?

headers

P T Withington | 1 Apr 02:52

Re: The current lossage

So, if I fix the swf9 compiler (by telling it _not_ to emit implicit  
this if it is not going to rename the locals) I get a bunch of new  
interesting errors:

Executing compiler: (cd /tmp/lzswf9/lzgen38150; /usr/local/flex_sdk_3/ 
bin/mxmlc -compiler.show-actionscript-warnings=false -compiler.source- 
path+=/tmp/lzswf9/lzgen38150 -debug=true -output /tmp/lzswf9/ 
lzgen38150/app.swf -default-size 800 600 -library-path+=/Users/ptw/ 
OpenLaszlo/ringding-clean/lps/includes/lfc/LFC9.swc /tmp/lzswf9/ 
lzgen38150/LzApplication.as)
compiler output:
Loading configuration file /usr/local/flex_sdk_3/frameworks/flex- 
config.xml

ERRORS:
Compiler error: at 262 [/tmp/lzswf9/lzgen38150/$lzc 
$class_basefocusview.as: 194]: Error: Access of possibly undefined  
property focuswithkey through a reference with static type Class.

this.setActive(LzFocus.focuswithkey);
                        ^

Compiler error: at 239 [/tmp/lzswf9/lzgen38150/$lzc 
$class_basebutton.as: 143]: Error: Incorrect number of arguments.   
Expected 3.

setTint(this, s.basecolor)
                  ^

Compiler error: at 201 [/tmp/lzswf9/lzgen38150/$lzc

(Continue reading)

headers

P T Withington | 1 Apr 02:56

For Review: Change 20080331-ptw-f Summary: Don't need explicit with this in swf9

Change 20080331-ptw-f by ptw <at> dueling-banjos.local on 2008-03-31  
20:53:05 EDT
     in /Users/ptw/OpenLaszlo/ringding-clean
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Don't need explicit with this in swf9

Technical Reviewer: dda (pending)
QA Reviewer: hqm (pending)

Details:
     JavascriptGenerator: If the swf9 compiler is not going to rename  
locals, it had better
     not shadow them with a `with (this)`.  AS3 methods already have
     implicit this.

Files:
M      WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080331-ptw-f.tar

headers

Philip Romanik | 1 Apr 03:00

Re: some other goodies when I try to compile a checkbox

FYI, I've been adding an optional argument to the destroy methods in the data objects to get around this issue.

Compiler error: at [/tmp/lzswf9/lzgen55150/$lzc$ class_basecomponent.as:
230]: Error: Incompatible override.

override function destroy () {
^

This is because we're not matching the destroy() method signature because
of the secret "recursiveCall" arg that LzNode.destroy uses

function destroy( recursiveCall = null){

That's a source change right?

Yes, but I don't really want to change all the classes in the LFC and in the component libraries (and random user apps) that define a destroy() method to give them an optional argument.

I wonder if we could make it so that destroy() method on LzNode takes no args, and then have
some other internal "destroy" method that takes the extra arg.

headers

Henry Minsky | 1 Apr 03:12

Re: The current lossage

I'll see if I can either fix this or define dummy classes or methods to get past them for now.

On undefined, P T Withington <ptw <at> pobox.com> wrote:

So, if I fix the swf9 compiler (by telling it _not_ to emit implicit
this if it is not going to rename the locals) I get a bunch of new
interesting errors:

Executing compiler: (cd /tmp/lzswf9/lzgen38150; /usr/local/flex_sdk_3/
bin/mxmlc -compiler.show-actionscript-warnings=false -compiler.source-
path+=/tmp/lzswf9/lzgen38150 -debug=true -output /tmp/lzswf9/
lzgen38150/app.swf -default-size 800 600 -library-path+=/Users/ptw/
OpenLaszlo/ringding-clean/lps/includes/lfc/LFC9.swc /tmp/lzswf9/
lzgen38150/LzApplication.as)
compiler output:
Loading configuration file /usr/local/flex_sdk_3/frameworks/flex-
config.xml

ERRORS:
Compiler error: at 262 [/tmp/lzswf9/lzgen38150/$lzc
$class_basefocusview.as: 194]: Error: Access of possibly undefined
property focuswithkey through a reference with static type Class.

this.setActive(LzFocus.focuswithkey);
^

Compiler error: at 239 [/tmp/lzswf9/lzgen38150/$lzc
$class_basebutton.as: 143]: Error: Incorrect number of arguments.
Expected 3.

setTint(this, s.basecolor)
^

Compiler error: at 201 [/tmp/lzswf9/lzgen38150/$lzc
$class_baseformitem.as: 118]: Error: Call to a possibly undefined
method xmlEscape through a reference with static type Class.

return LzBrowser.xmlEscape(this.submitname) + '="' +
LzBrowser.xmlEscape(val) + '"'
^

Compiler error: at 201 [/tmp/lzswf9/lzgen38150/$lzc
$class_baseformitem.as: 118]: Error: Call to a possibly undefined
method xmlEscape through a reference with static type Class.

return LzBrowser.xmlEscape(this.submitname) + '="' +
LzBrowser.xmlEscape(val) + '"'
^

On 2008-03-31, at 20:15 EDT, P T Withington wrote:
> Spot the bug:
>
> /* -*- file: base/basecomponent.lzx#110.11 -*- */
> 56 override function construct (parent, args) {
> 57 with (this) {
> 58 super.construct(parent, args);
> 59 var p = this.immediateparent;
> 60 while (p != canvas) {
> 61 if (p instanceof lz.basecomponent) {
> 62 this._parentcomponent = p;
>
> Er, there is a `parent` property on `this` that is shadowing the
> argument. Who is inserting that `with (this)`?
>
>

--
Henry Minsky
Software Architect
hminsky <at> laszlosystems.com

headers

Henry Minsky | 1 Apr 03:13

Re: For Review: Change 20080331-ptw-f Summary: Don't need explicit with this in swf9

approved

On undefined, P T Withington <ptw <at> pobox.com> wrote:

Change 20080331-ptw-f by ptw <at> dueling-banjos.local on 2008-03-31
20:53:05 EDT
in /Users/ptw/OpenLaszlo/ringding-clean
for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Don't need explicit with this in swf9

Technical Reviewer: dda (pending)
QA Reviewer: hqm (pending)

Details:
JavascriptGenerator: If the swf9 compiler is not going to rename
locals, it had better
not shadow them with a `with (this)`. AS3 methods already have
implicit this.

Files:
M WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080331-ptw-f.tar

--
Henry Minsky
Software Architect
hminsky <at> laszlosystems.com

headers

P T Withington | 1 Apr 03:18

Re: some other goodies when I try to compile a checkbox

We eliminated the recursiveCall argument altogether.  It was  
obsolete.  So you shouldn't need the optional argument if you are at  
ToT.

On 2008-03-31, at 21:00 EDT, Philip Romanik wrote:
> FYI, I've been adding an optional argument to the destroy methods in  
> the data objects to get around this issue.
>
>>
>>
>> Compiler error: at [/tmp/lzswf9/lzgen55150/$lzc$<http://class_basecomponent.as 
>> >class_basecomponent.as:
>> 230]: Error: Incompatible override.
>>
>> override function destroy () {
>>                 ^
>>
>> This is because we're not matching the destroy() method signature  
>> because
>> of  the secret "recursiveCall" arg that LzNode.destroy uses
>>
>> function destroy( recursiveCall = null){
>>
>> That's a source change right?
>>
>>
>> Yes, but I don't really want to change all the classes in the LFC  
>> and in the component libraries (and random user apps) that define  
>> a  destroy()  method to give them  an optional argument.
>>
>> I wonder if we could make it so that destroy()  method on LzNode  
>> takes no args, and then have
>> some other internal "destroy" method that takes the extra arg.
>>

headers

P T Withington | 1 Apr 03:19

Re: The current lossage

What I don't get is why the `with (this)` masked those errors?

On 2008-03-31, at 21:12 EDT, Henry Minsky wrote:
> I'll see if I can either fix this or define dummy classes or methods  
> to get
> past them for now.
>
>
> On undefined, P T Withington <ptw <at> pobox.com> wrote:
>
>> So, if I fix the swf9 compiler (by telling it _not_ to emit implicit
>> this if it is not going to rename the locals) I get a bunch of new
>> interesting errors:
>>
>> Executing compiler: (cd /tmp/lzswf9/lzgen38150; /usr/local/ 
>> flex_sdk_3/
>> bin/mxmlc -compiler.show-actionscript-warnings=false - 
>> compiler.source-
>> path+=/tmp/lzswf9/lzgen38150 -debug=true -output /tmp/lzswf9/
>> lzgen38150/app.swf -default-size 800 600 -library-path+=/Users/ptw/
>> OpenLaszlo/ringding-clean/lps/includes/lfc/LFC9.swc /tmp/lzswf9/
>> lzgen38150/LzApplication.as)
>> compiler output:
>> Loading configuration file /usr/local/flex_sdk_3/frameworks/flex-
>> config.xml
>>
>> ERRORS:
>> Compiler error: at 262 [/tmp/lzswf9/lzgen38150/$lzc
>> $class_basefocusview.as: 194]: Error: Access of possibly undefined
>> property focuswithkey through a reference with static type Class.
>>
>> this.setActive(LzFocus.focuswithkey);
>>                       ^
>>
>> Compiler error: at 239 [/tmp/lzswf9/lzgen38150/$lzc
>> $class_basebutton.as: 143]: Error: Incorrect number of arguments.
>> Expected 3.
>>
>> setTint(this, s.basecolor)
>>                 ^
>>
>> Compiler error: at 201 [/tmp/lzswf9/lzgen38150/$lzc
>> $class_baseformitem.as: 118]: Error: Call to a possibly undefined
>> method xmlEscape through a reference with static type Class.
>>
>> return LzBrowser.xmlEscape(this.submitname) + '="' +
>> LzBrowser.xmlEscape(val) + '"'
>>                 ^
>>
>> Compiler error: at 201 [/tmp/lzswf9/lzgen38150/$lzc
>> $class_baseformitem.as: 118]: Error: Call to a possibly undefined
>> method xmlEscape through a reference with static type Class.
>>
>> return LzBrowser.xmlEscape(this.submitname) + '="' +
>> LzBrowser.xmlEscape(val) + '"'
>>                                                               ^
>>
>> On 2008-03-31, at 20:15 EDT, P T Withington wrote:
>>> Spot the bug:
>>>
>>> /* -*- file: base/basecomponent.lzx#110.11 -*- */
>>> 56    override function construct (parent, args) {
>>> 57    with (this) {
>>> 58    super.construct(parent, args);
>>> 59    var p = this.immediateparent;
>>> 60    while (p != canvas) {
>>> 61    if (p instanceof lz.basecomponent) {
>>> 62    this._parentcomponent = p;
>>>
>>> Er, there is a `parent` property on `this` that is shadowing the
>>> argument.  Who is inserting that `with (this)`?
>>>
>>>
>>
>>
>
>
> -- 
> Henry Minsky
> Software Architect
> hminsky <at> laszlosystems.com

headers

Henry Minsky | 1 Apr 03:33

Re: The current lossage

I'm going to take this opportunity to try and make LzFocus.lzs compile and run in swf9.

On undefined, P T Withington <ptw <at> pobox.com> wrote:

So, if I fix the swf9 compiler (by telling it _not_ to emit implicit
this if it is not going to rename the locals) I get a bunch of new
interesting errors:

Executing compiler: (cd /tmp/lzswf9/lzgen38150; /usr/local/flex_sdk_3/
bin/mxmlc -compiler.show-actionscript-warnings=false -compiler.source-
path+=/tmp/lzswf9/lzgen38150 -debug=true -output /tmp/lzswf9/
lzgen38150/app.swf -default-size 800 600 -library-path+=/Users/ptw/
OpenLaszlo/ringding-clean/lps/includes/lfc/LFC9.swc /tmp/lzswf9/
lzgen38150/LzApplication.as)
compiler output:
Loading configuration file /usr/local/flex_sdk_3/frameworks/flex-
config.xml

ERRORS:
Compiler error: at 262 [/tmp/lzswf9/lzgen38150/$lzc
$class_basefocusview.as: 194]: Error: Access of possibly undefined
property focuswithkey through a reference with static type Class.

this.setActive(LzFocus.focuswithkey);
^

Compiler error: at 239 [/tmp/lzswf9/lzgen38150/$lzc
$class_basebutton.as: 143]: Error: Incorrect number of arguments.
Expected 3.

setTint(this, s.basecolor)
^

Compiler error: at 201 [/tmp/lzswf9/lzgen38150/$lzc
$class_baseformitem.as: 118]: Error: Call to a possibly undefined
method xmlEscape through a reference with static type Class.

return LzBrowser.xmlEscape(this.submitname) + '="' +
LzBrowser.xmlEscape(val) + '"'
^

Compiler error: at 201 [/tmp/lzswf9/lzgen38150/$lzc
$class_baseformitem.as: 118]: Error: Call to a possibly undefined
method xmlEscape through a reference with static type Class.

return LzBrowser.xmlEscape(this.submitname) + '="' +
LzBrowser.xmlEscape(val) + '"'
^

On 2008-03-31, at 20:15 EDT, P T Withington wrote:
> Spot the bug:
>
> /* -*- file: base/basecomponent.lzx#110.11 -*- */
> 56 override function construct (parent, args) {
> 57 with (this) {
> 58 super.construct(parent, args);
> 59 var p = this.immediateparent;
> 60 while (p != canvas) {
> 61 if (p instanceof lz.basecomponent) {
> 62 this._parentcomponent = p;
>
> Er, there is a `parent` property on `this` that is shadowing the
> argument. Who is inserting that `with (this)`?
>
>

--
Henry Minsky
Software Architect
hminsky <at> laszlosystems.com

headers

Henry Minsky | 1 Apr 03:32

Re: The current lossage

The flex compiler stops reporting errors after 50 are seen, but maybe it aborts early in other cases as well if it decides
things are too screwed up ?

On undefined, P T Withington <ptw <at> pobox.com> wrote:

What I don't get is why the `with (this)` masked those errors?

On 2008-03-31, at 21:12 EDT, Henry Minsky wrote:
> I'll see if I can either fix this or define dummy classes or methods
> to get
> past them for now.
>
>
> On undefined, P T Withington <ptw <at> pobox.com> wrote:
>
>> So, if I fix the swf9 compiler (by telling it _not_ to emit implicit
>> this if it is not going to rename the locals) I get a bunch of new
>> interesting errors:
>>
>> Executing compiler: (cd /tmp/lzswf9/lzgen38150; /usr/local/
>> flex_sdk_3/
>> bin/mxmlc -compiler.show-actionscript-warnings=false -
>> compiler.source-
>> path+=/tmp/lzswf9/lzgen38150 -debug=true -output /tmp/lzswf9/
>> lzgen38150/app.swf -default-size 800 600 -library-path+=/Users/ptw/
>> OpenLaszlo/ringding-clean/lps/includes/lfc/LFC9.swc /tmp/lzswf9/
>> lzgen38150/LzApplication.as)
>> compiler output:
>> Loading configuration file /usr/local/flex_sdk_3/frameworks/flex-
>> config.xml
>>
>> ERRORS:
>> Compiler error: at 262 [/tmp/lzswf9/lzgen38150/$lzc
>> $class_basefocusview.as: 194]: Error: Access of possibly undefined
>> property focuswithkey through a reference with static type Class.
>>
>> this.setActive(LzFocus.focuswithkey);
>> ^
>>
>> Compiler error: at 239 [/tmp/lzswf9/lzgen38150/$lzc
>> $class_basebutton.as: 143]: Error: Incorrect number of arguments.
>> Expected 3.
>>
>> setTint(this, s.basecolor)
>> ^
>>
>> Compiler error: at 201 [/tmp/lzswf9/lzgen38150/$lzc
>> $class_baseformitem.as: 118]: Error: Call to a possibly undefined
>> method xmlEscape through a reference with static type Class.
>>
>> return LzBrowser.xmlEscape(this.submitname) + '="' +
>> LzBrowser.xmlEscape(val) + '"'
>> ^
>>
>> Compiler error: at 201 [/tmp/lzswf9/lzgen38150/$lzc
>> $class_baseformitem.as: 118]: Error: Call to a possibly undefined
>> method xmlEscape through a reference with static type Class.
>>
>> return LzBrowser.xmlEscape(this.submitname) + '="' +
>> LzBrowser.xmlEscape(val) + '"'
>> ^
>>
>> On 2008-03-31, at 20:15 EDT, P T Withington wrote:
>>> Spot the bug:
>>>
>>> /* -*- file: base/basecomponent.lzx#110.11 -*- */
>>> 56 override function construct (parent, args) {
>>> 57 with (this) {
>>> 58 super.construct(parent, args);
>>> 59 var p = this.immediateparent;
>>> 60 while (p != canvas) {
>>> 61 if (p instanceof lz.basecomponent) {
>>> 62 this._parentcomponent = p;
>>>
>>> Er, there is a `parent` property on `this` that is shadowing the
>>> argument. Who is inserting that `with (this)`?
>>>
>>>
>>
>>
>
>
> --
> Henry Minsky
> Software Architect
> hminsky <at> laszlosystems.com

--
Henry Minsky
Software Architect
hminsky <at> laszlosystems.com

Mon	Tue	Wed	Thu	Fri	Sat	Sun

	1	2	3	4	5	6
7	8	9	10	11	12	13
14	15	16	17	18	19	20
21	22	23	24	25	26	27
28	29	30

12	February 2012
16	January 2012
77	December 2011
47	November 2011
80	October 2011
80	September 2011
67	August 2011
86	July 2011
75	June 2011
89	May 2011
206	April 2011
223	March 2011
285	February 2011
416	January 2011
215	December 2010
165	November 2010
142	October 2010
317	September 2010
416	August 2010
356	July 2010
392	June 2010
406	May 2010
285	April 2010
309	March 2010
238	February 2010
312	January 2010
228	December 2009
211	November 2009
326	October 2009
425	September 2009
344	August 2009
98	July 2009
303	June 2009
316	May 2009
376	April 2009
593	March 2009
467	February 2009
626	January 2009
480	December 2008
384	November 2008
493	October 2008
562	September 2008
376	August 2008
615	July 2008
740	June 2008
651	May 2008
668	April 2008
526	March 2008
422	February 2008
391	January 2008
300	December 2007
392	November 2007
498	October 2007
426	September 2007
364	August 2007
230	July 2007
378	June 2007
458	May 2007
276	April 2007
732	March 2007
439	February 2007
698	January 2007
634	December 2006
650	November 2006
552	October 2006
633	September 2006
436	August 2006
347	July 2006
571	June 2006
423	May 2006
266	April 2006
247	March 2006
139	February 2006
294	January 2006
309	December 2005
250	November 2005
76	October 2005
132	September 2005
95	August 2005
57	July 2005
180	June 2005
114	May 2005
61	April 2005
156	March 2005
196	February 2005
206	January 2005
67	December 2004
105	November 2004
21	October 2004