Max Carlson | 1 Jan 06:17
Favicon

For Review: Change 20071231-maxcarlson-9 Summary: Fix resizing in Safari

Change 20071231-maxcarlson-9 by maxcarlson <at> Roboto.lan on 2007-12-31  
20:24:53 PST
     in /Users/maxcarlson/openlaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix resizing in Safari

New Features:

Bugs Fixed: LPP-5309 - Window Resize with Safari

Technical Reviewer: ptw
QA Reviewer: promanik
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: LzSprite.js - Add document_size_use_offsetheight and set to  
true in Safari.

LzScreenKernel.js - Use offsetWidth/Height if  
document_size_use_offsetheight is true.  Clean up tests to use sc.

Tests: See LPP-5309.  Tested in Firefox and Safari 3 on OS X, IE 6 and  
7.

Files:
M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
(Continue reading)

Philip Romanik | 1 Jan 23:43
Favicon

Re: For Review: Change 20071231-maxcarlson-9 Summary: Fix resizing in Safari

Approved.

It continues to work fine in IE and FF. It doesn't work in Safari/PC (3.0.4) but there are lots of issues with the PC version. I can't try it on a Mac.


Change 20071231-maxcarlson-9 by maxcarlson <at> Roboto.lan on 2007-12-31
20:24:53 PST
     in /Users/maxcarlson/openlaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk
 
Summary: Fix resizing in Safari
 
New Features:
 
Bugs Fixed: LPP-5309 - Window Resize with Safari
 
Technical Reviewer: ptw
QA Reviewer: promanik
Doc Reviewer: (pending)
 
Documentation:
 
Release Notes:
 
Details: LzSprite.js - Add document_size_use_offsetheight and set to true in Safari.
 
LzScreenKernel.js - Use offsetWidth/Height if document_size_use_offsetheight is true.  Clean up tests to use sc.
 
 
Tests: See LPP-5309.  Tested in Firefox and Safari 3 on OS X, IE 6 and 7.
 
Files:
M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzScreenKernel.js
 
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071231-maxcarlson-9.tar
Benjamin Shine | 2 Jan 01:47
Favicon

For Review: Change 20080101-ben-w Summary: Fix misplaced comma in embedded examples

Change 20080101-ben-w by ben <at> slim.local on 2008-01-01 16:43:46 PST
     in /Users/ben/src/svn/openlaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix misplaced comma in embedded examples

New Features:

Bugs Fixed:

Technical Reviewer: (pending)
QA Reviewer: max (pending)
Doc Reviewer: (pending)

Documentation:

Max reported a bug due to a stray comma:
http://labs.openlaszlo.org/trunk-nightly/docs/developers/tutorials/ 
views-tutorial.html#

is failing now, due to a stray comma in the embedSWF calls, e.g.
           Lz.swfEmbed({url: 'programs/views-tutorial-$1.lzx? 
lzt=swf', id: 'd0e6065SWF', history: false, width: 500,
       height: 300,
       });

This change moves around where we generate commas in the canvas  
parameters when
generating a live example. It now looks like this:

  Lz.swfEmbed({url: 'programs/views-tutorial-$1.lzx?lzt=swf', id:  
'd0e6061SWF', history: false
, width: 500
, height: 300});

Release Notes:

Details:

Tests:
build the doc
inspect the source of tutorials/views-tutorial.html
note good comma-ness.

Files:
M      docs/src/xsl/common-html.xsl

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080101-ben- 
w.tar

Benjamin Shine | 2 Jan 03:30
Favicon

For Review: Change 20080101-ben-m Summary: Description of how to trace the reference page contents back to the source

Change 20080101-ben-m by ben <at> slim.local on 2008-01-01 18:26:23 PST
     in /Users/ben/src/svn/openlaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Description of how to trace the reference page contents back  
to the source

Documentation:
Febrile quest to trace important sections of the output reference *back*
to the xsl templates, js2doc intermediates, and docbook intermediates  
from
where they originate.

After the next build, this chapter will be available at:
http://labs.openlaszlo.org/trunk-nightly/docs/developers/doc- 
backwards.html

Files:
M      docs/src/developers/doc-backwards-xform.dbk

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080101-ben- 
m.tar

Max Carlson | 2 Jan 04:30
Favicon

Re: For Review: Change 20080101-ben-w Summary: Fix misplaced comma in embedded examples

Approved!

Benjamin Shine wrote:
> Change 20080101-ben-w by ben <at> slim.local on 2008-01-01 16:43:46 PST
>     in /Users/ben/src/svn/openlaszlo/trunk
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Fix misplaced comma in embedded examples
> 
> New Features:
> 
> Bugs Fixed:
> 
> Technical Reviewer: (pending)
> QA Reviewer: max (pending)
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Max reported a bug due to a stray comma:
> http://labs.openlaszlo.org/trunk-nightly/docs/developers/tutorials/views-tutorial.html# 
> 
> 
> is failing now, due to a stray comma in the embedSWF calls, e.g.
>           Lz.swfEmbed({url: 'programs/views-tutorial-$1.lzx?lzt=swf', 
> id: 'd0e6065SWF', history: false, width: 500,
>       height: 300,
>       });
> 
> 
> This change moves around where we generate commas in the canvas 
> parameters when
> generating a live example. It now looks like this:
> 
>  Lz.swfEmbed({url: 'programs/views-tutorial-$1.lzx?lzt=swf', id: 
> 'd0e6061SWF', history: false
> , width: 500
> , height: 300});
> 
> Release Notes:
> 
> Details:
> 
> 
> Tests:
> build the doc
> inspect the source of tutorials/views-tutorial.html
> note good comma-ness.
> 
> Files:
> M      docs/src/xsl/common-html.xsl
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080101-ben-w.tar

--

-- 
Regards,
Max Carlson
OpenLaszlo.org

Max Carlson | 2 Jan 08:33
Favicon

For Review: Change 20080101-maxcarlson-f Summary: UPDATED: Fix resizing in Safari

Change 20080101-maxcarlson-f by maxcarlson <at> Roboto.lan on 2008-01-01  
23:31:02 PST
     in /Users/maxcarlson/openlaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: UPDATED: Fix resizing in Safari

New Features:

Bugs Fixed: LPP-5309 - Window Resize with Safari

Technical Reviewer: ptw
QA Reviewer: promanik
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: LzSprite.js - Add document_size_use_offsetheight and set to  
true in
Safari and Opera.

LzScreenKernel.js - Use offsetWidth/Height if  
document_size_use_offsetheight is
true.  Clean up tests to use sc.

Tests: See LPP-5309.  Tested in Firefox, Opera and Safari 3 on OS X  
and Safari, IE 6 and 7 in windoze.

Files:
M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzScreenKernel.js

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080101-maxcarlson-f.tar

Henry Minsky | 2 Jan 18:35
Picon

How should we be dealing with dependency functions for swf9

In LaszloView, there are some explicit dependency functions declared, such as

prototype.setAttributeRelative.dependencies = function ( who,self, prop ,

How should we declare these? Can we set properties on swf9 methods like this?
I need to do some experiments to see what the flex compiler will accept..

--

-- 
Henry Minsky
Software Architect
hminsky <at> laszlosystems.com

Henry Minsky | 2 Jan 18:24
Picon

__LZlastmtrix, what is it doing on LzView.prototype?

In LaszloView.lzs, there's a declaration

LzView.prototype.__LZlastmtrix = [ 0,0,0,0,0,0,0,0,0,0,0 ];

This is declaring a class variable right? Is there any reason we
cannot  just change that to "static var ..." now?

--

-- 
Henry Minsky
Software Architect
hminsky <at> laszlosystems.com

Benjamin Shine | 2 Jan 23:06
Favicon

Re: Handling of the docs

Ono-san, I've prepared documentation that will help you create the  
Japanese developer's guide using the documentation toolchain.

This is the chapter where you should start:
http://labs.openlaszlo.org/trunk-nightly/docs/developers/doc- 
toolchain.html

These sections in particular:
http://labs.openlaszlo.org/trunk-nightly/docs/developers/doc- 
toolchain.html#docbook-is-central
http://labs.openlaszlo.org/trunk-nightly/docs/developers/doc- 
toolchain.html#developers-guide-toolchain
http://labs.openlaszlo.org/trunk-nightly/docs/developers/doc- 
toolchain.html#docbook-to-output
and
http://labs.openlaszlo.org/trunk-nightly/docs/developers/doc- 
toolchain.html#how-ant-drives
  See
http://labs.openlaszlo.org/trunk-nightly/docs/developers/doc- 
toolchain.html#directory-structure
for details of the directory structure

The basic approach I recommend for building the developer's guide in  
Japanese is to duplicate the (english) developers build using a  
parallel directory structure and parallel ant tasks.

Make a directory
docs/src/developers-jp
(It is very important that the developer's guide japanese directory  
is a sibling to the developer's guide english directory. Do not make  
docs/src/japanese/developers  -- trust me that this will cause  
problems.)
Copy
docs/src/developers/index.dbk
into
docs/src/developers-jp/index.dbk
and copy each of the chapters from docs/src/developers/*.dbk into  
docs/src/developers-jp/

In docs/src/build.xml, make a copy of these ant tasks, renaming them  
with .jp:
   developers --> developers.jp
   developers.resources --> developers.jp.resources
   developers.preprocess --> developers.jp.preprocess
   developers.html.generate --> developers.jp.html.generate
   developers.examples.preprocess --> developers.jp.examples.preprocess

Those ant tasks are parameterized with directories for docbook  
sources, intermediate files, and output files. Make your jp versions  
of these tasks refer to the developers-jp directories. For example,  
the ant property
developers.src.dir is set to $LPS_HOME/docs/src/developers, so you  
should make developers.jp.src.dir with the value $LPS_HOME/docs/src/ 
developers-jp.

Once you have taken all of these steps, you should be able to say  
"ant developers.jp" and create $LPS_HOME/docs/developers-jp/ 
index.html. Then you will be ready to put actual Japanese content  
into the docbook files in docs/src/developers-jp/

I hope this helps! Let us know how it goes!

-ben

On Dec 25, 2007, at 4:35 AM, keiji Ono wrote:

> Hi Ben,
>
> Now i am working in 4.0.7 devguide.
> I have known there were some differences between 4.0.7 and nightly  
> even
> content.
> It is hardly to catch up on every version to translate manually.
> Maybe it is good for me to work with your tools.
> I have never experienced with both xsl and docbook, but if  
> circumstances
> require,
> i will do them.
>
> Best regards,
> Keiji Ono
>
>
> Benjamin Shine wrote:
>
>>
>> Sorry, Ono-san, our servers were down last night. Please try those
>> URLs again, and let me know how far your current Japanese version is
>> from those.
>>
>> To communicate about the tools, it will help me to know how much, if
>> anything, you know about xsl, docbook, and ant. Do you have any
>> experience with any of those?
>>
>> Thanks!
>> -ben
>>
>> On Dec 20, 2007, at 12:04 AM, keiji Ono wrote:
>>
>>> Hi Ben,
>>>
>>> Thank you for your reply, Ben.
>>> It is good for us to be built the document by *tools*.
>>> In fact, the working of translation is hard and it contains some
>>> troubles by
>>> version up.
>>> We are always finding the OpenLaszlo documents quite impressive.
>>> They have described in detail and very useful, so we did not need
>>> another one.
>>> But, for getting more OpenLaszlo user in Japan, we have to meet  
>>> the need
>>> now.
>>>
>>> By the way, could you check the ULRs that you said to me?
>>> They were 404( not found ).
>>>
>>> Best regards,
>>> Keiji Ono
>>>
>>>
>>> Benjamin Shine wrote:
>>>
>>>>
>>>> Ono-san,
>>>>
>>>> I'd like to help make sure that the Japanese developer's guide is
>>>> based on the most recent, best English developer's guide. I'll  
>>>> be your
>>>> contact on this issue for now. We've been working a lot on the
>>>> developer guide and documentation tools for the last six months.  
>>>> We've
>>>> changed the workflow for developer's guide chapters a lot; now the
>>>> source is written in formal docbook files. Let me help you get  
>>>> up to
>>>> date using the new documentation tools, and work with you on the  
>>>> ant
>>>> files to make them build the developer's guide Japanese version
>>>> properly.
>>>>
>>>>
>>>> Unfortunately, these tools are not well-documented yet; I'll be
>>>> working on that in the next two weeks.
>>>>
>>>> To check where you are right now, please look at, for instance,
>>>> http://labs.openlaszlo.org/trunk-nightly/docs/developers/
>>>> architecture.html
>>>> and
>>>> http://labs.openlaszlo.org/trunk-nightly/docs/developers/  
>>>> compiler.html
>>>>
>>>> How different are these from what you're working on in Japanese?
>>>>
>>>> best,
>>>> ben
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Dec 17, 2007, at 12:59 AM, keiji Ono wrote:
>>>>
>>>>> Hi,
>>>>> I am working translation Dev's Guide to Japanese now.
>>>>> And i worry about how to know changing part of it in next version.
>>>>> Adding it, what is going on LZX Ref ?
>>>>> I would appreciate it if John took care of this issue.
>>>>>
>>>>> Regards,
>>>>> Keiji Ono
>>>>

Benjamin Shine | 2 Jan 23:30
Favicon

instructions for running performance analysis tests

To gather the data for performance analysis:
On each architecture of interest:
In $LPS_HOME/test/lfc/perf/build.xml edit these lines to indicate  
which browsers, branches, test suites, and runtimes you want to test:
     var suites = ["sprite", "functions", "viewperf",  
"imageperformance", "textperformance"];
     var runtimes = ["swf8", "dhtml"]; // swf7 numbers are boring,  
almost identical to swf8 numbers
     var browsers = ["Firefox"];
     var webapps = ["trunk"];

Then invoke ant to drive the tests... leave your machine alone for  
around 10 minutes while it runs the test.
$ cd $LPS_HOME/test/lfc/pref
$ ant -Dbranch=trunk hitallbrowsers storelog

This will result in a lot of log data being stored in svn -- the  
latest one (which I just stored) is here:
http://svn.openlaszlo.org/QA/performance/raw/7656-openlaszlo-trunk.txt
Each of those lines represents the results from one test (executed  
several times) in each suite. That's the raw data.

......

The tool for analyzing the raw data is in $LZ_TOOLS_ROOT/performance/ 
cruncher. It is a java program. To compile it, see instructions in
http://svn.openlaszlo.org/tools/trunk/performance/README.txt

cd $LZ_TOOLS_ROOT/performance/cruncher
ant -Dbuild.id=7656-openlaszlo-trunk go

performance/cruncher/build.xml fetches the raw performance logs for  
the specified build from subversion, runs the java performance  
analysis tool on it, and mails the results to a few interested  
parties. "ant go" is all you need.

The cruncher analyzes whatever data is in the checked-in raw log; it  
expects to analyze data recorded by test/lfc/perf/reporter.lzx via  
test/lfc/perf/reporter.jsp. The reporting itself does not need to  
happen on the same machine as the analysis.

Standard usage is from within the laszlosystems firewall (so we can  
send mail) and as a logged-in svn user with commit access to the  
repository. Then just
$ ant go

To run analysis on a particular build, pass in
-Dbuild.id=thebuildid for example
$ ant -Dbuild.id=2469-openlaszlo-branches-legals go

To prevent any interaction with subversion at all, pass in
-Dno.svn=true for example
$ ant -Dno.svn go

If you've already got the data locally and you just want to analyze  
it, with no network communication, do this
$ ant -v -Dno.svn=true -Dbuild.id=2469-openlaszlo-branches-legals  
analyze
$ more localanalysis/2469-openlaszlo-branches-legals-analysis.txt

Use the "clean" target to tidy up all local files. This is, of  
course, destructive.


Gmane