Philip Romanik | 1 Sep 01:16
Favicon

Re: For Review: Change 20070831-maxcarlson-S Summary: Use onload mechanism to hide splash

Approved!

Don't forget to update html-response_jp.xslt too.

>Change 20070831-maxcarlson-S by maxcarlson <at> plastik on 2007-08-31
>14:15:19 PDT
>      in /Users/maxcarlson/openlaszlo/legals-clean
>      for http://svn.openlaszlo.org/openlaszlo/branches/legals
>
>Summary: Use onload mechanism to hide splash
>
>New Features:
>
>Bugs Fixed: LPP-4578 - Add API to find out when an LZX app has been
>loaded
>
>Technical Reviewer: promanik
>QA Reviewer: jcrowley
>Doc Reviewer: (pending)
>
>Documentation:
>
>Release Notes:
>
>Details: LzSprite.js - Pass reference to canvas object to
>Lz.appid._ready().  Don't hide splash.
>
>html-response.xslt - Register for Lz.appid.onload to hide the splash
>div.
>
(Continue reading)

Philip Romanik | 1 Sep 16:37
Favicon

For Review: Change 20070901-Philip-8. Summary: Fix inputtext size

Change 20070901-Philip-8 by Philip <at> Philip-DC on 2007-09-01 10:29:16 EDT
     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/wafflecone
     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone

Summary: Fix inputtext size

New Features:

Bugs Fixed: LPP-4626

Technical Reviewer: max
QA Reviewer: hqm
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
LzTextSprite.getTextfieldHeight reuses the textclip to determine the 
height. However, it was not resetting the width when it was finished. This 
change caches/restores a few parameters so that the textclip is restored to 
its original value.

Some of these changes may not strictly be necessary but it is a safe change.

Tests:

This inputtext should be clickable anywhere along the width:
   <canvas>
(Continue reading)

Benjamin Shine | 1 Sep 18:42
Favicon

Re: For Review: Change 20070901-Philip-8. Summary: Fix inputtext size


Reviewed, not approved -- from IM: you reuse the variable tch as  
textclip._height and texctip.htmlText. It needs two different  
variables there.

but, ROCK, with the fast fix!

On Sep 1, 2007, at 7:37 AM, Philip Romanik wrote:

> Change 20070901-Philip-8 by Philip <at> Philip-DC on 2007-09-01 10:29:16  
> EDT
>     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/wafflecone
>     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
>
> Summary: Fix inputtext size
>
> New Features:
>
> Bugs Fixed: LPP-4626
>
> Technical Reviewer: max
> QA Reviewer: hqm
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> LzTextSprite.getTextfieldHeight reuses the textclip to determine  
(Continue reading)

Philip Romanik | 1 Sep 18:50
Favicon

For Review: Change 20070901-Philip-6. Summary: Fix inputtext size UPDATE

Change 20070901-Philip-6 by Philip <at> Philip-DC on 2007-09-01 10:29:16 EDT
     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/wafflecone
     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone

Summary: Fix inputtext size UPDATE

New Features:

Bugs Fixed: LPP-4626

Technical Reviewer: max
QA Reviewer: hqm
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
LzTextSprite.getTextfieldHeight reuses the textclip to determine the 
height. However, it was not resetting the width when it was finished. This 
change caches/restores a few parameters so that the textclip is restored to 
its original value.

Some of these changes may not strictly be necessary but it is a safe change.

Tests:

This inputtext should be clickable anywhere along the width:
   <canvas>
(Continue reading)

Max Carlson | 1 Sep 19:12
Favicon

Re: For Review: Change 20070901-Philip-6. Summary: Fix inputtext size UPDATE

Approved!

Philip Romanik wrote:
> Change 20070901-Philip-6 by Philip <at> Philip-DC on 2007-09-01 10:29:16 EDT
>     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/wafflecone
>     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
> 
> Summary: Fix inputtext size UPDATE
> 
> New Features:
> 
> Bugs Fixed: LPP-4626
> 
> Technical Reviewer: max
> QA Reviewer: hqm
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Release Notes:
> 
> Details:
> LzTextSprite.getTextfieldHeight reuses the textclip to determine the 
> height. However, it was not resetting the width when it was finished. 
> This change caches/restores a few parameters so that the textclip is 
> restored to its original value.
> 
> Some of these changes may not strictly be necessary but it is a safe 
> change.
> 
(Continue reading)

Henry Minsky | 2 Sep 03:01
Picon

For Review: Change 20070901-hqm-2 Summary: unlink request attribute and autorequest attribute on dataset

Change 20070901-hqm-2 by hqm <at> IBM-2E06404CB67 on 2007-09-01 20:56:30 EDT
    in /cygdrive/c/users/hqm/openlaszlo/wafflecone3
    for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone

Summary:  unlink request attribute and autorequest attribute on dataset

New Features:

Bugs Fixed: LPP-4630
Bugs: LPP-4630

Technical Reviewer: pkang (pending)
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

There doesn't seem to be any good reason for setAutorequest to call
setRequest. The user
can set them indepenndently in any combination  they want using the two setters.

Tests:

test/lfc/data/alldata.lzx

Files:
(Continue reading)

Henry Minsky | 2 Sep 03:13
Picon

For Review: Change 20070901-hqm-2 Summary: unlink request attribute and autorequest attribute on dataset

Change 20070901-hqm-2 by hqm <at> IBM-2E06404CB67 on 2007-09-01 20:56:30 EDT
    in /cygdrive/c/users/hqm/openlaszlo/wafflecone3
    for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone

Summary:  unlink request attribute and autorequest attribute on dataset

New Features:

Bugs Fixed: LPP-4630
Bugs: LPP-4630

Technical Reviewer: pkang (pending)
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

There doesn't seem to be any good reason for setAutorequest to call
setRequest. The user
can set them indepenndently in any combination  they want using the two setters.

Tests:

test/lfc/data/alldata.lzx

Files:
(Continue reading)

Henry Minsky | 2 Sep 03:25
Picon

For Review: Change 20070901-hqm-0 Summary: fix test to match new format from LzDataElement.serialize()

Change 20070901-hqm-0 by hqm <at> IBM-2E06404CB67 on 2007-09-01 21:21:21 EDT
    in /cygdrive/c/users/hqm/openlaszlo/wafflecone3/test/lfc/data
    for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone/test/lfc/data

Summary:  fix test to match new format from LzDataElement.serialize()

New Features:

Bugs Fixed: LPP-4631

Technical Reviewer: pbr (pending)
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

Tests:
test/lfc/data/alldata.lzx

Files:
M      datanode.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070901-hqm-0.tar

--

-- 
Henry Minsky
(Continue reading)

Pablo Kang | 2 Sep 03:45
Favicon

Re: For Review: Change 20070901-hqm-2 Summary: unlink request attribute and autorequest attribute on dataset

Approved. Thanks, Henry!

On Sat, 1 Sep 2007, Henry Minsky wrote:

> Change 20070901-hqm-2 by hqm <at> IBM-2E06404CB67 on 2007-09-01 20:56:30 EDT
>    in /cygdrive/c/users/hqm/openlaszlo/wafflecone3
>    for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
>
> Summary:  unlink request attribute and autorequest attribute on dataset
>
> New Features:
>
> Bugs Fixed: LPP-4630
> Bugs: LPP-4630
>
> Technical Reviewer: pkang (pending)
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>
> There doesn't seem to be any good reason for setAutorequest to call
> setRequest. The user
> can set them indepenndently in any combination  they want using the two setters.
>
>
(Continue reading)

Philip Romanik | 2 Sep 14:07
Favicon

Re: For Review: Change 20070901-hqm-0 Summary: fix test to match new format from LzDataElement.serialize()

Approved.

>Change 20070901-hqm-0 by hqm <at> IBM-2E06404CB67 on 2007-09-01 21:21:21 EDT
>     in /cygdrive/c/users/hqm/openlaszlo/wafflecone3/test/lfc/data
>     for 
> http://svn.openlaszlo.org/openlaszlo/branches/wafflecone/test/lfc/data
>
>Summary:  fix test to match new format from LzDataElement.serialize()
>
>New Features:
>
>Bugs Fixed: LPP-4631
>
>
>
>
>Technical Reviewer: pbr (pending)
>QA Reviewer: (pending)
>Doc Reviewer: (pending)
>
>Documentation:
>
>Release Notes:
>
>Details:
>
>
>Tests:
>test/lfc/data/alldata.lzx
>
(Continue reading)


Gmane