[RESENT] Re: For Review: Change 20070529-Philip-6. Summary: Ported LzTrack.lzs to new class system

Comments:

You should leave the arglist to `initialize` empty, since you don't  
use any args.  The list you give is the arglist of subclasses of  
LzNode, not relevant here.

Not sure I understand how __LZtrackDel is called on idle, since it  
does not register itself.  Is it somehow hardwired?  That seems like  
bad modularity.  Perhaps this is a question for Max.

Otherwise approved!

On 2007-05-29, at 14:32 EDT, Philip Romanik wrote:

> Change 20070529-Philip-6 by Philip <at> Philip-DC on 2007-05-29 14:15:49  
> EST
>     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/legals
>     for http://svn.openlaszlo.org/openlaszlo/branches/legals
>
> Summary: Ported LzTrack.lzs to new class system
>
> New Features:
>
> Bugs Fixed: LPP-3986
>
> Technical Reviewer: ptw
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:

For Review: Change 20070601-jcrowley-C Summary: Contributor Bug Fix - Got warning while resizing grid width.

Change 20070601-jcrowley-C by jcrowley <at> doctormanhattan.mshome.net on  
2007-06-01 04:44:41 EDT
     in /Users/jcrowley/src/svn/openlaszlo/legals-ten
     for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Contributor Bug Fix - Got warning while resizing grid width.

New Features:

Bugs Fixed: LPP-4012

Technical Reviewer: pbr
QA Reviewer: max
Doc Reviewer:

Documentation:

Release Notes:

Details: Applied Yuwen Fang's bug fix to grid.lzx.

Tests: Ran Yuwen's example from LPP-4012 with both the modified and  
unmodified files, and
	noticed an absence of the errors in the modified version.

Files:
M      lps/components/lz/grid.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070601- 
jcrowley-C.tar

Re: For Review: Change 20070601-jcrowley-C Summary: Contributor Bug Fix - Got warning while resizing grid width.

Approved!

BTW, Resizing the grid in the x direction is painfully slow in dhtml. This 
isn't caused by your change though.

>Change 20070601-jcrowley-C by jcrowley <at> doctormanhattan.mshome.net on
>2007-06-01 04:44:41 EDT
>      in /Users/jcrowley/src/svn/openlaszlo/legals-ten
>      for http://svn.openlaszlo.org/openlaszlo/branches/legals
>
>Summary: Contributor Bug Fix - Got warning while resizing grid width.
>
>New Features:
>
>Bugs Fixed: LPP-4012
>
>Technical Reviewer: pbr
>QA Reviewer: max
>Doc Reviewer:
>
>Documentation:
>
>Release Notes:
>
>Details: Applied Yuwen Fang's bug fix to grid.lzx.
>
>Tests: Ran Yuwen's example from LPP-4012 with both the modified and
>unmodified files, and
>         noticed an absence of the errors in the modified version.
>

For Review: Change 20070601-jcrowley-8 Summary: lzenv finds a lot of extra stuff due to .svn directories

Change 20070601-jcrowley-8 by jcrowley <at> doctormanhattan.mshome.net on  
2007-06-01 13:13:39 EDT
     in /Users/jcrowley/src/svn/openlaszlo/legals-ten
     for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: lzenv finds a lot of extra stuff due to .svn directories

New Features:

Bugs Fixed: LPP-2512

Technical Reviewer: pbr
QA Reviewer: ben
Doc Reviewer:

Documentation:

Release Notes:

Details: Applied Scott Evans' change to prevent lzenv from making  
classpath
	enormous due to adding stuff from .svn directories.

Tests:

Files:
M      WEB-INF/lps/server/bin/lzenv

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070601- 
jcrowley-8.tar

Re: for review, additional automatic test scripts

Re: for review, additional automatic test scripts

On 2007-06-01, at 15:09 EDT, Jim Grandy wrote:

> 1- you need to 'chmod +x build-tools/findtestsbrowser.sh'

Doesn't he also have to set the svn props? If he had his ~/subversion/ 
config set properly, svn would do that for him.

splash view and audio resources issues

Re: for review, additional automatic test scripts

Has no properties error

Hi all,

In DHTML (4.0.2), I'm seeing an error in the debugger that says "has no 
properties". This causes the runtime to break completely, so nothing 
further is drawn:

ERROR: 
http://localhost:8080/lps-4.0.2/lps/includes/lfc/LFCdhtml-debug.js:11855: 
$2_np has no properties

Can anyone explain what the "has no properties" errors mean? Is there a 
we can avoid having them be so destructive?

It happens both with the debugger open and closed.

Here's the offending line from the LFCdhtml-debug.js:

$2_np = $2_np.getFirstChild()

Not sure if it helps, but I've attached the gzipped LFCdhtml file too.

Thanks,

Antun

anyone know what svn is trying to tell me here?