Re: wish I could know what gets included by what

Fwd: [Platform-team] Reminder: migration proposals for 4.0.1]

Re: wish I could know what gets included by what

Re: wish I could know what gets included by what

If you make it a log thingy, you can enable logs on a per-class basis.

Something like

lzc -lorg.openlaszlo.compiler.Parser=debug

On 2007-03-31, at 21:16 EDT, Henry Minsky wrote:

> To start with you can add this line to Parser.java, and then when  
> you run
> lzc it will print to the console
>
> $ svn diff  WEB-INF/lps/server/src/org/openlaszlo/compiler/Parser.java
> Index: WEB-INF/lps/server/src/org/openlaszlo/compiler/Parser.java
> ===================================================================
> --- WEB-INF/lps/server/src/org/openlaszlo/compiler/Parser.java   
> (revision
> 4555)
> +++ WEB-INF/lps/server/src/org/openlaszlo/compiler/Parser.java   
> (working
> copy)
> @@ -440,6 +440,12 @@
>                 Parser.class.getName(),"051018-438")
> , child);
>                 }
> +
> +                System.err.println(href + " included by " +
> +
> getUserPathname(getSourcePathname(element)) + ":"+
> +                                   getSourceLocation(child, LINENO));
> +
> +
>                 File target = resolver.resolve(href, base);
>                 // An include whose href is a directory implicitly
>                 // includes the library.lzx file in that directory.
>
>
>
> And then it will print to the console when you run lzc
>
> On 3/31/07, Sarah Allen <sallen <at> laszlosystems.com> wrote:
>>
>> I just wrote up this feature request:
>> LPP-3815 Debugging tool that will tell me what files are included by
>> what
>>
>> I don't know if the size profiler would be the right spot for  
>> this.  But
>> when you have a big app and you are trying to make it smaller, it is
>> really time consuming to find where the extra stuff is added in.  I'd
>> settle for debug output from lzc.
>>
>> I'll bet this would be easy for someone who knows the compiler.   
>> Who can
>> I bribe to whip up a change to 3.4 that will let me see this  
>> info?  I'll
>> buy beers the next time you are in SF, or the beverage of your  
>> choice.
>> Or at least, maybe someone could point me to the place in the code  
>> where
>> I could make this change.
>>
>> Thanks!
>> Sarah
>>
>
>
>
> -- 
> Henry Minsky
> Software Architect
> hminsky <at> laszlosystems.com

Re: wish I could know what gets included by what

Re: Fwd: [Platform-team] Reminder: migration proposals for 4.0.1]

I think we should take these.  I'll move 'em over...

Henry Minsky wrote:
> migration proposal for changes from legals => 4.0.1
> 
> 
> 4516, 4517, trimwhitespace flag for compiled datasets
> risk: modest, it touches the code which initializes datasets
> benefit: minor , doubt many people are relying on this
> 
> 4537: fix for lzenv.bat in windows
> benefit: modest  makes lzc work in Windows , (workaround is to use cygwin)
> risk: low, only affects one file, which is broken now
> 
> 
> 4541: fix for basewindow DHTML
> benefit: modest, fixes a bug for case when people delete windows in DHTML
> risk: low, simple local changes, and it's a component
> 

--

-- 
Regards,
Max Carlson
OpenLaszlo.org

Re: wish I could know what gets included by what

I'll make a patch in the morning if you don't get to it first.

On 2007-03-31, at 21:37 EDT, Henry Minsky wrote:

> OK in that case use the line
>
>                mLogger.debug(href + " included by " +
>
> getUserPathname(getSourcePathname(element)) + ":"+
>                                   getSourceLocation(child, LINENO));
>
> and then do what Tucker said to get it to print out to console from  
> lzc
>
>
>
>
>
> On 3/31/07, P T Withington <ptw <at> openlaszlo.org> wrote:
>>
>> If you make it a log thingy, you can enable logs on a per-class  
>> basis.
>>
>> Something like
>>
>> lzc -lorg.openlaszlo.compiler.Parser=debug
>>
>> On 2007-03-31, at 21:16 EDT, Henry Minsky wrote:
>>
>> > To start with you can add this line to Parser.java, and then when
>> > you run
>> > lzc it will print to the console
>> >
>> > $ svn diff  WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
>> Parser.java
>> > Index: WEB-INF/lps/server/src/org/openlaszlo/compiler/Parser.java
>> > ===================================================================
>> > --- WEB-INF/lps/server/src/org/openlaszlo/compiler/Parser.java
>> > (revision
>> > 4555)
>> > +++ WEB-INF/lps/server/src/org/openlaszlo/compiler/Parser.java
>> > (working
>> > copy)
>> > @@ -440,6 +440,12 @@
>> >                 Parser.class.getName(),"051018-438")
>> > , child);
>> >                 }
>> > +
>> > +                System.err.println(href + " included by " +
>> > +
>> > getUserPathname(getSourcePathname(element)) + ":"+
>> > +                                   getSourceLocation(child,  
>> LINENO));
>> > +
>> > +
>> >                 File target = resolver.resolve(href, base);
>> >                 // An include whose href is a directory implicitly
>> >                 // includes the library.lzx file in that directory.
>> >
>> >
>> >
>> > And then it will print to the console when you run lzc
>> >
>> > On 3/31/07, Sarah Allen <sallen <at> laszlosystems.com> wrote:
>> >>
>> >> I just wrote up this feature request:
>> >> LPP-3815 Debugging tool that will tell me what files are  
>> included by
>> >> what
>> >>
>> >> I don't know if the size profiler would be the right spot for
>> >> this.  But
>> >> when you have a big app and you are trying to make it smaller,  
>> it is
>> >> really time consuming to find where the extra stuff is added  
>> in.  I'd
>> >> settle for debug output from lzc.
>> >>
>> >> I'll bet this would be easy for someone who knows the compiler.
>> >> Who can
>> >> I bribe to whip up a change to 3.4 that will let me see this
>> >> info?  I'll
>> >> buy beers the next time you are in SF, or the beverage of your
>> >> choice.
>> >> Or at least, maybe someone could point me to the place in the code
>> >> where
>> >> I could make this change.
>> >>
>> >> Thanks!
>> >> Sarah
>> >>
>> >
>> >
>> >
>> > --
>> > Henry Minsky
>> > Software Architect
>> > hminsky <at> laszlosystems.com
>>
>>
>
>
> -- 
> Henry Minsky
> Software Architect
> hminsky <at> laszlosystems.com

For Review: Change 20070322-ptw-m Summary: Add svn-updatechange

Change 20070322-ptw-m by ptw <at> dueling-banjos.local on 2007-03-22  
11:56:34 EDT
     in /Users/ptw/OpenLaszlo/tools/trunk/svn
     for http://svn.openlaszlo.org/tools/trunk/svn

Summary: Add svn-updatechange

Technical Reviewer: jgrandy (pending)
QA Reviewer: sallen (pending)
Doc Reviewer: n/a

Details:
     svn-bash: Add svn-updatechange which will update the file list of
     an existing change to reflect the current state of the directory.
     Insert line ends in change text in a platform-independent way.

     README: Documented svn-updatechange

Tests:
     IWFM

Files:
M      svn-bash.sh
M      README.txt

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070322-ptw- 
m.tar

For Review: Change 20070401-ptw-T Summary: Add debug logging of include processing for sallen

Sarah: This change implements Henry's include info as debug logging  
in the Parser, so you can turn it on or off as shown in 'Tests'.  Let  
us know if this is sufficient for what you want.  Probably you want  
to run the output of lzc through `sort`.

Change 20070401-ptw-T by ptw <at> dueling-banjos.local on 2007-04-01  
07:43:22 EDT
     in /Users/ptw/OpenLaszlo/3.4.1
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Add debug logging of include processing for sallen

Technical Reviewer: hminsky (pending)
QA Reviewer: sallen (pending)
Doc Reviewer: (pending)

Details:
     Parser.java: log includes

Tests:
     [ptw <at> dueling-banjos 3.4.1 07:34:46]$ lzc - 
lorg.openlaszlo.compiler.Parser=debug test/components/style_example.lzx
     lz/tree.lzx included by style_example.lzx:8
     testmedia/frosty.lzx included by style_example.lzx:118
     base/basetree.lzx included by ../../test/components/lz/tree.lzx:2

Files:
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/Parser.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070401-ptw- 
T.tar

Migration proposal for 4.0.1

Revision: 4551
Bugs Fixed:
LPP-3781 - documentation disables scrollwheel and navigation

Risk: low - only changes the html wrapper for docs
Reward: high - fixes annoying issues with documentation