Jim Grandy | 1 Mar 01:32
Favicon

Re: For Review: Change 20070228-maxcarlson-X Summary: Fix lzunit, dhtml clipping of clickable views, dhtml input text height measurement, dhtml edittext appearance

Approved!

On Feb 28, 2007, at 3:35 PM, Max Carlson wrote:

> Change 20070228-maxcarlson-X by maxcarlson <at> max-carlsons- 
> computer.local on 2007-02-28 15:29:00 PST
>     in /Users/maxcarlson/openlaszlo/legals
>
> Summary: Fix lzunit, dhtml clipping of clickable views, dhtml input  
> text height measurement, dhtml edittext appearance
>
> New Features:
>
> Bugs Fixed:
>
> Technical Reviewer: promanik
> QA Reviewer: jcrowley
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details: LzSprite.js - Don't check for Lz, assume it's there - see  
> rhino.js. Clip clickable divs along with regular divs.
>
> LzInputTextSprite.js - Fix text height and width metrics
>
> rhino.js - Add dummy Lz = {__propcache: {} }; object to DOM, like  
> the wrappers do for dhtml.
(Continue reading)

Philip Romanik | 1 Mar 01:52
Favicon

Re: For Review: Change 20070228-maxcarlson-X Summary: Fix lzunit, dhtml clipping of clickable views, dhtml input text height measurement, dhtml edittext appearance

Hi max,

I know you have to check this in, but I found an issue with one of the 
tests.The output of this test,

http://localhost:8080/legals/test/lztest/lztest-text.lzx?lzr=dhtml

is wrong in FireFox, and generates a dhtml error in IE6. In Firefox is 
looks like the background color and some of the formatting has been lost.

>Change 20070228-maxcarlson-X by maxcarlson <at> max-carlsons-
>computer.local on 2007-02-28 15:29:00 PST
>      in /Users/maxcarlson/openlaszlo/legals
>
>Summary: Fix lzunit, dhtml clipping of clickable views, dhtml input
>text height measurement, dhtml edittext appearance
>
>New Features:
>
>Bugs Fixed:
>
>Technical Reviewer: promanik
>QA Reviewer: jcrowley
>Doc Reviewer: (pending)
>
>Documentation:
>
>Release Notes:
>
>Details: LzSprite.js - Don't check for Lz, assume it's there - see
(Continue reading)

J Crowley | 1 Mar 01:55
Favicon

Re: For Review: Change 20070228-maxcarlson-X Summary: Fix lzunit, dhtml clipping of clickable views, dhtml input text height measurement, dhtml edittext appearance

Approved.

Though, in examples/components/edittext_example.lzx, in DHTML, on  
single-line edittext, the contents shifts up and down slightly when  
clicked in or when they get/lose focus.

On Feb 28, 2007, at 7:32 PM, Jim Grandy wrote:

> Approved!
>
> On Feb 28, 2007, at 3:35 PM, Max Carlson wrote:
>
>> Change 20070228-maxcarlson-X by maxcarlson <at> max-carlsons- 
>> computer.local on 2007-02-28 15:29:00 PST
>>     in /Users/maxcarlson/openlaszlo/legals
>>
>> Summary: Fix lzunit, dhtml clipping of clickable views, dhtml  
>> input text height measurement, dhtml edittext appearance
>>
>> New Features:
>>
>> Bugs Fixed:
>>
>> Technical Reviewer: promanik
>> QA Reviewer: jcrowley
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
(Continue reading)

Philip Romanik | 1 Mar 02:20
Favicon

Re: For Review: Change 20070228-maxcarlson-X Summary: Fix lzunit, dhtml clipping of clickable views, dhtml input text height measurement, dhtml edittext appearance

Hi Max,

I tracked down the IE6 error. It's in LzInputTextSprite.js. The error is 
'invalid argument' on the final code line of this function.

LzInputTextSprite.prototype.setHeight = function (h) {
    // call LzSprite.setHeight();
    this.__setHeight(h - this.____hpadding);
    if (LzSprite.prototype.quirks.fix_clickable) {
        var h = this.CSSDimension(this.h);
        this.__LZclickdiv.style.height = h;
        this.__LZinputclickdiv.style.height = h;
    }
}

>Hi max,
>
>I know you have to check this in, but I found an issue with one of the
>tests.The output of this test,
>
>http://localhost:8080/legals/test/lztest/lztest-text.lzx?lzr=dhtml
>
>is wrong in FireFox, and generates a dhtml error in IE6. In Firefox is
>looks like the background color and some of the formatting has been lost.
>
>
> >Change 20070228-maxcarlson-X by maxcarlson <at> max-carlsons- computer.local
> >on 2007-02-28 15:29:00 PST
> >      in /Users/maxcarlson/openlaszlo/legals
> >
(Continue reading)

Max Carlson | 1 Mar 02:25
Favicon

Re: For Review: Change 20070228-maxcarlson-X Summary: Fix lzunit, dhtml clipping of clickable views, dhtml input text height measurement, dhtml edittext appearance

I'll send a change out that fixes this and LPP-2608 shortly.

Philip Romanik wrote:
> Hi max,
> 
> I know you have to check this in, but I found an issue with one of the 
> tests.The output of this test,
> 
> http://localhost:8080/legals/test/lztest/lztest-text.lzx?lzr=dhtml
> 
> is wrong in FireFox, and generates a dhtml error in IE6. In Firefox is 
> looks like the background color and some of the formatting has been lost.
> 
> 
>> Change 20070228-maxcarlson-X by maxcarlson <at> max-carlsons-
>> computer.local on 2007-02-28 15:29:00 PST
>>      in /Users/maxcarlson/openlaszlo/legals
>>
>> Summary: Fix lzunit, dhtml clipping of clickable views, dhtml input
>> text height measurement, dhtml edittext appearance
>>
>> New Features:
>>
>> Bugs Fixed:
>>
>> Technical Reviewer: promanik
>> QA Reviewer: jcrowley
>> Doc Reviewer: (pending)
>>
>> Documentation:
(Continue reading)

Max Carlson | 1 Mar 02:40
Favicon

For Review: Change 20070228-maxcarlson-w Summary: UPDATED: Fix lzunit, dhtml clipping of clickable views, dhtml input text height measurement, dhtml edittext appearance, fix radio button clickability in IE DHTML

Change 20070228-maxcarlson-w by maxcarlson <at> max-carlsons- 
computer.local on 2007-02-28 17:28:31 PST
     in /Users/maxcarlson/openlaszlo/legals

Summary: UPDATED: Fix lzunit, dhtml clipping of clickable views,  
dhtml input text height measurement, dhtml edittext appearance, fix  
radio button clickability in IE DHTML

New Features:

Bugs Fixed: LPP-3608 - DHTML: Radio buttons don't work properly in  
IE6/IE7

Technical Reviewer: promanik
QA Reviewer: jcrowley
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: LzSprite.js - Don't check for Lz, assume it's there. Clip  
clickable divs along with regular divs.  Set this.__LZclick style in  
IE to fix radio buttons.

LzInputTextSprite.js - Fix text height and width metrics

rhino.js - Add dummy Lz = {__propcache: {} }; object to DOM, like the  
wrappers do for dhtml.

(Continue reading)

J Crowley | 1 Mar 02:51
Favicon

Re: For Review: Change 20070228-maxcarlson-w Summary: UPDATED: Fix lzunit, dhtml clipping of clickable views, dhtml input text height measurement, dhtml edittext appearance, fix radio button clickability in IE DHTML

I'm still getting the vertical shifting issue.  It seems to shift  
whenever the view loses focus.  I also have problems with it in  
Safari.  It seems like it isn't always focusing when clicked.  I keep  
having to click all over in order to finally be able to edit the  
text, and doing this has been repeatedly crashing Safari.

On Feb 28, 2007, at 8:40 PM, Max Carlson wrote:

> Change 20070228-maxcarlson-w by maxcarlson <at> max-carlsons- 
> computer.local on 2007-02-28 17:28:31 PST
>     in /Users/maxcarlson/openlaszlo/legals
>
> Summary: UPDATED: Fix lzunit, dhtml clipping of clickable views,  
> dhtml input text height measurement, dhtml edittext appearance, fix  
> radio button clickability in IE DHTML
>
> New Features:
>
> Bugs Fixed: LPP-3608 - DHTML: Radio buttons don't work properly in  
> IE6/IE7
>
> Technical Reviewer: promanik
> QA Reviewer: jcrowley
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details: LzSprite.js - Don't check for Lz, assume it's there. Clip  
(Continue reading)

Max Carlson | 1 Mar 02:55
Favicon

Re: For Review: Change 20070228-maxcarlson-w Summary: UPDATED: Fix lzunit, dhtml clipping of clickable views, dhtml input text height measurement, dhtml edittext appearance, fix radio button clickability in IE DHTML

Really?  With which test case?  Are you sure you built clean, etc?

J Crowley wrote:
> I'm still getting the vertical shifting issue.  It seems to shift 
> whenever the view loses focus.  I also have problems with it in Safari.  
> It seems like it isn't always focusing when clicked.  I keep having to 
> click all over in order to finally be able to edit the text, and doing 
> this has been repeatedly crashing Safari.
> 
> On Feb 28, 2007, at 8:40 PM, Max Carlson wrote:
> 
>> Change 20070228-maxcarlson-w by maxcarlson <at> max-carlsons-computer.local 
>> on 2007-02-28 17:28:31 PST
>>     in /Users/maxcarlson/openlaszlo/legals
>>
>> Summary: UPDATED: Fix lzunit, dhtml clipping of clickable views, dhtml 
>> input text height measurement, dhtml edittext appearance, fix radio 
>> button clickability in IE DHTML
>>
>> New Features:
>>
>> Bugs Fixed: LPP-3608 - DHTML: Radio buttons don't work properly in 
>> IE6/IE7
>>
>> Technical Reviewer: promanik
>> QA Reviewer: jcrowley
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
(Continue reading)

J Crowley | 1 Mar 03:06
Favicon

Re: For Review: Change 20070228-maxcarlson-w Summary: UPDATED: Fix lzunit, dhtml clipping of clickable views, dhtml input text height measurement, dhtml edittext appearance, fix radio button clickability in IE DHTML

I'm looking at the edittext example from Laszlo-Explorer.

I built clean... I'll try pulling down a fresh branch and get back to  
you.

On Feb 28, 2007, at 8:51 PM, J Crowley wrote:

> I'm still getting the vertical shifting issue.  It seems to shift  
> whenever the view loses focus.  I also have problems with it in  
> Safari.  It seems like it isn't always focusing when clicked.  I  
> keep having to click all over in order to finally be able to edit  
> the text, and doing this has been repeatedly crashing Safari.
>
> On Feb 28, 2007, at 8:40 PM, Max Carlson wrote:
>
>> Change 20070228-maxcarlson-w by maxcarlson <at> max-carlsons- 
>> computer.local on 2007-02-28 17:28:31 PST
>>     in /Users/maxcarlson/openlaszlo/legals
>>
>> Summary: UPDATED: Fix lzunit, dhtml clipping of clickable views,  
>> dhtml input text height measurement, dhtml edittext appearance,  
>> fix radio button clickability in IE DHTML
>>
>> New Features:
>>
>> Bugs Fixed: LPP-3608 - DHTML: Radio buttons don't work properly in  
>> IE6/IE7
>>
>> Technical Reviewer: promanik
>> QA Reviewer: jcrowley
(Continue reading)

Philip Romanik | 1 Mar 03:10
Favicon

Re: For Review: Change 20070228-maxcarlson-w Summary: UPDATED: Fix lzunit, dhtml clipping of clickable views, dhtml input text height measurement, dhtml edittext appearance, fix radio button clickability in IE DHTML

Approved, but there is still an issue with background color in the padding 
between text. This example will demonstrate it:

<canvas>
   <simplelayout axis="x"/>
   <text bgcolor="0xaaaaaa">Open</text>
   <text bgcolor="0xcccccc">Laszlo</text>
</canvas>

When run in swf, there is no white space between the two <text> elements. 
In dhtml it's white.

I was able to see what Josh is seeing. if I change the text in the first 
input box, and then change focus by clicking on the first two boxes, the 
text in the first text box shifts around.

>Change 20070228-maxcarlson-w by maxcarlson <at> max-carlsons-
>computer.local on 2007-02-28 17:28:31 PST
>      in /Users/maxcarlson/openlaszlo/legals
>
>Summary: UPDATED: Fix lzunit, dhtml clipping of clickable views,
>dhtml input text height measurement, dhtml edittext appearance, fix
>radio button clickability in IE DHTML
>
>New Features:
>
>Bugs Fixed: LPP-3608 - DHTML: Radio buttons don't work properly in
>IE6/IE7
>
>Technical Reviewer: promanik
(Continue reading)


Gmane