approved

approved

I came across an error in DHTML which is hard to reproduce but seems like it might have been due
to an animator calling setAttribute on a node which had already had destroy() called on it.
At least, that was the only way I could see that the 'setters' slot could be null on an LzNode.

http://www.openlaszlo.org/jira/browse/LPP-2447

So I'm proposing putting a check into setAttribute which checks if setters is null, and gives a warning in debug
mode. Anyone think this is a good or bad idea?


LzNode.prototype.setAttribute = function(prop, val) {
    // <at> field String name: The name for this subnode. If given, then this node's
    //parent and immediate parent will use store a pointer to this node as the
    //given name value

    // <at> field String id: A global identifer for this node. If given, a pointer
    //to this node with the given value will be placed in the global namespace

    // <at> field String datapath: The string to use as this node's datapath. This
    //usually creates a datapath that attaches to the node.

    if ( this.setters == null || null == this.setters[ prop ] ){
        if ( $debug && this.setters == null){
            Debug.warn( "setAttribute called on destroy()'ed node: ", prop, val, this );
        }
        this[ prop ] = val;
        var evt = ("on" + prop);
        if (evt in this) {
            this[ evt ].sendEvent( val );
        }
    } else {
        this[ this.setters [ prop ] ] ( val );
    }
}

--
Henry Minsky
Software Architect
hminsky <at> laszlosystems.com

Change change.bEAaK5100.txt by hqm <at> domokun /home/hqm/src/svn/openlaszlo/branches/legals-pr2/demos/ on 2006-08-01 01:14:53 EDT

Summary: workaround for LPP-2377 - hide details button

New Features:

Bugs Fixed:LPP-2377

Technical Reviewer: max (pending)
QA Reviewer: mkratt (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

work around a bug in mouse handling in DHTML / Safari runtime

opening new bug to describe the underlying problem

Removed the transparent overlay on hideDetailsButton and added an onclick handler
on the parent view.



Tests:

Files:
M      lzpix/app.lzx


--
Henry Minsky
Software Architect
hminsky <at> laszlosystems.com