headers
Max Carlson | 10 Feb 01:24
Favicon

[Laszlo-reviews] For Review: Change 20100209-maxcarlson-6 Summary: fix potential 'Unspecified error' exceptions in IE DHTML

Change 20100209-maxcarlson-6 by maxcarlson <at> bank on 2010-02-09 16:17:27 PST
    in /Users/maxcarlson/openlaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: fix potential 'Unspecified error' exceptions in IE DHTML

Bugs Fixed: LPP-8759 -  IE DHTML view.isMouseOver() throws an 'Unspecified error'

Technical Reviewer: ptw
QA Reviewer: hminsky

Details: Check to make sure the element is attached to the DOM before calling getBoundingClientRect().

Tests: See LPP-8759

Files:
M       lps/includes/source/embednew.js

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100209-maxcarlson-6.tar
Permalink | Reply | 0 comments |
headers
Max Carlson | 9 Feb 23:59
Favicon

[Laszlo-reviews] For Review: Change 20100209-maxcarlson-v Summary: Fix potential issue with fix for LPP-8753

Change 20100209-maxcarlson-v by maxcarlson <at> bank on 2010-02-09 14:54:56 PST
    in /Users/maxcarlson/openlaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix potential issue with fix for LPP-8753

Bugs Fixed: LPP-8753 - There is extra space below Webtop in IE

Technical Reviewer: ptw
QA Reviewer: dwheeler

Details: Only show the iframe's parent div if we're running in IE - to prevent other divs from being shown in
other browsers.

Tests: examples/extensions/html.lzx?lzt=html&lzwmode=transparent runs as before in IE8 and FF 3.5 windows

Files:
M       lps/includes/source/iframemanager.js

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100209-maxcarlson-v.tar
Permalink | Reply | 2 comments |
headers
P T Withington | 10 Feb 00:03
Favicon

Re: [Laszlo-reviews] For Review: Change 20100209-maxcarlson-v Summary: Fix potential issue with fix for LPP-8753

Approved.  Can you put a comment that document.all is IE magic?

On 2010-02-09, at 17:59, Max Carlson wrote:

> Change 20100209-maxcarlson-v by maxcarlson <at> bank on 2010-02-09 14:54:56 PST
>    in /Users/maxcarlson/openlaszlo/trunk-clean
>    for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Fix potential issue with fix for LPP-8753
> 
> Bugs Fixed: LPP-8753 - There is extra space below Webtop in IE
> 
> Technical Reviewer: ptw
> QA Reviewer: dwheeler
> 
> Details: Only show the iframe's parent div if we're running in IE - to prevent other divs from being shown in
other browsers.
> 
> Tests: examples/extensions/html.lzx?lzt=html&lzwmode=transparent runs as before in IE8 and FF 3.5 windows
> 
> Files:
> M       lps/includes/source/iframemanager.js
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100209-maxcarlson-v.tar
> 
> _______________________________________________
> Laszlo-reviews mailing list
> Laszlo-reviews <at> www.openlaszlo.org
> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
Permalink | Reply | 1 comment |
headers
Max Carlson | 10 Feb 00:20
Favicon

Re: [Laszlo-reviews] For Review: Change 20100209-maxcarlson-v Summary: Fix potential issue with fix for LPP-8753

Okay, it's in and merged to pagan...  I think I'm done!

Regards,
Max Carlson
OpenLaszlo.org

On 2/9/10 3:03 PM, P T Withington wrote:
> Approved.  Can you put a comment that document.all is IE magic?
>
> On 2010-02-09, at 17:59, Max Carlson wrote:
>
>> Change 20100209-maxcarlson-v by maxcarlson <at> bank on 2010-02-09 14:54:56 PST
>>     in /Users/maxcarlson/openlaszlo/trunk-clean
>>     for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: Fix potential issue with fix for LPP-8753
>>
>> Bugs Fixed: LPP-8753 - There is extra space below Webtop in IE
>>
>> Technical Reviewer: ptw
>> QA Reviewer: dwheeler
>>
>> Details: Only show the iframe's parent div if we're running in IE - to prevent other divs from being shown
in other browsers.
>>
>> Tests: examples/extensions/html.lzx?lzt=html&lzwmode=transparent runs as before in IE8 and FF 3.5 windows
>>
>> Files:
>> M       lps/includes/source/iframemanager.js
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100209-maxcarlson-v.tar
>>
>> _______________________________________________
>> Laszlo-reviews mailing list
>> Laszlo-reviews <at> www.openlaszlo.org
>> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
>
Permalink | Reply | 0 comments |
headers
P T Withington | 9 Feb 23:50
Picon
Favicon

Re: [Laszlo-builds] FAILURE for 15672-openlaszlo-branches-pagan-deities on linux-builder.corp.laszlosystems.com

Something just broke here...

Digging...

On 2010-02-09, at 17:30, svnbuild <at> laszlosystems.com wrote:

> 2010-02-09 14:30:02 PST: FAILURE for 15672-openlaszlo-branches-pagan-deities with build return
code 1 on linux-builder.corp.laszlosystems.com (Deploy return code -1; Megatest , -1) attaching /home/svnbuild/logs/tail-15671-branches-pagan-deities-nightly.log
> <tail-15671-branches-pagan-deities-nightly.log>
> _______________________________________________
> Laszlo-builds mailing list
> Laszlo-builds <at> openlaszlo.org
> http://www.openlaszlo.org/mailman/listinfo/laszlo-builds
Permalink | Reply | 2 comments |
headers
Max Carlson | 10 Feb 00:00
Favicon

Re: [Laszlo-builds] FAILURE for 15672-openlaszlo-branches-pagan-deities on linux-builder.corp.laszlosystems.com

I just realized part of one of my patches the build was needed for had a 
potential issue - the fix is out for review to you.

Regards,
Max Carlson
OpenLaszlo.org

On 2/9/10 2:50 PM, P T Withington wrote:
> Something just broke here...
>
> Digging...
>
> On 2010-02-09, at 17:30, svnbuild <at> laszlosystems.com wrote:
>
>> 2010-02-09 14:30:02 PST: FAILURE for 15672-openlaszlo-branches-pagan-deities with build return
code 1 on linux-builder.corp.laszlosystems.com (Deploy return code -1; Megatest , -1) attaching /home/svnbuild/logs/tail-15671-branches-pagan-deities-nightly.log
>> <tail-15671-branches-pagan-deities-nightly.log>
>> _______________________________________________
>> Laszlo-builds mailing list
>> Laszlo-builds <at> openlaszlo.org
>> http://www.openlaszlo.org/mailman/listinfo/laszlo-builds
>
>
Permalink | Reply | 1 comment |
headers
P T Withington | 10 Feb 00:02
Picon
Favicon

Re: [Laszlo-builds] FAILURE for 15672-openlaszlo-branches-pagan-deities on linux-builder.corp.laszlosystems.com

Ok, well the build is failing for me anyways...

On 2010-02-09, at 18:00, Max Carlson wrote:

> I just realized part of one of my patches the build was needed for had a potential issue - the fix is out for
review to you.
> 
> Regards,
> Max Carlson
> OpenLaszlo.org
> 
> On 2/9/10 2:50 PM, P T Withington wrote:
>> Something just broke here...
>> 
>> Digging...
>> 
>> On 2010-02-09, at 17:30, svnbuild <at> laszlosystems.com wrote:
>> 
>>> 2010-02-09 14:30:02 PST: FAILURE for 15672-openlaszlo-branches-pagan-deities with build return
code 1 on linux-builder.corp.laszlosystems.com (Deploy return code -1; Megatest , -1) attaching /home/svnbuild/logs/tail-15671-branches-pagan-deities-nightly.log
>>> <tail-15671-branches-pagan-deities-nightly.log>
>>> _______________________________________________
>>> Laszlo-builds mailing list
>>> Laszlo-builds <at> openlaszlo.org
>>> http://www.openlaszlo.org/mailman/listinfo/laszlo-builds
>> 
>>
Permalink | Reply | 0 comments |
headers
Max Carlson | 9 Feb 21:46
Favicon

[Laszlo-reviews] For Review: Change 20100209-maxcarlson-W Summary: UPDATED: Ensure iframe container is positioned and hidden on startup for IE

Change 20100209-maxcarlson-W by maxcarlson <at> bank on 2010-02-09 12:05:05 PST
    in /Users/maxcarlson/openlaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: UPDATED: Ensure iframe container is positioned and hidden on startup for IE

Bugs Fixed: LPP-8753 - There is extra space below Webtop in IE

Technical Reviewer: ptw
QA Reviewer: dwheeler

Details: Removed unneeded style attribute from <iframe/>

Set style of IE-specific container div to be hidden and positioned absolutely in the top-left of the page to
begin, then show after _gotload happens.

Tests: examples/extensions/html.lzx?lzt=html&lzwmode=transparent runs as before in IE8 and
Firefox.  Using the IE8 DOM explorer shows the iframe's container is positioned, and starts hidden.

Files:
M       lps/includes/source/iframemanager.js

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100209-maxcarlson-W.tar
Permalink | Reply | 2 comments |
headers
P T Withington | 9 Feb 22:00
Favicon

Re: [Laszlo-reviews] For Review: Change 20100209-maxcarlson-W Summary: UPDATED: Ensure iframe container is positioned and hidden on startup for IE

Seems reasonable to me.  There is a lot of magic going on here!

On 2010-02-09, at 15:46, Max Carlson wrote:

> Change 20100209-maxcarlson-W by maxcarlson <at> bank on 2010-02-09 12:05:05 PST
>    in /Users/maxcarlson/openlaszlo/trunk-clean
>    for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: UPDATED: Ensure iframe container is positioned and hidden on startup for IE
> 
> Bugs Fixed: LPP-8753 - There is extra space below Webtop in IE
> 
> Technical Reviewer: ptw
> QA Reviewer: dwheeler
> 
> Details: Removed unneeded style attribute from <iframe/>
> 
> Set style of IE-specific container div to be hidden and positioned absolutely in the top-left of the page
to begin, then show after _gotload happens.
> 
> Tests: examples/extensions/html.lzx?lzt=html&lzwmode=transparent runs as before in IE8 and
Firefox.  Using the IE8 DOM explorer shows the iframe's container is positioned, and starts hidden.
> 
> Files:
> M       lps/includes/source/iframemanager.js
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100209-maxcarlson-W.tar
Permalink | Reply | 1 comment |
headers
Max Carlson | 9 Feb 22:55
Favicon

Re: [Laszlo-reviews] For Review: Change 20100209-maxcarlson-W Summary: UPDATED: Ensure iframe container is positioned and hidden on startup for IE

Indeed - IE is very 'special' and needs a lot of 'magic'.

On 2/9/10 1:00 PM, P T Withington wrote:
> Seems reasonable to me.  There is a lot of magic going on here!
>
> On 2010-02-09, at 15:46, Max Carlson wrote:
>
>> Change 20100209-maxcarlson-W by maxcarlson <at> bank on 2010-02-09 12:05:05 PST
>>     in /Users/maxcarlson/openlaszlo/trunk-clean
>>     for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: UPDATED: Ensure iframe container is positioned and hidden on startup for IE
>>
>> Bugs Fixed: LPP-8753 - There is extra space below Webtop in IE
>>
>> Technical Reviewer: ptw
>> QA Reviewer: dwheeler
>>
>> Details: Removed unneeded style attribute from<iframe/>
>>
>> Set style of IE-specific container div to be hidden and positioned absolutely in the top-left of the page
to begin, then show after _gotload happens.
>>
>> Tests: examples/extensions/html.lzx?lzt=html&lzwmode=transparent runs as before in IE8 and
Firefox.  Using the IE8 DOM explorer shows the iframe's container is positioned, and starts hidden.
>>
>> Files:
>> M       lps/includes/source/iframemanager.js
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100209-maxcarlson-W.tar
>
Permalink | Reply | 0 comments |
headers
P T Withington | 9 Feb 21:23
Picon
Favicon

[Laszlo-reviews] For Review: Change 20100209-ptw-6 Summary: Make tag compiler runtime neutral

[Would like to get this into 4.7.1 because I think it is the only thing blocking swf9 .lzo's]

Change 20100209-ptw-6 by ptw <at> repo-man.home on 2010-02-09 15:06:31 EST
    in /Users/ptw/OpenLaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Make tag compiler runtime neutral

Bugs Fixed: LPP-8604 runtime-specific code being inserted by ClassModel in the tag compiler

Technical Reviewer: hminsky (pending)
QA Reviewer: max (pending)

Details:
    NodeModel: Don't put file/line on nodes classes.  It's
    non-portable, and we have a better mechanism (backtrace
    annotations).  There is no reason to disallow <passthrough> in the
    tag compiler, let the back end worry about that.

    ClassModel: Be honest and declare a valid default constructor for
    all tag classes (instead of relying on undocumented behavior of
    our class runtime).

    build.xml: type-oh noticed in passing

Tests:
    smokecheck and test case from forums works in all runtimes.

Files:
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java
M      build.xml

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100209-ptw-6.tar
Permalink | Reply | 2 comments |

Gmane