headers
pavel.porvatov | 2 Jun 2008 17:13
Picon

hg: jdk7/swing/jdk: 6709530: There are unnecessary code in slider classes, such as in JSlider and SliderUIs

Changeset: be7d7a297c3d
Author:    rupashka
Date:      2008-06-02 19:08 +0400
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/be7d7a297c3d

6709530: There are unnecessary code in slider classes, such as in JSlider and SliderUIs
Summary: Removed unnecessary code like unused variables, castings, imports etc
Reviewed-by: peterz

! src/share/classes/javax/swing/JSlider.java
! src/share/classes/javax/swing/plaf/basic/BasicSliderUI.java
! src/share/classes/javax/swing/plaf/synth/SynthSliderUI.java
Permalink | Reply | 0 comments |
headers
pavel.porvatov | 3 Jun 2008 16:04
Picon

hg: jdk7/swing/jdk: 4987336: JSlider doesn't show label's animated icon

Changeset: af37dad9022d
Author:    rupashka
Date:      2008-06-03 18:00 +0400
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/af37dad9022d

4987336: JSlider doesn't show label's animated icon
Summary: JSlider registers as an image observer of label's icon
Reviewed-by: alexp

! src/share/classes/javax/swing/JSlider.java
! src/share/classes/javax/swing/plaf/basic/BasicSliderUI.java
+ test/javax/swing/JSlider/4987336/box.gif
+ test/javax/swing/JSlider/4987336/bug4987336.html
+ test/javax/swing/JSlider/4987336/bug4987336.java
+ test/javax/swing/JSlider/4987336/cupanim.gif
Permalink | Reply | 0 comments |
headers
Alexander Potochkin | 3 Jun 2008 17:40
Picon

Re: JViewport Performance issues

Hello Chen

Thanks for the information

I wonder if JViewport in the BACKINGSTORE_SCROLL_MODE
works better in this case?

Could you please give more details about the workaround
from JadeDisplay which you mentioned below ?

Thanks
alexp

> Hello Swing Dev,
> 
>  
> 
> Could we get some visibility on bugs 4478765 and 4486696?
> 
>  
> 
> I noticed there are a lot of flash based applications that use the mouse 
> drag to scroll in all directions.  This is a great user interface 
> device, but it currently cannot be implemented in Swing due to 
> performance bug 4486696.
> 
>  
> 
> The current work around is to do something like what JadeDisplay did 
> using their JViewportImage
(Continue reading)

Permalink | Reply | 0 comments |
headers
pavel.porvatov | 4 Jun 2008 16:55
Picon

hg: jdk7/swing/jdk: 6571802: 'Shared Documents' listed in-between C, D drives in the JFileChooser, does not match with native

Changeset: f36f0f189064
Author:    rupashka
Date:      2008-06-04 18:48 +0400
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/f36f0f189064

6571802: 'Shared Documents' listed in-between C,D drives in the JFileChooser, does not match with native
Summary: now sun.awt.shell.ShellFolder#sort uses system sorting instead of alphabetical
Reviewed-by: loneid, peterz

! src/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java
! src/share/classes/sun/awt/shell/ShellFolder.java
! src/share/classes/sun/awt/shell/ShellFolderManager.java
! src/windows/classes/sun/awt/shell/Win32ShellFolder2.java
! src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java
Permalink | Reply | 0 comments |
headers
Clemens Eisserer | 4 Jun 2008 17:05
Picon

Re: <AWT Dev> Inefficiencies with custom TableCellRenderer and Applets

Hi Artem,

Sorry, I haven't been monitoring this discussion the last two weeks or so.
Thanks a lot for looking into it, and for filing the bug.

Clemens

2008/5/23 Artem Ananiev <Artem.Ananiev@...>:
>
> Artem Ananiev wrote:
>>
>> Shannon Hickey wrote:
>>>
>>> Clemens Eisserer wrote:
>>>>
>>>> Hi,
>>>>
>>>> I've created a library which has to use custom TableCellRenderers for
>>>> its tables.
>>>> I experienced a large performance difference between running my
>>>> application as Application inside an JFrame and as an JApplet.
>>>> Parented inside of the JFrame scrolling the table was smooth, however
>>>> scrolling inside the applet was slow, especially if the mouse is over
>>>> the table while scrolling.
>>>>
>>>> I did some profiling with netbeans-profiler and found the root-cause:
>>>>
>>>> BasicTableUI.paintCell->CellRendererPane.paintComponent->Container.validate->Component.updateCursorImmediatly->GlobalCursorManager.updateCursorImmediatly()->_updateCursor....
>>>>
>>>> The updateCursorImmediatly was called both times about 16.000 times,
(Continue reading)

Permalink | Reply | 0 comments |
headers
pavel.porvatov | 5 Jun 2008 11:42
Picon

hg: jdk7/swing/jdk: 6688110: JSlider has incorrect javadoc for the setValueIsAdjusting method

Changeset: e26917dd7b7c
Author:    rupashka
Date:      2008-06-05 13:30 +0400
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/e26917dd7b7c

6688110: JSlider has incorrect javadoc for the setValueIsAdjusting method
Summary: The sentence about ChangeEvents generation was removed
Reviewed-by: peterz

! src/share/classes/javax/swing/JSlider.java
Permalink | Reply | 0 comments |
headers
Daniel Janus | 9 Jun 2008 19:33
Picon
Picon

Polish translation of JFileChooser, JColorChooser and JOptionPane

Dear list,

Let me introduce myself since this is my first (and hopefully not last)
post here.  I'm Daniel Janus, the current maintainer and one of the
developers of Poliqarp, the open-source concordancer for large
collections of texts.  

The GUI client of Poliqarp is written in Java and is currently
undergoing a major rewrite.  The GUI in question is bilingual,
completely translated to English and Polish (with an Ukrainian
translation coming soon), which means that not only are the system's own
messages translated to Polish, but so are some of the standard Swing
dialogs provided by the JRE (JFileChooser, to be more precise, since
it's the only one that's currently used).  I had produced a crude
translation of the latter sometime in early 2006; this involved creating
a Polish version of some .properties files under
com.sun.swing.internal.plaf.

Because the Poliqarp code is currently being reviewed and most of the
JDK went open source since then, I would like to take this opportunity,
complete the translation, synchronize it with the latest OpenJDK code
and contribute to the community.  I checked out the Mercurial
repositories, and if I am not mistaken this will involve providing a
patch that will add the translated .properties files in
jdk/src/share/classes/com/sun/swing/internal/plaf/{basic,metal,synth}/resources.

If there is anybody that would be willing to guide me through the
process of submitting such a patch, or else direct me to the more
proper place where it might be considered, I will be extremely grateful.
(Continue reading)

Permalink | Reply | 2 comments |
headers
Phil Race | 9 Jun 2008 19:43
Picon

Re: Polish translation of JFileChooser, JColorChooser and JOptionPane

The process for making openjdk contributions is documented here :
http://openjdk.java.net/contribute/

My sense here is that it would be preferable to have translations
for all messages that are localised into other languages, not
just the ones in these particular dialogs.

Also since dialogs change, then an ongoing commitment to
translate new strings would be best.

-phil.

Daniel Janus wrote:
> Dear list,
> 
> Let me introduce myself since this is my first (and hopefully not last)
> post here.  I'm Daniel Janus, the current maintainer and one of the
> developers of Poliqarp, the open-source concordancer for large
> collections of texts.  
> 
> The GUI client of Poliqarp is written in Java and is currently
> undergoing a major rewrite.  The GUI in question is bilingual,
> completely translated to English and Polish (with an Ukrainian
> translation coming soon), which means that not only are the system's own
> messages translated to Polish, but so are some of the standard Swing
> dialogs provided by the JRE (JFileChooser, to be more precise, since
> it's the only one that's currently used).  I had produced a crude
> translation of the latter sometime in early 2006; this involved creating
> a Polish version of some .properties files under
> com.sun.swing.internal.plaf.
(Continue reading)

Permalink | Reply | 1 comment |
headers
Daniel Janus | 9 Jun 2008 20:14
Picon
Picon

Re: Polish translation of JFileChooser, JColorChooser and JOptionPane

Thanks for replying so fast!

> The process for making openjdk contributions is documented here :
> http://openjdk.java.net/contribute/

Yes, I've read that document.  Sorry for not having mentioned it.

While we're at it, the document mentions supplying a unit test.  Does
that also apply to the kind of contributions we're discussing here?
If so, any hints how such a unit-test might look like (i.e., what
should it test)?

> My sense here is that it would be preferable to have translations
> for all messages that are localised into other languages, not
> just the ones in these particular dialogs.
> 
> Also since dialogs change, then an ongoing commitment to
> translate new strings would be best.

I agree that this situation would be ideal.  In reality, however,
translations tend to have omissions -- in the German translation for
JFileChooser, for instance, some items are left untranslated.  And 
I probably can't cope with single-handedly translating the sheer volume
of .properties floating around the JDK code, much as I'd like to.

So probably I'll just submit a mercurial changeset within the next few
days or so, and then let the maintainers decide what to do with it.
Does that sound right?

Best regards,
(Continue reading)

Permalink | Reply | 0 comments |
headers
pavel.porvatov | 10 Jun 2008 12:25
Picon

hg: jdk7/swing/jdk: 5035693: "Open" button should be a default one in JFileChooser under Windows XP LAF

Changeset: 5083f5c15103
Author:    rupashka
Date:      2008-06-06 13:30 +0400
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/5083f5c15103

5035693: "Open" button should be a default one in JFileChooser under Windows XP LAF
Summary: The "Open" button was made default button of FileChooser dialog windows
Reviewed-by: loneid, peterz

! src/share/classes/com/sun/java/swing/plaf/motif/MotifLookAndFeel.java
! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java
! src/share/classes/javax/swing/JFileChooser.java
! src/share/classes/javax/swing/plaf/FileChooserUI.java
! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java
! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java
Permalink | Reply | 0 comments |

Gmane