headers
Michael McMahon | 2 Feb 2012 16:36
Picon
Favicon

RFR: 7142123 test/java/net/ProxySelector/B6737819.java failing on all platforms since Mac OS integration

Can I get the following change reviewed please?

http://cr.openjdk.java.net/~michaelm/7142123/webrev.1/

The fix for 7141335 (on Mac) caused a regression on all platforms
breaking the fix fo 6737819. This was testing a very unusual usage of 
proxies,
but one we probably have to support anyway, which was the case where 
sometimes
someone might really want to connect to "localhost" through a proxy.

To support that case, this fix keeps the behavior introduced by 7141335 
except when
-D<proto>.nonProxyHosts exists, but is an empty string. In that specific 
case, there will
be no non-proxied hosts as required. But, in all other cases, the 
default non-proxy list will
be added to whatever was provided in the system property.

Thanks,
Michael.
Permalink | Reply | 1 comment |
headers
Chris Hegarty | 2 Feb 2012 16:35
Picon
Favicon

Re: RFR: 7142123 test/java/net/ProxySelector/B6737819.java failing on all platforms since Mac OS integration

Looks good.

-Chris.

On 02/ 2/12 03:36 PM, Michael McMahon wrote:
> Can I get the following change reviewed please?
>
> http://cr.openjdk.java.net/~michaelm/7142123/webrev.1/
>
> The fix for 7141335 (on Mac) caused a regression on all platforms
> breaking the fix fo 6737819. This was testing a very unusual usage of
> proxies,
> but one we probably have to support anyway, which was the case where
> sometimes
> someone might really want to connect to "localhost" through a proxy.
>
> To support that case, this fix keeps the behavior introduced by 7141335
> except when
> -D<proto>.nonProxyHosts exists, but is an empty string. In that specific
> case, there will
> be no non-proxied hosts as required. But, in all other cases, the
> default non-proxy list will
> be added to whatever was provided in the system property.
>
> Thanks,
> Michael.
Permalink | Reply | 0 comments |
headers
chris hegarty | 8 Feb 2012 22:07
Picon
Favicon

RFR 7133367: ResponseCache.put should not be called when setUseCaches(false)

This seems to be an oversight in HttpURLConnection where the system-wide 
ResponseCache handler is used to store responses even if getUsesCaches 
returns false.

I guess this was never really noticed before since the cached response 
will not be used if getUsesCaches returns false for future requests.

The solution is to check if (cacheHandler != null && getUsesCaches()), 
similar to what is done during connect/plainConnect().

http://cr.openjdk.java.net/~chegar/7133367/webrev.00/webrev/

Thanks,
-Chris.
Permalink | Reply | 1 comment |
headers
Michael McMahon | 9 Feb 2012 22:55
Picon
Favicon

Re: RFR 7133367: ResponseCache.put should not be called when setUseCaches(false)

On 08/02/12 21:07, chris hegarty wrote:
> This seems to be an oversight in HttpURLConnection where the 
> system-wide ResponseCache handler is used to store responses even if 
> getUsesCaches returns false.
>
> I guess this was never really noticed before since the cached response 
> will not be used if getUsesCaches returns false for future requests.
>
> The solution is to check if (cacheHandler != null && getUsesCaches()), 
> similar to what is done during connect/plainConnect().
>
> http://cr.openjdk.java.net/~chegar/7133367/webrev.00/webrev/
>
> Thanks,
> -Chris.
Looks good.

- Michael
Permalink | Reply | 0 comments |
headers
Kurchi Hazra | 13 Feb 2012 23:03
Picon
Favicon

Code Review Request: 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup()


Hi,

Before joining multicast groups with IPv6 addresses on Mac OS, the
network interface to be used should also be set correctly. This
change enables using a default network interface on Mac OS X if no interface
has been specified.

Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144274

Webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.01/

Thanks,
Kurchi
Permalink | Reply | 4 comments |
headers
Alan Bateman | 14 Feb 2012 08:46
Picon
Favicon

Re: Code Review Request: 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup()

On 13/02/2012 22:03, Kurchi Hazra wrote:
>
> Hi,
>
> Before joining multicast groups with IPv6 addresses on Mac OS, the
> network interface to be used should also be set correctly. This
> change enables using a default network interface on Mac OS X if no 
> interface
> has been specified.
>
> Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144274
>
> Webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.01/
Kurchi - I think you should include an #else return 0; in 
getDefaultScopeID as otherwise I will guess you will get warnings when 
this code is compiled on other platforms.

-Alan.
Permalink | Reply | 3 comments |
headers
Chris Hegarty | 14 Feb 2012 09:58
Picon
Favicon

Re: Code Review Request: 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup()

Trivially, I don't think getDefaultScopeID needs it's implementation to 
be ifdef'ed with MACOSX, at all. Then won't need the 'else return 0;'.

It is just a general utility method to get the value of the defaultIndex 
field of NetworkInterace. Yes, the value will be 0 on all platforms 
other than Mac, but equally getDefaultScopeID will not be called on any 
platform, other than Mac.

-Chris.

On 02/14/12 07:46 AM, Alan Bateman wrote:
> On 13/02/2012 22:03, Kurchi Hazra wrote:
>>
>> Hi,
>>
>> Before joining multicast groups with IPv6 addresses on Mac OS, the
>> network interface to be used should also be set correctly. This
>> change enables using a default network interface on Mac OS X if no
>> interface
>> has been specified.
>>
>> Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144274
>>
>> Webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.01/
> Kurchi - I think you should include an #else return 0; in
> getDefaultScopeID as otherwise I will guess you will get warnings when
> this code is compiled on other platforms.
>
> -Alan.
(Continue reading)

Permalink | Reply | 2 comments |
headers
Kurchi Hazra | 14 Feb 2012 20:12
Picon
Favicon

Re: Code Review Request: 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup()

Updated webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.02/

- Kurchi

On 2/14/2012 12:58 AM, Chris Hegarty wrote:
> Trivially, I don't think getDefaultScopeID needs it's implementation 
> to be ifdef'ed with MACOSX, at all. Then won't need the 'else return 0;'.
>
> It is just a general utility method to get the value of the 
> defaultIndex field of NetworkInterace. Yes, the value will be 0 on all 
> platforms other than Mac, but equally getDefaultScopeID will not be 
> called on any platform, other than Mac.
>
> -Chris.
>
> On 02/14/12 07:46 AM, Alan Bateman wrote:
>> On 13/02/2012 22:03, Kurchi Hazra wrote:
>>>
>>> Hi,
>>>
>>> Before joining multicast groups with IPv6 addresses on Mac OS, the
>>> network interface to be used should also be set correctly. This
>>> change enables using a default network interface on Mac OS X if no
>>> interface
>>> has been specified.
>>>
>>> Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144274
>>>
>>> Webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.01/
>> Kurchi - I think you should include an #else return 0; in
(Continue reading)

Permalink | Reply | 1 comment |
headers
Chris Hegarty | 14 Feb 2012 20:09
Picon
Favicon

Re: Code Review Request: 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup()

Looks fine to me.

-Chris.

On 02/14/12 07:12 PM, Kurchi Hazra wrote:
> Updated webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.02/
>
> - Kurchi
>
>
>
> On 2/14/2012 12:58 AM, Chris Hegarty wrote:
>> Trivially, I don't think getDefaultScopeID needs it's implementation
>> to be ifdef'ed with MACOSX, at all. Then won't need the 'else return 0;'.
>>
>> It is just a general utility method to get the value of the
>> defaultIndex field of NetworkInterace. Yes, the value will be 0 on all
>> platforms other than Mac, but equally getDefaultScopeID will not be
>> called on any platform, other than Mac.
>>
>> -Chris.
>>
>> On 02/14/12 07:46 AM, Alan Bateman wrote:
>>> On 13/02/2012 22:03, Kurchi Hazra wrote:
>>>>
>>>> Hi,
>>>>
>>>> Before joining multicast groups with IPv6 addresses on Mac OS, the
>>>> network interface to be used should also be set correctly. This
>>>> change enables using a default network interface on Mac OS X if no
(Continue reading)

Permalink | Reply | 0 comments |
headers
Kurchi Hazra | 15 Feb 2012 20:46
Picon
Favicon

Code Review Request: 7144268: [macosx] ProblemList.txt updates to exclude networking tests failing on Mac OS X


Hi,

There are a few networking tests failing on Mac OS X due to the following issues:

(a) http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7122846
(b) http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7145658 (Not available yet)
(c) http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7143960

For the time being, we plan to exclude the problematic tests when
running tests via the Makefile, until these issues are resolved.

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144268

Webrev: http://cr.openjdk.java.net/~khazra/7144268/webrev.00/

Thanks,
Kurchi
Permalink | Reply | 1 comment |

Gmane