Wenbo Zhu | 18 Dec 03:42 2014
Picon

Re: JEP 110: HTTP 2 Client

I am new to the JEP process. Has there been any update on this work? Is there an API proposal to look at?

Thanks,
Wenbo
 

JEP 110: HTTP 2 Client

mark.reinhold at oracle.com mark.reinhold at oracle.com 
Wed Nov 12 22:59:55 UTC 2014

New JEP Candidate: http://openjdk.java.net/jeps/110 - Mark
Amanda Jiang | 18 Dec 00:23 2014
Picon

RFR 8065420: Update test java/net/ResponseCache/ResponseCacheTest.java to eliminate internal API dependency

Hi,

May I request your review for following changeset?
There is one networking tests that has dependency on internal API sun.net.www.ParseUtil.
This fix is to remove the internal API dependency from that test.

bug:https://bugs.openjdk.java.net/browse/JDK-8065420
webrev: http://cr.openjdk.java.net/~tyan/amandaj/8065420/webrev.00/

Thanks,
Amanda

Chris Hegarty | 17 Dec 16:47 2014
Picon

RFR 8067105: Socket returned by ServerSocket.accept() is inherited by child process on Windows

A socket connection which is returned by ServerSocket.accept() is 
inherited by a child process. The expected behavior is that the socket 
connection is not inherited by the child process. This is an oversight 
in the original implementation, that only sets HANDLE_FLAG_INHERIT for 
newly created sockets.

The native socket returned by ServerSocket.accept() should be configured 
so it will not be inherited by a child process, 
SetHandleInformation(<HANDLE>, HANDLE_FLAG_INHERIT, FALSE) .

The change is in Java_java_net_DualStackPlainSocketImpl_accept0

diff --git 
a/src/java.base/windows/native/libnet/DualStackPlainSocketImpl.c 
b/src/java.base/windows/native/libnet/DualStackPlainSocketImpl.c
--- a/src/java.base/windows/native/libnet/DualStackPlainSocketImpl.c
+++ b/src/java.base/windows/native/libnet/DualStackPlainSocketImpl.c
 <at>  <at>  -294,6 +294,8  <at>  <at> 
          return -1;
      }

+    SetHandleInformation((HANDLE)(UINT_PTR)newfd, HANDLE_FLAG_INHERIT, 
FALSE);
+
      ia = NET_SockaddrToInetAddress(env, (struct sockaddr *)&sa, &port);
      isa = (*env)->NewObject(env, isa_class, isa_ctorID, ia, port);
      (*env)->SetObjectArrayElement(env, isaa, 0, isa);

-Chris.

Konstantin Shefov | 10 Dec 16:21 2014
Picon

[9] Review request : JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

Hello,

Please, review the bug fix: https://bugs.openjdk.java.net/browse/JDK-6933879
Webrev: http://cr.openjdk.java.net/~kshefov/6933879/webrev.00

It is suggested to add some more symbols allowed for scope id in IPv6 
URI, namely "_", "." and ":", because these symbols may be included in 
network interface names. Now only alphanumeric characters are allowed to 
be in a scope id.

Thanks
-Konstantin

Mark Sheppard | 9 Dec 13:18 2014
Picon

RFR: JDK-8039595 - closed/java/net/DatagramPacket/CheckInetAddress.java fails on macosx

Hi
     please oblige and review the following change

http://cr.openjdk.java.net/~msheppar/8039595/webrev/

which addresses the failures raised in

https://bugs.openjdk.java.net/browse/JDK-8039595

it should also address the CheckInetAddress test failures

https://bugs.openjdk.java.net/browse/JDK-6924602 - TEST_BUG: 
CheckInetAddress.java sometimes fails because it uses wrong address
https://bugs.openjdk.java.net/browse/JDK-8028680 - 
closed/java/net/DatagramPacket/CheckInetAddress.java fails in azure

investigation of the issue saw the problem occur on multi-homed network 
configurations.
In some circumstances there was no connectivity between the address 
chosen for the client datagram socket, and
the address used for the server datagram socket.
In macos case the test was selecting a temporary address that was 
deprecated, therefore not usable
as an initiating socket address.

The purpose of the test is to determine that a server DatagramPacket can 
be re-used in a receive call and
obtain the relevant sender address from the datagram. The server socket 
is bound to a wild card address.
As such, the test now uses InetAddress.getLocalHost() in both the send 
datagram packet address and for the
client's DatagramSocket to ensure connectivity with the server 
DatagramSocket.

regards
Mark

Amanda Jiang | 5 Dec 22:58 2014
Picon

www.MessageHeader and some other internal APIs

Hi, May I request your review for following changeset? There are 33 networking tests that have dependency on internal API sun.net.www.MessageHeader and sun.net.www.HeaderParser This fix is to remove the internal API dependency from those tests. bug: https://bugs.openjdk.java.net/browse/JDK-8061729 webrev: http://cr.openjdk.java.net/~tyan/amandaj/8061729/webrev.05/ Thanks, Amanda
Mark Sheppard | 28 Nov 19:09 2014
Picon

RFR: JDK-8066130 - com.sun.net.httpserver stop() throws NullPointerException if it is not started

Hi,
    Please oblige and review the minor change
http://cr.openjdk.java.net/~msheppar/8066130/webrev/

to address the issue

https://bugs.openjdk.java.net/browse/JDK-8066130

a previous amendment to com.sun.net.httpserver.ServerImpl ( 
https://bugs.openjdk.java.net/browse/JDK-8015692)
failed to consider that a stop method may be invoked prior to a start 
method, hence assumed dispatcherThread would be set,
null check on disptacherThread added to stop 
com.sun.net.httpserver.ServerImpl stop method

regards
Mark

Chris Hegarty | 25 Nov 16:45 2014
Picon

RFR [9] 8065072: sun/net/www/http/HttpClient/StreamingRetry.java failed intermittently

This test has been failing intermittently since I updated it recently to cover another similar issue. The
test shares a ServerSocket instance across two threads, and as such it should be a volatile field. The test
should also ensure that any thread that it starts completes before it continues its iteration.

With these simple changes I ran the test several thousand times, on a machine that reproduced the
intermittent failure 1 in 10 times, and it was never seen to fail.

diff --git a/test/sun/net/www/http/HttpClient/StreamingRetry.java b/test/sun/net/www/http/HttpClient/StreamingRetry.java
--- a/test/sun/net/www/http/HttpClient/StreamingRetry.java
+++ b/test/sun/net/www/http/HttpClient/StreamingRetry.java
 <at>  <at>  -37,13 +37,13  <at>  <at> 

 public class StreamingRetry implements Runnable {
     static final int ACCEPT_TIMEOUT = 20 * 1000; // 20 seconds
-    ServerSocket ss;
+    volatile ServerSocket ss;

-    public static void main(String[] args) throws IOException {
+    public static void main(String[] args) throws Exception {
         (new StreamingRetry()).instanceMain();
     }

-    void instanceMain() throws IOException {
+    void instanceMain() throws Exception {
         out.println("Test with default method");
         test(null);
         out.println("Test with POST method");
 <at>  <at>  -54,12 +54,13  <at>  <at> 
         if (failed > 0) throw new RuntimeException("Some tests failed");
     }

-    void test(String method) throws IOException {
+    void test(String method) throws Exception {
         ss = new ServerSocket(0);
         ss.setSoTimeout(ACCEPT_TIMEOUT);
         int port = ss.getLocalPort();

-        (new Thread(this)).start();
+        Thread otherThread = new Thread(this);
+        otherThread.start();

         try {
             URL url = new URL("http://localhost:" + port + "/");
 <at>  <at>  -77,6 +78,7  <at>  <at> 
             //expected.printStackTrace();
         } finally {
             ss.close();
+            otherThread.join();
         }
     }

-Chris.
Mark Sheppard | 19 Nov 20:50 2014
Picon

RFR: JDK-8065222 - sun/net/www/protocol/http/B6369510.java doesn't execute as expected

Hi,
    please oblige and review the following change
http://cr.openjdk.java.net/~msheppar/8065222/webrev/

to address the issue
https://bugs.openjdk.java.net/browse/JDK-8065222

The URL construction in the test now uses 
InetAddress.getLocalHost().getHostName(), rather than the
address.getHostName(), which was returning wildcard IP address, causing 
a MalformedURLException.
Test, amended to propagate exception failures, also.

regards
Mark

mark.reinhold | 12 Nov 23:59 2014
Picon

JEP 110: HTTP 2 Client

New JEP Candidate: http://openjdk.java.net/jeps/110

- Mark

Chris Hegarty | 7 Nov 12:44 2014
Picon

www.http.HttpClient break HTTP PUT streaming

This is a trivial change to fix a failed previous attempt to prevent all 
HTTP requests, with a streaming body, from automatically being retried, 
by the HttpURLConnection implementation.

The existing implementation only prevents POST requests from being 
automatically retried, it should prevent all, incl PUT.

http://cr.openjdk.java.net/~chegar/8050983/webrev.00/webrev/

-Chris.

[1] https://bugs.openjdk.java.net/browse/JDK-8050983


Gmane