Michael McMahon | 3 May 13:44 2016
Picon

RFR: 8155928: Remove hardcoded port numbers from httpclient/Security.java test

Some tests with hardcoded port numbers were included in the initial http 
tests.

The fix uses a driver to allocate a free port and pass it into the existing
security test through a system property.

http://cr.openjdk.java.net/~michaelm/8155928/webrev.1/index.html

Thanks,
Michael

Seán Coffey | 20 Apr 15:33 2016
Picon

RFR: 8071125: Improve exception messages in URLPermission

Looking for a review for these simple changes. URLPermissions is a class 
introduced for JDK 8. Exception messaging can be improved to capture 
context.

https://bugs.openjdk.java.net/browse/JDK-8071125
http://cr.openjdk.java.net/~coffeys/webrev.8071125/webrev/

--

-- 
Regards,
Sean.

Felix Yang | 20 Apr 09:07 2016
Picon

RFR 8154543, NetworkInterfaceStreamTest.java fails intermittently after JDK-8146758

Hi there,
     I introduced a problem in fix for JDK-8146758. When calling 
allNetworkInterfaces(), it will concat sub interfaces into the stream 
incorrectly. Then the test fails on a Solaris host which has 
virtual(sub) interfaces.

Bug: https://bugs.openjdk.java.net/browse/JDK-8154543
Webrev: http://cr.openjdk.java.net/~xiaofeya/8154543/webrev.00/

Thanks,
Felix

Pavel Rappo | 19 Apr 11:15 2016
Picon

RFR JDK-8154487: java.httpclient/sun.net.httpclient.hpack.DecoderTest failing on Windows

Hi,

Could you please review my change for JDK-8154487?

http://cr.openjdk.java.net/~prappo/8154487/webrev.00/

This shows up only on Windows machines where EOL is '\r\n' rather than '\n'.

I used '\n' as a line separator in expected table state strings in the tests
(e.g. [1]). At the same time actual strings were constructed with
String.format("%n") [2]. This is the cause of the failure.

Since lines in the tests are not supposed to be printed out or observed by human
while testing, I think fixing construction of actual strings is cleaner than
fixing each an every '\n' in the tests.

Thanks,
-Pavel

--------------------------------------------------------------------------------
[1] http://hg.openjdk.java.net/jdk9/dev/jdk/rev/4eff3bde0dc3#l24.52
[2] http://hg.openjdk.java.net/jdk9/dev/jdk/rev/4eff3bde0dc3#l6.275

Claes Redestad | 18 Apr 16:38 2016
Picon

RFR: 8154454: Fix compilation issue in PlainSocketImpl

Hi,

a small omission in JDK-8154238 cause Windows builds to fail. Sorry 
about that, see patch to fix this below (I was 100% certain I had run this
through JPRT last week)

Bug: https://bugs.openjdk.java.net/browse/JDK-8154454

Thanks!

/Claes

diff -r 3459ee432728 
src/java.base/windows/classes/java/net/PlainSocketImpl.java
--- a/src/java.base/windows/classes/java/net/PlainSocketImpl.java  Mon 
Apr 18 14:01:03 2016 +0200
+++ b/src/java.base/windows/classes/java/net/PlainSocketImpl.java  Mon 
Apr 18 16:35:03 2016 +0200
 <at>  <at>  -80,7 +80,7  <at>  <at> 
       * Constructs an instance with the given file descriptor.
       */
      PlainSocketImpl(FileDescriptor fd) {
-        if (useDualStackImpl) {
+        if (!preferIPv4Stack) {
              impl = new DualStackPlainSocketImpl(fd, exclusiveBind);
          } else {
              impl = new TwoStacksPlainSocketImpl(fd, exclusiveBind);

Simone Bordet | 18 Apr 15:59 2016
Picon
Gravatar

ServiceLoader for HTTP/2 and WebSocket clients

Hi,

is there any plan to make the new HTTP/2 and WebSocket client
implementation replaceable via a ServiceLoader mechanism ?

Thanks !

--

-- 
Simone Bordet
http://bordet.blogspot.com
---
Finally, no matter how good the architecture and design are,
to deliver bug-free software with optimal performance and reliability,
the implementation technique must be flawless.   Victoria Livschitz

Simone Bordet | 18 Apr 15:55 2016
Picon
Gravatar

ALPN and HTTP/2 client

Hi,

I am missing where the ALPN negotiation is performed in the new HTTP/2
client code, can you direct me at where this is done ?

The HTTP/2 spec requires to close the connection with
INADEQUATE_SECURITY if the cipher does not meet the HTTP/2
requirements, but I don't see this code ?

SSLEngine.getApplicationProtocol() seems only to be used for debugging ?

Thanks !

--

-- 
Simone Bordet
http://bordet.blogspot.com
---
Finally, no matter how good the architecture and design are,
to deliver bug-free software with optimal performance and reliability,
the implementation technique must be flawless.   Victoria Livschitz

Claes Redestad | 14 Apr 14:49 2016
Picon

RFR: 8154238: Drop code to support Windows XP in windows socket impl

Hi,

more code in the Windows socket implementation that can be dropped

Bug: https://bugs.openjdk.java.net/browse/JDK-8154238
Webrev: http://cr.openjdk.java.net/~redestad/8154238/webrev.01/

Thanks!

/Claes

Claes Redestad | 13 Apr 23:31 2016
Picon

RFR: 8154185: Drop code to support Windows XP in DefaultDatagramSocketImplFactory

Hi,

since we're dropping support for Windows XP in JDK 9, we can simplify 
initialization of DefaultDatagramSocketImplFactory.

Bug: https://bugs.openjdk.java.net/browse/JDK-8154185
Webrev: http://cr.openjdk.java.net/~redestad/8154185/webrev.01/

Thanks!

/Claes

Bernd Eckenfels | 12 Apr 22:27 2016
Picon

[JDK-8016521] IPV6 address selection

Hello,

a while back I brought up the discussion that there is no
preferIPV6=system (or similar) setting which allows to turn off the
reordering of address families by Java. Because only the OS can try to
correctly do target address determinaton.

A Bug was opened and it was excluded from Java 8 - would there be a
window for Java 9, still?

https://bugs.openjdk.java.net/browse/JDK-8016521

Gruss
Bernd

Pavel Rappo | 6 Apr 20:00 2016
Picon

RFR JDK-8153353: HPACK implementation

Hi,

Could you please review my change for JDK-8153353?

http://cr.openjdk.java.net/~prappo/8153353/webrev.00/

This is an implementation of HPACK (Header Compression for HTTP/2) [1]
Internal API classes are (package sun.net.httpclient.hpack):

    Encoder, Decoder and DecodingCallback

Example of their usage can be seen in the RFR for HTTP/2 implementation
published previously today [2, 3].

Thanks,
-Pavel

--------------------------------------------------------------------------------
[1] https://tools.ietf.org/html/rfc7541
[2]
http://cr.openjdk.java.net/~michaelm/8087124/webrev.1/src/java.httpclient/share/classes/java/net/http/Http2Connection.java.html 304:306
[3]
http://cr.openjdk.java.net/~michaelm/8087124/webrev.1/src/java.httpclient/share/classes/java/net/http/Http2Connection.java.html 682:695

Gmane