Michael McMahon | 4 Feb 17:14 2016
Picon

RFR: 8087112 HTTP API and HTTP/1.1 implementation

Hi,

The following webrevs are for the initial implementation of JEP 110.
Most of it is in the jdk repository with some build configuration in the top
level repo for putting this code in its own module (java.httpclient).

http://cr.openjdk.java.net/~michaelm/8087112/01/top/webrev/

http://cr.openjdk.java.net/~michaelm/8087112/01/jdk/webrev/

The HTTP/2 implementation will come later.

Thanks,
Michael.

Martin Buchholz | 28 Jan 03:29 2016
Picon

JDK-8148424 Support ipv6-only environments

Are y'all interested in our ipv6-only changes?
https://bugs.openjdk.java.net/browse/JDK-8148424
If yes, there will be some work on both sides, mostly for
multi-platform testing.

Mark Sheppard | 22 Jan 13:36 2016
Picon

RFR: JDK-8147862 - Null check too late in sun.net.httpserver.ServerImpl

Hi
    please oblige and review the small change
http://cr.openjdk.java.net/~msheppar/8147862/webrev/

to address
https://bugs.openjdk.java.net/browse/JDK-8147862

it was observed that  a null check on a SocketChannel object in
the Disptacher.run() method within ServerImpl, should be
earlier in the call flow.

regards
Mark

Claes Redestad | 21 Jan 18:27 2016
Picon

RFR: 8147962: URL should handle lower-casing of protocol locale-independently

Hi,

using String.toLowerCase() in URL allows some strings to lower-case to a 
string that'd be invalid, e.g. "FILE".toLowerCase() -> "f\u0131le" in 
turkish locales.

This patch suggests using the locale-independent 
String.toLowerCase(Locale.ENGLISH) instead, since only a-z and A-Z are 
legal alphabeticals according to spec.

Webrev: http://cr.openjdk.java.net/~redestad/8147962/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8147962

Thanks!

Claes

Claes Redestad | 17 Jan 16:30 2016
Picon

RFR: 8147462: URI.toURL could be more efficient for most non-opaque URIs

Hi,

please review this patch which might make URI.toURL more efficient

Webrev: http://cr.openjdk.java.net/~redestad/8147462
Bug: https://bugs.openjdk.java.net/browse/JDK-8147462

This patch exploits the fact that URI will apply the same validation to 
the URI/URL specification for any valid non-opaque URL, thus it's safe 
to use the component-based URL constructor. Also, URIs representing 
malformed URLs will throw an exception as specified both before and 
after. A number of simple test cases to capture and document this was 
added to the existing java/net/URI/URItoURL jtreg test.

Microbenchmarks covering various URIs vary from neutral (for opaque) to 
1.5x (for the simplest URIs without query and fragment components), 
while also bringing in a small footprint improvement in jake builds.

While toURL() could arguably construct the URL file as 
path[?query][#fragment], the implementation I tried for this caused 
regressions in micros due to hitting C2 inlining limit.

Thanks!

/Claes

Claes Redestad | 8 Jan 15:41 2016
Picon

RFR: 8146686: Create the schemeSpecificPart for non-opaque URIs lazily

Hi,

please review this patch to lazily create schemeSpecificPart for non-opaque URIs. This change accounts for some improvement in footprint characteristics and a 10-20% improvement on URI creation microbenchmarks, while not regressing notably on a targetted microbenchmark which explicitly generate and retrieve the schemeSpecificPart.

Bug: https://bugs.openjdk.java.net/browse/JDK-8146686
Webrev: http://cr.openjdk.java.net/~redestad/8146686/webrev.01/

Thanks!

/Claes
Brian Burkhalter | 6 Jan 03:22 2016
Picon

RFC on 8146041: java.net.URLConnection.guessContentTypeFromStream() does not recognize TIFF streams

This core-libs-dev RFR

http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-December/037847.html

was already approved on core-libs-dev but I would like to make sure there is no objection from the net-dev community.

Thanks,

Brian
Claes Redestad | 5 Jan 23:47 2016
Picon

RFR: 8146526: Improve java.net.URI$Parser startup characteristics

Hi,

please review this patch to cleanup URI$Parser to help URI construction 
when run with the interpreter, mostly by inlining wrapping methods:

Bug: https://bugs.openjdk.java.net/browse/JDK-8146526

Webrev: http://cr.openjdk.java.net/~redestad/8146526/webrev.01

This is motivated by Jigsaw where URIs might be created unconditionally 
during startup, and this trivial patch is extracted from an experiment 
to address observed inefficiencies in java.net.URI[1]. Around half the 
improvement detailed in [1] can be attributed to this patch, while it 
does not impact compiled code performance.

Thanks!

/Claes

[1]http://cr.openjdk.java.net/~redestad/scratch/URIParserBench.java

Volker Simonis | 5 Jan 18:49 2016
Picon

RFR(XS): 8146482: [TESTBUG] java/net/SocketOption/OptionTest should only use multicast capable interfaces for multicast tests

Hi,

can somebody please review this small test fix:

http://cr.openjdk.java.net/~simonis/webrevs/2016/8146482/
https://bugs.openjdk.java.net/browse/JDK-8146482

The java/net/SocketOption/OptionTest test chooses the first network
interface returned by NetworkInterface.getNetworkInterfaces() for
doing some tests on multicast sockets.

But it may be that the chosen interface does not even support
multicasting. So better iterate over all interfaces and only choose
one if NetworkInterface.supportsMulticast() returns true.

Thanks,
Volker

Felix Yang | 14 Dec 07:53 2015
Picon

RFR 8131155/9, java/net/NetworkInterface/NetworkInterfaceStreamTest.java failed because of Teredo Tunneling Pseudo-Interface

Hi all,
     please review the fix for 
java/net/NetworkInterface/NetworkInterfaceStreamTest.java. It is 
necessary to exclude "Teredo Tunneling Pseudo-Interface" whose 
configuration changes frequently.

Bug: https://bugs.openjdk.java.net/browse/JDK-8131155
Webrev: http://cr.openjdk.java.net/~xiaofeya/8131155/webrev.00

Thanks,
Felix

Artem Smotrakov | 4 Dec 12:41 2015
Picon

[9] RFR: 8138990: Implementation of HTTP Digest authentication may be more flexible

Hello,

Please review this small fix for DigestAuthentication class.

1. Added a check in DigestAuthentication.setNonce(String) that nonce is not null. NPE may happen if a buggy HTTP server returns "WWW-Authenticate" header which doesn't contain a "nonce" field. According to RFCs 2069 [1] and 2617 [2], this is not expected behaviour, but it would be better if an HTTP client threw a checked IOException instead of NPE.

2. Updated DigestAuthentication.setQop(String) method to accept both a whitespace and a comma as a delimiter. RFC 2617 [2] says that "qop" may contain more than one token, but it doesn't specify a delimiter for "qop" field in "WWW-Authenticate" header. There is an example of "WWW-Authenticate" header in RFC 2617 [2] where a comma is used as a delimiter of value in "qop" field.

3. Added a test for Digest authentication.

Bug: https://bugs.openjdk.java.net/browse/JDK-8138990
Webrev: http://cr.openjdk.java.net/~asmotrak/http_auth_digest/webrev.00/

[1] https://tools.ietf.org/html/rfc2069
[2] https://tools.ietf.org/html/rfc2617

Artem

Gmane