Re: IdealGraphVisualizer

Re: IdealGraphVisualizer

Is this based on the improved kenai version?  The text view in that is nice but there seem to be some
interaction bugs that result in exceptions in the event thread that screw up the display.

tom

On Jun 1, 2011, at 10:59 AM, Christian Wimmer wrote:

> Unfortunately, every new version of NetBeans requires a bunch of trivial and a few non-trivial changes to
get a NetBeans-based application running again.
> 
> The good news is, a student at the University Linz - Peter Hofer - is actively working on the visualizer, and
probably already has a version working with NetBeans 7.  I copied him on this mail, hopefully he can help
with this.
> 
> -Christian
> 
> 
> On Tue, May 31, 2011 at 11:13 AM, Tom Rodriguez
<tom.rodriguez@...> wrote:
> IGV is based on an older version of netbeans, 6.5.1 I think. 
http://netbeans.org/downloads/6.5.1/index.html.  It could probably be forward ported to 7 but that
would require more knowledge than I have.
> 
> tom
> 
> On May 31, 2011, at 9:53 AM, Mikael Vidstedt wrote:
> 
> >
> > IdealGraphVisualizer gurus,
> >
> > I’m trying to build the latest greatest version of the project in Netbeans (7.0) but my success rate is
so far limited. The build terminates with the following error:
> >
> > com.sun.hotspot.igv.filter.compile:
> > Compiling 12 source files to D:\hg\hotspot\tst\hotspot-comp\src\share\tools\IdealGraphVisualizer\Filter\build\classes
> > Note: Attempting to workaround 6512707
> >
D:\hg\hotspot\tst\hotspot-comp\src\share\tools\IdealGraphVisualizer\Filter\src\com\sun\hotspot\igv\filter\CustomFilter.java:81:
cannot access org.netbeans.api.actions.Openable
> > class file for org.netbeans.api.actions.Openable not found
> >         return new OpenCookie() {
> > C:\Program Files\NetBeans 7.0\harness\suite.xml:182: The following error occurred while
executing this line:
> > C:\Program Files\NetBeans 7.0\harness\common.xml:206: Compile failed; see the compiler error
output for details.
> >
> > Anybody seen this problem before?
> >
> > Thanks,
> > Mikael
> 
> 

review request (URGENT): 7049415: Failure of resolution of sym.reference to the c.s.s. should be wrapped in BootstrapMethodError

Low-level fix to ensure wrapping of early linkage errors in bootstrap method errors, for invokedynamic
corner cases.

7049415: Failure of resolution of sym.reference to the c.s.s. should be wrapped in BootstrapMethodError
JVM Summary: Delegate invokedynamic linkage errors to MethodHandleNatives.raiseException.
JDK Summary: Wrap invokedynamic linkage errors in BootstrapMethodError, as needed.

http://cr.openjdk.java.net/~jrose/7049415/webrev.jvm.00
http://cr.openjdk.java.net/~jrose/7049415/webrev.jdk.00

These changes can integrate in any order.  To fix the bug, both must be integrated.

Test case attached.  All paths have been exercised.

-- John

Re: review request (URGENT): 7049415: Failure of resolution of sym.reference to the c.s.s. should be wrapped in BootstrapMethodError

Looks ok.

tom

On Jun 1, 2011, at 11:44 AM, John Rose wrote:

> Low-level fix to ensure wrapping of early linkage errors in bootstrap method errors, for invokedynamic
corner cases.
> 
> 7049415: Failure of resolution of sym.reference to the c.s.s. should be wrapped in BootstrapMethodError
> JVM Summary: Delegate invokedynamic linkage errors to MethodHandleNatives.raiseException.
> JDK Summary: Wrap invokedynamic linkage errors in BootstrapMethodError, as needed.
> 
> http://cr.openjdk.java.net/~jrose/7049415/webrev.jvm.00
> http://cr.openjdk.java.net/~jrose/7049415/webrev.jdk.00
> 
> These changes can integrate in any order.  To fix the bug, both must be integrated.
> 
> Test case attached.  All paths have been exercised.
> 
> -- John
> 
> <Test7049415.java>

Re: review request (URGENT): 7049415: Failure of resolution of sym.reference to the c.s.s. should be wrapped in BootstrapMethodError

Thanks, Tom.

On Jun 1, 2011, at 11:50 AM, Tom Rodriguez wrote:

> Looks ok.

Re: IdealGraphVisualizer

Request for reviews (S): 7044738: Loop unroll optimization causes incorrect result

For next release, too risky for jdk7.

http://cr.openjdk.java.net/~kvn/7044738/webrev

Fixed 7044738: Loop unroll optimization causes incorrect result

It is rare case when OSR compilation is done for nested loop which prevents 
ciTypeFlow to clone loop's head. As result the control node of loop's nodes is 
loop's back control. During loop iterations split clone_up_backedge_goo() 
creates clones for nodes which are pinned to loop's back control and it does not 
take into account memory dependencies by creating duplicated clones.

Added regression test. Tested with full CTW.

review request (URGENT): 7050328: (jsr-292) findConstructor throws ExceptionInInitializerError if run under SecurityManager

Summary: Wrap system property and reflection accesses under doPrivileged.  Ensure constant pool linkage
bypasses the SM as specified.

http://cr.openjdk.java.net/~jrose/7050328/webrev.00  (jdk changes only; no jvm changes)

Testing:
- Passes jtreg unit tests for java.lang.invoke and ad hoc mlvm tests.
- Newly modified unit test spot-tests APIs with a toxic security manager, to ensure that the specified
security exceptions are thrown.
- Passes test reported in 7050328.
- No regression on related bug 7042829.

Note to reviewers:  Please confirm that the duplicated or moved code lines are accurate duplicates.

The change to the unit test shows how I verified the places that needed change.  These places were
independently found by grepping.

-- John

Re: review request (URGENT): 7050328: (jsr-292) findConstructor throws ExceptionInInitializerError if run under SecurityManager

Looks good to me.

Vladimir

John Rose wrote:
> Summary: Wrap system property and reflection accesses under doPrivileged.  Ensure constant pool
linkage bypasses the SM as specified.
> 
> http://cr.openjdk.java.net/~jrose/7050328/webrev.00  (jdk changes only; no jvm changes)
> 
> Testing:
> - Passes jtreg unit tests for java.lang.invoke and ad hoc mlvm tests.
> - Newly modified unit test spot-tests APIs with a toxic security manager, to ensure that the specified
security exceptions are thrown.
> - Passes test reported in 7050328.
> - No regression on related bug 7042829.
> 
> Note to reviewers:  Please confirm that the duplicated or moved code lines are accurate duplicates.
> 
> The change to the unit test shows how I verified the places that needed change.  These places were
independently found by grepping.
> 
> -- John

Re: review request (URGENT): 7050328: (jsr-292) findConstructor throws ExceptionInInitializerError if run under SecurityManager

Thanks, Vladimir.  -- John

On Jun 1, 2011, at 1:56 PM, Vladimir Kozlov wrote:

> Looks good to me.