headers
Jonathan Lu | 1 Feb 03:28
Picon

Re: POSIX compatibility change for including wait.h in UNIXProcess_md.c

On 01/31/2012 06:40 PM, Neil Richards wrote:
> On Thu, 2012-01-26 at 17:45 +0800, Jonathan Lu wrote:
>>
>>
>>          I think we forgot to create a bug for this, I've created it
>>          now:
>>
>>          7133301: (process) UNIXProcess_md.c should include sys/wait.h
>>          rather than wait.h
>>
>> Thanks a lot, Alan!
>>
>>
>>          I don't mind pushing it for you but maybe this is something
>>          that Neil wants to do?
>>
>>
>> Hi Neil, could you please help to push it?
>>
>>
>>          -Alan
>>
>> Cheers!
>> - Jonathan
>>
> Hi Johnathan,
> I've now pushed this change [1].
>
> Thanks, Alan, for doing the review.
>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Joe Darcy | 1 Feb 07:24
Picon
Favicon

Re: JDK 8 code review request for 7140820 Add covariant overrides to Collections clone methods

Hello,

Follow-up below...

On 01/30/2012 09:10 AM, Joe Darcy wrote:
> On 01/29/2012 10:52 PM, Rémi Forax wrote:
>> On 01/30/2012 04:58 AM, Joe Darcy wrote:
>>> Hello,
>>>
>>> As an indirect outgrowth of warnings cleanup day, various categories 
>>> of warnings can be eliminated by in the use of Cloneable types by 
>>> overriding the
>>>
>>>     Object clone()
>>>
>>> method inherited from java.lang.Object with a covariant override 
>>> such as
>>>
>>>     MyType clone()
>>>
>>> Please review my changes for
>>>
>>>     7140820 Add covariant overrides to Collections clone methods
>>>     http://cr.openjdk.java.net/~darcy/7140820.0/
>>>
>>> which add such covariant override clone methods to collections and a 
>>> few other classes in java.util.  Doing a full JDK build with these 
>>> changes, I've also made alterations to other classes to remove now 
>>> superfuous casts (casts which are a javac lint warning!) and some 
>>> unneeded @SuppressWarnings annotations.  I also cleaned up a few
(Continue reading)

Permalink | Reply | 0 comments |
headers
Kumar Srinivasan | 1 Feb 22:37
Picon
Favicon

Review request : 7141141 Add 3 new test scenarios for testing Main-Class attribute in jar manifest file

Hi,

Here are some improvements to the launcher tests, contributed by Sonali
Goel of the SQE team, please review:

http://cr.openjdk.java.net/~ksrini/7141141/webrev.0/

The CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7141141

Thanks
Kumar
Permalink | Reply | 4 comments |
headers
Joseph Darcy | 2 Feb 01:46
Picon
Favicon

Re: Review request : 7141141 Add 3 new test scenarios for testing Main-Class attribute in jar manifest file

Hello,

On 2/1/2012 1:37 PM, Kumar Srinivasan wrote:
> Hi,
>
> Here are some improvements to the launcher tests, contributed by Sonali
> Goel of the SQE team, please review:
>
> http://cr.openjdk.java.net/~ksrini/7141141/webrev.0/
>
> The CR:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7141141
>
> Thanks
> Kumar
>

A few stylistic comments:

29  * @compile -XDignore.symbol.file MainClassAttributeTest.java

It might suffice to use @build instead of @compile.

   43  * only English is seleced and will pass vacuosly for other locales.
   44  *
   45  */

Extra line.

   98     public static void main(String[] args) throws Throwable {
(Continue reading)

Permalink | Reply | 3 comments |
headers
David Schlosnagle | 2 Feb 02:48
Picon

Re: Review request : 7141141 Add 3 new test scenarios for testing Main-Class attribute in jar manifest file

On Wed, Feb 1, 2012 at 7:46 PM, Joseph Darcy <joe.darcy@...> wrote:
>  43  * only English is seleced and will pass vacuosly for other locales.

Pedantic I know, but can you correct the two spelling mistakes in
MainClassAttributeTest.java?

s/seleced/selected/
s/vacuosly/vacuously/

 43  * only English is seleced and will pass vacuosly for other locales.
                           ^^                    ^^
Thanks,
Dave
Permalink | Reply | 0 comments |
headers
Kumar Srinivasan | 2 Feb 04:47
Picon
Favicon

Re: Review request : 7141141 Add 3 new test scenarios for testing Main-Class attribute in jar manifest file

Hi Joe, David,

Thanks for the feedback, here is the modified delta webrev:
http://cr.openjdk.java.net/~ksrini/7141141/webrev.1/webrev.delta/index.html

Changes are:
* Eliminated typos and fixed the comments
* Replaced @compile with @build
* Replaced Throwable with IOException this makes it consistent.

Thanks
Kumar

> Hello,
>
> On 2/1/2012 1:37 PM, Kumar Srinivasan wrote:
>> Hi,
>>
>> Here are some improvements to the launcher tests, contributed by Sonali
>> Goel of the SQE team, please review:
>>
>> http://cr.openjdk.java.net/~ksrini/7141141/webrev.0/
>>
>> The CR:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7141141
>>
>> Thanks
>> Kumar
>>
>
(Continue reading)

Permalink | Reply | 1 comment |
headers
Joe Darcy | 2 Feb 20:26
Picon
Favicon

Re: Review request : 7141141 Add 3 new test scenarios for testing Main-Class attribute in jar manifest file

Looks fine,

-Joe

On 2/1/2012 7:47 PM, Kumar Srinivasan wrote:
> Hi Joe, David,
>
> Thanks for the feedback, here is the modified delta webrev:
> http://cr.openjdk.java.net/~ksrini/7141141/webrev.1/webrev.delta/index.html 
>
>
> Changes are:
> * Eliminated typos and fixed the comments
> * Replaced @compile with @build
> * Replaced Throwable with IOException this makes it consistent.
>
> Thanks
> Kumar
>
>
>> Hello,
>>
>> On 2/1/2012 1:37 PM, Kumar Srinivasan wrote:
>>> Hi,
>>>
>>> Here are some improvements to the launcher tests, contributed by Sonali
>>> Goel of the SQE team, please review:
>>>
>>> http://cr.openjdk.java.net/~ksrini/7141141/webrev.0/
>>>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Roger Riggs | 2 Feb 21:15
Picon
Favicon

Need reviewer: JDK 8 CR for Support Integer overflow

There is a need for arithmetic operations that throw exceptions
when the results overflow the representation of int or long.

The CR is 6708398: Support integer overflow 
<http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6708398>

Please review this webrev 
<http://cr.openjdk.java.net/%7Erriggs/CR6708398/webrev/> to add static 
methods in java.lang.Math
to support addExact(), subtractExact(), negateExact(), multiplyExact(),
and toIntExact() for int and long primitive types.

Thanks, Roger Riggs
Permalink | Reply | 22 comments |
headers
Florian Weimer | 3 Feb 09:11
Picon

Re: Need reviewer: JDK 8 CR for Support Integer overflow

* Roger Riggs:

> to support addExact(), subtractExact(), negateExact(), multiplyExact(),
> and toIntExact() for int and long primitive types.

Would it make sense to replace (x ^ r) < 0 && (x ^ y) >= 0
in

+    public static int addExact(int x, int y) {
+        int r = x + y;
+        if ((x ^ r) < 0 && (x ^ y) >= 0) {
+            throw new ArithmeticException("Addition overflows an int");
+        }
+        return r;
+    }

with (x ^ y ^ r) < 0?

For substraction, you could use ((x ^ r) & (x ^ y)) < 0.

Will Hotspot be able to optimize away the string construction on the
exception path in multiplyExact() if the exception is caught locally?

--

-- 
Florian Weimer                <fweimer@...>
BFK edv-consulting GmbH       http://www.bfk.de/
Kriegsstraße 100              tel: +49-721-96201-1
D-76133 Karlsruhe             fax: +49-721-96201-99
(Continue reading)

Permalink | Reply | 10 comments |
headers
Krystal Mok | 3 Feb 09:38
Picon
Gravatar

Re: Need reviewer: JDK 8 CR for Support Integer overflow

Hi Florian,

On Fri, Feb 3, 2012 at 4:11 PM, Florian Weimer <fweimer@...> wrote:

> Will Hotspot be able to optimize away the string construction on the
> exception path in multiplyExact() if the exception is caught locally?
>
> At least -XX:+OptimizeStringConcat should remove the need to construct a
StringBuilder instance, in multiplyExact()'s case.

Cc'ing hotspot-compiler-dev for confirmation.

- Kris
Permalink | Reply | 3 comments |

Gmane