8 Dec 2008 15:47
8 Dec 2008 16:10
Re: [PATCH] Cleanup AWT peer interfaces
Hi Andrei, > did you already send updated patch for peer's documentation? > I'd love to review it again. :) No I didn't. Actually I was caught up in some other project, then did some stuff in OpenJDK, found that the hotspot build is broken on my (Ubuntu) machine (this is notorious: everytime I update my repos, the hotspot build becomes broken...), gave up and went back to other projects. I will send something for you to review soon/Roman -- -- Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-48 USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe Geschäftsführer: Dr. James J. Hunt
9 Dec 2008 12:39
Re: [PATCH] Cleanup AWT peer interfaces
Hi Andrei,
Finally I came around to fix the suggested stuff. See comments inline.
> 1) src/share/classes/java/awt/peer/CheckboxMenuItemPeer.java
>
> +import java.awt.CheckboxMenuItem;
> if that's really needed? I thought that { <at> link ...} doesn't require such
> stuff.
I don't know. If you fully qualify the stuff in the { <at> link } it's not
needed. Should I fully-qualify things everywhere or let the import in
place? I don't care really.
> 2) src/share/classes/java/awt/peer/ContainerPeer.java
> There is a typo in the second word:
> - * Indicates availabiltity of restacking operation in this container.
> + * Indicates availability of restacking operation in this container.
Fixed.
> 3) Common thing.
> <code>true</code> have a shorter synonym since JDK 5: { <at> code true}
Fixed.
> 4) src/share/classes/java/awt/peer/RobotPeer.java
> I noticed that you prefer not to leave "public" modifier in an
> interface. But here you are leaving all of them.
(Continue reading)
15 Dec 2008 15:31
Re: [PATCH] Cleanup AWT peer interfaces
Hi Roman,
Cool! I'm comfortable with this fix now.
We still need second approve vote to push this change in.
Artem...? Others? ;)
Thanks,
Andrei
Roman Kennke wrote:
> Hi Andrei,
>
> Finally I came around to fix the suggested stuff. See comments inline.
>
>> 1) src/share/classes/java/awt/peer/CheckboxMenuItemPeer.java
>>
>> +import java.awt.CheckboxMenuItem;
>> if that's really needed? I thought that { <at> link ...} doesn't require such
>> stuff.
>
> I don't know. If you fully qualify the stuff in the { <at> link } it's not
> needed. Should I fully-qualify things everywhere or let the import in
> place? I don't care really.
>
>
>> 2) src/share/classes/java/awt/peer/ContainerPeer.java
>> There is a typo in the second word:
>> - * Indicates availabiltity of restacking operation in this container.
>> + * Indicates availability of restacking operation in this container.
(Continue reading)
19 Dec 2008 14:06
hg: jdk7/awt/jdk: 6773985: OutOfMemory (PermGen space) under Linux / Firefox when switching bw. applets
Changeset: d5bf2dd61ed5 Author: art Date: 2008-12-19 16:04 +0300 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/d5bf2dd61ed5 6773985: OutOfMemory (PermGen space) under Linux / Firefox when switching bw. applets Summary: XEmbedClientHelper is uninstalled when its embedded frame is disposed. Reviewed-by: dcherepanov, ant ! src/solaris/classes/sun/awt/X11/XEmbedClientHelper.java ! src/solaris/classes/sun/awt/X11/XEmbeddedFramePeer.java
23 Dec 2008 09:56
Re: [PATCH] Cleanup AWT peer interfaces
Andrei V. Dmitriev wrote:
> Hi Roman,
>
> Cool! I'm comfortable with this fix now.
>
> We still need second approve vote to push this change in.
> Artem...? Others? ;)
Well, I'm fine with the proposed changes in general. Still, some JavaDoc
comments looks to be too implementation-specific. For example, most of
Container's methods contain a statement like this:
This is called from { <at> link ...}, before/after ...
and they really called from the specified places, however this may not
be true in future. I'd remove all these statements from JavaDoc, leaving
only behavioral description.
Thanks,
Artem
> Thanks,
> Andrei
>
> Roman Kennke wrote:
>> Hi Andrei,
>>
>> Finally I came around to fix the suggested stuff. See comments inline.
(Continue reading)
29 Dec 2008 11:27
Re: [PATCH] Cleanup AWT peer interfaces
Hi Artem,
> > Cool! I'm comfortable with this fix now.
> >
> > We still need second approve vote to push this change in.
> > Artem...? Others? ;)
>
> Well, I'm fine with the proposed changes in general. Still, some JavaDoc
> comments looks to be too implementation-specific. For example, most of
> Container's methods contain a statement like this:
>
> This is called from { <at> link ...}, before/after ...
>
> and they really called from the specified places, however this may not
> be true in future. I'd remove all these statements from JavaDoc, leaving
> only behavioral description.
Yeah, you are right. I put these in because I found it very useful while
implementing the peers to see exactly where and when it is called. I
removed those comments and only let the <at> see references in there. The
updated webrev is here:
http://kennke.org/~roman/docpeers/webrev/
Ok now?
Cheers, Roman
>
> Thanks,
(Continue reading)
RSS Feed