headers
Stefan Birkner (JIRA | 1 Jun 2011 09:34

[jira] Created: (MOJO-1681) [jslint-plugin] improve readability of the code

[jslint-plugin] improve readability of the code
-----------------------------------------------

                 Key: MOJO-1681
                 URL: http://jira.codehaus.org/browse/MOJO-1681
             Project: Mojo
          Issue Type: Task
            Reporter: Stefan Birkner
            Priority: Minor
         Attachments: readability.patch

There are some issues, which makes it difficult to read the code.
* The enum Scope is only clutter.
* There's one big method doExecute, which does all the work.

I removed the enum and renamed doExecute to checkFolder. According to the guidelines of clean code,
checkFolder has been splitted into checkFolderForIssues, reportIssues and optionallyFailForIssues.

--

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email
(Continue reading)

Permalink | Reply | 1 comment |
headers
Salvador Diaz (JIRA | 1 Jun 2011 10:05

[jira] Commented: (MGWT-284) Goal "gwt:eclipse" generates buggy launch configuration


    [
http://jira.codehaus.org/browse/MGWT-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=269244#action_269244
] 

Salvador Diaz commented on MGWT-284:
------------------------------------

I just checked the project layout generated by the 2.3.0 SDK and the host page really is outside the module
folder. I have the fix in a local branch, should I just push it ?

> Goal "gwt:eclipse" generates buggy launch configuration 
> --------------------------------------------------------
>
>                 Key: MGWT-284
>                 URL: http://jira.codehaus.org/browse/MGWT-284
>             Project: Maven 2.x GWT Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2.0
>         Environment: See text below.
>            Reporter: hp gisler
>            Assignee: nicolas de loof
>
> Environment:
> GWT Plugin Version: 2.2
> Eclipse: Helios
> Platform: Win xp
> Using non standard GWT directory structure. Instead using default maven structure as is generated by
archetype 
> mvn archetype:generate \
(Continue reading)

Permalink | Reply | 0 comments |
headers
nicolas de loof (JIRA | 1 Jun 2011 10:39

[jira] Commented: (MGWT-284) Goal "gwt:eclipse" generates buggy launch configuration


    [
http://jira.codehaus.org/browse/MGWT-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=269251#action_269251
] 

nicolas de loof commented on MGWT-284:
--------------------------------------

please do

> Goal "gwt:eclipse" generates buggy launch configuration 
> --------------------------------------------------------
>
>                 Key: MGWT-284
>                 URL: http://jira.codehaus.org/browse/MGWT-284
>             Project: Maven 2.x GWT Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2.0
>         Environment: See text below.
>            Reporter: hp gisler
>            Assignee: nicolas de loof
>
> Environment:
> GWT Plugin Version: 2.2
> Eclipse: Helios
> Platform: Win xp
> Using non standard GWT directory structure. Instead using default maven structure as is generated by
archetype 
> mvn archetype:generate \
>    -DarchetypeRepository=repo1.maven.org \
(Continue reading)

Permalink | Reply | 0 comments |
headers
jieryn (JIRA | 1 Jun 2011 15:34

[jira] Commented: (MGWT-285) Filtered resource files are not used to create generated sources


    [
http://jira.codehaus.org/browse/MGWT-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=269272#action_269272
] 

jieryn commented on MGWT-285:
-----------------------------

+1 month and this problem is still hitting a lot of users. The intricacies of Maven classpath munging are
beyond my abilities.. what can I do to help this problem get resolved?

I really want this to be resolved because I maintain lots of .gwt.xml files which are twinned for production
and development modes (e.g. setting GWT j.u.logging to different levels) and it would be nice to simply
reference a variable in my exploiting project's .gwt.xml for the <inherits
name="com.acme.base.gwt.Logging-${env}"/> where ${env} is set by default for production and
overridden via profile for development.

> Filtered resource files are not used to create generated sources
> ----------------------------------------------------------------
>
>                 Key: MGWT-285
>                 URL: http://jira.codehaus.org/browse/MGWT-285
>             Project: Maven 2.x GWT Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1.0-1, 2.2.0
>            Reporter: Benjamin Peter
>         Attachments: MGWT-285.zip
>
>
> Hello,
(Continue reading)

Permalink | Reply | 0 comments |
headers
jieryn (JIRA | 1 Jun 2011 15:37

http://mojo.codehaus.org/gwt-maven-plugin/index.html


    [
http://jira.codehaus.org/browse/MGWT-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=269273#action_269273
] 

jieryn commented on MGWT-276:
-----------------------------

This site now references v2.3.0-SNAPSHOT. Please close this issue, thanks.

> gwt-maven-plugin 2.2.0 : Update documentation at
http://mojo.codehaus.org/gwt-maven-plugin/index.html 
> ------------------------------------------------------------------------------------------------------
>
>                 Key: MGWT-276
>                 URL: http://jira.codehaus.org/browse/MGWT-276
>             Project: Maven 2.x GWT Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1.0-1, 2.2.0
>            Reporter: reda abdi
>            Priority: Trivial
>
> Hi,
> The documentation of gwt-maven plugin 2.1.0-1 at
http://mojo.codehaus.org/gwt-maven-plugin/index.html should be updated because gwt-maven plugin
2.1.0-1 is broken with GWT 2.2.0 and it is impossible to create successfully a project using
GWT-maven-plugin archetype with gwt 2.2 under Eclipse.
> Original thread created here http://stackoverflow.com/questions/5248088/unable-to-create-successfully-a-project-using-gwt-maven-plugin-with-gwt-2-2
> Best regards
> Reda
(Continue reading)

Permalink | Reply | 0 comments |
headers
jieryn (JIRA | 1 Jun 2011 15:42

[jira] Commented: (MGWT-93) Serialization policy was not found


    [
http://jira.codehaus.org/browse/MGWT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=269274#action_269274
] 

jieryn commented on MGWT-93:
----------------------------

This is probably not a valid bug, and it's over a year old ... please recreate with a current version or close
the defect.

> Serialization policy was not found
> ----------------------------------
>
>                 Key: MGWT-93
>                 URL: http://jira.codehaus.org/browse/MGWT-93
>             Project: Maven 2.x GWT Plugin
>          Issue Type: Bug
>    Affects Versions: 1.1
>         Environment: Windows XP
> GWT 1.5
>            Reporter: Zaccret
>             Fix For: 2.2.1
>
>         Attachments: gmaven-test.zip
>
>
> Hi,
> I cannot launch a GWT app in hosted mode with the gwt:run goal. I get a serialization error :
> [INFO] StandardContext[]ERROR: The serialization policy file
(Continue reading)

Permalink | Reply | 0 comments |
headers
nicolas de loof (JIRA | 1 Jun 2011 15:45

[jira] Commented: (MGWT-285) Filtered resource files are not used to create generated sources


    [
http://jira.codehaus.org/browse/MGWT-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=269275#action_269275
] 

nicolas de loof commented on MGWT-285:
--------------------------------------

As generate-source phase occurs prior to resource filtering I can't see a simple solution at plugin level.

I'd suggest that you package your bundles in another artefact and use them as project dependency.

> Filtered resource files are not used to create generated sources
> ----------------------------------------------------------------
>
>                 Key: MGWT-285
>                 URL: http://jira.codehaus.org/browse/MGWT-285
>             Project: Maven 2.x GWT Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1.0-1, 2.2.0
>            Reporter: Benjamin Peter
>         Attachments: MGWT-285.zip
>
>
> Hello,
> when I use filtered resources for messages or constant files in my maven gwt project it seems like the
original source .properties files are used instead of the filtered ones from the target directory.
> As far as I can see it, I have the same problem as MGWT-216 which seems to be closed. But it does not work for me
in 2.1.0-1 or 2.2.0.
> Example:
(Continue reading)

Permalink | Reply | 0 comments |
headers
jieryn (JIRA | 1 Jun 2011 15:51

[jira] Commented: (MGWT-285) Filtered resource files are not used to create generated sources


    [
http://jira.codehaus.org/browse/MGWT-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=269277#action_269277
] 

jieryn commented on MGWT-285:
-----------------------------

gwt:compile runs at prepare-package phase which is long after the process-resources phase.

> Filtered resource files are not used to create generated sources
> ----------------------------------------------------------------
>
>                 Key: MGWT-285
>                 URL: http://jira.codehaus.org/browse/MGWT-285
>             Project: Maven 2.x GWT Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1.0-1, 2.2.0
>            Reporter: Benjamin Peter
>         Attachments: MGWT-285.zip
>
>
> Hello,
> when I use filtered resources for messages or constant files in my maven gwt project it seems like the
original source .properties files are used instead of the filtered ones from the target directory.
> As far as I can see it, I have the same problem as MGWT-216 which seems to be closed. But it does not work for me
in 2.1.0-1 or 2.2.0.
> Example:
> Following command is executed by the maven gwt plugin:
> /usr/lib/jvm/java-6-sun-1.6.0.22/jre/bin/java -Xmx512m -classpath
(Continue reading)

Permalink | Reply | 0 comments |
headers
Robert Munteanu (JIRA | 1 Jun 2011 16:06

[jira] Commented: (MGWT-93) Serialization policy was not found


    [
http://jira.codehaus.org/browse/MGWT-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=269278#action_269278
] 

Robert Munteanu commented on MGWT-93:
-------------------------------------

Have you tried reproducing it? I have been hit by it until I moved to IsSerializable exclusively.

> Serialization policy was not found
> ----------------------------------
>
>                 Key: MGWT-93
>                 URL: http://jira.codehaus.org/browse/MGWT-93
>             Project: Maven 2.x GWT Plugin
>          Issue Type: Bug
>    Affects Versions: 1.1
>         Environment: Windows XP
> GWT 1.5
>            Reporter: Zaccret
>             Fix For: 2.2.1
>
>         Attachments: gmaven-test.zip
>
>
> Hi,
> I cannot launch a GWT app in hosted mode with the gwt:run goal. I get a serialization error :
> [INFO] StandardContext[]ERROR: The serialization policy file
'/test.GMavenTest/3D8C9ED7A7ACB57FC755C1283A84575C.gwt.rpc' was not found; did you forget to
(Continue reading)

Permalink | Reply | 0 comments |
headers
Edward Staub (JIRA | 1 Jun 2011 18:25

[jira] Updated: (MCOBERTURA-146) Process all the source roots


     [
http://jira.codehaus.org/browse/MCOBERTURA-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward Staub updated MCOBERTURA-146:
------------------------------------

    Comment: was deleted

(was: Not sure whether this is new info or not... 

In my case, at least, the normal src/test/java test source root is not being included in the source roots.

Perversely, a generated-source test-source root added via
build-helper-maven-plugin.add-test-source, IS being included.  Because exclude isn't working
([MCOBERTURA-52|http://jira.codehaus.org/browse/MCOBERTURA-52]), I can't get rid of it (which is
what I want).  Because it's dependent on the src/test/java code, I can't compile for instrumentation.  )

> Process all the source roots
> ----------------------------
>
>                 Key: MCOBERTURA-146
>                 URL: http://jira.codehaus.org/browse/MCOBERTURA-146
>             Project: Maven 2.x Cobertura Plugin
>          Issue Type: Bug
>    Affects Versions: 2.5
>            Reporter: Benson Margulies
>
> MCOBERTURA-87 amounts to a report that the plugin does not pay attention to all the source roots. It should.
(Continue reading)

Permalink | Reply | 0 comments |

Gmane