Tim Carpenter (JIRA | 1 Apr 2010 08:03

[jira] Created: (MOJO-1517) XML plugin transform fails when XSL imports from grandparent directories

XML plugin transform fails when XSL imports from grandparent directories
------------------------------------------------------------------------

                 Key: MOJO-1517
                 URL: http://jira.codehaus.org/browse/MOJO-1517
             Project: Mojo
          Issue Type: Bug
            Reporter: Tim Carpenter

If my XSL file has something like

<xsl:stylesheet>
    <xsl:import href="../../somefile.xsl"/>

    <xsl:template ...>
    </xsl:template>
</xsl:stylesheet>

then the plugin throws an exception (the exception is really caused by classworlds) and the
transformation fail

java.lang.StringIndexOutOfBoundsException: String index out of range: -1
	at java.lang.String.substring(String.java:1937)
	at org.codehaus.classworlds.UrlUtils.normalizeUrlPath(UrlUtils.java:28)
	at org.codehaus.classworlds.DefaultClassRealm.getResource(DefaultClassRealm.java:284)
	at org.codehaus.classworlds.DefaultClassRealm.getResource(DefaultClassRealm.java:314)
	at org.codehaus.classworlds.RealmClassLoader.getResource(RealmClassLoader.java:237)
	at org.codehaus.mojo.xml.Resolver.resolveAsResource(Resolver.java:209)
	at org.codehaus.mojo.xml.Resolver.resolve(Resolver.java:280)
	at org.codehaus.mojo.xml.Resolver.resolve(Resolver.java:112)
(Continue reading)

Erik Schepers (JIRA | 1 Apr 2010 08:53

[jira] Commented: (MVERSIONS-102) Add parameter to report on transitive dependencies, to display-dependency-updates goal


    [
http://jira.codehaus.org/browse/MVERSIONS-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=216318#action_216318
] 

Erik Schepers commented on MVERSIONS-102:
-----------------------------------------

I'm not sure if anyone would use this plugin if they have unresolvable dependencies (being them transitive
or direct). If so, than this patch imposes a problem indeed, and it maybe better to create a separate goal.
However, if you make it a new goal, than the plugin has two goals, that do almost the same.

It would be better to try to resolve the dependencies only when the transitive-flag is true. However, I
don't know how to do that (I've tried, but the only way I can get it to work is by adding the
 <at> requiresDependencyResolution tag... If you have any hints or ideas, I'm willing to spend some more
effort on it.

On the other issue, yes you're right that upgrading transitives could break things, but with this feature
I'm not upgrading, but only getting the notification of a newer version.

Our usecase for this feature is that we use it during the release of our products. Typically, we want to use
the latest versions of all dependencies, unless there is a specific reason not to. The reason is that, we
have a lot of applications (~100), that are developed in parallel and somewhat independentlt, but in the
end, need to execute in the same execution environment. This means we only want to deploy one version of
each application. We use version-ranges for most of our dependencies (so we do get automatic upgrades to
some extent), but we want some kind of notification, when newer versions (outside the version-range) are
available for all (including transitive) dependencies, to help us deploy a consistent set of
applications in the end.

> Add parameter to report on transitive dependencies, to display-dependency-updates goal
(Continue reading)

Jochen Wiedmann (JIRA | 1 Apr 2010 09:17

[jira] Updated: (MOJO-1517) XML plugin transform fails when XSL imports from grandparent directories


     [
http://jira.codehaus.org/browse/MOJO-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jochen Wiedmann updated MOJO-1517:
----------------------------------

    Assignee: Jochen Wiedmann

> XML plugin transform fails when XSL imports from grandparent directories
> ------------------------------------------------------------------------
>
>                 Key: MOJO-1517
>                 URL: http://jira.codehaus.org/browse/MOJO-1517
>             Project: Mojo
>          Issue Type: Bug
>            Reporter: Tim Carpenter
>            Assignee: Jochen Wiedmann
>
> If my XSL file has something like
> <xsl:stylesheet>
>     <xsl:import href="../../somefile.xsl"/>
>     <xsl:template ...>
>     </xsl:template>
> </xsl:stylesheet>
> then the plugin throws an exception (the exception is really caused by classworlds) and the
transformation fail
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> 	at java.lang.String.substring(String.java:1937)
> 	at org.codehaus.classworlds.UrlUtils.normalizeUrlPath(UrlUtils.java:28)
(Continue reading)

Dennis Lundberg (JIRA | 1 Apr 2010 10:32

[jira] Updated: (MWEBSTART-120) jnlp-download-servlet goal creates incorrect jar entries in jnlp file for jarResources marked with outputJarVersion=false


     [
http://jira.codehaus.org/browse/MWEBSTART-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MWEBSTART-120:
--------------------------------------

    Description: 
In my project, I am using the jnlp-download-servlet goal. Since I am deploying snapshots that change
frequently, I do not want jar versions to be output in the generated jnlp file. So I use
<outputJarVersion>false</outputJarVersion> for every jarResource.

The generated jnlp file does not contain any version attributes (correct), but the href attributes for the
jar files do not include the version numbers (wrong).

As a workaround, I tried to use a custom hrefValue tag for the jarResource, but the jnlp-download-servlet
goal overwrites any custom values.

  was:
In my project, I am using the jnlp-download-servlet goal. Since I am deploying snapshots that change
frequently, I do not want jar versions to be output in the generated jnlp file. So I use
<outputJarVersion>false</outputJarVersion> for every jarResource.

The generated jnlp file does not contain and version attributes (correct), but the hrefs for the jar files
do not include the version numbers in their href attributes (wrong).

As a workaround, I tried to use a custom hrefValue tag for the jarResource, but the jnlp-download-servlet
goal overwrites any custom values.

> jnlp-download-servlet goal creates incorrect jar entries in jnlp file for jarResources marked with outputJarVersion=false
(Continue reading)

Dennis Lundberg (JIRA | 1 Apr 2010 10:34

[jira] Reopened: (MWEBSTART-120) jnlp-download-servlet goal creates incorrect jar entries in jnlp file for jarResources marked with outputJarVersion=false


     [
http://jira.codehaus.org/browse/MWEBSTART-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg reopened MWEBSTART-120:
---------------------------------------

There is still a problem with this.

> jnlp-download-servlet goal creates incorrect jar entries in jnlp file for jarResources marked with outputJarVersion=false
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MWEBSTART-120
>                 URL: http://jira.codehaus.org/browse/MWEBSTART-120
>             Project: Maven 2.x Webstart Plugin
>          Issue Type: Bug
>          Components: jnlp-download-servlet
>    Affects Versions: 1.0-alpha-2
>         Environment: Linux, JDK 1.5, Maven 2.0.9
>            Reporter: Johannes Martin
>            Assignee: Dennis Lundberg
>             Fix For: 1.0-alpha-3
>
>
> In my project, I am using the jnlp-download-servlet goal. Since I am deploying snapshots that change
frequently, I do not want jar versions to be output in the generated jnlp file. So I use
<outputJarVersion>false</outputJarVersion> for every jarResource.
> The generated jnlp file does not contain any version attributes (correct), but the href attributes for
the jar files do not include the version numbers (wrong).
> As a workaround, I tried to use a custom hrefValue tag for the jarResource, but the jnlp-download-servlet
(Continue reading)

Dennis Lundberg (JIRA | 1 Apr 2010 10:41

[jira] Closed: (MWEBSTART-120) jnlp-download-servlet goal creates incorrect jar entries in jnlp file for jarResources marked with outputJarVersion=false


     [
http://jira.codehaus.org/browse/MWEBSTART-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg closed MWEBSTART-120.
-------------------------------------

    Resolution: Fixed

The code now makes sure that we only rewrite the href value if we need to.

> jnlp-download-servlet goal creates incorrect jar entries in jnlp file for jarResources marked with outputJarVersion=false
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MWEBSTART-120
>                 URL: http://jira.codehaus.org/browse/MWEBSTART-120
>             Project: Maven 2.x Webstart Plugin
>          Issue Type: Bug
>          Components: jnlp-download-servlet
>    Affects Versions: 1.0-alpha-2
>         Environment: Linux, JDK 1.5, Maven 2.0.9
>            Reporter: Johannes Martin
>            Assignee: Dennis Lundberg
>             Fix For: 1.0-alpha-3
>
>
> In my project, I am using the jnlp-download-servlet goal. Since I am deploying snapshots that change
frequently, I do not want jar versions to be output in the generated jnlp file. So I use
<outputJarVersion>false</outputJarVersion> for every jarResource.
> The generated jnlp file does not contain any version attributes (correct), but the href attributes for
(Continue reading)

Dennis Lundberg (JIRA | 1 Apr 2010 11:10

[jira] Closed: (MWEBSTART-141) $project variables in template are not replaced


     [
http://jira.codehaus.org/browse/MWEBSTART-141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg closed MWEBSTART-141.
-------------------------------------

    Resolution: Not A Bug

There are 2 problems with the IT you supplied.

1. ${project.name} in the template.vm file will not work. It should be ${project.Name} (note the capital n
in Name)

2. The POM lacks a <url> element but template.vm tries to use it

When these 2 problems are fixed your IT passes.

> $project variables in template are not replaced
> -----------------------------------------------
>
>                 Key: MWEBSTART-141
>                 URL: http://jira.codehaus.org/browse/MWEBSTART-141
>             Project: Maven 2.x Webstart Plugin
>          Issue Type: Bug
>          Components: jnlps
>    Affects Versions: 1.0-alpha-2
>         Environment: Maven 2.2.1, Java 1.6.0_17, Fedora 11 x86_64
>            Reporter: Peter Janes
>         Attachments: MWEBSTART-test-mavenProjectValues.patch
(Continue reading)

Barry Pitman (JIRA | 1 Apr 2010 12:12

[jira] Commented: (MWEBSTART-117) Using properties defined in pom.xml to fill values in the template.vm


    [
http://jira.codehaus.org/browse/MWEBSTART-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=216330#action_216330
] 

Barry Pitman commented on MWEBSTART-117:
----------------------------------------

+1 for closing the issue, I found that dots didn't work and by changing the property to not use dots fixed it.

> Using properties defined in pom.xml to fill values in the template.vm
> ---------------------------------------------------------------------
>
>                 Key: MWEBSTART-117
>                 URL: http://jira.codehaus.org/browse/MWEBSTART-117
>             Project: Maven 2.x Webstart Plugin
>          Issue Type: Improvement
>          Components: jnlp-download-servlet, jnlps
>    Affects Versions: 1.0-alpha-2
>            Reporter: Valerio Schiavoni
>
> When properties like the followings are defined in pom.xml:
> 	<properties>
> 		<webstart.deploy.site>some-url</webstart.deploy.site>
> 	</properties>
> it would be nice to being able to use them in the template.vm file, like the following:
> <jnlp
>     spec="$jnlpspec"
>     codebase="$properties.webstart.deploy.site"
>     href="$outputFile">
(Continue reading)

Dennis Lundberg (JIRA | 1 Apr 2010 12:34

[jira] Closed: (MWEBSTART-124) Encoding of generated jnlp file(s) always is the system file encoding


     [
http://jira.codehaus.org/browse/MWEBSTART-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg closed MWEBSTART-124.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.0-alpha-3
         Assignee: Dennis Lundberg

Patch applied in r12051. Thanks!

> Encoding of generated jnlp file(s) always is the system file encoding
> ---------------------------------------------------------------------
>
>                 Key: MWEBSTART-124
>                 URL: http://jira.codehaus.org/browse/MWEBSTART-124
>             Project: Maven 2.x Webstart Plugin
>          Issue Type: Bug
>          Components: jnlp-download-servlet
>    Affects Versions: 1.0-alpha-2
>            Reporter: Marius Shekow
>            Assignee: Dennis Lundberg
>             Fix For: 1.0-alpha-3
>
>         Attachments: xml-encoding.patch
>
>
> When the jnlp files are generated from a .vm template which has <?xml version="1.0" encoding="UTF-8"?>
(Continue reading)

Dennis Lundberg (JIRA | 1 Apr 2010 12:54

[jira] Closed: (MWEBSTART-117) Using properties defined in pom.xml to fill values in the template.vm


     [
http://jira.codehaus.org/browse/MWEBSTART-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg closed MWEBSTART-117.
-------------------------------------

    Resolution: Not A Bug

The solution is to use properties without dots.

> Using properties defined in pom.xml to fill values in the template.vm
> ---------------------------------------------------------------------
>
>                 Key: MWEBSTART-117
>                 URL: http://jira.codehaus.org/browse/MWEBSTART-117
>             Project: Maven 2.x Webstart Plugin
>          Issue Type: Improvement
>          Components: jnlp-download-servlet, jnlps
>    Affects Versions: 1.0-alpha-2
>            Reporter: Valerio Schiavoni
>
> When properties like the followings are defined in pom.xml:
> 	<properties>
> 		<webstart.deploy.site>some-url</webstart.deploy.site>
> 	</properties>
> it would be nice to being able to use them in the template.vm file, like the following:
> <jnlp
>     spec="$jnlpspec"
>     codebase="$properties.webstart.deploy.site"
(Continue reading)


Gmane