headers
Steve McKay☄ | 4 Oct 2007 02:42
Picon
Favicon

Re: Tweaking default java.awt.Robot settings

Here's a patch for the test. Everything seems to be working well. I
haven't looked through the other tests yet to see how this might be
shared.

--steve

On 9/25/07, Steve McKay☄ <smckay <at> google.com> wrote:
> Thomas,
>
> > Even after you've ensured that the frame has responded, subsequent checks will
> > still need to be synchronized, since Robot calls are not synchronous.
>
> That was just a code snippet to demonstrate how to solve one part of
> the problem. The code that does the actual testing is synchronized on
> the lock as well. But like I said, there were liveness issues. I'll
> try to work those out. Still, I can't honestly say that I'd want to go
> through the same amount of effort for every test involving Robot, so
> this change is sorta speculative rather than practical.
>
> --
> Steve McKay <smckay <at> google.com>
>

--

-- 
Steve McKay <smckay <at> google.com>
Attachment (KeyPressTest.patch): text/x-patch, 3663 bytes
Permalink | Reply | 1 comment |
headers
Lillian Angel | 4 Oct 2007 15:04
Picon
Favicon

Re: Tweaking default java.awt.Robot settings

Looks good, I tested it out and committed it for you:

2007-10-03  Steve McKay  <smckay@...>

        * gnu/testlet/java/awt/Component/keyPressTest.java: Fixed test so
        event is not created and dispatched. Completely waits for the 
frame to
        receive and respond keypress events.

Lillian

Steve McKay☄ wrote:
> Here's a patch for the test. Everything seems to be working well. I
> haven't looked through the other tests yet to see how this might be
> shared.
>   
> --steve
>
> On 9/25/07, Steve McKay☄ <smckay@...> wrote:
>   
>> Thomas,
>>
>>     
>>> Even after you've ensured that the frame has responded, subsequent checks will
>>> still need to be synchronized, since Robot calls are not synchronous.
>>>       
>> That was just a code snippet to demonstrate how to solve one part of
>> the problem. The code that does the actual testing is synchronized on
>> the lock as well. But like I said, there were liveness issues. I'll
>> try to work those out. Still, I can't honestly say that I'd want to go
(Continue reading)

Permalink | Reply | 0 comments |

Gmane