headers
Chris Dolan (JIRA | 3 Aug 2011 18:58
Picon

[JIRA] Commented: (LBCLASSIC-275) LoggingEvent casts to LogbackMDCAdapter without checking


    [
http://jira.qos.ch/browse/LBCLASSIC-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12072#action_12072
] 

Chris Dolan commented on LBCLASSIC-275:
---------------------------------------

Pretty please? I think my proposed implementation is low-risk and fairly straightforward. This one
glitch is blocking a Logback implementation of the PAX-Logging service, which currently uses log4j.

> LoggingEvent casts to LogbackMDCAdapter without checking
> --------------------------------------------------------
>
>                 Key: LBCLASSIC-275
>                 URL: http://jira.qos.ch/browse/LBCLASSIC-275
>             Project: logback-classic
>          Issue Type: Bug
>    Affects Versions: 0.9.28
>            Reporter: Chris Dolan
>            Assignee: Ceki Gulcu
>
> LoggingEvent has this code:
>     // ugly but under the circumstances acceptable
>     LogbackMDCAdapter logbackMDCAdapter = (LogbackMDCAdapter) MDC
>         .getMDCAdapter();
>     mdcPropertyMap = logbackMDCAdapter.getPropertyMap();
> I'm trying to build a logback implementation of the OSGi pax-logging-service
(http://www.ops4j.org/projects/pax/logging/index.html). But I've got a problem that PAX exports
org.slf4j.impl with their own MDC adapter that fails this cast. Theirs has the nice feature that the OSGi
(Continue reading)

Permalink | Reply | 0 comments |
headers
Pascal Leclercq (JIRA | 4 Aug 2011 17:13
Picon

[JIRA] Created: (LBCORE-217) CyclicBufferFileAppender

CyclicBufferFileAppender
------------------------

                 Key: LBCORE-217
                 URL: http://jira.qos.ch/browse/LBCORE-217
             Project: logback-core
          Issue Type: New Feature
          Components: Appender
            Reporter: Pascal Leclercq
            Assignee: Logback dev list

We mostly use "FileAppender" and/or RollingFileAppender.

We have a debug level on certain logger just to be sure we'll be able to analyse what's goign wrong in case of an error.

This cause huge amount of logs and slow down our application.

It would be nice to combine CyclicBufferTracker (like in SMTPAppender) and FileAppender to be able to get
only the n last lines before and error event occurs.

I create a POC and end up to the conclusion that 50 % performance improvement  (with the last 1000 lines).

I would like to send you the POC but I can't upload here.

Sample conf :
<configuration>
<appender name="FILE" class="fr.opensagres.CyclicBufferFileAppender">
    <file>testFile.log</file>
    <append>true</append>
(Continue reading)

Permalink | Reply | 1 comment |
headers
Pascal Leclercq (JIRA | 4 Aug 2011 17:15
Picon

[JIRA] Updated: (LBCORE-217) CyclicBufferFileAppender


     [
http://jira.qos.ch/browse/LBCORE-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pascal Leclercq updated LBCORE-217:
-----------------------------------

    Attachment: logback-cyclic-appender.zip

Finally I can upload after issue creation.

> CyclicBufferFileAppender
> ------------------------
>
>                 Key: LBCORE-217
>                 URL: http://jira.qos.ch/browse/LBCORE-217
>             Project: logback-core
>          Issue Type: New Feature
>          Components: Appender
>            Reporter: Pascal Leclercq
>            Assignee: Logback dev list
>         Attachments: logback-cyclic-appender.zip
>
>
> We mostly use "FileAppender" and/or RollingFileAppender.
> We have a debug level on certain logger just to be sure we'll be able to analyse what's goign wrong in case of
an error.
> This cause huge amount of logs and slow down our application.
> It would be nice to combine CyclicBufferTracker (like in SMTPAppender) and FileAppender to be able to get
only the n last lines before and error event occurs.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Nicolas Bouillon (JIRA | 5 Aug 2011 15:51
Picon

[JIRA] Commented: (LBGENERAL-35) TimeBasedRollingWithArchiveRemovalTest failed


    [
http://jira.qos.ch/browse/LBGENERAL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12074#action_12074
] 

Nicolas Bouillon commented on LBGENERAL-35:
-------------------------------------------

I just tried to build the last release (0.9.29) on my Mac, and I got an error that seams to be the same :

Failed tests: 
  montlyRolloverOverManyPeriods(ch.qos.logback.core.rolling.TimeBasedRollingWithArchiveRemovalTest)

Tests run: 305, Failures: 1, Errors: 0, Skipped: 2

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Logback-Parent .................................... SUCCESS [0.791s]
[INFO] Logback Core Module ............................... FAILURE [22.939s]
[INFO] Logback Classic Module ............................
SKIPPED

montlyRolloverOverManyPeriods(ch.qos.logback.core.rolling.TimeBasedRollingWithArchiveRemovalTest)
 Time elapsed: 0.001 sec  <<< FAILURE!
java.lang.AssertionError: expected:<8> but was:<7>
	at org.junit.Assert.fail(Assert.java:91)
	at org.junit.Assert.failNotEquals(Assert.java:645)
	at org.junit.Assert.assertEquals(Assert.java:126)
	at org.junit.Assert.assertEquals(Assert.java:470)
(Continue reading)

Permalink | Reply | 0 comments |
headers
Pierre Queinnec (JIRA | 5 Aug 2011 18:10
Picon

[JIRA] Created: (LBCORE-218) Incorrect switch fallthrough in the SQL dialect selection

Incorrect switch fallthrough in the SQL dialect selection
---------------------------------------------------------

                 Key: LBCORE-218
                 URL: http://jira.qos.ch/browse/LBCORE-218
             Project: logback-core
          Issue Type: Bug
          Components: Other
    Affects Versions: 0.9.30
            Reporter: Pierre Queinnec
            Assignee: Logback dev list

There's a break missing in the switch statement for SQL dialects in DBUtil#getDialectFromCode. As HSQLDB
and H2 have the same syntax it has gone un-noticed.
I'll open a pull request.

--

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Permalink | Reply | 2 comments |
headers
Pierre Queinnec (JIRA | 5 Aug 2011 18:14
Picon

[JIRA] Commented: (LBCORE-218) Incorrect switch fallthrough in the SQL dialect selection


    [
http://jira.qos.ch/browse/LBCORE-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12075#action_12075
] 

Pierre Queinnec commented on LBCORE-218:
----------------------------------------

Opened pull-request at https://github.com/ceki/logback/pull/24

> Incorrect switch fallthrough in the SQL dialect selection
> ---------------------------------------------------------
>
>                 Key: LBCORE-218
>                 URL: http://jira.qos.ch/browse/LBCORE-218
>             Project: logback-core
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: 0.9.30
>            Reporter: Pierre Queinnec
>            Assignee: Logback dev list
>
> There's a break missing in the switch statement for SQL dialects in DBUtil#getDialectFromCode. As
HSQLDB and H2 have the same syntax it has gone un-noticed.
> I'll open a pull request.

--

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.qos.ch/secure/Administrators.jspa
(Continue reading)

Permalink | Reply | 0 comments |
headers
Nicolas Bouillon (JIRA | 5 Aug 2011 21:58
Picon

[JIRA] Commented: (LBGENERAL-35) TimeBasedRollingWithArchiveRemovalTest failed


    [
http://jira.qos.ch/browse/LBGENERAL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12076#action_12076
] 

Nicolas Bouillon commented on LBGENERAL-35:
-------------------------------------------

I've tested at home on my Ubuntu and I got the error too. (On  master or on tag v_0.9.29)

> TimeBasedRollingWithArchiveRemovalTest failed
> ---------------------------------------------
>
>                 Key: LBGENERAL-35
>                 URL: http://jira.qos.ch/browse/LBGENERAL-35
>             Project: logback-general
>          Issue Type: Sub-task
>    Affects Versions: 0.9.17
>         Environment: Mac OSX
>            Reporter: Ralph Goers
>            Assignee: Ceki Gulcu
>             Fix For: 0.9.18
>
>
> This is not a frequent occurence.
> -------------------------------------------------------------------------------
> Test set: ch.qos.logback.core.rolling.TimeBasedRollingWithArchiveRemovalTest
> -------------------------------------------------------------------------------
> Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.411 sec <<< FAILURE!
> montlyRollover(ch.qos.logback.core.rolling.TimeBasedRollingWithArchiveRemovalTest)  Time
(Continue reading)

Permalink | Reply | 0 comments |
headers
Daniel Serodio (JIRA | 15 Aug 2011 22:52
Picon

[JIRA] Commented: (LBCLASSIC-146) SysLog Appender and Line Breaks = :(


    [
http://jira.qos.ch/browse/LBCLASSIC-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12080#action_12080
] 

Daniel Serodio commented on LBCLASSIC-146:
------------------------------------------

What's the correct format for a multi-line message in syslog?

> SysLog Appender and Line Breaks  =  :(
> --------------------------------------
>
>                 Key: LBCLASSIC-146
>                 URL: http://jira.qos.ch/browse/LBCLASSIC-146
>             Project: logback-classic
>          Issue Type: Bug
>          Components: appender
>         Environment: Debian 4 Etch, 64 Bit (most likely all enviroments)
>            Reporter: Ingo Siebert
>            Assignee: Logback dev list
>
> I'm using the SysLog appender and it works well.
> But I've problems with line breaks, especially for exceptions. Every strack trace line is written as new
SysLog-Entry. Example:
> Aug 11 20:25:21 192.168.33.11 app2-cas org.osgi.framework.BundleException: The bundle class path
entry "patch.jar"..."
> Aug 11 20:25:21 192.168.33.11 app2-cas ^Iat org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findClassPathEntry(ClasspathManager.java:168)
> Aug 11 20:25:21 192.168.33.11 app2-cas ^Iat org.eclipse.osgi.baseadaptor.loader.ClasspathManager.buildClasspath(ClasspathManager.java:145)
> Aug 11 20:25:21 192.168.33.11 app2-cas ^Iat org.eclipse.osgi.baseadaptor.loader.ClasspathManager.initialize(ClasspathManager.java:79)
(Continue reading)

Permalink | Reply | 0 comments |
headers
Ralph Goers (JIRA | 16 Aug 2011 02:45
Picon

[JIRA] Commented: (LBCLASSIC-146) SysLog Appender and Line Breaks = :(


    [
http://jira.qos.ch/browse/LBCLASSIC-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12081#action_12081
] 

Ralph Goers commented on LBCLASSIC-146:
---------------------------------------

There are two variations on the syslog specification. RFC 3164 is the original 'BSD' syslog spec and can be
found at http://tools.ietf.org/html/rfc3164. It explicitly states that only printable characters
and spaces are allowed.  

RFC 5424 is the new syslog spec and can be found at http://tools.ietf.org/html/rfc5424. This
specification is much more extensive. It specifies this about the message portion:

"The syslog application SHOULD avoid octet values below 32 (the traditional US-ASCII control character
range except DEL).  These values are legal, but a syslog application MAY modify these characters upon
reception.  For example, it might change them into an escape sequence (e.g., value 0 may be changed to
"\0").  A syslog application SHOULD NOT modify any other octet values."

Logback does not support RFC 5424.

> SysLog Appender and Line Breaks  =  :(
> --------------------------------------
>
>                 Key: LBCLASSIC-146
>                 URL: http://jira.qos.ch/browse/LBCLASSIC-146
>             Project: logback-classic
>          Issue Type: Bug
>          Components: appender
(Continue reading)

Permalink | Reply | 0 comments |
headers
Daniel Serodio (JIRA | 16 Aug 2011 16:17
Picon

[JIRA] Commented: (LBCLASSIC-116) SyslogAppender should support RFC 5424


    [
http://jira.qos.ch/browse/LBCLASSIC-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12082#action_12082
] 

Daniel Serodio commented on LBCLASSIC-116:
------------------------------------------

It would be great to have this integrated into Logback, because logging on a remote syslog server over TCP is
a requirement for a project I'm beginning to work on.

> SyslogAppender should support RFC 5424
> --------------------------------------
>
>                 Key: LBCLASSIC-116
>                 URL: http://jira.qos.ch/browse/LBCLASSIC-116
>             Project: logback-classic
>          Issue Type: Improvement
>          Components: appender
>    Affects Versions: 0.9.16
>         Environment: All
>            Reporter: Ralph Goers
>            Assignee: Logback dev list
>
> The SyslogAppender supports RFC 3164. RFC 5424 has been released with obsoletes RFC 3164. See
http://www.ietf.org/rfc/rfc5424.txt. At the very least the format of the timestamp has been changed.
Either the SyslogAppender should be enhanced to comply with RFC 5424 or a new SyslogAppender should be
created which does.

--

--
(Continue reading)

Permalink | Reply | 0 comments |

Gmane