Jingcheng Du (JIRA | 31 Oct 08:04 2014
Picon

[jira] [Created] (HBASE-12392) Incorrect implementation of CompactionRequest.isRetainDeleteMarkers

Jingcheng Du created HBASE-12392:
------------------------------------

             Summary: Incorrect implementation of CompactionRequest.isRetainDeleteMarkers
                 Key: HBASE-12392
                 URL: https://issues.apache.org/jira/browse/HBASE-12392
             Project: HBase
          Issue Type: Sub-task
            Reporter: Jingcheng Du
            Assignee: Jingcheng Du

Now in the implementation of the isRetainDeleteMarkers method, the code look like,
{code}
return (this.retainDeleteMarkers != null) ? this.retainDeleteMarkers.booleanValue()
        : isAllFiles();
{code}
It means for a major compaction in a normal store, this method returns true. Consequently the delete marks
could not be deleted in the major compaction, which leads the unit test TestKeepDeletes fails.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Jingcheng Du (JIRA | 31 Oct 07:51 2014
Picon

[jira] [Created] (HBASE-12391) Correct a typo in the mob metrics

Jingcheng Du created HBASE-12391:
------------------------------------

             Summary: Correct a typo in the mob metrics
                 Key: HBASE-12391
                 URL: https://issues.apache.org/jira/browse/HBASE-12391
             Project: HBase
          Issue Type: Sub-task
            Reporter: Jingcheng Du
            Assignee: Jingcheng Du
            Priority: Minor

There's a typo in the temp variable in the region server metrics for mob. It's now
"testMobCompactedFromMobCellsSize", and should be changed to "tempMobCompactedFromMobCellsSize"

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Ted Yu (JIRA | 31 Oct 05:31 2014
Picon

[jira] [Resolved] (HBASE-12274) Race between RegionScannerImpl#nextInternal() and RegionScannerImpl#close() may produce null pointer exception


     [
https://issues.apache.org/jira/browse/HBASE-12274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu resolved HBASE-12274.
----------------------------
    Resolution: Fixed

> Race between RegionScannerImpl#nextInternal() and RegionScannerImpl#close() may produce null
pointer exception
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12274
>                 URL: https://issues.apache.org/jira/browse/HBASE-12274
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.6.1
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 2.0.0, 0.98.8, 0.99.2
>
>         Attachments: 12274-0.98.addendum, 12274-region-server.log, 12274-v2.txt, 12274-v2.txt, 12274-v3.txt
>
>
> I saw the following in region server log:
> {code}
> 2014-10-15 03:28:36,976 ERROR [B.DefaultRpcServer.handler=0,queue=0,port=60020]
ipc.RpcServer: Unexpected throwable object
> java.lang.NullPointerException
>   at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:5023)
(Continue reading)

Lars Hofhansl (JIRA | 31 Oct 05:16 2014
Picon

[jira] [Reopened] (HBASE-12274) Race between RegionScannerImpl#nextInternal() and RegionScannerImpl#close() may produce null pointer exception


     [
https://issues.apache.org/jira/browse/HBASE-12274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl reopened HBASE-12274:
-----------------------------------

Just seeing this now.
Adding synchronized to nextRaw is *not* OK.
I added nextRaw specifically for callers who know what they are doing (like Phoenix).

This needs to reverted and we need to find another solution.

-1

> Race between RegionScannerImpl#nextInternal() and RegionScannerImpl#close() may produce null
pointer exception
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12274
>                 URL: https://issues.apache.org/jira/browse/HBASE-12274
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.6.1
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 2.0.0, 0.98.8, 0.99.2
>
>         Attachments: 12274-region-server.log, 12274-v2.txt, 12274-v2.txt, 12274-v3.txt
>
(Continue reading)

Enis Soztutar (JIRA | 31 Oct 04:15 2014
Picon

[jira] [Created] (HBASE-12390) Change revision style from svn to git

Enis Soztutar created HBASE-12390:
-------------------------------------

             Summary: Change revision style from svn to git
                 Key: HBASE-12390
                 URL: https://issues.apache.org/jira/browse/HBASE-12390
             Project: HBase
          Issue Type: Improvement
            Reporter: Enis Soztutar
            Assignee: Enis Soztutar
            Priority: Minor
             Fix For: 2.0.0, 0.99.2

This was bothering me. We should change the {{-r <revision_id>}} style that is an svn thing. 

We can do: 
{code}
2.0.0-SNAPSHOT, revision=64b6109ce917a47e4fa4b88cdb800bcc7a228484
{code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

stack (JIRA | 31 Oct 03:29 2014
Picon

[jira] [Reopened] (HBASE-11819) Unit test for CoprocessorHConnection


     [
https://issues.apache.org/jira/browse/HBASE-11819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack reopened HBASE-11819:
---------------------------

Reopened. Reverted from branch-1+. Failed here: https://builds.apache.org/job/PreCommit-HBASE-Build/11530//testReport/org.apache.hadoop.hbase.coprocessor/TestCoprocessorHConnection/testHConnection/

> Unit test for CoprocessorHConnection 
> -------------------------------------
>
>                 Key: HBASE-11819
>                 URL: https://issues.apache.org/jira/browse/HBASE-11819
>             Project: HBase
>          Issue Type: Test
>            Reporter: Andrew Purtell
>            Assignee: Talat UYARER
>            Priority: Minor
>              Labels: newbie++
>             Fix For: 2.0.0, 0.99.2
>
>         Attachments: HBASE-11819.patch, HBASE-11819v2.patch, HBASE-11819v3.patch
>
>
> Add a unit test to hbase-server that exercises CoprocessorHConnection . 

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
(Continue reading)

Andrew Purtell (JIRA | 30 Oct 23:15 2014
Picon

[jira] [Created] (HBASE-12389) Reduce the number of versions configured for the ACL table

Andrew Purtell created HBASE-12389:
--------------------------------------

             Summary: Reduce the number of versions configured for the ACL table
                 Key: HBASE-12389
                 URL: https://issues.apache.org/jira/browse/HBASE-12389
             Project: HBase
          Issue Type: Improvement
          Components: security
            Reporter: Andrew Purtell
            Assignee: Andrew Purtell
            Priority: Minor
             Fix For: 2.0.0, 0.98.8, 0.99.2

We recently reduced the number of versions kept for entries in META from 10 to 3. This same arbitrary
constant was used for the ACL table definition in AccessControlLists. We should change this to 3 also, or
even 1. 

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Sean Busbey (JIRA | 30 Oct 22:54 2014
Picon

[jira] [Created] (HBASE-12388) Document that WALObservers don't get empty edits.

Sean Busbey created HBASE-12388:
-----------------------------------

             Summary: Document that WALObservers don't get empty edits.
                 Key: HBASE-12388
                 URL: https://issues.apache.org/jira/browse/HBASE-12388
             Project: HBase
          Issue Type: Task
          Components: wal
            Reporter: Sean Busbey
            Assignee: Sean Busbey
             Fix For: 2.0.0, 0.99.2

in branch-1+, WALObservers don't get any notice of WALEdits that return true for isEmpty().

Make sure this is noted in the docs. It was surprising while I was writing a test, and it's a different edge
case than in 0.98.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

stack (JIRA | 30 Oct 22:35 2014
Picon

[jira] [Resolved] (HBASE-11819) Unit test for CoprocessorHConnection


     [
https://issues.apache.org/jira/browse/HBASE-11819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-11819.
---------------------------
       Resolution: Fixed
    Fix Version/s:     (was: 0.98.8)
     Hadoop Flags: Reviewed

Applied to branch-1+.  Thanks for the patch [~talat]  What I applied differed in the formatting.  I removed
white space too.  See d719ea1db795686f893cba8ad85d16b3e136e89b and compare to what you posted so you
know for next time.  Good on you.

> Unit test for CoprocessorHConnection 
> -------------------------------------
>
>                 Key: HBASE-11819
>                 URL: https://issues.apache.org/jira/browse/HBASE-11819
>             Project: HBase
>          Issue Type: Test
>            Reporter: Andrew Purtell
>            Assignee: Talat UYARER
>            Priority: Minor
>              Labels: newbie++
>             Fix For: 2.0.0, 0.99.2
>
>         Attachments: HBASE-11819.patch, HBASE-11819v2.patch, HBASE-11819v3.patch
>
>
(Continue reading)

Sean Busbey (JIRA | 30 Oct 22:06 2014
Picon

[jira] [Created] (HBASE-12387) committer guidelines should include patch signoff

Sean Busbey created HBASE-12387:
-----------------------------------

             Summary: committer guidelines should include patch signoff
                 Key: HBASE-12387
                 URL: https://issues.apache.org/jira/browse/HBASE-12387
             Project: HBase
          Issue Type: Task
          Components: documentation
            Reporter: Sean Busbey

Right now our guide for committers apply patches has them use {{git am}} without a signoff flag. This works
okay, but it misses adding the "signed-off-by" blurb in the commit message.

Those messages make it easier to see at a glance with e.g. {{git log}} which committer applied the patch.

this section:

{quote}
The directive to use git format-patch rather than git diff, and not to use --no-prefix, is a new one. See the
second example for how to apply a patch created with git diff, and educate the person who created the patch.

{code}
$ git checkout -b HBASE-XXXX
$ git am ~/Downloads/HBASE-XXXX-v2.patch
$ git checkout master
$ git pull --rebase
$ git cherry-pick <sha-from-commit>
# Resolve conflicts if necessary or ask the submitter to do it
$ git pull --rebase          # Better safe than sorry
(Continue reading)

Stack | 30 Oct 21:49 2014
Picon

Review of "HBASE-10201 Port 'Make flush decisions per column family' to trunk" please

This is a very nice feature.  Its been reviewed once.  Needs another
review. As is, it is on by default. IMO this is how it should be as I think
what we have currently -- region-wide flush --  is 'broke' (smile).  Would
be good to get into branch-1.  Anyone else up for a +1?

Thanks,
St.Ack

Gmane