headers
Mark Thomas | 1 Nov 2009 05:42
Picon
Favicon
Gravatar

Re: svn commit: r831536 - in /tomcat/trunk: java/org/apache/tomcat/util/http/ test/org/apache/tomcat/util/http/ webapps/docs/config/

Remy Maucherat wrote:
> On Sat, 2009-10-31 at 12:59 +0000, markt <at> apache.org wrote:
>> Author: markt
>> Date: Sat Oct 31 12:59:51 2009
>> New Revision: 831536
>>
>> URL: http://svn.apache.org/viewvc?rev=831536&view=rev
>> Log:
>> Add an explicit configuration option for cookie version switching and update test cases and docs to
include it.
> 
> The version switch flag is not correct.
> 
> Following a clarification, the Servlet EG has validated the concept of
> cookie version switching, to support comments (if a comment is set on
> the cookie, then the cookie automatically becomes v1, if it was v0; so
> evidently it is now acceptable to switch versions to handle values that
> are invalid in v0).
> 
> Rémy

Thanks for that info - I wasn't aware of that. I'll update the cookie handling
code accordingly.

Cheers,

Mark
Permalink | Reply | 0 comments |
headers
markt | 1 Nov 2009 19:16
Picon
Favicon
Gravatar

svn commit: r831716 - /tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java

Author: markt
Date: Sun Nov  1 18:16:57 2009
New Revision: 831716

URL: http://svn.apache.org/viewvc?rev=831716&view=rev
Log:
Add another feature to the Tomcat based unit tests.

Modified:
    tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java

Modified: tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java?rev=831716&r1=831715&r2=831716&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java (original)
+++ tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java Sun Nov  1 18:16:57 2009
 <at>  <at>  -58,6 +58,14  <at>  <at> 
         return port;
     }

+    /**
+     * Sub-classes may want to add connectors on a new port
+     */
+    public int getNextPort() {
+        port++;
+        return getPort();
+    }
+    
     public void setUp() throws Exception {
         tempDir = new File("output/tmp");
(Continue reading)

Permalink | Reply | 0 comments |
headers
bugzilla | 1 Nov 2009 19:20
Picon
Favicon

DO NOT REPLY [Bug 47364] HttpServletRequest.getAttributeNames() does not return the names of all attributes

https://issues.apache.org/bugzilla/show_bug.cgi?id=47364

--- Comment #2 from Mark Thomas <markt <at> apache.org> 2009-11-01 10:20:36 GMT ---
Created an attachment (id=24451)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24451)
Patch that adds internal attributes but breaks TCK tests

I looked at just including all the Tomcat internal attributes in the return
from getAttributeNames() but this causes problems with the Servlet 2.5 TCK
tests which expect that getAttributeNames() return only those attributes that
have been set via setAttribute().

Therefore it looks like the doc change is the way I'll have to go. For
completeness the patch I tried that returned all the attribute names is
attached so you can patch Tomcat locally if you particularly need that
functionality. I thought about making this a configurable option but I didn't
want to add the complexity for something that I couldn't see causing any
problems that can't be easily worked around by an app that needed to.

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
Permalink | Reply | 0 comments |
headers
pero | 1 Nov 2009 19:29
Picon
Favicon

svn commit: r831718 - /tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java

Author: pero
Date: Sun Nov  1 18:29:14 2009
New Revision: 831718

URL: http://svn.apache.org/viewvc?rev=831718&view=rev
Log:
Fix ReplicationValve crossContext support

Modified:
    tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java

Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java?rev=831718&r1=831717&r2=831718&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java (original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java Sun Nov  1 18:29:14 2009
 <at>  <at>  -361,6 +361,16  <at>  <at> 
         return (this.isValid);
     }

+    /**
+     * End the access and register to ReplicationValve (crossContext support)
+     */
+    public void endAccess() {
+    	super.endAccess() ;
+    	if(manager instanceof DeltaManager) {
+            ((DeltaManager)manager).registerSessionAtReplicationValve(this);   	
+    	}
+    }
+
(Continue reading)

Permalink | Reply | 0 comments |
headers
pero | 1 Nov 2009 19:34
Picon
Favicon

svn commit: r831720 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: pero
Date: Sun Nov  1 18:34:04 2009
New Revision: 831720

URL: http://svn.apache.org/viewvc?rev=831720&view=rev
Log:
Add ReplicationValve CrossContext support patch

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=831720&r1=831719&r2=831720&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Nov  1 18:34:04 2009
 <at>  <at>  -383,3 +383,9  <at>  <at> 
   http://svn.apache.org/viewvc?rev=831106&view=rev
   +1: fhanik, kkolinko
   -1:
+
+* Fix ReplicationValve CrossContext support
+  http://svn.apache.org/viewvc?rev=831718&view=rev
+  +1: pero
+  -1:
+
Permalink | Reply | 0 comments |
headers
markt | 1 Nov 2009 19:35
Picon
Favicon
Gravatar

svn commit: r831722 - /tomcat/trunk/java/org/apache/catalina/connector/Request.java

Author: markt
Date: Sun Nov  1 18:35:02 2009
New Revision: 831722

URL: http://svn.apache.org/viewvc?rev=831722&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47364
Document that HttpServletRequest.getAttributeNames() does not return the names of all attributes
(internal Tomcat attributes are excluded)

Modified:
    tomcat/trunk/java/org/apache/catalina/connector/Request.java

Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Request.java?rev=831722&r1=831721&r2=831722&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/connector/Request.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Request.java Sun Nov  1 18:35:02 2009
 <at>  <at>  -919,7 +919,30  <at>  <at> 

     /**
      * Return the names of all request attributes for this Request, or an
-     * empty <code>Enumeration</code> if there are none.
+     * empty <code>Enumeration</code> if there are none. Note that the attribute
+     * names return will only be those for the attributes set via
+     * { <at> link #setAttribute(String, Object)}. Tomcat internal attributes will
+     * not be included although they are accessible via
+     * { <at> link #getAttribute(String)}. The Tomcat internal attributes include:
+     * <ul>
+     * <li>{ <at> link Globals.DISPATCHER_TYPE_ATTR}</li>
(Continue reading)

Permalink | Reply | 0 comments |
headers
markt | 1 Nov 2009 19:38
Picon
Favicon
Gravatar

svn commit: r831724 - in /tomcat/tc6.0.x/trunk: java/org/apache/catalina/connector/Request.java webapps/docs/changelog.xml

Author: markt
Date: Sun Nov  1 18:38:46 2009
New Revision: 831724

URL: http://svn.apache.org/viewvc?rev=831724&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47364
Document that HttpServletRequest.getAttributeNames() does not return the names of all attributes
(internal Tomcat attributes are excluded)

Modified:
    tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java
    tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java?rev=831724&r1=831723&r2=831724&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java (original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java Sun Nov  1 18:38:46 2009
 <at>  <at>  -930,7 +930,30  <at>  <at> 

     /**
      * Return the names of all request attributes for this Request, or an
-     * empty <code>Enumeration</code> if there are none.
+     * empty <code>Enumeration</code> if there are none. Note that the attribute
+     * names return will only be those for the attributes set via
+     * { <at> link #setAttribute(String, Object)}. Tomcat internal attributes will
+     * not be included although they are accessible via
+     * { <at> link #getAttribute(String)}. The Tomcat internal attributes include:
+     * <ul>
(Continue reading)

Permalink | Reply | 0 comments |
headers
bugzilla | 1 Nov 2009 19:39
Picon
Favicon

DO NOT REPLY [Bug 47364] HttpServletRequest.getAttributeNames() does not return the names of all attributes

https://issues.apache.org/bugzilla/show_bug.cgi?id=47364

Mark Thomas <markt <at> apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Mark Thomas <markt <at> apache.org> 2009-11-01 10:39:08 GMT ---
Trunk and 6.0.x now have updated Javadoc. Thsi will be included in 6.0.21
onwards.

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
Permalink | Reply | 0 comments |
headers
bugzilla | 1 Nov 2009 20:06
Picon
Favicon

DO NOT REPLY [Bug 48097] New: NoClassDefFoundError on first access of first jsp

https://issues.apache.org/bugzilla/show_bug.cgi?id=48097

           Summary: NoClassDefFoundError on first access of first jsp
           Product: Tomcat 6
           Version: 6.0.20
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
        AssignedTo: dev <at> tomcat.apache.org
        ReportedBy: amichai2 <at> amichais.net

Created an attachment (id=24452)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24452)
simple webapp with one jsp and one class in one jar, reproducing the error

I've had a strange situation getting NoClassDefFoundErrors on a particular jsp
page (which happened to be the index.jsp page). The class it claimed to not
find is a simple session bean class within a jar in the WEB-INF/lib folder. The
strange thing is that it gave this error only when this page was the first one
accessed after a tomcat restart. If any page was accessed before it, it would
work properly. But if this page was accessed first, then no matter what pages
were later accessed, the error remained in place. So the error/success state
was determined by whichever page was accessed first ater the tomcat restart,
and remained in the same error/success state for as long as tomcat was up,
regardless of anything happening later on (until the next restart)

This seems to be some sort of class-loading oder-of-initialization bug, but is
(Continue reading)

Permalink | Reply | 16 comments |
headers
bugzilla | 1 Nov 2009 20:07
Picon
Favicon

DO NOT REPLY [Bug 48097] NoClassDefFoundError on first access of first jsp

https://issues.apache.org/bugzilla/show_bug.cgi?id=48097

Amichai <amichai2 <at> amichais.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amichai2 <at> amichais.net

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
Permalink | Reply | 0 comments |

Gmane