headers
bugzilla | 1 Oct 17:31
Picon
Favicon

DO NOT REPLY [Bug 47926] New: pathelement 'ant.jar' of path 'tomcat.classpath' is needless in build.xml

https://issues.apache.org/bugzilla/show_bug.cgi?id=47926

           Summary: pathelement 'ant.jar' of path 'tomcat.classpath' is
                    needless in build.xml
           Product: Tomcat 6
           Version: 6.0.20
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: Catalina
        AssignedTo: dev <at> tomcat.apache.org
        ReportedBy: qingyang.xu <at> qunar.com

following is the relevant parts of the 'build.xml' file:

<path id="tomcat.classpath">
    <pathelement location="${ant.jar}"/>
    <pathelement location="${jdt.jar}"/>
</path>

... ...
<target name="compile">
     <javac srcdir="java" destdir="${tomcat.classes}"
           debug="${compile.debug}"
           deprecation="${compile.deprecation}"
           source="${compile.source}"
           target="${compile.target}"
           optimize="${compile.optimize}"
(Continue reading)

Permalink | Reply | 2 comments |
headers
fhanik | 1 Oct 18:36
Picon
Favicon

svn commit: r820710 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: fhanik
Date: Thu Oct  1 16:36:11 2009
New Revision: 820710

URL: http://svn.apache.org/viewvc?rev=820710&view=rev
Log:
votes

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=820710&r1=820709&r2=820710&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Oct  1 16:36:11 2009
@@ -222,18 +222,19 @@
   +1: fhanik
   -1: 
   rjung: Note discussion at http://marc.info/?t=125182574600001&r=1&w=2
+  fhanik @rjung: The scheme for file:// has two slashes, that's the definition.

 * Allow per instance log4j.properties, JAR files (JDBC drivers) etc
   http://svn.apache.org/viewvc?rev=810916&view=rev
   http://svn.apache.org/viewvc?rev=810977&view=rev
-  +1: markt, rjung
+  +1: markt, rjung, fhanik
   -1:
(Continue reading)

Permalink | Reply | 0 comments |
headers
Konstantin Kolinko | 2 Oct 02:37
Picon

Re: svn commit: r810132 - /tomcat/tc6.0.x/trunk/STATUS.txt

I am in favor of using file.toURI().toString(), as proposed by Rainer.

To construct an URL by simply prepending "file:" + several slashes to
the path is simply wrong.

Spaces are not allowed in an URL (see chapter 2.4.3 of RFC2396) and
must be encoded as %20, as well as % symbols in the file name must be
encoded as %25.

The protocol handler for file: protocol unescapes %-encoded symbols
when opening URLConnection to the file, so if the original file name
contained '%' symbol, it should have been escaped.

(sun.net.www.protocol.file.Handler#openConnection(..))

Best regards,
Konstantin Kolinko

2009/9/1 Rainer Jung <rainer.jung <at> kippdata.de>:
> On 01.09.2009 20:48, Larry Isaacs wrote:
>> Hi Filip,
>>
>> I have a vague recollection about tripping over this issue while working on the Tomcat support in the
Eclipse Web Tools Platform.  WTP has its own version(s) of VirtualWebappLoader, called
WtpWebappLoader, to address it.  If I'm recalling the issue correctly, pre-pending "file:/" worked on
Windows, but not on Linux since an absolute path ended up as "file://somedir/...".  I believe with the
change below, pre-pending "file://" will work for Linux, but not for Windows, i.e.
"file://C:/somedir/..." is going to have problems.  If it helps, I went with the URL form
"file:/somedir/..." and used the following code snippet to get it working for Windows and Linux in WtpWebappLoader:
>
(Continue reading)

Permalink | Reply | 1 comment |
headers
kkolinko | 2 Oct 03:01
Picon
Favicon

svn commit: r820858 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: kkolinko
Date: Fri Oct  2 01:01:23 2009
New Revision: 820858

URL: http://svn.apache.org/viewvc?rev=820858&view=rev
Log:
votes

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=820858&r1=820857&r2=820858&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Oct  2 01:01:23 2009
@@ -151,7 +151,7 @@
   when I have done more testing) for embeddability become possible.
   Step 1: Clean-up
   http://svn.apache.org/viewvc?view=rev&revision=647344
-  +1: markt
+  +1: markt, kkolinko
   -1: 
   Step 2: Make validation configuration per-context
   http://svn.apache.org/viewvc?view=rev&revision=751502
@@ -202,7 +202,7 @@
    0: jim
   -1: 

-* Fix VirtualWebappClassLoader file directives
(Continue reading)

Permalink | Reply | 0 comments |
headers
kkolinko | 2 Oct 04:18
Picon
Favicon

svn commit: r820867 - /tomcat/tc5.5.x/trunk/STATUS.txt

Author: kkolinko
Date: Fri Oct  2 02:18:33 2009
New Revision: 820867

URL: http://svn.apache.org/viewvc?rev=820867&view=rev
Log:
votes

Modified:
    tomcat/tc5.5.x/trunk/STATUS.txt

Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=820867&r1=820866&r2=820867&view=diff
==============================================================================
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Fri Oct  2 02:18:33 2009
@@ -151,7 +151,7 @@
   They are not present in TC 6.0 and trunk.
   svn rm https://svn.apache.org/repos/asf/tomcat/tc5.5.x/trunk/connectors/jni/test
   svn rm https://svn.apache.org/repos/asf/tomcat/tc5.5.x/trunk/connectors/jni/examples
-  +1: rjung, markt
+  +1: rjung, markt, kkolinko
   -1: 

 * Clean up native classes (connectors/jni) in TC 5.5:
@@ -159,7 +159,7 @@
     That's the only task used (called) by our top level build.xml
   - Remove build.properties.default. All that's needed is in
     the top level file
-  +1: rjung, markt
(Continue reading)

Permalink | Reply | 0 comments |
headers
kkolinko | 2 Oct 05:16
Picon
Favicon

svn commit: r820874 - /tomcat/trunk/res/META-INF/bootstrap.jar.manifest

Author: kkolinko
Date: Fri Oct  2 03:16:12 2009
New Revision: 820874

URL: http://svn.apache.org/viewvc?rev=820874&view=rev
Log:
tomcat-coyote.jar (former tomcat-util.jar before rev.389946) is not needed by bootstrap classes

Modified:
    tomcat/trunk/res/META-INF/bootstrap.jar.manifest

Modified: tomcat/trunk/res/META-INF/bootstrap.jar.manifest
URL: http://svn.apache.org/viewvc/tomcat/trunk/res/META-INF/bootstrap.jar.manifest?rev=820874&r1=820873&r2=820874&view=diff
==============================================================================
--- tomcat/trunk/res/META-INF/bootstrap.jar.manifest (original)
+++ tomcat/trunk/res/META-INF/bootstrap.jar.manifest Fri Oct  2 03:16:12 2009
@@ -1,5 +1,5 @@
 Manifest-Version: 1.0
 Main-Class: org.apache.catalina.startup.Bootstrap
-Class-Path: commons-daemon.jar tomcat-coyote.jar
+Class-Path: commons-daemon.jar
 Specification-Title: Catalina
 Specification-Version: @VERSION_MAJOR_MINOR@
\ No newline at end of file
Permalink | Reply | 0 comments |
headers
kkolinko | 2 Oct 06:07
Picon
Favicon

svn commit: r820880 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: kkolinko
Date: Fri Oct  2 04:07:21 2009
New Revision: 820880

URL: http://svn.apache.org/viewvc?rev=820880&view=rev
Log:
votes, veto, proposal

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=820880&r1=820879&r2=820880&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Oct  2 04:07:21 2009
@@ -227,15 +227,24 @@
 * Allow per instance log4j.properties, JAR files (JDBC drivers) etc
   http://svn.apache.org/viewvc?rev=810916&view=rev
   http://svn.apache.org/viewvc?rev=810977&view=rev
-  +1: markt, rjung, fhanik
+  +1: markt, rjung, fhanik, kkolinko
   -1:
+  kkolinko: A side effect of this change will be that when catalina.home
+  and catalina.base are the same, all the jar files will be listed twice.
+  I doubt that it will cause any issues (reading the same jar file twice
+  should be possible, and should not cause any additional locking or
+  whatever, though wasting resources).
+  An alternative would be to document this option and to instruct people to
+  modify catalina.properties,  or we can guard against duplicate URLs in
(Continue reading)

Permalink | Reply | 0 comments |
headers
bugzilla | 2 Oct 07:20
Picon
Favicon

DO NOT REPLY [Bug 47797] The body of the request is lost when you send the POST method !

https://issues.apache.org/bugzilla/show_bug.cgi?id=47797

Eugene <johnbat26 <at> gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #12 from Eugene <johnbat26 <at> gmail.com> 2009-10-01 22:20:08 PDT ---
I embed several count of code in Http11Processor and StandardEngineValve.
In Http11Processor,process() I added next after invoke   
inputBuffer.parseRequestLine();  :
------------
 if (request.unparsedURI().equals("/lost-post/generic"))
        {                   
log.error("----------------------------------------------------------");
   StringBuffer stringBuffer = new StringBuffer();                              
                    for (int i = 0; i < inputBuffer.buf.length; i++) {
                        stringBuffer.append((char) inputBuffer.buf[i]);
                    }

                    log.error(stringBuffer);
                    log.error("LENGTH: "+ inputBuffer.buf.length);              

log.error("++++++++++++++++++++++++++++++++++++++++++++++");                    
                }
------------

and in StandardEngineValve.invoke() I added next code:
(Continue reading)

Permalink | Reply | 0 comments |
headers
bugzilla | 2 Oct 07:21
Picon
Favicon

DO NOT REPLY [Bug 47797] The body of the request is lost when you send the POST method !

https://issues.apache.org/bugzilla/show_bug.cgi?id=47797

--- Comment #13 from Eugene <johnbat26 <at> gmail.com> 2009-10-01 22:21:35 PDT ---
Created an attachment (id=24330)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24330)
My Http11Processor class

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
Permalink | Reply | 0 comments |
headers
bugzilla | 2 Oct 07:24
Picon
Favicon

DO NOT REPLY [Bug 47797] The body of the request is lost when you send the POST method !

https://issues.apache.org/bugzilla/show_bug.cgi?id=47797

--- Comment #14 from Eugene <johnbat26 <at> gmail.com> 2009-10-01 22:24:07 PDT ---
Created an attachment (id=24331)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24331)
My InputBuffer

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
Permalink | Reply | 0 comments |

Gmane