bugzilla | 1 Aug 01:04
Picon
Favicon

DO NOT REPLY [Bug 47609] Failsafe EOL conversion

https://issues.apache.org/bugzilla/show_bug.cgi?id=47609

--- Comment #2 from Filip Hanik <fhanik <at> apache.org>  2009-07-31 16:04:23 PST ---
So the only safe way to do it, would be to specify an includes list instead of
using an excludes.
Patches welcome

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
markt | 2 Aug 16:13
Picon
Favicon
Gravatar

svn commit: r800083 - /tomcat/build/tc5.5.x/sign.bat

Author: markt
Date: Sun Aug  2 14:13:04 2009
New Revision: 800083

URL: http://svn.apache.org/viewvc?rev=800083&view=rev
Log:
Prep for next release

Modified:
    tomcat/build/tc5.5.x/sign.bat

Modified: tomcat/build/tc5.5.x/sign.bat
URL: http://svn.apache.org/viewvc/tomcat/build/tc5.5.x/sign.bat?rev=800083&r1=800082&r2=800083&view=diff
==============================================================================
--- tomcat/build/tc5.5.x/sign.bat (original)
+++ tomcat/build/tc5.5.x/sign.bat Sun Aug  2 14:13:04 2009
@@ -22,7 +22,7 @@
 rem todo - make one for unix as well, and avoid signing the .md5 files

 @echo off
-set VERSION=v5.5.25
+set VERSION=v5.5.29
 FOR /R %cd%\release\%VERSION% %%i in (*.tar.gz) do (
   echo Signing %%i
   echo %1|gpg --passphrase-fd 0 -a -b %%i 
bugzilla | 2 Aug 16:26
Picon
Favicon

DO NOT REPLY [Bug 47609] Failsafe EOL conversion

https://issues.apache.org/bugzilla/show_bug.cgi?id=47609

--- Comment #3 from Sebb <sebb <at> apache.org>  2009-08-02 07:26:27 PST ---
OK, I will create a patch shortly

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
sebb | 2 Aug 16:56
Picon

Re: [VOTE] Release build 5.5.28

On 27/07/2009, sebb <sebbaz <at> gmail.com> wrote:
> On 27/07/2009, Filip Hanik - Dev Lists <devlists <at> hanik.com> wrote:
>  > The candidates binaries are available here:
>  > http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.28/
>  >
>  >  According to the release process, the 5.5.28 tag is:
>
> >  [X] Broken
>
>  Because:
>  * There are no NOTICE or LICENSE files in the top-level of the source archives.
>  * the keystore files are corrupt in the archives.
>  * server.xml in the EXE is different from the other versions

Just noticed another problem - the source archive does not contain the
overall build script.
There are probably other source files missing.

It ought to be possible to build Tomcat from the sources without
needing to download any further Tomcat files.

>
>  >  [ ] Alpha
>  >  [ ] Beta
>  >  [ ] Stable
>  >
>  >
>  > ---------------------------------------------------------------------
>  >  To unsubscribe, e-mail: dev-unsubscribe <at> tomcat.apache.org
>  >  For additional commands, e-mail: dev-help <at> tomcat.apache.org
(Continue reading)

bugzilla | 2 Aug 17:24
Picon
Favicon

DO NOT REPLY [Bug 47609] Failsafe EOL conversion

https://issues.apache.org/bugzilla/show_bug.cgi?id=47609

--- Comment #4 from Sebb <sebb <at> apache.org>  2009-08-02 08:24:37 PST ---
Created an attachment (id=24080)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24080)
fixcrlf use include rather than exclude

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
bugzilla | 2 Aug 17:29
Picon
Favicon

DO NOT REPLY [Bug 47609] Failsafe EOL conversion

https://issues.apache.org/bugzilla/show_bug.cgi?id=47609

Sebb <sebb <at> apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24080|0                           |1
        is obsolete|                            |

--- Comment #5 from Sebb <sebb <at> apache.org>  2009-08-02 08:29:53 PST ---
Created an attachment (id=24081)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24081)
Improved patch - detab

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
Mark Thomas | 2 Aug 17:52
Picon
Favicon
Gravatar

Re: [VOTE] Release build 5.5.28

sebb wrote:
> Just noticed another problem - the source archive does not contain the
> overall build script.

I don't know where you are looking, but the script is there.

> There are probably other source files missing.

Making assumptions about what is and isn't present is not helpful.

There are a couple of files missing when compared to svn but:
a) the missing build files are for an optional module not included in
the distributed binary
b) they have been missing in previous releases
c) no user has ever complained about them being missing.

None of the missing files *need* to be in the src archive but I do think
that they should be. Given the circumstances, I see no issue with fixing
this for the next release rather than re-rolling this release.

> It ought to be possible to build Tomcat from the sources without
> needing to download any further Tomcat files.

It is. I just have.

Mark
Mark Thomas | 2 Aug 18:22
Picon
Favicon
Gravatar

Re: [VOTE] Release build 5.5.28

Filip Hanik - Dev Lists wrote:
> The candidates binaries are available here:
> http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.28/
> 
> According to the release process, the 5.5.28 tag is:
> [ ] Broken
> [ ] Alpha
> [ ] Beta
> [X] Stable

A few minor niggles but nothing to stop the release.

See below for details.

Mark

Checked:
-src.zip
.zip
.exe

MD5s OK
PGP sigs OK

build/sign.bat
 Tomcat version wrong
 Fixed in svn for next release
 Non-issue for this release

container/modules/groupcom/build
(Continue reading)

sebb | 2 Aug 18:34
Picon

Re: [VOTE] Release build 5.5.28

On 02/08/2009, Mark Thomas <markt <at> apache.org> wrote:
> sebb wrote:
>  > Just noticed another problem - the source archive does not contain the
>  > overall build script.
>
>
> I don't know where you are looking, but the script is there.

Sorry, my bad - I'd expanded the archives and was looking in the wrong
directory.

>
>  > There are probably other source files missing.
>
>
> Making assumptions about what is and isn't present is not helpful.

It looked like the whole build directory was missing.

>  There are a couple of files missing when compared to svn but:
>  a) the missing build files are for an optional module not included in
>  the distributed binary
>  b) they have been missing in previous releases
>  c) no user has ever complained about them being missing.
>
>  None of the missing files *need* to be in the src archive but I do think
>  that they should be. Given the circumstances, I see no issue with fixing
>  this for the next release rather than re-rolling this release.
>
>
(Continue reading)

Steven Mahurin | 2 Aug 20:16
Picon
Favicon

5.5.28 issue when multiple services with engines named the same


I am using tomcat 5.5.27 to run a set of simple set of applications.  I am looking at 5.5.28 to address a number
of security vulnerabilties.  When I tried the 5.5.28, we ran into an issue when two services were defined in
server.xml, if the same engine name was used for both but different host names/settings, the second
engine would not start up. This worked in 5.5.27, and the documentation indicates that the engine name
must be unique-per-service, not per server.  Is this a known issue?  

I ended up just renaming the engine defined in the second service and it works fine.  However, this may cause
other people issue when going to 5.5.28 from previous releases, and it seems to differ from the
configuration reference.

Note that I verified that this issue is present using the 5.5.28 build that Filip had as a release candidate
on 7/24:
http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.28/

You should be able to reproduce this by adding a service definition similar to the following to the end of the
default server.xml file (and creating a webapps-testonly folder in the tomcat directory):

<Service name="testservice">
    <Engine name="Catalina" defaultHost="testpsuedohostname">
      <Realm className="org.apache.catalina.realm.UserDatabaseRealm" resourceName="UserDatabase" />
      <Host name="testpsuedohostname" appBase="webapps-testonly" />
    </Engine>
    <Connector port="8010" enableLookups="false" protocol="AJP/1.3" address="127.0.0.1" />
  </Service>

In 5.5.27, both defined services startup normally.  In 5.5.28, the following trace is generated when the
above testservice starts up:
INFO: Starting service testservice
Aug 1, 2009 2:22:19 PM org.apache.catalina.core.StandardEngine start
(Continue reading)


Gmane