rjung | 1 Jul 11:06
Picon
Favicon

svn commit: r790080 - /tomcat/current/tc5.5.x/STATUS.txt

Author: rjung
Date: Wed Jul  1 09:06:22 2009
New Revision: 790080

URL: http://svn.apache.org/viewvc?rev=790080&view=rev
Log:
Mark answered the questions, so now vote +1.

Modified:
    tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=790080&r1=790079&r2=790080&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Wed Jul  1 09:06:22 2009
@@ -75,16 +75,8 @@
   Handle chunked POSTs. If maxPostSize is exceeded, a 500 results
   http://svn.apache.org/viewvc?rev=785381&view=rev
   http://svn.apache.org/viewvc?rev=786487&view=rev
-  +1: markt
+  +1: markt, rjung
   -1: 
-  rjung: +1 in principle, but a few questions/suggestions:
-      - Do we need to dechunk the read request body? I didn't see were this happens.
-      - Do chunked requests actually set a content-length? If not, we have len == -1
-        and will not enter the try/catch block. Maybe only a question of correct backport
-        from trunk.
-      - I think instead of: len == actualLen => non-chunked, else check transfer-encoding
-        it should be the other waqy round. If transfer-encoding is chunked, handle as chunked,
(Continue reading)

bugzilla | 1 Jul 11:51
Picon
Favicon

DO NOT REPLY [Bug 47462] New: The annotation doesn't become effective.(metadata-complete="false" is not effective.)

https://issues.apache.org/bugzilla/show_bug.cgi?id=47462

           Summary: The annotation doesn't become
                    effective.(metadata-complete="false" is not
                    effective.)
           Product: Tomcat 6
           Version: 6.0.20
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
        AssignedTo: dev <at> tomcat.apache.org
        ReportedBy: fujino.keiichi <at> oss.ntt.co.jp

Even if "false" is set to metadata-complete, 
the annotation doesn't become effective. 

To invalidate the annotation by all the Web applications of Tomcat, 
metadata-complete of conf/web.xml is set to "true". 

[conf/web.xml]
<web-app xmlns="http://java.sun.com/xml/ns/javaee"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd"
    version="2.5"
    metadata-complete="true"
    >
(Continue reading)

rjung | 1 Jul 11:56
Picon
Favicon

svn commit: r790095 - /tomcat/sandbox/tomcat-oacc/trunk/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java

Author: rjung
Date: Wed Jul  1 09:56:07 2009
New Revision: 790095

URL: http://svn.apache.org/viewvc?rev=790095&view=rev
Log:
Keep class in sync with TC 5.5.
Only logging changes.

Modified:
    tomcat/sandbox/tomcat-oacc/trunk/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java

Modified: tomcat/sandbox/tomcat-oacc/trunk/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java
URL: http://svn.apache.org/viewvc/tomcat/sandbox/tomcat-oacc/trunk/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java?rev=790095&r1=790094&r2=790095&view=diff
==============================================================================
---
tomcat/sandbox/tomcat-oacc/trunk/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java (original)
+++
tomcat/sandbox/tomcat-oacc/trunk/src/share/org/apache/catalina/cluster/mcast/McastServiceImpl.java
Wed Jul  1 09:56:07 2009
@@ -170,8 +170,7 @@
     protected void setupSocket() throws IOException {
         if (mcastBindAddress != null) {
             try {
-                if(log.isInfoEnabled())
-                    log.info("Attempting to bind the multicast socket to "+address+":"+port);
+                log.info("Attempting to bind the multicast socket to "+address+":"+port);
                 socket = new MulticastSocket(new InetSocketAddress(address,port));
             } catch (BindException e) {
                 /*
(Continue reading)

kkolinko | 1 Jul 12:38
Picon
Favicon

svn commit: r790105 - /tomcat/current/tc5.5.x/STATUS.txt

Author: kkolinko
Date: Wed Jul  1 10:38:47 2009
New Revision: 790105

URL: http://svn.apache.org/viewvc?rev=790105&view=rev
Log:
proposal

Modified:
    tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=790105&r1=790104&r2=790105&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Wed Jul  1 10:38:47 2009
@@ -105,6 +105,9 @@
   http://people.apache.org/~markt/patches/2009-06-30-AccessLogValve-tc5.patch
   +1: markt, kkolinko
   -1: 
+  kkolinko: I am not sure, that it is good to change signature of the
+  public log() method. Also I updated the patch and made the
+  AccessDateStruct static. I am proposing it below.

 * Make access log valves thread safe
   https://issues.apache.org/bugzilla/show_bug.cgi?id=38483
@@ -115,8 +118,18 @@

 * Make FastCommonAccessLogValve thread safe
   http://people.apache.org/~markt/patches/2009-06-30-FastCommonAccessLogValve-tc5.patch
(Continue reading)

kkolinko | 1 Jul 13:02
Picon
Favicon

svn commit: r790116 - /tomcat/current/tc5.5.x/STATUS.txt

Author: kkolinko
Date: Wed Jul  1 11:02:48 2009
New Revision: 790116

URL: http://svn.apache.org/viewvc?rev=790116&view=rev
Log:
votes

Modified:
    tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=790116&r1=790115&r2=790116&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Wed Jul  1 11:02:48 2009
@@ -142,27 +142,27 @@
   DeltaManager doesn't do session replication if notifySessionListenersOnReplication=false.
   Backport of http://svn.apache.org/viewvc?view=rev&revision=786124 from tc6
   resp. http://svn.apache.org/viewvc?view=rev&revision=789821 from OACC.
-  +1: rjung
+  +1: rjung, kkolinko
   -1:

 * Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=46990
   Improve locking in cluster membership.
   Backport of http://svn.apache.org/viewvc?view=rev&revision=771009 from tc6
   resp. http://svn.apache.org/viewvc?view=rev&revision=789826 from OACC.
-  +1: rjung
+  +1: rjung, kkolinko
(Continue reading)

rjung | 1 Jul 13:09
Picon
Favicon

svn commit: r790119 - /tomcat/current/tc5.5.x/STATUS.txt

Author: rjung
Date: Wed Jul  1 11:09:14 2009
New Revision: 790119

URL: http://svn.apache.org/viewvc?rev=790119&view=rev
Log:
Add some more tiny cluster backports from
TC6 and OACC.

The remaining backports are either to huge/risky or
the ratio between size+risk and usefulness is to bad.

Modified:
    tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=790119&r1=790118&r2=790119&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Wed Jul  1 11:09:14 2009
@@ -166,3 +166,23 @@
   +1: rjung, kkolinko
   -1:

+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45317
+  Properly output the state transfer timeout for sessions.
+  Backport of http://svn.apache.org/viewvc?view=rev&revision=674750 from tc6
+  resp. http://svn.apache.org/viewvc?view=rev&revision=735630 from OACC.
+  +1: rjung
+  -1:
(Continue reading)

rjung | 1 Jul 13:33
Picon
Favicon

svn commit: r790124 - /tomcat/current/tc5.5.x/STATUS.txt

Author: rjung
Date: Wed Jul  1 11:33:15 2009
New Revision: 790124

URL: http://svn.apache.org/viewvc?rev=790124&view=rev
Log:
Add proposal.

Modified:
    tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=790124&r1=790123&r2=790124&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Wed Jul  1 11:33:15 2009
@@ -186,3 +186,10 @@
   +1: rjung
   -1:

+* Remove obsolete classpath entry for commons-logging from start script.
+  The cl jar is contained in the cp via the manifest of the bootstrap.jar.
+  The cl jar file name in the startup script also is no longer correct,
+  so remove it completely.
+  http://people.apache.org/~rjung/patches/remove_cl_from_cp.patch
+  +1: rjung
+  -1:
kkolinko | 1 Jul 13:40
Picon
Favicon

svn commit: r790129 - /tomcat/current/tc5.5.x/STATUS.txt

Author: kkolinko
Date: Wed Jul  1 11:40:21 2009
New Revision: 790129

URL: http://svn.apache.org/viewvc?rev=790129&view=rev
Log:
votes

Modified:
    tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=790129&r1=790128&r2=790129&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Wed Jul  1 11:40:21 2009
@@ -170,20 +170,20 @@
   Properly output the state transfer timeout for sessions.
   Backport of http://svn.apache.org/viewvc?view=rev&revision=674750 from tc6
   resp. http://svn.apache.org/viewvc?view=rev&revision=735630 from OACC.
-  +1: rjung
+  +1: rjung, kkolinko
   -1:

 * Fix small memory leak found by find bugs.
   Backport of http://svn.apache.org/viewvc?view=rev&revision=717906 from tc6
   resp. http://svn.apache.org/viewvc?view=rev&revision=735645 from OACC.
-  +1: rjung
+  +1: rjung, kkolinko
   -1:
(Continue reading)

bugzilla | 1 Jul 14:31
Picon
Favicon

DO NOT REPLY [Bug 46384] Due to missing synchronization, a member may disappear permanent.

https://issues.apache.org/bugzilla/show_bug.cgi?id=46384

--- Comment #4 from Mark Thomas <markt <at> apache.org>  2009-07-01 05:31:22 PST ---
Patch withdrawn based on Filip's comment

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
markt | 1 Jul 14:31
Picon
Favicon
Gravatar

svn commit: r790141 - /tomcat/current/tc5.5.x/STATUS.txt

Author: markt
Date: Wed Jul  1 12:31:37 2009
New Revision: 790141

URL: http://svn.apache.org/viewvc?rev=790141&view=rev
Log:
Withdraw patch based in bz comment

Modified:
    tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=790141&r1=790140&r2=790141&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Wed Jul  1 12:31:37 2009
@@ -25,15 +25,6 @@
 PATCHES PROPOSED TO BACKPORT:
   [ New proposals should be added at the end of the list ]

-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46384
-  Use sync when adding and removing members
-  Note: Untested
-  https://issues.apache.org/bugzilla/attachment.cgi?id=23501
-  +1: markt
-  -1: 
-  +0: rjung
-  rjung: memebrshipMutex -> membershipMutex
-
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43343
(Continue reading)


Gmane