fhanik | 1 May 04:02 2009
Picon

svn commit: r770514 - /tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml

Author: fhanik
Date: Fri May  1 02:02:04 2009
New Revision: 770514

URL: http://svn.apache.org/viewvc?rev=770514&view=rev
Log:
doco

Modified:
    tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml

Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml?rev=770514&r1=770513&r2=770514&view=diff
==============================================================================
--- tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml (original)
+++ tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Fri May  1 02:02:04 2009
 <at>  <at>  -52,6 +52,9  <at>  <at> 
       <li>Tomcat jdbc pool implements a fairness option not available in commons-dbcp and still performs
faster than commons-dbcp</li>
       <li>Tomcat jdbc pool implements the ability retrieve a connection asynchronously, without adding
additional threads to the library itself</li> 
       <li>Tomcat jdbc pool is a Tomcat module, it depends on Tomcat JULI, a simplified logging framework used in Tomcat.</li>
+      <li>Retrieve the underlying connection using the javax.sql.PooledConnection interface.</li>
+      <li>Starvation proof. If a pool is empty, and threads are waiting for a connection, when a connection is
returned, 
+          the pool will awake the correct thread waiting. Most pools will simply starve.</li>
     </ol>
   </p>
fhanik | 1 May 05:40 2009
Picon

svn commit: r770525 - in /tomcat/trunk/modules/jdbc-pool: build.xml sign.sh

Author: fhanik
Date: Fri May  1 03:40:28 2009
New Revision: 770525

URL: http://svn.apache.org/viewvc?rev=770525&view=rev
Log:
Prepare for next build

Modified:
    tomcat/trunk/modules/jdbc-pool/build.xml
    tomcat/trunk/modules/jdbc-pool/sign.sh

Modified: tomcat/trunk/modules/jdbc-pool/build.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/build.xml?rev=770525&r1=770524&r2=770525&view=diff
==============================================================================
--- tomcat/trunk/modules/jdbc-pool/build.xml (original)
+++ tomcat/trunk/modules/jdbc-pool/build.xml Fri May  1 03:40:28 2009
 <at>  <at>  -23,7 +23,7  <at>  <at> 
   <!-- See "build.properties.sample" in the top level directory for all     -->
   <property name="version.major"         value="1" />
   <property name="version.minor"         value="0" />
-  <property name="version.build"         value="1" />
+  <property name="version.build"         value="2" />
   <property name="version.patch"         value="" />
   <property name="version"              
value="${version.major}.${version.minor}.${version.build}${version.patch}" />
   <!-- property values you must customize for successful building!!!        -->

Modified: tomcat/trunk/modules/jdbc-pool/sign.sh
URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/sign.sh?rev=770525&r1=770524&r2=770525&view=diff
(Continue reading)

fhanik | 1 May 05:43 2009
Picon

svn commit: r770526 - /tomcat/tags/JDBC_POOL_1_0_2/

Author: fhanik
Date: Fri May  1 03:42:59 2009
New Revision: 770526

URL: http://svn.apache.org/viewvc?rev=770526&view=rev
Log:
2nd tag for the pool code

Added:
    tomcat/tags/JDBC_POOL_1_0_2/   (props changed)
      - copied from r770525, tomcat/trunk/modules/jdbc-pool/

Propchange: tomcat/tags/JDBC_POOL_1_0_2/
------------------------------------------------------------------------------
    svn:mergeinfo = /tomcat/tc6.0.x/trunk/modules/jdbc-pool:742915
bugzilla | 1 May 13:09 2009
Picon

DO NOT REPLY [Bug 47133] New: Reloading web application causes CPU usage to spike when using AIO

https://issues.apache.org/bugzilla/show_bug.cgi?id=47133

           Summary: Reloading web application causes CPU usage to spike
                    when using AIO
           Product: Tomcat 6
           Version: 6.0.18
          Platform: PC
        OS/Version: Windows Vista
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Connectors
        AssignedTo: dev <at> tomcat.apache.org
        ReportedBy: kenneth.gendron <at> gmail.com

Created an attachment (id=23568)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23568)
Web Application

When using Tomcat 6 with Advanced IO the CPU usage will go to 100% under the
following sequence of events:

1) Start Tomcat
2) "Reload" AIO-Enabled Web Application from Tomcat Web Application Manager
page
3) Open Web Application
4) Terminate Web Application in middle of a request (i.e. Close Browser or
issue an XMLHttpRequest.abort()).

Once this is done the CPU will jump dramatically.
(Continue reading)

bugzilla | 1 May 13:39 2009
Picon

DO NOT REPLY [Bug 47133] Reloading web application causes CPU usage to spike when using AIO

https://issues.apache.org/bugzilla/show_bug.cgi?id=47133

--- Comment #1 from Kenneth Gendron <kenneth.gendron <at> gmail.com>  2009-05-01 04:39:37 PST ---
After further investigation CPU usage will spike if "Stop", "Reload" or
"Undeploy" is used from the manager while an active AIO request is being
processed by the container and that request gets terminated.  Even if the web
application were to be redeployed it will not prevent CPU from spiking.

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
Filip Hanik - Dev Lists | 1 May 16:29 2009

jdbc pool - prepping for a first release

I was thinking to create a release, (I know I dropped the ball on the 
last one), to gather feedback on the code itself.
There have been community members already provided feedback and bug 
fixes so I'm hoping to gather even more.
I created a tag and put it up here
http://people.apache.org/~fhanik/jdbc-pool/v1.0.2/
For feedback.

If everyone thinks its a good idea, I'll put up a vote for a release 
next week.

best
Filip
bugzilla | 1 May 16:31 2009
Picon

DO NOT REPLY [Bug 47053] org.apache.catalina.loader.WebAppClassLoader.getResources returns two resource URLs for identical resource when spaces exists in classpath

https://issues.apache.org/bugzilla/show_bug.cgi?id=47053

Mark Thomas <markt <at> apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WORKSFORME

--- Comment #1 from Mark Thomas <markt <at> apache.org>  2009-05-01 07:31:21 PST ---
I have tried, and failed, to reproduce this. Can you double check this and if
you still see this issue, provide the minimal steps to reproduce on a clean
Tomcat install. Ideally this would be something along the lines of:
- add the struts jar to WEB-INF/lib
- run this JSP

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
markt | 1 May 17:34 2009
Picon

svn commit: r770716 - /tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java

Author: markt
Date: Fri May  1 15:34:43 2009
New Revision: 770716

URL: http://svn.apache.org/viewvc?rev=770716&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47050
Remove unnecessary filtering

Modified:
    tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java

Modified: tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java?rev=770716&r1=770715&r2=770716&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java Fri May  1 15:34:43 2009
 <at>  <at>  -34,7 +34,6  <at>  <at> 
 import org.apache.catalina.connector.Request;
 import org.apache.catalina.connector.Response;
 import org.apache.catalina.deploy.ErrorPage;
-import org.apache.catalina.util.RequestUtil;
 import org.apache.catalina.util.StringManager;
 import org.apache.catalina.valves.ValveBase;
 import org.apache.juli.logging.Log;
 <at>  <at>  -323,7 +322,7  <at>  <at> 
             request.setAttribute(Globals.STATUS_CODE_ATTR,
                               new Integer(statusCode));

-            String message = RequestUtil.filter(response.getMessage());
(Continue reading)

bugzilla | 1 May 17:35 2009
Picon

DO NOT REPLY [Bug 47050] StandardHostValve.status unnecessarily HTML-escapes the error message

https://issues.apache.org/bugzilla/show_bug.cgi?id=47050

--- Comment #1 from Mark Thomas <markt <at> apache.org>  2009-05-01 08:35:29 PST ---
I fixed this for trunk as I can't see any negative security (XSS) impact. I'll
leave it a little while before proposing for backport in case others see
something I missed.

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
bugzilla | 1 May 17:48 2009
Picon

DO NOT REPLY [Bug 47061] JDBCStore for saving sessions doesn't support datasource

https://issues.apache.org/bugzilla/show_bug.cgi?id=47061

Mark Thomas <markt <at> apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

--- Comment #2 from Mark Thomas <markt <at> apache.org>  2009-05-01 08:48:56 PST ---
A couple of comments on your patch:
- It appears to more than advertised - eg moving the call to remove(). Should
this be a separate issue?
- The documentation is not updated.
- Think about the visibility of the new attributes and methods you are adding.
I'd probably start them off as private and increase visibility of required.

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Gmane