headers
bugzilla | 1 Nov 11:33
Picon
Favicon

DO NOT REPLY [Bug 46131] for a root context getContextPath returns "/" after a forward

https://issues.apache.org/bugzilla/show_bug.cgi?id=46131

Mark Thomas <markt <at> apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WORKSFORME

--- Comment #1 from Mark Thomas <markt <at> apache.org>  2008-11-01 03:33:25 PST ---
This works for me with a simple filter and servlet. I suspect something else in
your setup is responsible for the incorrect return value. 

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
Permalink | Reply | 0 comments |
headers
bugzilla | 1 Nov 22:30
Picon
Favicon

DO NOT REPLY [Bug 46131] for a root context getContextPath returns "/" after a forward

https://issues.apache.org/bugzilla/show_bug.cgi?id=46131

Denny Strietzbaum <denny.strietzbaum <at> hybris.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WORKSFORME                  |INVALID

--- Comment #2 from Denny Strietzbaum <denny.strietzbaum <at> hybris.de>  2008-11-01 14:30:29 PST ---
You're absolutely right.
I've tried it again at a my home machine and the problem was gone.
I still have this problem at work with a preconfigured tomcat installation.
Anyway, i'll change this bug to "invalid".

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
Permalink | Reply | 0 comments |
headers
markt | 2 Nov 01:34
Picon
Favicon
Gravatar

svn commit: r709811 - /tomcat/trunk/java/org/apache/coyote/http11/InternalInputBuffer.java

Author: markt
Date: Sat Nov  1 17:34:01 2008
New Revision: 709811

URL: http://svn.apache.org/viewvc?rev=709811&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46125
Change the exception if the headers are too big to force a 400 status code rather than the current 200

Modified:
    tomcat/trunk/java/org/apache/coyote/http11/InternalInputBuffer.java

Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalInputBuffer.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/InternalInputBuffer.java?rev=709811&r1=709810&r2=709811&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http11/InternalInputBuffer.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/InternalInputBuffer.java Sat Nov  1 17:34:01 2008
@@ -723,7 +723,7 @@
         if (parsingHeader) {

             if (lastValid == buf.length) {
-                throw new IOException
+                throw new IllegalArgumentException
                     (sm.getString("iib.requestheadertoolarge.error"));
             }
Permalink | Reply | 0 comments |
headers
markt | 2 Nov 01:36
Picon
Favicon
Gravatar

svn commit: r709812 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: markt
Date: Sat Nov  1 17:36:05 2008
New Revision: 709812

URL: http://svn.apache.org/viewvc?rev=709812&view=rev
Log:
Propose fix for 46125

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=709812&r1=709811&r2=709812&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sat Nov  1 17:36:05 2008
@@ -238,3 +238,10 @@
   http://svn.apache.org/viewvc?rev=709294&view=rev
   +1: markt
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46125
+  Change the exception to cause a 400 status code if the request headers are too
+  big
+  http://svn.apache.org/viewvc?rev=709811&view=rev
+  +1: markt
+  -1:
Permalink | Reply | 0 comments |
headers
bugzilla | 2 Nov 01:38
Picon
Favicon

DO NOT REPLY [Bug 46125] Setting large cookies in the request causes Tomcat to abort the connection

https://issues.apache.org/bugzilla/show_bug.cgi?id=46125

--- Comment #3 from Mark Thomas <markt <at> apache.org>  2008-11-01 17:38:01 PST ---
This has been fixed in trunk and proposed for 6.0.x.

Note that no content is returned but the return code is 400. There will also be
a log message if debug logging is enabled.

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
Permalink | Reply | 0 comments |
headers
markt | 2 Nov 01:39
Picon
Favicon
Gravatar

svn commit: r709816 - /tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties

Author: markt
Date: Sat Nov  1 17:39:54 2008
New Revision: 709816

URL: http://svn.apache.org/viewvc?rev=709816&view=rev
Log:
Path is required for a deploy

Modified:
    tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties

Modified: tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties?rev=709816&r1=709815&r2=709816&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties (original)
+++ tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties Sat Nov  1 17:39:54 2008
@@ -32,7 +32,7 @@
 htmlManagerServlet.helpManagerFile=../docs/manager-howto.html
 htmlManagerServlet.deployButton=Deploy
 htmlManagerServlet.deployConfig=XML Configuration file URL:
-htmlManagerServlet.deployPath=Context Path (optional):
+htmlManagerServlet.deployPath=Context Path (required):
 htmlManagerServlet.deployServer=Deploy directory or WAR file located on server
 htmlManagerServlet.deployTitle=Deploy
 htmlManagerServlet.deployUpload=WAR file to deploy
Permalink | Reply | 0 comments |
headers
markt | 2 Nov 01:42
Picon
Favicon
Gravatar

svn commit: r709819 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: markt
Date: Sat Nov  1 17:42:34 2008
New Revision: 709819

URL: http://svn.apache.org/viewvc?rev=709819&view=rev
Log:
Propose fix for 46115

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=709819&r1=709818&r2=709819&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sat Nov  1 17:42:34 2008
@@ -245,3 +245,9 @@
   http://svn.apache.org/viewvc?rev=709811&view=rev
   +1: markt
   -1:
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46115
+  Path is required when using deploy
+  http://svn.apache.org/viewvc?rev=709816&view=rev
+  +1: markt
+  -1:
Permalink | Reply | 0 comments |
headers
bugzilla | 2 Nov 01:42
Picon
Favicon

DO NOT REPLY [Bug 46115] Cannot deploy without specifying "Context Path"

https://issues.apache.org/bugzilla/show_bug.cgi?id=46115

--- Comment #1 from Mark Thomas <markt <at> apache.org>  2008-11-01 17:42:58 PST ---
You are correct, pah is required. I have updated trunk and proposed the fix for
6.0.x

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
Permalink | Reply | 0 comments |
headers
bugzilla | 2 Nov 01:44
Picon
Favicon

DO NOT REPLY [Bug 46096] DefaultAnnotationProcessor.processAnnotations should use doPrivileged to call getDeclaredFields

https://issues.apache.org/bugzilla/show_bug.cgi?id=46096

--- Comment #3 from Mark Thomas <markt <at> apache.org>  2008-11-01 17:44:21 PST ---
Comment#2 looks like a configuration issue. The security policy already grants
that permission to all code.

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
Permalink | Reply | 0 comments |
headers
markt | 2 Nov 01:48
Picon
Favicon
Gravatar

svn commit: r709821 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteWriter.java

Author: markt
Date: Sat Nov  1 17:48:28 2008
New Revision: 709821

URL: http://svn.apache.org/viewvc?rev=709821&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46051
The PrintWriter interface requires that the line separator is platform dependant. Not that this makes
much sense for a web application but there is a spec so we shoud stick to it.

Modified:
    tomcat/trunk/java/org/apache/catalina/connector/CoyoteWriter.java

Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteWriter.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/CoyoteWriter.java?rev=709821&r1=709820&r2=709821&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/connector/CoyoteWriter.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/CoyoteWriter.java Sat Nov  1 17:48:28 2008
@@ -32,8 +32,10 @@

     // -------------------------------------------------------------- Constants

-
-    private static final char[] LINE_SEP = { '\r', '\n' };
+    // No need for a do privileged block - every web app has permission to read
+    // this by default
+    private static final char[] LINE_SEP =
+        System.getProperty("line.separator").toCharArray();
(Continue reading)

Permalink | Reply | 0 comments |

Gmane