headers
Costin Manolache | 1 May 01:31
Picon
Gravatar

Re: Mavenizing Tomcat : Was: Osgifing Tomcat

Aren't we in 'comit then review' mode for the trunk ?

My understanding was that RTC is in effect for the stable releases, but not
the trunk,
and if there is no controversy ( and so far I think the only major issues
was
 'don't touch file structure or break ant' ) - he can just submit.

Sorry, I haven't been paying attention to all the rule changes - if someone
could
post the short version, I'm quite interested - I plan to re-start
contributing few things and it
would be good to know the process.

Costin

On Wed, Apr 30, 2008 at 3:55 PM, Filip Hanik - Dev Lists <devlists <at> hanik.com>
wrote:

> Costin Manolache wrote:
>
> > On Wed, Apr 30, 2008 at 11:31 AM, Filip Hanik - Dev Lists <
> > devlists <at> hanik.com> wrote:
> >
> >
> >
> > > Costin Manolache wrote:
> > >
> > >
> > >
(Continue reading)

Permalink | Reply | 13 comments |
headers
Filip Hanik - Dev Lists | 1 May 02:32

Re: Mavenizing Tomcat : Was: Osgifing Tomcat

Costin Manolache wrote:
> Aren't we in 'comit then review' mode for the trunk ?
>
> My understanding was that RTC is in effect for the stable releases, but not
> the trunk,
> and if there is no controversy ( and so far I think the only major issues
> was 'don't touch file structure or break ant' ) - he can just submit.
>   
if that was the case, the old trunk would have never been moved to sandbox,
that trunk was moved to sandbox based on code that never got a veto, -1.

I think the group has been careful lately, and always discussing changes 
to a consensus even before committing to trunk to avoid conflicts like 
that last one, which got quite ugly, even though it was just following CTR.

in terms of the maven stuff, I don't fully believe that it is non 
intrusive yet. if it means adding poms everywhere in our java source 
code directory structure, i would consider that intrusive.
> Sorry, I haven't been paying attention to all the rule changes - if someone
> could
> post the short version, I'm quite interested - I plan to re-start
> contributing few things and it
> would be good to know the process.
>   
consensus is always good to have, dont think we have fully recovered 
from the last episode yet to the point where we can just CTR anything

and listen to me, I was the one that marked revolutionary :)

Filip
(Continue reading)

Permalink | Reply | 10 comments |
headers
Costin Manolache | 1 May 03:06
Picon
Gravatar

Re: Mavenizing Tomcat : Was: Osgifing Tomcat

On Wed, Apr 30, 2008 at 5:32 PM, Filip Hanik - Dev Lists <devlists <at> hanik.com>
wrote:

> Costin Manolache wrote:
>
> > Aren't we in 'comit then review' mode for the trunk ?
> >
> > My understanding was that RTC is in effect for the stable releases, but
> > not
> > the trunk,
> > and if there is no controversy ( and so far I think the only major
> > issues
> > was 'don't touch file structure or break ant' ) - he can just submit.
> >
> >
> if that was the case, the old trunk would have never been moved to
> sandbox,
> that trunk was moved to sandbox based on code that never got a veto, -1.

I'm confused - there is a tomcat6/trunk repo - isn't this the trunk ?

I know there are different things in sandbox - and that's all fine for
things that are bigger
or controversial changes - but not sure how a project can work without a
trunk ( unless
tomcat is dead and moved to maintainance only - but I don't remember that
announcement )

> I think the group has been careful lately, and always discussing changes
> to a consensus even before committing to trunk to avoid conflicts like that
(Continue reading)

Permalink | Reply | 9 comments |
headers
Costin Manolache | 1 May 03:11
Picon
Gravatar

Re: Mavenizing Tomcat : Was: Osgifing Tomcat

BTW - can someone remove ever.sac <at> higienebeleza.com.br from tomcat-dev ?

It's quite annoying, after each mail I get an auto-reply from them...  I
don't think I have karma to do it.

Costin

On Wed, Apr 30, 2008 at 6:06 PM, Costin Manolache <costin <at> gmail.com> wrote:

> On Wed, Apr 30, 2008 at 5:32 PM, Filip Hanik - Dev Lists <
> devlists <at> hanik.com> wrote:
>
> > Costin Manolache wrote:
> >
> > > Aren't we in 'comit then review' mode for the trunk ?
> > >
> > > My understanding was that RTC is in effect for the stable releases,
> > > but not
> > > the trunk,
> > > and if there is no controversy ( and so far I think the only major
> > > issues
> > > was 'don't touch file structure or break ant' ) - he can just submit.
> > >
> > >
> > if that was the case, the old trunk would have never been moved to
> > sandbox,
> > that trunk was moved to sandbox based on code that never got a veto, -1.
>
>
> I'm confused - there is a tomcat6/trunk repo - isn't this the trunk ?
(Continue reading)

Permalink | Reply | 1 comment |
headers
Mark Thomas | 1 May 08:44
Picon
Favicon
Gravatar

Re: Mavenizing Tomcat : Was: Osgifing Tomcat

any Manolache wrote:
> BTW - can someone remove ever.sac <at> higienebeleza.com.br from tomcat-dev ?

being done now.

Mark
Permalink | Reply | 0 comments |
headers
Mark Thomas | 1 May 08:47
Picon
Favicon
Gravatar

Re: Mavenizing Tomcat : Was: Osgifing Tomcat

Costin Manolache wrote:
> Sorry, I haven't been paying attention to all the rule changes - if someone
> could
> post the short version, I'm quite interested - I plan to re-start
> contributing few things and it
> would be good to know the process.

trunk is CTR - normal veto rules apply
all release branches are RTC needing 3 more +1s than -1s to get committed

Everywhere else is also CTR - again with normal veto rules although it 
would have to be pretty drastic (eg license violation) to get a veto in the 
sandbox.

There is also a summary here:
http://wiki.apache.org/tomcat/TomcatVersions

HTH,

Mark
Permalink | Reply | 0 comments |
headers
Mark Thomas | 1 May 08:49
Picon
Favicon
Gravatar

Re: Mavenizing Tomcat : Was: Osgifing Tomcat

Costin Manolache wrote:
> Aren't we in 'comit then review' mode for the trunk ?
Yes.

> My understanding was that RTC is in effect for the stable releases, but not
> the trunk,
> and if there is no controversy ( and so far I think the only major issues
> was
>  'don't touch file structure or break ant' ) - he can just submit.
Correct. I'd need more convincing to vote +1 to get it into one of the 
release branches but for trunk - assuming no change to existing file 
structure - go for it.

Mark
Permalink | Reply | 0 comments |
headers
markt | 1 May 09:00
Picon
Favicon
Gravatar

svn commit: r652441 - /tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java

Author: markt
Date: Thu May  1 00:00:14 2008
New Revision: 652441

URL: http://svn.apache.org/viewvc?rev=652441&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43142
If someone is daft enough to name their directory xxx.war, don't assume it is a war file.

Modified:
    tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java

Modified: tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java?rev=652441&r1=652440&r2=652441&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java Thu May  1 00:00:14 2008
@@ -701,7 +701,7 @@
             if (files[i].equalsIgnoreCase("WEB-INF"))
                 continue;
             File dir = new File(appBase, files[i]);
-            if (files[i].toLowerCase().endsWith(".war")) {
+            if (files[i].toLowerCase().endsWith(".war") && dir.isFile()) {

                 // Calculate the context path and make sure it is unique
                 String contextPath = "/" + files[i];
Permalink | Reply | 0 comments |
headers
bugzilla | 1 May 09:36
Picon
Favicon

DO NOT REPLY [Bug 43142] webapp expanded in a FOLDER named webapps/xxx. war is loaded TWICE

https://issues.apache.org/bugzilla/show_bug.cgi?id=43142

--- Comment #1 from Mark Thomas <markt <at> apache.org>  2008-05-01 00:36:01 PST ---
Fixed in trunk and proposed for 6.0.17 onwards.

--

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
Permalink | Reply | 0 comments |
headers
markt | 1 May 09:42
Picon
Favicon
Gravatar

svn commit: r652447 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: markt
Date: Thu May  1 00:42:25 2008
New Revision: 652447

URL: http://svn.apache.org/viewvc?rev=652447&view=rev
Log:
Propose fix for 43142.

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=652447&r1=652446&r2=652447&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu May  1 00:42:25 2008
@@ -159,3 +159,9 @@
   http://svn.apache.org/viewvc?rev=651988&view=rev
   +1: markt
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43142
+  Don't assume a directory named xxx.war is a war file
+  http://svn.apache.org/viewvc?rev=652441&view=rev
+  +1: markt
+  -1:
Permalink | Reply | 0 comments |

Gmane