headers
remm | 1 May 2007 01:36
Picon
Favicon

svn commit: r533881 - /tomcat/tc6.0.x/trunk/webapps/examples/WEB-INF/classes/chat/ChatServlet.java

Author: remm
Date: Mon Apr 30 16:36:10 2007
New Revision: 533881

URL: http://svn.apache.org/viewvc?view=rev&rev=533881
Log:
- New read loop (much more conventional using the more accurate InputStream.available() method).

Modified:
    tomcat/tc6.0.x/trunk/webapps/examples/WEB-INF/classes/chat/ChatServlet.java

Modified: tomcat/tc6.0.x/trunk/webapps/examples/WEB-INF/classes/chat/ChatServlet.java
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/examples/WEB-INF/classes/chat/ChatServlet.java?view=diff&rev=533881&r1=533880&r2=533881
==============================================================================
--- tomcat/tc6.0.x/trunk/webapps/examples/WEB-INF/classes/chat/ChatServlet.java (original)
+++ tomcat/tc6.0.x/trunk/webapps/examples/WEB-INF/classes/chat/ChatServlet.java Mon Apr 30
16:36:10 2007
 <at>  <at>  -149,16 +149,18  <at>  <at> 
         throws IOException, ServletException {
         InputStream is = request.getInputStream();
         byte[] buf = new byte[512];
-        do {
+        while (is.available() > 0) {
+            log("Available: " + is.available());
             int n = is.read(buf);
             if (n > 0) {
                 log("Read " + n + " bytes: " + new String(buf, 0, n) 
                         + " for session: " + request.getSession(true).getId());
             } else if (n < 0) {
-                error(event, request, response);
(Continue reading)

Permalink | Reply | 5 comments |
headers
remm | 1 May 2007 01:39
Picon
Favicon

svn commit: r533882 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/InputBuffer.java

Author: remm
Date: Mon Apr 30 16:39:41 2007
New Revision: 533882

URL: http://svn.apache.org/viewvc?view=rev&rev=533882
Log:
- Obvious typo in didRead. Ooops. Maybe Eclipse did that.
- Return 1 for available when using a Comet read and no real read was done (actually, it could well be good enough
  to only use didRead to get an "accurate" available() method, but it could probably be useful for blocking IO).

Modified:
    tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/InputBuffer.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/InputBuffer.java
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/InputBuffer.java?view=diff&rev=533882&r1=533881&r2=533882
==============================================================================
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/InputBuffer.java (original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/InputBuffer.java Mon Apr 30
16:39:41 2007
 <at>  <at>  -101,7 +101,7  <at>  <at> 
     /**
      * Flag which if a read was performed.
      */
-    private boolean didRead = false;
+    private boolean didRead = true;

 
     /**
 <at>  <at>  -274,12 +274,20  <at>  <at> 
             coyoteRequest.action(ActionCode.ACTION_AVAILABLE, null);
(Continue reading)

Permalink | Reply | 0 comments |
headers
bugzilla | 1 May 2007 04:44
Picon
Favicon

DO NOT REPLY [Bug 40668] - MailSessionFactory is missing in Tomcat 5.5.23

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40668>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40668

sprior <at> geekster.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sprior <at> geekster.com

------- Additional Comments From sprior <at> geekster.com  2007-04-30 19:44 -------
add cc

--

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
Permalink | Reply | 0 comments |
headers
bugzilla | 1 May 2007 10:57
Picon
Favicon

DO NOT REPLY [Bug 42308] New: - with APR bytessent bytesreceived performance data is not collected

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42308>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42308

           Summary: with APR bytessent bytesreceived performance data is not
                    collected
           Product: Tomcat 6
           Version: 6.0.10
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
        AssignedTo: tomcat-dev <at> jakarta.apache.org
        ReportedBy: rzo <at> gmx.de

with APR bytes received and bytes sent are always 0.

--

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
Permalink | Reply | 1 comment |
headers
bugzilla | 1 May 2007 11:03
Picon
Favicon

DO NOT REPLY [Bug 42309] New: - Request: support for NIO in Embedded Tomcat

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42309>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42309

           Summary: Request: support for NIO in Embedded Tomcat
           Product: Tomcat 6
           Version: 6.0.10
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Catalina
        AssignedTo: tomcat-dev <at> jakarta.apache.org
        ReportedBy: rzo <at> gmx.de

in org.apache.catalina.startup.Embedded there is no direct API to create an NIO
connector. This would be very helpful for all applications which use tomcat in
embedded mode and require the CometProcessor.

--

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
Permalink | Reply | 1 comment |
headers
rjung | 1 May 2007 12:55
Picon
Favicon

svn commit: r534003 - /tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c

Author: rjung
Date: Tue May  1 03:55:14 2007
New Revision: 534003

URL: http://svn.apache.org/viewvc?view=rev&rev=534003
Log:
Changing init order for nsapi plugin maps.
Otherwise using mount attribute inside workers.properties
will crash during startup.

Modified:
    tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c

Modified: tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c
URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c?view=diff&rev=534003&r1=534002&r2=534003
==============================================================================
--- tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c (original)
+++ tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c Tue May  1 03:55:14 2007
 <at>  <at>  -90,11 +90,11  <at>  <at> 
     init_map = (jk_map_t *)init_d;
     /* we add the URI->WORKER MAP since workers using AJP14 will feed it */
     /* but where are they here in Netscape ? */
-    if (wc_open(init_map, &worker_env, logger)) {
-        if (uri_worker_map_alloc(&uw_map, NULL, logger)) {
-            uw_map->fname = "";
-            uw_map->reload = JK_URIMAP_DEF_RELOAD;
-            worker_env.uri_to_worker = uw_map;
+    if (uri_worker_map_alloc(&uw_map, NULL, logger)) {
+        uw_map->fname = "";
+        uw_map->reload = JK_URIMAP_DEF_RELOAD;
(Continue reading)

Permalink | Reply | 0 comments |
headers
rjung | 1 May 2007 12:57
Picon
Favicon

svn commit: r534004 - /tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c

Author: rjung
Date: Tue May  1 03:57:45 2007
New Revision: 534004

URL: http://svn.apache.org/viewvc?view=rev&rev=534004
Log:
Add init for more recent service properties forgotten
in nsapi plugin.

Modified:
    tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c

Modified: tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c
URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c?view=diff&rev=534004&r1=534003&r2=534004
==============================================================================
--- tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c (original)
+++ tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c Tue May  1 03:57:45 2007
 <at>  <at>  -342,6 +342,7  <at>  <at> 

         s.ws_private = &private_data;
         s.pool = &private_data.p;
+        s.retries = worker->retries;

         wc_maintain(logger);
         if (init_ws_service(&private_data, &s)) {
 <at>  <at>  -371,6 +372,9  <at>  <at> 
     s->read = ws_read;
     s->write = ws_write;
     s->flush = NULL;
+    s->flush_packets = JK_FALSE;
(Continue reading)

Permalink | Reply | 0 comments |
headers
bugzilla | 1 May 2007 13:50
Picon
Favicon

DO NOT REPLY [Bug 42310] New: - Improve JSP performance with inline in JspWriterImpl

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42310>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42310

           Summary: Improve JSP performance with inline in JspWriterImpl
           Product: Tomcat 5
           Version: Unknown
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Jasper
        AssignedTo: tomcat-dev <at> jakarta.apache.org
        ReportedBy: michael.mao <at> achievo.com

I am not sure if all JDK can support smart inline at runtime. During testing 
JSP performance with profile tools, I found that so many performance cost was 
took for checking to see if ServletResponse is closed. It is not very worth. 
Please inline the following methods for better performance.

ensureOpen
min

--

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
(Continue reading)

Permalink | Reply | 1 comment |
headers
fuankg | 1 May 2007 13:53
Picon
Favicon

svn commit: r534021 - /tomcat/connectors/trunk/jk/native/common/jk_map.c

Author: fuankg
Date: Tue May  1 04:53:37 2007
New Revision: 534021

URL: http://svn.apache.org/viewvc?view=rev&rev=534021
Log:
changed to use jk_stat() to initialite the stat struct so that *modified = statbuf.st_mtime can work.

Modified:
    tomcat/connectors/trunk/jk/native/common/jk_map.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_map.c
URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_map.c?view=diff&rev=534021&r1=534020&r2=534021
==============================================================================
--- tomcat/connectors/trunk/jk/native/common/jk_map.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_map.c Tue May  1 04:53:37 2007
 <at>  <at>  -485,7 +485,7  <at>  <at> 
     if (m && f) {
         struct stat statbuf;
         FILE *fp;
-        if (jk_file_exists(f) != JK_TRUE)
+        if (jk_stat(f, &statbuf) == -1)
             return JK_FALSE;
 #if defined(AS400) && !defined(AS400_UTF8)
         fp = fopen(f, "r, o_ccsid=0");
Permalink | Reply | 1 comment |
headers
Guenter Knauf | 1 May 2007 13:59
Picon
Favicon

Re: svn commit: r534021 - /tomcat/connectors/trunk/jk/native/common/jk_map.c

Hi Henri,
I've commited the change below because I think this is an oversight with all your recent changes;
the stat struct was not initialized with your change to jk_file_exists(f), and thus later on
*modified = statbuf.st_mtime
was set from the uninitialized struct, and could never return someting useful in 'time_t modified'.

greets, Guenter.

> Author: fuankg
> Date: Tue May  1 04:53:37 2007
> New Revision: 534021

> URL: http://svn.apache.org/viewvc?view=rev&rev=534021
> Log:
> changed to use jk_stat() to initialite the stat struct so that *modified =
> statbuf.st_mtime can work.

> Modified:
>     tomcat/connectors/trunk/jk/native/common/jk_map.c

> Modified: tomcat/connectors/trunk/jk/native/common/jk_map.c
> URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common
> /jk_map.c?view=diff&rev=534021&r1=534020&r2=534021
> ==========================================================================
> ====
> --- tomcat/connectors/trunk/jk/native/common/jk_map.c (original)
> +++ tomcat/connectors/trunk/jk/native/common/jk_map.c Tue May  1 04:53:37
> 2007
>  <at>  <at>  -485,7 +485,7  <at>  <at> 
>      if (m && f) {
(Continue reading)

Permalink | Reply | 0 comments |

Gmane