Tomcat Servlet Container development

Phil Steitz | 1 Jan 2003 02:01

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session ManagerBase.java

billbarker <at> apache.org wrote:
> billbarker    2002/12/30 19:45:48
> 
>   Modified:    catalina/src/share/org/apache/catalina/session
>                         ManagerBase.java
>   Log:
>   Make certain that the jvmRoute is attached to the session before comparing for uniqueness.
>   
>   Submitted by: Glenn Olander glenn <at> greenoak.com
>   
>   Revision  Changes    Path
>   1.16      +15 -9     jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/ManagerBase.java
>   
>   Index: ManagerBase.java
>   ===================================================================
>   RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/ManagerBase.java,v
>   retrieving revision 1.15
>   retrieving revision 1.16
>   diff -u -r1.15 -r1.16
>   --- ManagerBase.java	30 Dec 2002 02:36:26 -0000	1.15
>   +++ ManagerBase.java	31 Dec 2002 03:45:48 -0000	1.16
>    <at>  <at>  -580,17 +580,23  <at>  <at> 
>            session.setMaxInactiveInterval(this.maxInactiveInterval);
>            String sessionId = generateSessionId();
>    
>   -        synchronized (sessions) {
>   -            while (sessions.get(sessionId) != null)        // Guarantee uniqueness
>   -                sessionId = generateSessionId();
>   -        }
>   -

(Continue reading)

Glenn Olander | 1 Jan 2003 02:17

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session ManagerBase.java

fyi, this still isn't correct.  If you can simply copy/paste the code
from these messages I'm sending, that should ensure the correct code 
gets checked in. Here is
what it should look like:

        String sessionId = generateSessionId();
        String jvmRoute = getJvmRoute();
        //  <at> todo Move appending of jvmRoute generateSessionId()???
        if (jvmRoute != null) {
            sessionId += '.' + jvmRoute;
        }  
        synchronized (sessions) {
            while (sessions.get(sessionId) != null){        // Guarantee 
uniqueness
                log("Found duplicate session id, getting a new one.");
                sessionId = generateSessionId();
                if (jvmRoute != null) {
                    sessionId += '.' + jvmRoute;
                }
            }
            session.setId(sessionId);
        }
        return (session);

bugzilla | 1 Jan 2003 03:10

Picon

DO NOT REPLY [Bug 15746] New: - Possible concurrency problem in StandardSession.recycle()

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15746>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15746

Possible concurrency problem in StandardSession.recycle()

           Summary: Possible concurrency problem in
                    StandardSession.recycle()
           Product: Tomcat 4
           Version: 4.1.19
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Catalina
        AssignedTo: tomcat-dev <at> jakarta.apache.org
        ReportedBy: phil <at> steitz.com

A session being recycled could have attributes added by other threads *after*
the attributes are cleared, since this method is not synchronized.

This exposure can be eliminated by moving the isValid = false to the beginning
of the method.

bugzilla | 1 Jan 2003 03:12

Picon

DO NOT REPLY [Bug 15746] - Possible concurrency problem in StandardSession.recycle()

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15746>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15746

Possible concurrency problem in StandardSession.recycle()

------- Additional Comments From phil <at> steitz.com  2003-01-01 02:12 -------
Created an attachment (id=4311)
Patch to move isValid = false to start of StandardSession.recycle()

billbarker | 1 Jan 2003 07:24

Picon

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session ManagerBase.java

billbarker    2002/12/31 22:24:26

  Modified:    catalina/src/share/org/apache/catalina/session
                        ManagerBase.java
  Log:
  Set the sessionId property only once.

  It seems that this is an issue for the community, so let's get it right.

  Submitted by: Phil Steitz phil <at> steitz.com

  Revision  Changes    Path
  1.17      +4 -6      jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/ManagerBase.java

  Index: ManagerBase.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/ManagerBase.java,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- ManagerBase.java	31 Dec 2002 03:45:48 -0000	1.16
  +++ ManagerBase.java	1 Jan 2003 06:24:26 -0000	1.17
   <at>  <at>  -584,7 +584,6  <at>  <at> 
           //  <at> todo Move appending of jvmRoute generateSessionId()???
           if (jvmRoute != null) {
               sessionId += '.' + jvmRoute;
  -            session.setId(sessionId);
           }
           synchronized (sessions) {
               while (sessions.get(sessionId) != null){ // Guarantee uniqueness

(Continue reading)

billbarker | 1 Jan 2003 07:26

Picon

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session ManagerBase.java

billbarker    2002/12/31 22:26:32

  Modified:    catalina/src/share/org/apache/catalina/session
                        ManagerBase.java
  Log:
  Port from Tomcat 4.

  Revision  Changes    Path
  1.10      +4 -6      jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/ManagerBase.java

  Index: ManagerBase.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/ManagerBase.java,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- ManagerBase.java	31 Dec 2002 03:48:08 -0000	1.9
  +++ ManagerBase.java	1 Jan 2003 06:26:32 -0000	1.10
   <at>  <at>  -637,7 +637,6  <at>  <at> 
           //  <at> todo Move appending of jvmRoute generateSessionId()???
           if (jvmRoute != null) {
               sessionId += '.' + jvmRoute;
  -            session.setId(sessionId);
           }
           synchronized (sessions) {
               while (sessions.get(sessionId) != null){ // Guarantee uniqueness
   <at>  <at>  -645,7 +644,6  <at>  <at> 
                   //  <at> todo Move appending of jvmRoute generateSessionId()???
                   if (jvmRoute != null) {
                       sessionId += '.' + jvmRoute;

(Continue reading)

remm | 1 Jan 2003 13:25

Picon

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler TagPluginManager.java

remm        2003/01/01 04:25:58

  Modified:    jasper2/src/share/org/apache/jasper/compiler
                        TagPluginManager.java
  Log:
  - To support nested tags, we should also visit child nodes.

  Revision  Changes    Path
  1.9       +13 -7     jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagPluginManager.java

  Index: TagPluginManager.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagPluginManager.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- TagPluginManager.java	6 Dec 2002 23:19:58 -0000	1.8
  +++ TagPluginManager.java	1 Jan 2003 12:25:58 -0000	1.9
   <at>  <at>  -97,11 +97,17  <at>  <at> 
   	    return;
   	}

  -	page.visit(new Node.Visitor() {
  -            public void visit(Node.CustomTag n) {
  -		invokePlugin(n);
  +        page.visit(new Node.Visitor() {
  +            public void visit(Node.CustomTag n)
  +                throws JasperException {
  +                invokePlugin(n);
  +                Node.Nodes body = n.getBody();

(Continue reading)

remm | 1 Jan 2003 14:55

Picon

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

remm        2003/01/01 05:55:22

  Modified:    util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java
  Log:
  - Don't check for null on the connection (it should never be null, and should be
    caught by the throwable and logged if it happens).
  - Fix a problem when using SSL: when an exception occurs during the handshake,
    if continue is used, the thread will immediately start to listen on the socket,
    for no good reason. I found that patch on tomcat-user, alledgedly submitted
    by Xiaojian Wang (I couldn't find the original message), and reposted
    by Carl Zetterberg.

  Revision  Changes    Path
  1.11      +5 -7      jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java

  Index: PoolTcpEndpoint.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- PoolTcpEndpoint.java	19 Dec 2002 15:55:45 -0000	1.10
  +++ PoolTcpEndpoint.java	1 Jan 2003 13:55:22 -0000	1.11
   <at>  <at>  -519,12 +519,12  <at>  <at> 
                           endpoint.getServerSocketFactory().handshake(s);
    		    }
                   } catch (Throwable t) {
  -                    endpoint.log.info("Handshake failed", t);
  +                    endpoint.log.debug("Handshake failed", t);
                       // Try to close the socket

(Continue reading)

remm | 1 Jan 2003 16:21

Picon

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper EmbededServletOptions.java

remm        2003/01/01 07:21:01

  Modified:    jasper2/src/share/org/apache/jasper
                        EmbededServletOptions.java
  Log:
  - Due to continued problems with javac, I think fork should default to true.

  Revision  Changes    Path
  1.17      +4 -4      jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbededServletOptions.java

  Index: EmbededServletOptions.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbededServletOptions.java,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- EmbededServletOptions.java	31 Dec 2002 14:01:17 -0000	1.16
  +++ EmbededServletOptions.java	1 Jan 2003 15:21:01 -0000	1.17
   <at>  <at>  -93,7 +93,7  <at>  <at> 
       /**
        * Should Ant fork its java compiles of JSP pages.
        */
  -    public boolean fork = false;
  +    public boolean fork = true;

       /**
        * Do you want to keep the generated Java files around?

remm | 1 Jan 2003 16:21

Picon

cvs commit: jakarta-tomcat-catalina/catalina/src/conf web.xml

remm        2003/01/01 07:21:40

  Modified:    catalina/src/conf web.xml
  Log:
  - Due to continued problems with javac, I think fork should default to true.

  Revision  Changes    Path
  1.11      +1 -1      jakarta-tomcat-catalina/catalina/src/conf/web.xml

  Index: web.xml
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/conf/web.xml,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- web.xml	31 Dec 2002 14:12:31 -0000	1.10
  +++ web.xml	1 Jan 2003 15:21:40 -0000	1.11
   <at>  <at>  -113,7 +113,7  <at>  <at> 
     <!--                                                                      -->
     <!--   fork                Tell Ant to fork compiles of JSP pages so that -->
     <!--                       a separate JVM is used for JSP page compiles   -->
  -  <!--                       from the one Tomcat is running in. [false]     -->
  +  <!--                       from the one Tomcat is running in. [true]      -->
     <!--                                                                      -->
     <!--   ieClassId           The class-id value to be sent to Internet      -->
     <!--                       Explorer when using <jsp:plugin> tags.         -->

Group

gmane.comp.jakarta.tomcat.devel.

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 142

Articles in period: 1419

January 2003

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

buildbot failure in ASF Buildbot on tomcat-trunk (24 May 2013)
svn commit: r1486134 - in /tomcat/trunk: java/org/apache/catalina/conn (24 May 2013)
mod_jk AM_MAINTAINER_MODE nightmares (24 May 2013)
svn commit: r1486085 - /tomcat/trunk/java/org/apache/coyote/AsyncState (24 May 2013)
[Bug 55017] New: Ability to configure RMI bind address (24 May 2013)
[jira] [Created] (MTOMCAT-224) Tomcat Maven Plugin is not marked @thre (24 May 2013)
svn commit: r1486064 - /tomcat/trunk/test/org/apache/catalina/nonblock (24 May 2013)
svn commit: r1486062 - /tomcat/trunk/test/org/apache/catalina/connecto (24 May 2013)
svn commit: r1486061 - /tomcat/trunk/java/org/apache/catalina/connecto (24 May 2013)
svn commit: r1486060 - in /tomcat/trunk/java/org/apache: catalina/conn (24 May 2013)
svn commit: r1486059 - /tomcat/trunk/java/org/apache/coyote/http11/fil (24 May 2013)
svn commit: r1486056 - in /tomcat/trunk/java/org/apache/coyote/http11: (24 May 2013)
svn commit: r1485972 - /tomcat/trunk/java/org/apache/catalina/connecto (24 May 2013)
svn commit: r1485862 - /tomcat/trunk/test/org/apache/catalina/startup/ (23 May 2013)
svn commit: r1485855 - /tomcat/trunk/java/org/apache/coyote/http11/Htt (23 May 2013)
svn commit: r1485854 - /tomcat/trunk/java/org/apache/coyote/http11/Abs (23 May 2013)
svn commit: r1485847 - /tomcat/trunk/java/org/apache/tomcat/util/net/A (23 May 2013)
svn commit: r1485833 - /tomcat/trunk/test/org/apache/tomcat/util/net/T (23 May 2013)
svn commit: r1485720 - /tomcat/trunk/java/org/apache/coyote/http11/Abs (23 May 2013)
svn commit: r1485660 - in /tomcat/trunk/java/org/apache/coyote/http11: (23 May 2013)
svn commit: r1485659 - /tomcat/trunk/java/org/apache/coyote/http11/Loc (23 May 2013)

Archives

500	May 2013
601	April 2013
1143	March 2013
1048	February 2013
1196	January 2013
779	December 2012
874	November 2012
868	October 2012
573	September 2012
808	August 2012
754	July 2012
1126	June 2012
857	May 2012
658	April 2012
1521	March 2012
1073	February 2012
967	January 2012
841	December 2011
979	November 2011
1220	October 2011
887	September 2011
807	August 2011
997	July 2011
1013	June 2011
654	May 2011
478	April 2011
743	March 2011
780	February 2011
1168	January 2011
740	December 2010
956	November 2010
1158	October 2010
980	September 2010
702	August 2010
862	July 2010
746	June 2010
733	May 2010
955	April 2010
1246	March 2010
1081	February 2010
1007	January 2010
895	December 2009
1174	November 2009
449	October 2009
572	September 2009
539	August 2009
854	July 2009
1000	June 2009
464	May 2009
653	April 2009
632	March 2009
319	February 2009
463	January 2009
429	December 2008
625	November 2008
758	October 2008
669	September 2008
508	August 2008
523	July 2008
437	June 2008
538	May 2008
646	April 2008
756	March 2008
627	February 2008
989	January 2008
545	December 2007
620	November 2007
820	October 2007
645	September 2007
668	August 2007
451	July 2007
583	June 2007
792	May 2007
854	April 2007
1036	March 2007
612	February 2007
606	January 2007
781	December 2006
863	November 2006
879	October 2006
842	September 2006
696	August 2006
3487	July 2006
797	June 2006
701	May 2006
878	April 2006
966	March 2006
754	February 2006
677	January 2006
617	December 2005
726	November 2005
589	October 2005
957	September 2005
611	August 2005
988	July 2005
820	June 2005
818	May 2005
1083	April 2005
1167	March 2005
1111	February 2005
922	January 2005
1118	December 2004
1061	November 2004
1220	October 2004
1142	September 2004
1328	August 2004
1683	July 2004
946	June 2004
1122	May 2004
1196	April 2004
2254	March 2004
1597	February 2004
1437	January 2004
1006	December 2003
983	November 2003
1131	October 2003
1276	September 2003
1211	August 2003
1138	July 2003
938	June 2003
1051	May 2003
1547	April 2003
1524	March 2003
1117	February 2003
1415	January 2003
1205	December 2002
1393	November 2002
1852	October 2002
1917	September 2002
1650	August 2002
1434	July 2002
2092	June 2002
1975	May 2002
2047	April 2002
926	March 2002
1	November 2001
1	May 2000
1	October 1998

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template