Re: [jira] Updated: (LUCENE-1855) Change AttributeSource API to use generics

Re: [jira] Updated: (LUCENE-1855) Change AttributeSource API to use generics

The op precedence parser (PrecedenceQueryParser) is somewhat
experimental if I remember right, and doesnt fully work right. I think
it talks about that in the comments.

It should prob be deprecated in light of the new queryparser framework.

Michael Busch wrote:
> I think the new contrib query parser already has support for operator
> precedence, but it's turned off for backwards-compatibility with the
> core parser. It's planned to turn it on with LUCENE-1823.
>
>  Michael
>
> On 9/30/09 3:18 PM, Robert Muir wrote:
>> also I don't claim to understand what the precedence features really
>> are, perhaps this functionality is obseleted by the new query parser,
>> or could be implemented by it?
>>
>> On Wed, Sep 30, 2009 at 6:10 PM, Robert Muir <rcmuir <at> gmail.com
>> <mailto:rcmuir <at> gmail.com>> wrote:
>>
>>     uwe, somewhat related to attributes API... anyway I can trick you
>>     or Luis or someone more familiar with QueryParsing into looking
>>     at PrecedenceQueryParser under contrib/misc?
>>
>>     This still uses the old tokenstream next(Token) API!
>>
>>     I think for this one I don't feel comfortable trying to convert
>>     it... scared to introduce bugs :)
>>
>>
>>     On Wed, Sep 30, 2009 at 5:56 PM, Uwe Schindler <uwe <at> thetaphi.de
>>     <mailto:uwe <at> thetaphi.de>> wrote:
>>
>>         Thanks...! I asked, because you know the tokenizers better J
>>
>>          
>>
>>         Uwe
>>
>>         -----
>>         Uwe Schindler
>>         H.-H.-Meier-Allee 63, D-28213 Bremen
>>         http://www.thetaphi.de
>>         eMail: uwe <at> thetaphi.de <mailto:uwe <at> thetaphi.de>
>>
>>         ------------------------------------------------------------------------
>>
>>         *From:* Robert Muir [mailto:rcmuir <at> gmail.com
>>         <mailto:rcmuir <at> gmail.com>]
>>         *Sent:* Wednesday, September 30, 2009 11:52 PM
>>         *To:* java-dev <at> lucene.apache.org
>>         <mailto:java-dev <at> lucene.apache.org>
>>         *Subject:* Re: [jira] Updated: (LUCENE-1855) Change
>>         AttributeSource API to use generics
>>
>>          
>>
>>         Uwe, I can work on the contrib portion tonight (jira is not
>>         happy with me right now)
>>
>>         On Wed, Sep 30, 2009 at 5:33 PM, Uwe Schindler (JIRA)
>>         <jira <at> apache.org <mailto:jira <at> apache.org>> wrote:
>>
>>
>>             [
>>         https://issues.apache.org/jira/browse/LUCENE-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>         ]
>>
>>         Uwe Schindler updated LUCENE-1855:
>>         ----------------------------------
>>
>>            Attachment: LUCENE-1855.patch
>>
>>         Some Javadoc additions, also change QueryParser.jj file.
>>
>>         Contrib and contrib queryparser was not converted. The new
>>         Queryparser would also get cleaner without the unneeded casts.
>>
>>         I will commit this tomorrow, when JIRA hopefully works better.
>>
>>         Robert Muir: Do you have time to remove the casts from contrib?
>>         Luis Alves: You can also update the new Queryparser to not
>>         cas the return of getAttribute/addAttribute
>>
>>
>>         > Change AttributeSource API to use generics
>>         > ------------------------------------------
>>         >
>>         >                 Key: LUCENE-1855
>>         >                 URL:
>>         https://issues.apache.org/jira/browse/LUCENE-1855
>>         >             Project: Lucene - Java
>>         >          Issue Type: Improvement
>>         >          Components: Analysis
>>         >            Reporter: Michael Busch
>>         >            Assignee: Uwe Schindler
>>         >            Priority: Minor
>>         >             Fix For: 3.0
>>         >
>>
>>         >         Attachments: AttributeSource.jad, LUCENE-1855.patch,
>>         LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855.patch,
>>         LUCENE-1855.patch
>>
>>         >
>>         >
>>         > The AttributeSource API will be easier to use with JDK 1.5
>>         generics.
>>         > Uwe, if you started working on a patch for this already feel
>>         free to assign this to you.
>>
>>         --
>>         This message is automatically generated by JIRA.
>>         -
>>         You can reply to this email to add a comment to the issue online.
>>
>>
>>         ---------------------------------------------------------------------
>>         To unsubscribe, e-mail:
>>         java-dev-unsubscribe <at> lucene.apache.org
>>         <mailto:java-dev-unsubscribe <at> lucene.apache.org>
>>         For additional commands, e-mail:
>>         java-dev-help <at> lucene.apache.org
>>         <mailto:java-dev-help <at> lucene.apache.org>
>>
>>
>>
>>
>>         -- 
>>         Robert Muir
>>         rcmuir <at> gmail.com <mailto:rcmuir <at> gmail.com>
>>
>>
>>
>>
>>     -- 
>>     Robert Muir
>>     rcmuir <at> gmail.com <mailto:rcmuir <at> gmail.com>
>>
>>
>>
>>
>> -- 
>> Robert Muir
>> rcmuir <at> gmail.com <mailto:rcmuir <at> gmail.com>
>

--

-- 
- Mark

http://www.lucidimagination.com

Create large preallocated file blocks when performing merges

I wanted to post this before I forgot. Based on an informal
discussion at the Katta meeting regarding the high write
throughput of Zookeeper (see
http://wiki.apache.org/hadoop/ZooKeeper/Performance ) which uses
the database technique of preallocating large empty files before
filling them up with real data, it came up that perhaps this
technique could help with the speed of Lucene segment merging?

Lucene would preallocate new target merge files with zeroes of
lets say one megabyte in size, then proceed to fill it in with
the merge data, truncating the file to the actual size when
completed. This would probably only need to be switched on when
merging large segments.

[jira] Updated: (LUCENE-1855) Change AttributeSource API to use generics

     [
https://issues.apache.org/jira/browse/LUCENE-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-1855:
--------------------------------

    Attachment: LUCENE-1855_contrib.patch

patch for contrib (except for the new queryparser)

> Change AttributeSource API to use generics
> ------------------------------------------
>
>                 Key: LUCENE-1855
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1855
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>            Reporter: Michael Busch
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: AttributeSource.jad, LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855.patch,
LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855_contrib.patch
>
>
> The AttributeSource API will be easier to use with JDK 1.5 generics.
> Uwe, if you started working on a patch for this already feel free to assign this to you.

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [jira] Updated: (LUCENE-1855) Change AttributeSource API to use generics

On Sep 30, 2009, at 3:10 PM, Robert Muir wrote:

> uwe, somewhat related to attributes API... anyway I can trick you or  
> Luis or someone more familiar with QueryParsing into looking at  
> PrecedenceQueryParser under contrib/misc?

PQP was my contribution, I think.  But it was merely a proof-of- 
concept.  Anyone using it?  I'm not.  I'm fine with it going away  
rather than spending time on it.

	Erik

[jira] Updated: (LUCENE-1855) Change AttributeSource API to use generics

     [
https://issues.apache.org/jira/browse/LUCENE-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adriano Crestani updated LUCENE-1855:
-------------------------------------

    Attachment: LUCENE-1855_contrib_queryparser.patch

Here is the patch for contrib/queryparser

> Change AttributeSource API to use generics
> ------------------------------------------
>
>                 Key: LUCENE-1855
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1855
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>            Reporter: Michael Busch
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: AttributeSource.jad, LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855.patch,
LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855_contrib.patch, LUCENE-1855_contrib_queryparser.patch
>
>
> The AttributeSource API will be easier to use with JDK 1.5 generics.
> Uwe, if you started working on a patch for this already feel free to assign this to you.

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (LUCENE-1855) Change AttributeSource API to use generics

    [
https://issues.apache.org/jira/browse/LUCENE-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761108#action_12761108
] 

Uwe Schindler commented on LUCENE-1855:
---------------------------------------

Oh thanks Adriano, I haven't seen your patch! I will add it!

Thank you very much!

> Change AttributeSource API to use generics
> ------------------------------------------
>
>                 Key: LUCENE-1855
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1855
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>            Reporter: Michael Busch
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: AttributeSource.jad, LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855.patch,
LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855_contrib.patch, LUCENE-1855_contrib_queryparser.patch
>
>
> The AttributeSource API will be easier to use with JDK 1.5 generics.
> Uwe, if you started working on a patch for this already feel free to assign this to you.

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (LUCENE-1855) Change AttributeSource API to use generics

     [
https://issues.apache.org/jira/browse/LUCENE-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-1855:
----------------------------------

    Attachment: LUCENE-1855.patch

A small update to my core patch, it now needs no  <at> SuppressWarnings anymore in addAttribute/getAttribute impl

I will commit soon.

Thanks Robert for the contrib patch. I will do the new QueryParser later. The PrecedenceParser must be
fixed or removed, when the old TokenStream API gets removed.

> Change AttributeSource API to use generics
> ------------------------------------------
>
>                 Key: LUCENE-1855
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1855
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>            Reporter: Michael Busch
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: AttributeSource.jad, LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855.patch,
LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855_contrib.patch, LUCENE-1855_contrib_queryparser.patch
>
>
> The AttributeSource API will be easier to use with JDK 1.5 generics.
> Uwe, if you started working on a patch for this already feel free to assign this to you.

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (LUCENE-1855) Change AttributeSource API to use generics

     [
https://issues.apache.org/jira/browse/LUCENE-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adriano Crestani updated LUCENE-1855:
-------------------------------------

    Attachment: LUCENE-1855_precedence_queryparser.patch

This patch updates the PQP to use the new TokenStream API...all tests still pass.

I hope this helps to keep the PQP :)

> Change AttributeSource API to use generics
> ------------------------------------------
>
>                 Key: LUCENE-1855
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1855
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>            Reporter: Michael Busch
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: AttributeSource.jad, LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855.patch,
LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855_contrib.patch,
LUCENE-1855_contrib_queryparser.patch, LUCENE-1855_precedence_queryparser.patch
>
>
> The AttributeSource API will be easier to use with JDK 1.5 generics.
> Uwe, if you started working on a patch for this already feel free to assign this to you.

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (LUCENE-1855) Change AttributeSource API to use generics

    [
https://issues.apache.org/jira/browse/LUCENE-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761119#action_12761119
] 

Uwe Schindler commented on LUCENE-1855:
---------------------------------------

Thanks Adriano, I will open another issue about that, as it has not really something to do with this issue!

> Change AttributeSource API to use generics
> ------------------------------------------
>
>                 Key: LUCENE-1855
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1855
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>            Reporter: Michael Busch
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: AttributeSource.jad, LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855.patch,
LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855.patch, LUCENE-1855_contrib.patch,
LUCENE-1855_contrib_queryparser.patch, LUCENE-1855_precedence_queryparser.patch
>
>
> The AttributeSource API will be easier to use with JDK 1.5 generics.
> Uwe, if you started working on a patch for this already feel free to assign this to you.

--

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.