Gtkpod CVS commits

dforsi | 28 Feb 2013 22:11

Picon

[gtpd-cvs] [gtkpod] Fix showing tracks of selected artist on 64-bit systems

commit 665fe093cb053559deef0a9bc6c8d41e7ad6ca08
Author: Daniele Forsi <daniele <at> forsi.it>
Date:   Thu Feb 28 22:07:14 2013 +0100

    Fix showing tracks of selected artist on 64-bit systems

    The return value of gdk_threads_add_idle_full() is guint and is
    greater than 0; see
    http://developer.gnome.org/gdk/2.22/gdk-Threads.html#gdk-threads-add-idle-full

    Bug reported in http://sourceforge.net/mailarchive/message.php?msg_id=30490385

 plugins/sorttab_display/normal_sorttab_page.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/plugins/sorttab_display/normal_sorttab_page.c b/plugins/sorttab_display/normal_sorttab_page.c
index ee00304..00d9c11 100644
--- a/plugins/sorttab_display/normal_sorttab_page.c
+++ b/plugins/sorttab_display/normal_sorttab_page.c
 <at>  <at>  -41,7 +41,7  <at>  <at> 
 #include "normal_sorttab_page.h"
 #include "sorttab_display_context_menu.h"

-#define NO_IDLE_SELECTION_CALLBACK -1
+#define NO_IDLE_SELECTION_CALLBACK 0

 G_DEFINE_TYPE( NormalSortTabPage, normal_sort_tab_page, GTK_TYPE_TREE_VIEW);

 <at>  <at>  -570,7 +570,7  <at>  <at>  static gboolean _st_selection_changed_cb(gpointer data) {
 static void _st_selection_changed(GtkTreeSelection *selection, gpointer user_data) {

(Continue reading)

dforsi | 28 Feb 2013 22:11

Picon

[gtpd-cvs] [gtkpod] Revert "Fix showing tracks of selected artist on 64-bit systems"

commit d4e665b59a73d43a8a8be7d428cb1ccef9e80d96
Author: Daniele Forsi <daniele <at> forsi.it>
Date:   Thu Feb 28 21:57:58 2013 +0100

    Revert "Fix showing tracks of selected artist on 64-bit systems"

    This reverts commit 3732944d096943125e4a51f753644a00726acc68.

 plugins/sorttab_display/normal_sorttab_page.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/plugins/sorttab_display/normal_sorttab_page.c b/plugins/sorttab_display/normal_sorttab_page.c
index 0fb3286..ee00304 100644
--- a/plugins/sorttab_display/normal_sorttab_page.c
+++ b/plugins/sorttab_display/normal_sorttab_page.c
 <at>  <at>  -66,7 +66,7  <at>  <at>  struct _NormalSortTabPagePrivate {
      * Handler id of the idle callback when the selection
      * changed callback is executed
      */
-    gulong selection_changed_idle_id;
+    guint selection_changed_idle_id;

     /* name of entry last selected */
     GList *last_selection;

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb

(Continue reading)

dforsi | 15 Feb 2013 18:34

Picon

[gtpd-cvs] [gtkpod] Fix showing tracks of selected artist on 64-bit systems

commit 3732944d096943125e4a51f753644a00726acc68
Author: Benno <fwxx <at> rocketmail.com>
Date:   Fri Feb 15 18:27:24 2013 +0100

    Fix showing tracks of selected artist on 64-bit systems

    The handler_id is of type gulong (while signal_id is guint); see
    http://developer.gnome.org/gobject/unstable/gobject-Signals.html

    Bug reported in http://sourceforge.net/mailarchive/message.php?msg_id=30490385

 plugins/sorttab_display/normal_sorttab_page.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/plugins/sorttab_display/normal_sorttab_page.c b/plugins/sorttab_display/normal_sorttab_page.c
index ee00304..0fb3286 100644
--- a/plugins/sorttab_display/normal_sorttab_page.c
+++ b/plugins/sorttab_display/normal_sorttab_page.c
 <at>  <at>  -66,7 +66,7  <at>  <at>  struct _NormalSortTabPagePrivate {
      * Handler id of the idle callback when the selection
      * changed callback is executed
      */
-    guint selection_changed_idle_id;
+    gulong selection_changed_idle_id;

     /* name of entry last selected */
     GList *last_selection;

------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer

(Continue reading)

dforsi | 15 Feb 2013 12:54

Picon

[gtpd-cvs] [gtkpod] Fix possible crasher

commit 881b49115e4e37174b5250fe7e4780a536762ef2
Author: Daniele Forsi <daniele <at> forsi.it>
Date:   Fri Feb 15 12:14:24 2013 +0100

    Fix possible crasher

    When opening the About dialog for the second time, a variable pointed
    to freed memory.

    Fixes:
    (lt-gtkpod:13277): Gtk-WARNING **: Failed to set text from markup due to error parsing markup: Error on
line 1 char 36: Invalid UTF-8 encoded text in name - not valid ' \xc5\xc5	h\xdd\xc3	'

    (lt-gtkpod:13277): Pango-WARNING **: Invalid UTF-8 string passed to pango_layout_set_text()

 src/anjuta-about.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/src/anjuta-about.c b/src/anjuta-about.c
index 112bbd5..988ff1b 100644
--- a/src/anjuta-about.c
+++ b/src/anjuta-about.c
 <at>  <at>  -142,6 +142,7  <at>  <at>  static void about_free_credit(void) {
         g_free(ptr[i]);

     g_free(translators);
+    translators = NULL;
 }

 GtkWidget *about_box_new(GtkWindow *parent) {

(Continue reading)

dforsi | 15 Feb 2013 12:54

Picon

[gtpd-cvs] [gtkpod] Fix tabs

commit 0fae682cd063a62ecbf004b71a2c86e36ca5df04
Author: Daniele Forsi <daniele <at> forsi.it>
Date:   Fri Feb 15 11:37:41 2013 +0100

    Fix tabs

 AUTHORS |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)
---
diff --git a/AUTHORS b/AUTHORS
index aa4912d..f9c096e 100644
--- a/AUTHORS
+++ b/AUTHORS
 <at>  <at>  -69,7 +69,7  <at>  <at>  es				Javier Kohen <jkohen at users.sourceforge.net>

 sv				Stefan Asserhall <stefan.asserhall at comhem dot se>

-zh_CN			Tan Zhixin <tanzhxin <at> gmail.com>
+zh_CN				Tan Zhixin <tanzhxin <at> gmail.com>
 		  		Américo Wang <xiyou.wangcong at gmail.com>

 Website:
 <at>  <at>  -81,17 +81,17  <at>  <at>  Paul Richardson <phantom_sf at users dot sourceforge dot net>
 Note:
 -------------------------------------------------------------------------------
 This program borrows code from the following projects
-	gnutools		- mktunes.pl, ported to C, reading and writing 
-							 		of iTunesDB  <http://www.gnu.org/software/gnupod/>
-		
+	gnutools	- mktunes.pl, ported to C, reading and writing

(Continue reading)

dforsi | 4 Dec 2012 22:58

Picon

[gtpd-cvs] [gtkpod] Update Italian translation

commit 5490dee7df08b604b0b4df47bbd9c1bce93b05e7
Author: Daniele Forsi <daniele <at> forsi.it>
Date:   Tue Dec 4 22:56:12 2012 +0100

    Update Italian translation

 po/it.po |  171 ++++++++++++++++++++++++++++++++++++--------------------------
 1 files changed, 100 insertions(+), 71 deletions(-)
---
diff --git a/po/it.po b/po/it.po
index 61a3af3..981ca1b 100644
--- a/po/it.po
+++ b/po/it.po
 <at>  <at>  -16,8 +16,8  <at>  <at>  msgid ""
 msgstr ""
 "Project-Id-Version: gtkpod\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2012-07-14 00:09+0200\n"
-"PO-Revision-Date: 2012-07-13 22:48+0200\n"
+"POT-Creation-Date: 2012-12-04 22:09+0100\n"
+"PO-Revision-Date: 2012-12-04 22:22+0100\n"
 "Last-Translator: Daniele Forsi <dforsi <at> gmail.com>\n"
 "Language-Team: Italian <tp <at> lists.linux.it>\n"
 "Language: it\n"
 <at>  <at>  -674,7 +674,7  <at>  <at>  msgstr ""
 "Testi non scritti, tipo del file non determinabile (%s).\n"
 "\n"

-#: ../libgtkpod/file.c:2185
+#: ../libgtkpod/file.c:2185 ../libgtkpod/file.c:2190

(Continue reading)

Joel Smith | 13 Nov 2012 02:46

Picon

[gtpd-cvs] [gtkpod] make MP4 generated chapter names translateable

commit 474b4287771b95a6e8407b72c39c15d700e206d4
Author: Joel Smith <jsf-lists.gtkpod <at> jk1.net>
Date:   Mon Nov 12 16:36:11 2012 -0700

    make MP4 generated chapter names translateable

    Thanks to Daniele Forsi for the suggestion

 libs/atomic-parsley/AtomicParsleyBridge.cpp |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/libs/atomic-parsley/AtomicParsleyBridge.cpp b/libs/atomic-parsley/AtomicParsleyBridge.cpp
index 25ba8af..4841af2 100644
--- a/libs/atomic-parsley/AtomicParsleyBridge.cpp
+++ b/libs/atomic-parsley/AtomicParsleyBridge.cpp
 <at>  <at>  -261,9 +261,9  <at>  <at>  void AP_read_metadata(const char *filePath, Track *track) {
                 }
                 else
                 {
-                    // chapter title couldn't be found; create our own titles
-                    // (and some ipods don't display them anyway)
-                    title = g_strdup_printf("Chapter %3d", i);
+                    // chapter title couldn't be found; create our own titles (and some ipods don't display them anyway).
+                    // Translators: this string is used to create a chapter title when no chapter title could be found
+                    title = g_strdup_printf(_("Chapter %3d"), i);
                 }

                 if (!timescale) // assume 1000, also, don't divide by 0

------------------------------------------------------------------------------

(Continue reading)

Joel Smith | 13 Nov 2012 02:46

Picon

[gtpd-cvs] [gtkpod] MP4 text tags are already UTF-8. Remove UTF-8 conversion.

commit 0fd91b5fe7e93e5b2409b7b5a36e9dd052042237
Author: Joel Smith <jsf-lists.gtkpod <at> jk1.net>
Date:   Mon Nov 12 16:12:58 2012 -0700

    MP4 text tags are already UTF-8. Remove UTF-8 conversion.

 libs/atomic-parsley/AtomicParsleyBridge.cpp |   28 +++++++++++++-------------
 1 files changed, 14 insertions(+), 14 deletions(-)
---
diff --git a/libs/atomic-parsley/AtomicParsleyBridge.cpp b/libs/atomic-parsley/AtomicParsleyBridge.cpp
index 74930a1..25ba8af 100644
--- a/libs/atomic-parsley/AtomicParsleyBridge.cpp
+++ b/libs/atomic-parsley/AtomicParsleyBridge.cpp
 <at>  <at>  -296,49 +296,49  <at>  <at>  void AP_read_metadata(const char *filePath, Track *track) {
         // MP4 Title
         value = find_atom_value(TITLE);
         if (value) {
-            track->title = charset_to_utf8(value);
+            track->title = g_strdup(value);
             free(value);
         }

         // MP4 Artist
         value = find_atom_value(ARTIST);
         if (value) {
-            track->artist = charset_to_utf8(value);
+            track->artist = g_strdup(value);
             free(value);
         }

(Continue reading)

Joel Smith | 11 Nov 2012 03:32

Picon

[gtpd-cvs] [gtkpod] fix mp4 tag crash on tempo (BPM) values above 99

commit 7684c22d7665e47a125e54ba03e2b1552791dfd0
Author: Joel Smith <jsf-lists.gtkpod <at> jk1.net>
Date:   Sat Nov 10 19:11:48 2012 -0700

    fix mp4 tag crash on tempo (BPM) values above 99

    As reported here:
    http://sourceforge.net/tracker/index.php?func=detail&aid=3575205&group_id=67873&atid=519273

 libs/atomic-parsley/AtomicParsley.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/libs/atomic-parsley/AtomicParsley.cpp b/libs/atomic-parsley/AtomicParsley.cpp
index 69830d5..868d1f0 100644
--- a/libs/atomic-parsley/AtomicParsley.cpp
+++ b/libs/atomic-parsley/AtomicParsley.cpp
 <at>  <at>  -1816,7 +1816,7  <at>  <at>  char* APar_ExtractDataAtom(int this_atom_number) {
                     }
                 }
                 case 2: { //tmpo
-                    char* result = (char*) malloc(sizeof(char) * 4);
+                    char* result = (char*) malloc(sizeof(char) * 7); // 5 for tempo value, up to 65535, 2 for \n\0
                     sprintf(result, "%hu\n", UInt16FromBigEndian(data_payload));
                     return result;
                 }

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:

(Continue reading)

Joel Smith | 11 Nov 2012 03:32

Picon

[gtpd-cvs] [gtkpod] fix compilation flag and media type tag for mp4 files

commit dbbadb72e33f99edd610f7392b6926c168ee5fef
Author: Joel Smith <jsf-lists.gtkpod <at> jk1.net>
Date:   Thu Nov 8 16:16:11 2012 -0700

    fix compilation flag and media type tag for mp4 files

 libs/atomic-parsley/AtomicParsleyBridge.cpp |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)
---
diff --git a/libs/atomic-parsley/AtomicParsleyBridge.cpp b/libs/atomic-parsley/AtomicParsleyBridge.cpp
index 704fd3b..74930a1 100644
--- a/libs/atomic-parsley/AtomicParsleyBridge.cpp
+++ b/libs/atomic-parsley/AtomicParsleyBridge.cpp
 <at>  <at>  -32,6 +32,7  <at>  <at> 
 #include "AtomicParsley.h"
 #include "AP_AtomExtracts.h"
 #include "AtomicParsleyBridge.h"
+#include "AtomicParsley_genres.h"

 extern "C" {
 #include <glib/gstdio.h>
 <at>  <at>  -462,14 +463,18  <at>  <at>  void AP_read_metadata(const char *filePath, Track *track) {
         // MP4 Media Type
         value = find_atom_value(MEDIA_TYPE);
         if (value) {
-            track->mediatype = mediaTypeTagToMediaType(atoi(value));
+            stiks * stik = MatchStikString(value);
+            if (stik)
+            {
+                track->mediatype = mediaTypeTagToMediaType(stik->stik_number);

(Continue reading)

Joel Smith | 11 Nov 2012 03:32

Picon

[gtpd-cvs] [gtkpod] add mp4 chapter reading support to Atomic Parsley bridge

commit 3fbdec07724f4806f88dd93ac3927162b2cdaabd
Author: Joel Smith <jsf-lists.gtkpod <at> jk1.net>
Date:   Thu Nov 8 14:23:35 2012 -0700

    add mp4 chapter reading support to Atomic Parsley bridge

 libs/atomic-parsley/AtomicParsleyBridge.cpp |  125 +++++++++++++++++++++++++--
 1 files changed, 119 insertions(+), 6 deletions(-)
---
diff --git a/libs/atomic-parsley/AtomicParsleyBridge.cpp b/libs/atomic-parsley/AtomicParsleyBridge.cpp
index ef1a182..704fd3b 100644
--- a/libs/atomic-parsley/AtomicParsleyBridge.cpp
+++ b/libs/atomic-parsley/AtomicParsleyBridge.cpp
 <at>  <at>  -146,7 +146,10  <at>  <at>  void AP_read_metadata(const char *filePath, Track *track) {
     FILE *mp4File;
     Trackage *trackage;
     uint8_t track_cur;
+    uint8_t txttrack_cur;
     gboolean audio_or_video_found = FALSE;
+    gboolean has_quicktime_chaps = FALSE;
+    uint32_t timescale = 0;

     APar_ScanAtoms(filePath, true);
     mp4File = openSomeFile(filePath, true);
 <at>  <at>  -156,11 +159,8  <at>  <at>  void AP_read_metadata(const char *filePath, Track *track) {
     for (track_cur = 0; track_cur < trackage->total_tracks; ++track_cur) {
         TrackInfo *info = trackage->infos[track_cur];

-        // FIXME no chapter information implemented yet
-

(Continue reading)

Group

gmane.comp.ipod.gtkpod.cvs.

Project Web Page

Gtkpod CVS commits

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11

May 2013

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

[gtpd-cvs] [gtkpod] Fix showing tracks of selected artist on 64-bit sy (28 Feb 2013)
[gtpd-cvs] [gtkpod] Revert "Fix showing tracks of selected artist on 6 (28 Feb 2013)
[gtpd-cvs] [gtkpod] Fix showing tracks of selected artist on 64-bit sy (15 Feb 2013)
[gtpd-cvs] [gtkpod] Fix possible crasher (15 Feb 2013)
[gtpd-cvs] [gtkpod] Fix tabs (15 Feb 2013)
[gtpd-cvs] [gtkpod] Update Italian translation (4 Dec 2012)
[gtpd-cvs] [gtkpod] make MP4 generated chapter names translateable (13 Nov 2012)
[gtpd-cvs] [gtkpod] MP4 text tags are already UTF-8. Remove UTF-8 conv (13 Nov 2012)
[gtpd-cvs] [gtkpod] fix mp4 tag crash on tempo (BPM) values above 99 (11 Nov 2012)
[gtpd-cvs] [gtkpod] fix compilation flag and media type tag for mp4 fi (11 Nov 2012)
[gtpd-cvs] [gtkpod] add mp4 chapter reading support to Atomic Parsley (11 Nov 2012)
[gtpd-cvs] [gtkpod] add track ID field to AtomicParseley library (11 Nov 2012)
[gtpd-cvs] [gtkpod] add text track type to AtomicParseley library (11 Nov 2012)
[gtpd-cvs] [gtkpod] add track sort fields read/write support to AP lib (11 Nov 2012)
[gtpd-cvs] [gtkpod] Mitigate possibility of sort tab category where tr (10 Nov 2012)
[gtpd-cvs] [gtkpod] Solve the confusing sorting of the track display (24 Oct 2012)
[gtpd-cvs] [gtkpod] Reduce the number of selection changed callbacks (24 Oct 2012)
[gtpd-cvs] [gtkpod] Fix to cater for changing API in anjuta version 3. (13 Oct 2012)
[gtpd-cvs] [libgpod: 11/11] Add backward compatible definition for g_m (7 Oct 2012)
[gtpd-cvs] [libgpod: 10/11] Merge branch 'dev' of git://github.com/neu (7 Oct 2012)
[gtpd-cvs] [libgpod: 9/11] replace deprecated g_basename() (7 Oct 2012)

Archives

5	February 2013
1	December 2012
9	November 2012
17	October 2012
3	August 2012
26	July 2012
11	June 2012
3	May 2012
11	April 2012
17	March 2012
11	February 2012
8	January 2012
10	December 2011
7	November 2011
12	October 2011
44	September 2011
7	August 2011
59	July 2011
5	June 2011
38	May 2011
18	April 2011
28	March 2011
27	February 2011
50	January 2011
47	December 2010
8	November 2010
23	October 2010
59	September 2010
88	August 2010
99	July 2010
13	June 2010
17	May 2010
41	April 2010
30	March 2010
45	February 2010
72	January 2010
165	December 2009
11	November 2009
7	October 2009
3	September 2009
10	August 2009
1	July 2009
9	June 2009
27	May 2009
40	April 2009
29	March 2009
14	February 2009
68	January 2009
33	December 2008
10	November 2008
21	October 2008
9	September 2008
40	August 2008
48	July 2008
24	June 2008
39	May 2008
9	April 2008
6	March 2008
6	February 2008
51	January 2008
88	December 2007
56	November 2007
39	October 2007
22	September 2007
23	August 2007
50	July 2007
103	June 2007
74	May 2007
104	April 2007
66	March 2007
82	February 2007
136	January 2007
15	December 2006
86	November 2006
49	October 2006
81	September 2006
23	August 2006
15	July 2006
258	June 2006
197	May 2006
82	April 2006
34	March 2006
36	November 2005
35	October 2005

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template