DJ Houghton | 1 Sep 21:08
Picon

Projects tagged for 20080902 integration build

The map file has been updated for the following Bug changes:
+ Bug 238240. InstructionParser should support escaped characters (FIXED)
+ Bug 241451. [server] HttpServletRequestAdaptor.getContextPath() returns inconsistent values. (FIXED)
+ Bug 243166. NullPointerException in java.io.File constructor (FIXED)
+ Bug 243654. TextProcessor should also be active on the Mac (FIXED)
+ Bug 244813. Files Missing in update jars (NEW)
+ Bug 245271. Change PackageAdminImpl.doResolveBundles to protected (FIXED)
+ Bug 245303. [app] implement new ApplicationHandle.getExitValue (FIXED)
+ Bug 245603. Refactor Service Layer (FIXED)
+ Bug 245723. Properties from "advice" are not published for feature artifacts (FIXED)

The following projects have changed:
org.eclipse.equinox.app
org.eclipse.equinox.p2.publisher
org.eclipse.osgi.tests
org.eclipse.equinox.p2.engine
org.eclipse.equinox.p2.tests
org.eclipse.equinox.p2.metadata.generator
org.eclipse.osgi
org.eclipse.equinox.servletbridge
org.eclipse.equinox.p2.directorywatcher

Thomas Watson | 2 Sep 16:38
Picon
Favicon

Re: .qualifier for export package?

Before recommending every package uses a qualifier I have the following concerns:

1) In Eclipse we have loads of packages. We better make sure all identical qualifier Strings are shared (interned etc.) for performance reasons. Today when loading from a cached state we share identical Version objects. Because package versions are managed independently we will end up with lots of different versions that have the same qualifier exported by a bundle. We also will limit the ability to share Version objects across bundles because each will use a different qualifier (unless we happen to use the same CVS tag).

2) The qualifier will change even in cases where no code was touched in the package. I'm not sure this is a valid concern. The code got recompiled so perhaps changing the version qualifier is warranted. But we need to think about the consequences. For example, I can see API tooling start to complain that the micro version of a package should be increased to indicate a bug "fix" when comparing the package versions with a base line. It will notice that the qualifier changed from a previous release but the micro version was not increased.

3) What about versions of packages which we do not maintain the API for at Eclipse. Things like org.osgi.* and orbit bundles. Shouldn't we use the version the producers of the API have defined? Adding a qualifier here does not seem right, especially if a qualifier is already defined by the producers.

On the surface this sounds like a fine idea, and I am not completely against it. But I would like to take the first step of versioning the Eclipse API packages first to see what all the issues are with independent package versioning. I'm sure we will run into other hurdles along the way. For example, how does a developer maintain the version of a split package across all the bundles the package is split?

Tom



"Chris Aniszczyk" ---08/31/2008 02:46:34 PM---On Sun, Aug 31, 2008 at 5:53 AM, Jeff McAffer < jeff-sqSPYpuUfRYAvxtiuMwx3w@public.gmane.org


From:

"Chris Aniszczyk" <caniszczyk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

To:

"Equinox development mailing list" <equinox-dev-j9T/66MeVpFAfugRpC6u6w@public.gmane.org>

Date:

08/31/2008 02:46 PM

Subject:

Re: [equinox-dev] .qualifier for export package?



On Sun, Aug 31, 2008 at 5:53 AM, Jeff McAffer <jeff-sqSPYpuUfRYAvxtiuMwx3w@public.gmane.org> wrote:
    As version numbers on packages become more prevalent does it start making sense to use .qualifier on them in addition to bundle version numbers? The logic here is the same as for bundles. we rev the version number of the bundle to match the most extreme change for that release. in between if hte provisioning system is going to do its job, it needs to have different version numbers. Teh .qualifier allows for the auto-qualification of bundle version numbers. The same is true for folks using import/export package.

+1

In PDE, I plan on releasing some builder logic to flag exported packages without versions with a warning in M2. API Tooling also has items in plan that deal with package versioning, but that will be post M2

    Thoughts for how/if this should be introduced?

I say before M2, we formulate a plan across the Eclipse proper projects to deal with versions on package exports. We can than look at pushing that plan to other Eclipse.org projects as a best practice once we get the hang of it.

--
Cheers,

~ Chris Aniszczyk_______________________________________________
equinox-dev mailing list
equinox-dev-j9T/66MeVpFAfugRpC6u6w@public.gmane.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev


BJ Hargrave | 2 Sep 17:37
Picon
Favicon

Re: .qualifier for export package?


I would be extremely cautious about using qualifier on package versions. I must say that I have never seen it done.

It seems an over specification. I think that having build tools to advise you to increment the micro is more than sufficient.
--

BJ Hargrave
Senior Technical Staff Member, IBM
OSGi Fellow and CTO of the OSGi Alliance
hargrave-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org

office: +1 386 848 1781
mobile: +1 386 848 3788





From: Thomas Watson/Austin/IBM <at> IBMUS
To: Equinox development mailing list <equinox-dev-j9T/66MeVpFAfugRpC6u6w@public.gmane.org>
Date: 2008/09/02 10:45 AM
Subject: Re: [equinox-dev] .qualifier for export package?




Before recommending every package uses a qualifier I have the following concerns:

1) In Eclipse we have loads of packages. We better make sure all identical qualifier Strings are shared (interned etc.) for performance reasons. Today when loading from a cached state we share identical Version objects. Because package versions are managed independently we will end up with lots of different versions that have the same qualifier exported by a bundle. We also will limit the ability to share Version objects across bundles because each will use a different qualifier (unless we happen to use the same CVS tag).

2) The qualifier will change even in cases where no code was touched in the package. I'm not sure this is a valid concern. The code got recompiled so perhaps changing the version qualifier is warranted. But we need to think about the consequences. For example, I can see API tooling start to complain that the micro version of a package should be increased to indicate a bug "fix" when comparing the package versions with a base line. It will notice that the qualifier changed from a previous release but the micro version was not increased.

3) What about versions of packages which we do not maintain the API for at Eclipse. Things like org.osgi.* and orbit bundles. Shouldn't we use the version the producers of the API have defined? Adding a qualifier here does not seem right, especially if a qualifier is already defined by the producers.

On the surface this sounds like a fine idea, and I am not completely against it. But I would like to take the first step of versioning the Eclipse API packages first to see what all the issues are with independent package versioning. I'm sure we will run into other hurdles along the way. For example, how does a developer maintain the version of a split package across all the bundles the package is split?

Tom



"Chris Aniszczyk" ---08/31/2008 02:46:34 PM---On Sun, Aug 31, 2008 at 5:53 AM, Jeff McAffer < jeff-sqSPYpuUfRYAvxtiuMwx3w@public.gmane.org

From:

"Chris Aniszczyk" <caniszczyk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

To:

"Equinox development mailing list" <equinox-dev-j9T/66MeVpFAfugRpC6u6w@public.gmane.org>

Date:

08/31/2008 02:46 PM

Subject:

Re: [equinox-dev] .qualifier for export package?




On Sun, Aug 31, 2008 at 5:53 AM, Jeff McAffer <jeff-sqSPYpuUfRYAvxtiuMwx3w@public.gmane.org> wrote:
As version numbers on packages become more prevalent does it start making sense to use .qualifier on them in addition to bundle version numbers? The logic here is the same as for bundles. we rev the version number of the bundle to match the most extreme change for that release. in between if hte provisioning system is going to do its job, it needs to have different version numbers. Teh .qualifier allows for the auto-qualification of bundle version numbers. The same is true for folks using import/export package.

+1

In PDE, I plan on releasing some builder logic to flag exported packages without versions with a warning in M2. API Tooling also has items in plan that deal with package versioning, but that will be post M2

Thoughts for how/if this should be introduced?

I say before M2, we formulate a plan across the Eclipse proper projects to deal with versions on package exports. We can than look at pushing that plan to other Eclipse.org projects as a best practice once we get the hang of it.

--
Cheers,

~ Chris Aniszczyk_______________________________________________
equinox-dev mailing list
equinox-dev-j9T/66MeVpFAfugRpC6u6w@public.gmane.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev

_______________________________________________
equinox-dev mailing list
equinox-dev-j9T/66MeVpFAfugRpC6u6w@public.gmane.org
https://dev.eclipse.org/mailman/listinfo/equinox-dev

Ricardo Giacomin | 2 Sep 18:45

GWT+Equinox

Hi there,

 

I tried to follow the directions from wiki page http://wiki.eclipse.org/index.php/Google_Web_Toolkit_and_Equinox with no success. The problem is that no matter what I do I still get the ClassCastException when the ServletManager tries to instantiate the servlet. It is probably a problem of different servlet API version (2.4 in equinox http and 2.3 in gwt).

 

I’m using:

 

GWT 1.5.2

Eclipse 3.4

Jetty Http from http://www.eclipse.org/equinox/server/downloads/jettyhttp-anon.psf

 

Any hints?

 

Thank you in advance.

 

Regards,

Ricardo Giacomin

Darin Wright | 2 Sep 20:33
Picon

Re: .qualifier for export package?

> API Tooling also has
> items in plan that deal with package versioning, but that will be post 
M2

FYI - plans for package version support in API tooling have been reduced. 
Currently, there is nothing on the draft plan due to resources available 
to do the work, and the fact that SDK plug-in developers generally use 
components at the plug-in granularity vs. package granularity. I'm not 
sure there is a compelling story to have SDK bundles change to using 
package imports. Of course, if someone else has the resources to do the 
work and sees this as a priority, please step up.

        http://www.eclipse.org/pde/pde-api-tools/dev_plans/r3_5/plan.php

> Thoughts for how/if this should be introduced?

To start, I would like to see a better specification developed/agreed upon 
before tooling is introduced. Currently, the description of package 
versioning is minimal - leaving questions to the developers and tool 
implementors:

        http://wiki.eclipse.org/Version_Numbering#How_to_version_packages

Here are some obvious questions:

* How are @since tags formatted to indicate that the version number 
corresponds to packages vs. bundles?
* How are initial package versions derived for existing bundles?

Darin
Thomas Watson | 2 Sep 20:59
Picon
Favicon

Re: .qualifier for export package?


> Here are some obvious questions:
>
> * How are <at> since tags formatted to indicate that the version number
> corresponds to packages vs. bundles?

If there is a package version then the <at> since should always reference
the package version exported in my opinion.

> * How are initial package versions derived for existing bundles?

The simple answer here is to seed the package versions with the
bundle's version.  This makes some sense because using the Eclipse
versioning rules today the API packages from a single bundle are
versioned together as one unit using the Bundle-Version.

Tom.

>
> Darin

Ian Bull | 2 Sep 21:14
Picon
Picon
Favicon

Re: GWT+Equinox

Ricardo,

I have this working with GWT 1.5 and Eclipse 3.4, so we know it's 
possible :-).

Have you tried adding javax.servlet to the required plug-ins for GWT? I 
have a GWT bundle, and I noticed that it depends on javax.servlet. If I 
remove this dependency I get the class cast exception.

I also removed all the servlet stuff from Exported Packages list. (See 
the Runtime tab in the Manifest editor).

Cheers,
Ian

Ricardo Giacomin wrote:
>
> Hi there,
>
> I tried to follow the directions from wiki page 
> http://wiki.eclipse.org/index.php/Google_Web_Toolkit_and_Equinox with 
> no success. The problem is that no matter what I do I still get the 
> ClassCastException when the ServletManager tries to instantiate the 
> servlet. It is probably a problem of different servlet API version 
> (2.4 in equinox http and 2.3 in gwt).
>
> I’m using:
>
> GWT 1.5.2
>
> Eclipse 3.4
>
> Jetty Http from 
> http://www.eclipse.org/equinox/server/downloads/jettyhttp-anon.psf
>
> Any hints?
>
> Thank you in advance.
>
> Regards,
>
> Ricardo Giacomin
>
>
> -- 
> This message has been scanned for viruses and
> dangerous content by *MailScanner* <http://www.mailscanner.info/>, and is
> believed to be clean.
> ------------------------------------------------------------------------
>
> _______________________________________________
> equinox-dev mailing list
> equinox-dev@...
> https://dev.eclipse.org/mailman/listinfo/equinox-dev
>   

-- 
R. Ian Bull
PhD Candidate, University of Victoria
http://www.ianbull.com
http://irbull.blogspot.com/

--

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Darin Wright | 2 Sep 21:17
Picon

Re: .qualifier for export package?

Darin Wright
Eclipse Debug Lead,
Rational Team,
IBM Canada
(204)938-8051

equinox-dev-bounces@... wrote on 09/02/2008 01:59:00 PM:

> 
> > Here are some obvious questions:
> > 
> > * How are @since tags formatted to indicate that the version number 
> > corresponds to packages vs. bundles?
> 
> If there is a package version then the @since should always reference
> the package version exported in my opinion.

Right, but since package versions will now evolve independently of bundle 
versions, should the package name also appear in the @since tag - like 
"@since org.eclipse.jdt.debug.model 3.4". Else, when just looking at the 
Javadoc, consumers of an API will not know if they need a required bundle 
or a package import.

> 
> > * How are initial package versions derived for existing bundles?
> 
> The simple answer here is to seed the package versions with the 
> bundle's version.  This makes some sense because using the Eclipse 
> versioning rules today the API packages from a single bundle are 
> versioned together as one unit using the Bundle-Version.

Another option is to use the highest @since tag in the package. If a most 
recent since tag in a package is 3.1, it could start at 3.1 instead of 
3.5.

Darin

BJ Hargrave | 2 Sep 21:36
Picon
Favicon

Re: .qualifier for export package?


> Right, but since package versions will now evolve independently of bundle
> versions, should the package name also appear in the <at> since tag - like
> " <at> since org.eclipse.jdt.debug.model 3.4". Else, when just looking at the
> Javadoc, consumers of an API will not know if they need a required bundle
> or a package import.

Wouldn't the package name already be stated by the package statement at the head of the source code? It seem redundant and repetitive to put it in the <at> since tag.

I think <at> since obviously applies to the package. When you javadoc the code, bundle membership is absent. Only the package organization remains.
--

BJ Hargrave
Senior Technical Staff Member, IBM
OSGi Fellow and CTO of the OSGi Alliance
hargrave-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org

office: +1 386 848 1781
mobile: +1 386 848 3788



Darin Wright | 2 Sep 21:43
Picon

Re: .qualifier for export package?

> > Right, but since package versions will now evolve independently of 
bundle 
> > versions, should the package name also appear in the @since tag - like 

> > "@since org.eclipse.jdt.debug.model 3.4". Else, when just looking at 
the 
> > Javadoc, consumers of an API will not know if they need a required 
bundle 
> > or a package import.
> 
> Wouldn't the package name already be stated by the package statement
> at the head of the source code? It seem redundant and repetitive to 
> put it in the @since tag. 
> 
> I think @since obviously applies to the package. When you javadoc 
> the code, bundle membership is absent. Only the package organization 
remains.

OK, this would be a good argument to have initial package versions reflect 
the highest @since tag in the package, rather than the current bundle 
version. Else we'd have a mix of @since tags in existing bundles - where 
some referenced the bundle version, and some referenced the package 
version.

Darin

Gmane