headers
Aygon, Bertrand | 1 Dec 2011 09:51
Picon
Favicon

RE: [PATCH 1/5] cdma-providers: add driver APIs header

Hi Philippe,

> diff --git a/include/cdma-providers.h b/include/cdma-providers.h new file mode
> 100644 index 0000000..8ee9e1e
> --- /dev/null
> +++ b/include/cdma-providers.h
>  <at>  <at>  -0,0 +1,44  <at>  <at> 
> +/*
> + *
> + *  oFono - Open Telephony stack for Linux
> + *
> + *  Copyright (C) 2011  Nokia Corporation and/or its subsidiary(-ies).

Are you sure about the copyright?

> + *
> + *  This program is free software; you can redistribute it and/or
> +modify
> + *  it under the terms of the GNU General Public License version 2 as
> + *  published by the Free Software Foundation.
> + *
> + *  This program is distributed in the hope that it will be useful,
> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *  GNU General Public License for more details.
> + *
> + *  You should have received a copy of the GNU General Public License
> + *  along with this program; if not, write to the Free Software
> + *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
> +02110-1301  USA
(Continue reading)

Permalink | Reply | 0 comments |
headers
Aygon, Bertrand | 1 Dec 2011 09:56
Picon
Favicon

RE: [PATCH 3/5] cdma-providers: add driver APIs implementation

Hi Philippe,

> diff --git a/src/cdma-providers.c b/src/cdma-providers.c new file mode 100644
> index 0000000..d02d41c
> --- /dev/null
> +++ b/src/cdma-providers.c
>  <at>  <at>  -0,0 +1,80  <at>  <at> 
> +/*
> + *
> + *  oFono - Open Source Telephony
> + *
> + *  Copyright (C) 2011  Nokia Corporation and/or its subsidiary(-ies).

Same comment about copyright.

> + *
> + *  This program is free software; you can redistribute it and/or
> +modify
> + *  it under the terms of the GNU General Public License version 2 as
> + *  published by the Free Software Foundation.
> + *
> + *  This program is distributed in the hope that it will be useful,
> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *  GNU General Public License for more details.
> + *
> + *  You should have received a copy of the GNU General Public License
> + *  along with this program; if not, write to the Free Software
> + *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
> +02110-1301  USA
(Continue reading)

Permalink | Reply | 0 comments |
headers
Guillaume Zajac | 1 Dec 2011 16:37
Picon

[RFC_v0] sierra: Add SIM state polling

It has been reported than for some Sierra modem, the SIM
initialization process leads to +CME ERROR: 10 sim not
present. The issue might come from SIM is not ready.
---
 plugins/sierra.c |   26 +++++++++++++++++++++++++-
 1 files changed, 25 insertions(+), 1 deletions(-)

diff --git a/plugins/sierra.c b/plugins/sierra.c
index c41e2d1..db54817 100644
--- a/plugins/sierra.c
+++ b/plugins/sierra.c
 <at>  <at>  -47,6 +47,8  <at>  <at>  static const char *none_prefix[] = { NULL };

 struct sierra_data {
 	GAtChat *chat;
+	gboolean have_sim;
+	struct at_util_sim_state_query *sim_state_query;
 };

 static void sierra_debug(const char *str, void *user_data)
 <at>  <at>  -79,6 +81,12  <at>  <at>  static void sierra_remove(struct ofono_modem *modem)

 	ofono_modem_set_data(modem, NULL);

+	/* Cleanup potential SIM state polling */
+	at_util_sim_state_query_free(data->sim_state_query);
+
+	/* Cleanup after hot-unplug */
+	g_at_chat_unref(data->chat);
+
(Continue reading)

Permalink | Reply | 1 comment |
headers
Aygon, Bertrand | 1 Dec 2011 17:02
Picon
Favicon

RE: [RFC_v0] sierra: Add SIM state polling

Hi Guillaume,

>  static void sierra_debug(const char *str, void *user_data)  <at>  <at>  -79,6 +81,12
>  <at>  <at>  static void sierra_remove(struct ofono_modem *modem)
> 
>  	ofono_modem_set_data(modem, NULL);
> 
> +	/* Cleanup potential SIM state polling */
> +	at_util_sim_state_query_free(data->sim_state_query);
> +
> +	/* Cleanup after hot-unplug */
> +	g_at_chat_unref(data->chat);

Seems that you found an issue not related to your change. Maybe a dedicated submit would be nice.

> +
>  	g_free(data);
>  }
> 
>  <at>  <at>  -115,6 +123,21  <at>  <at>  static GAtChat *open_device(struct ofono_modem
> *modem,
>  	return chat;
>  }
> 
> +static void sim_state_cb(gboolean present, gpointer user_data) {
> +	struct ofono_modem *modem = user_data;
> +	struct sierra_data *data = ofono_modem_get_data(modem);
> +
> +	at_util_sim_state_query_free(data->sim_state_query);
> +	data->sim_state_query = NULL;
(Continue reading)

Permalink | Reply | 0 comments |
headers
Guillaume Zajac | 1 Dec 2011 17:40
Picon

[PATCH_v0 0/3] cdma-connman add roaming support

Hi,

Those 3 patches are implementing roaming property support.
It contains the cdma-netreg status watches implementation, to notify
cdma connection manager that network status has changed to disable or not
data call in case roaming is allowed or not.

Kind regards,
Guillaume

Guillaume Zajac (3):
  doc: Add RoamingAllowed property
  cdma-netreg: Add cdma-netreg status watch
  cdma-connman: Add RoamingAllowed support

 doc/cdma-connman-api.txt |    8 +++++
 src/cdma-connman.c       |   70 +++++++++++++++++++++++++++++++++++++++++++++-
 src/cdma-netreg.c        |   52 ++++++++++++++++++++++++++++++++++
 src/ofono.h              |   13 ++++++++
 4 files changed, 142 insertions(+), 1 deletions(-)
Permalink | Reply | 7 comments |
headers
Guillaume Zajac | 1 Dec 2011 17:40
Picon

[PATCH_v0 1/3] doc: Add RoamingAllowed property

---
 doc/cdma-connman-api.txt |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/doc/cdma-connman-api.txt b/doc/cdma-connman-api.txt
index 48699a3..319c973 100644
--- a/doc/cdma-connman-api.txt
+++ b/doc/cdma-connman-api.txt
 <at>  <at>  -45,6 +45,14  <at>  <at>  Properties	boolean Powered [readwrite]
 			Holds the password to be used for authentication
 			purposes.

+		boolean RoamingAllowed [readwrite]
+
+			Contains whether data roaming is allowed.  In the off
+			setting, if the packet radio registration state
+			indicates that the modem is roaming, oFono will
+			automatically shutdown connection and no further
+			connection establishment will be possible.
+
 		dict Settings [readonly, optional]

 			Holds all the IP network settings
--

-- 
1.7.1
Permalink | Reply | 4 comments |
headers
Guillaume Zajac | 1 Dec 2011 17:40
Picon

[PATCH_v0 2/3] cdma-netreg: Add cdma-netreg status watch

---
 src/cdma-netreg.c |   52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 src/ofono.h       |   13 +++++++++++++
 2 files changed, 65 insertions(+), 0 deletions(-)

diff --git a/src/cdma-netreg.c b/src/cdma-netreg.c
index 222c3b7..34c11c0 100644
--- a/src/cdma-netreg.c
+++ b/src/cdma-netreg.c
 <at>  <at>  -35,6 +35,7  <at>  <at>  struct ofono_cdma_netreg {
 	enum cdma_netreg_status status;
 	int strength;
 	int hdr_strength;
+	struct ofono_watchlist *status_watches;
 	const struct ofono_cdma_netreg_driver *driver;
 	void *driver_data;
 	struct ofono_atom *atom;
 <at>  <at>  -104,6 +105,53  <at>  <at>  static GDBusSignalTable cdma_netreg_manager_signals[] = {
 	{ }
 };

+unsigned int __ofono_cdma_netreg_add_status_watch(
+				struct ofono_cdma_netreg *netreg,
+				ofono_cdma_netreg_status_notify_cb_t notify,
+				void *data, ofono_destroy_func destroy)
+{
+	struct ofono_watchlist_item *item;
+
+	DBG("%p", netreg);
+
(Continue reading)

Permalink | Reply | 0 comments |
headers
Guillaume Zajac | 1 Dec 2011 17:40
Picon

[PATCH_v0 3/3] cdma-connman: Add RoamingAllowed support

We need to use status watch in case we are registered to a network
and we pass into roaming status. We have to deactivate the data
call.
---
 src/cdma-connman.c |   70 +++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 files changed, 69 insertions(+), 1 deletions(-)

diff --git a/src/cdma-connman.c b/src/cdma-connman.c
index 87cefd6..34c2d24 100644
--- a/src/cdma-connman.c
+++ b/src/cdma-connman.c
 <at>  <at>  -52,6 +52,10  <at>  <at>  struct cdma_connman_settings {
 struct ofono_cdma_connman {
 	ofono_bool_t powered;
 	ofono_bool_t dormant;
+	ofono_bool_t roaming_allowed;
+	struct ofono_cdma_netreg *cdma_netreg;
+	unsigned int cdma_netreg_watch;
+	unsigned int status_watch;
 	struct cdma_connman_settings *settings;
 	DBusMessage *pending;
 	const struct ofono_cdma_connman_driver *driver;
 <at>  <at>  -354,8 +358,10  <at>  <at>  static ofono_bool_t network_registered(struct ofono_cdma_connman *cm)

 	switch (status) {
 	case NETWORK_REGISTRATION_STATUS_REGISTERED:
-	case NETWORK_REGISTRATION_STATUS_ROAMING:
 		return TRUE;
+	case NETWORK_REGISTRATION_STATUS_ROAMING:
+		if (cm->roaming_allowed == TRUE)
(Continue reading)

Permalink | Reply | 0 comments |
headers
Guillaume Zajac | 1 Dec 2011 17:48
Picon

[RFC_v1 0/2] Add SIM polling mechanism for Sierra

Hi,

Change log from v0:
	- Separate memory leak fix in another patch
	- Fix issue into polling mechanism

Kind regards,
Guillaume

Guillaume Zajac (2):
  sierra: Fix memory leak
  sierra: Add SIM state polling

 plugins/sierra.c |   29 ++++++++++++++++++++++++++++-
 1 files changed, 28 insertions(+), 1 deletions(-)
Permalink | Reply | 7 comments |
headers
Guillaume Zajac | 1 Dec 2011 17:48
Picon

[RFC_v1 1/2] sierra: Fix memory leak

---
 plugins/sierra.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/plugins/sierra.c b/plugins/sierra.c
index c41e2d1..b33382d 100644
--- a/plugins/sierra.c
+++ b/plugins/sierra.c
 <at>  <at>  -79,6 +79,9  <at>  <at>  static void sierra_remove(struct ofono_modem *modem)

 	ofono_modem_set_data(modem, NULL);

+	/* Cleanup after hot-unplug */
+	g_at_chat_unref(data->chat);
+
 	g_free(data);
 }

--

-- 
1.7.1
Permalink | Reply | 1 comment |

Gmane